brent/combine-message-diagnostic - Branch - astral-sh/ruff

Unify `OldDiagnostic` and `Message`

#18391Merged

Comparing

brent/combine-message-diagnostic

(

52a54a9

) with

main

(

4e83db4

)

Untouched: 37

Benchmarks

Passed

linter/default-rules[pydantic/types.py]

crates/ruff_benchmark/benches/linter.rs::default_rules::benchmark_default_rules

+1%

2 ms2 ms

linter/default-rules[large/dataset.py]

crates/ruff_benchmark/benches/linter.rs::default_rules::benchmark_default_rules

+1%

4.1 ms4 ms

linter/default-rules[numpy/ctypeslib.py]

crates/ruff_benchmark/benches/linter.rs::default_rules::benchmark_default_rules

+1%

971 µs964.1 µs

linter/default-rules[numpy/globals.py]

crates/ruff_benchmark/benches/linter.rs::default_rules::benchmark_default_rules

+1%

196 µs194.9 µs

linter/default-rules[unicode/pypinyin.py]

crates/ruff_benchmark/benches/linter.rs::default_rules::benchmark_default_rules

381.7 µs379.8 µs

parser[unicode/pypinyin.py]

crates/ruff_benchmark/benches/parser.rs::parser::benchmark_parser

320.9 µs320.9 µs

ty_micro[many_string_assignments]

crates/ruff_benchmark/benches/ty.rs::micro::benchmark_many_string_assignments

67.4 ms67.4 ms

parser[numpy/ctypeslib.py]

crates/ruff_benchmark/benches/parser.rs::parser::benchmark_parser

931.2 µs931.1 µs

ty_micro[many_tuple_assignments]

crates/ruff_benchmark/benches/ty.rs::micro::benchmark_many_tuple_assignments

180.9 ms180.9 ms

hydra-zen

crates/ruff_benchmark/benches/ty.rs::project::hydra::project

719.7 ms719.7 ms

ty_check_file[cold]

crates/ruff_benchmark/benches/ty.rs::check_file::benchmark_cold

120.6 ms120.6 ms

lexer[unicode/pypinyin.py]

crates/ruff_benchmark/benches/lexer.rs::lexer::benchmark_lexer

75.3 µs75.3 µs

anyio

crates/ruff_benchmark/benches/ty.rs::project::anyio::project

878.6 ms878.6 ms

formatter[large/dataset.py]

crates/ruff_benchmark/benches/formatter.rs::formatter::benchmark_formatter

9.5 ms9.5 ms

attrs

crates/ruff_benchmark/benches/ty.rs::project::attrs::project

364.1 ms364.1 ms

parser[pydantic/types.py]

crates/ruff_benchmark/benches/parser.rs::parser::benchmark_parser

2 ms2 ms

formatter[numpy/globals.py]

crates/ruff_benchmark/benches/formatter.rs::formatter::benchmark_formatter

241.7 µs241.7 µs

formatter[pydantic/types.py]

crates/ruff_benchmark/benches/formatter.rs::formatter::benchmark_formatter

3.6 ms3.6 ms

formatter[unicode/pypinyin.py]

crates/ruff_benchmark/benches/formatter.rs::formatter::benchmark_formatter

664.2 µs664.2 µs

formatter[numpy/ctypeslib.py]

crates/ruff_benchmark/benches/formatter.rs::formatter::benchmark_formatter

1.9 ms1.9 ms

parser[large/dataset.py]

crates/ruff_benchmark/benches/parser.rs::parser::benchmark_parser

5 ms5 ms

lexer[large/dataset.py]

crates/ruff_benchmark/benches/lexer.rs::lexer::benchmark_lexer

1.1 ms1.1 ms

parser[numpy/globals.py]

crates/ruff_benchmark/benches/parser.rs::parser::benchmark_parser

105.8 µs105.8 µs

ty_check_file[incremental]

crates/ruff_benchmark/benches/ty.rs::check_file::benchmark_incremental

5.7 ms5.7 ms

lexer[pydantic/types.py]

crates/ruff_benchmark/benches/lexer.rs::lexer::benchmark_lexer

488.3 µs488.3 µs

lexer[numpy/ctypeslib.py]

crates/ruff_benchmark/benches/lexer.rs::lexer::benchmark_lexer

218.3 µs218.4 µs

linter/all-rules[numpy/ctypeslib.py]

crates/ruff_benchmark/benches/linter.rs::all_rules::benchmark_all_rules

4.1 ms4.1 ms

lexer[numpy/globals.py]

crates/ruff_benchmark/benches/lexer.rs::lexer::benchmark_lexer

29.1 µs29.1 µs

linter/all-rules[pydantic/types.py]

crates/ruff_benchmark/benches/linter.rs::all_rules::benchmark_all_rules

8.4 ms8.4 ms

linter/all-with-preview-rules[pydantic/types.py]

crates/ruff_benchmark/benches/linter.rs::preview_rules::benchmark_preview_rules

9.9 ms9.9 ms

linter/all-with-preview-rules[unicode/pypinyin.py]

crates/ruff_benchmark/benches/linter.rs::preview_rules::benchmark_preview_rules

-1%

2.1 ms2.1 ms

linter/all-with-preview-rules[numpy/ctypeslib.py]

crates/ruff_benchmark/benches/linter.rs::preview_rules::benchmark_preview_rules

-1%

4.8 ms4.9 ms

linter/all-with-preview-rules[numpy/globals.py]

crates/ruff_benchmark/benches/linter.rs::preview_rules::benchmark_preview_rules

-1%

797 µs802.9 µs

linter/all-with-preview-rules[large/dataset.py]

crates/ruff_benchmark/benches/linter.rs::preview_rules::benchmark_preview_rules

-1%

20.7 ms20.9 ms

linter/all-rules[numpy/globals.py]

crates/ruff_benchmark/benches/linter.rs::all_rules::benchmark_all_rules

-1%

698.6 µs705.7 µs

linter/all-rules[unicode/pypinyin.py]

crates/ruff_benchmark/benches/linter.rs::all_rules::benchmark_all_rules

-1%

1.8 ms1.8 ms

linter/all-rules[large/dataset.py]

crates/ruff_benchmark/benches/linter.rs::all_rules::benchmark_all_rules

-1%

17.1 ms17.3 ms

Commits

Click on a commit to change the comparison range

Base

main

4e83db4

-0.36%

convert to Rule "directly" from NoqaCode it's not exactly direct because we're still matching on a bunch of &'static strs, but it's better than having to call Rule::from_code, which has to format a string and then reparse the NoqaCode into pieces

08a227e

6 months ago

by ntBre

+0.26%

noqa_code().rule() instead of name().parse()

52a54a9

5 months ago

by ntBre

Home Terms Privacy Docs