alex/basic-liskov - Branch - astral-sh/ruff

[ty] Check method definitions on subclasses for Liskov violations

#21436

Comparing

alex/basic-liskov

(

c4b5edb

) with

main

(

192c37d

)

-10%

Regressions: 4

Untouched: 18

Skipped: 30

Benchmarks

Skipped (30)

These benchmarks were skipped, so their baseline results are used instead. If they were deleted in your codebase, archive them to remove them from the performance reports.
Learn more about archiving benchmarks

Uses the CPU Simulation instrument
to collect CPU performance metrics.

linter/all-rules[large/dataset.py]

crates/ruff_benchmark/benches/linter.rs::all_rules::benchmark_all_rules

Skipped

18.9 ms*

Uses the CPU Simulation instrument
to collect CPU performance metrics.

formatter[numpy/globals.py]

crates/ruff_benchmark/benches/formatter.rs::formatter::benchmark_formatter

Skipped

249.3 µs*

Uses the CPU Simulation instrument
to collect CPU performance metrics.

linter/all-with-preview-rules[numpy/globals.py]

crates/ruff_benchmark/benches/linter.rs::preview_rules::benchmark_preview_rules

Skipped

831.4 µs*

Uses the CPU Simulation instrument
to collect CPU performance metrics.

linter/all-rules[numpy/globals.py]

crates/ruff_benchmark/benches/linter.rs::all_rules::benchmark_all_rules

Skipped

735.2 µs*

Uses the CPU Simulation instrument
to collect CPU performance metrics.

lexer[large/dataset.py]

crates/ruff_benchmark/benches/lexer.rs::lexer::benchmark_lexer

Skipped

1.1 ms*

Uses the CPU Simulation instrument
to collect CPU performance metrics.

linter/all-with-preview-rules[unicode/pypinyin.py]

crates/ruff_benchmark/benches/linter.rs::preview_rules::benchmark_preview_rules

Skipped

2.2 ms*

Uses the CPU Simulation instrument
to collect CPU performance metrics.

linter/all-with-preview-rules[numpy/ctypeslib.py]

crates/ruff_benchmark/benches/linter.rs::preview_rules::benchmark_preview_rules

Skipped

5.2 ms*

Uses the CPU Simulation instrument
to collect CPU performance metrics.

linter/all-with-preview-rules[pydantic/types.py]

crates/ruff_benchmark/benches/linter.rs::preview_rules::benchmark_preview_rules

Skipped

10.2 ms*

Uses the CPU Simulation instrument
to collect CPU performance metrics.

linter/all-rules[pydantic/types.py]

crates/ruff_benchmark/benches/linter.rs::all_rules::benchmark_all_rules

Skipped

8.6 ms*

Uses the CPU Simulation instrument
to collect CPU performance metrics.

linter/default-rules[large/dataset.py]

crates/ruff_benchmark/benches/linter.rs::default_rules::benchmark_default_rules

Skipped

4.4 ms*

Uses the CPU Simulation instrument
to collect CPU performance metrics.

formatter[large/dataset.py]

crates/ruff_benchmark/benches/formatter.rs::formatter::benchmark_formatter

Skipped

9.7 ms*

Uses the CPU Simulation instrument
to collect CPU performance metrics.

linter/all-rules[numpy/ctypeslib.py]

crates/ruff_benchmark/benches/linter.rs::all_rules::benchmark_all_rules

Skipped

4.4 ms*

Uses the CPU Simulation instrument
to collect CPU performance metrics.

formatter[pydantic/types.py]

crates/ruff_benchmark/benches/formatter.rs::formatter::benchmark_formatter

Skipped

3.6 ms*

Uses the CPU Simulation instrument
to collect CPU performance metrics.

parser[large/dataset.py]

crates/ruff_benchmark/benches/parser.rs::parser::benchmark_parser

Skipped

5.1 ms*

Uses the CPU Simulation instrument
to collect CPU performance metrics.

formatter[numpy/ctypeslib.py]

crates/ruff_benchmark/benches/formatter.rs::formatter::benchmark_formatter

Skipped

2 ms*

Uses the CPU Simulation instrument
to collect CPU performance metrics.

formatter[unicode/pypinyin.py]

crates/ruff_benchmark/benches/formatter.rs::formatter::benchmark_formatter

Skipped

678.1 µs*

Uses the CPU Simulation instrument
to collect CPU performance metrics.

linter/default-rules[pydantic/types.py]

crates/ruff_benchmark/benches/linter.rs::default_rules::benchmark_default_rules

Skipped

2.2 ms*

Uses the CPU Simulation instrument
to collect CPU performance metrics.

lexer[unicode/pypinyin.py]

crates/ruff_benchmark/benches/lexer.rs::lexer::benchmark_lexer

Skipped

77.4 µs*

Uses the CPU Simulation instrument
to collect CPU performance metrics.

lexer[numpy/ctypeslib.py]

crates/ruff_benchmark/benches/lexer.rs::lexer::benchmark_lexer

Skipped

222.4 µs*

Uses the CPU Simulation instrument
to collect CPU performance metrics.

linter/default-rules[unicode/pypinyin.py]

crates/ruff_benchmark/benches/linter.rs::default_rules::benchmark_default_rules

Skipped

412.5 µs*

Uses the CPU Simulation instrument
to collect CPU performance metrics.

linter/default-rules[numpy/globals.py]

crates/ruff_benchmark/benches/linter.rs::default_rules::benchmark_default_rules

Skipped

210.3 µs*

Uses the CPU Simulation instrument
to collect CPU performance metrics.

linter/default-rules[numpy/ctypeslib.py]

crates/ruff_benchmark/benches/linter.rs::default_rules::benchmark_default_rules

Skipped

1 ms*

Uses the CPU Simulation instrument
to collect CPU performance metrics.

lexer[numpy/globals.py]

crates/ruff_benchmark/benches/lexer.rs::lexer::benchmark_lexer

Skipped

29.9 µs*

Uses the CPU Simulation instrument
to collect CPU performance metrics.

lexer[pydantic/types.py]

crates/ruff_benchmark/benches/lexer.rs::lexer::benchmark_lexer

Skipped

496.7 µs*

Uses the CPU Simulation instrument
to collect CPU performance metrics.

linter/all-with-preview-rules[large/dataset.py]

crates/ruff_benchmark/benches/linter.rs::preview_rules::benchmark_preview_rules

Skipped

22.6 ms*

Uses the CPU Simulation instrument
to collect CPU performance metrics.

parser[numpy/ctypeslib.py]

crates/ruff_benchmark/benches/parser.rs::parser::benchmark_parser

Skipped

956.5 µs*

Uses the CPU Simulation instrument
to collect CPU performance metrics.

parser[unicode/pypinyin.py]

crates/ruff_benchmark/benches/parser.rs::parser::benchmark_parser

Skipped

329.9 µs*

Uses the CPU Simulation instrument
to collect CPU performance metrics.

linter/all-rules[unicode/pypinyin.py]

crates/ruff_benchmark/benches/linter.rs::all_rules::benchmark_all_rules

Skipped

2 ms*

Uses the CPU Simulation instrument
to collect CPU performance metrics.

parser[numpy/globals.py]

crates/ruff_benchmark/benches/parser.rs::parser::benchmark_parser

Skipped

109.3 µs*

Uses the CPU Simulation instrument
to collect CPU performance metrics.

parser[pydantic/types.py]

crates/ruff_benchmark/benches/parser.rs::parser::benchmark_parser

Skipped

2.1 ms*

Failed

Uses the Wall Time instrument
to collect wall time performance metrics.

multithreaded[altair]

crates/ruff_benchmark/benches/ty_walltime.rs

Regression

-10%

559.5 ms622.4 ms

Uses the Wall Time instrument
to collect wall time performance metrics.

medium[static-frame]

crates/ruff_benchmark/benches/ty_walltime.rs

Regression

-7%

15.3 s16.5 s

Uses the Wall Time instrument
to collect wall time performance metrics.

small[tanjun]

crates/ruff_benchmark/benches/ty_walltime.rs

Regression

-5%

2.3 s2.5 s

Uses the CPU Simulation instrument
to collect CPU performance metrics.

anyio

crates/ruff_benchmark/benches/ty.rs::project::anyio::project

Regression

-5%

1.1 s1.1 s

Passed

Uses the CPU Simulation instrument
to collect CPU performance metrics.

ty_micro[complex_constrained_attributes_3]

crates/ruff_benchmark/benches/ty.rs::micro::benchmark_complex_constrained_attributes_3

+1%

70 ms69.6 ms

Uses the CPU Simulation instrument
to collect CPU performance metrics.

ty_micro[many_tuple_assignments]

crates/ruff_benchmark/benches/ty.rs::micro::benchmark_many_tuple_assignments

65.7 ms65.4 ms

Uses the CPU Simulation instrument
to collect CPU performance metrics.

ty_micro[many_tuple_assignments]

crates/ruff_benchmark/benches/ty.rs::micro::benchmark_tuple_implicit_instance_attributes

66.9 ms66.7 ms

Uses the CPU Simulation instrument
to collect CPU performance metrics.

ty_micro[complex_constrained_attributes_1]

crates/ruff_benchmark/benches/ty.rs::micro::benchmark_complex_constrained_attributes_1

69.7 ms69.6 ms

Uses the CPU Simulation instrument
to collect CPU performance metrics.

ty_micro[many_string_assignments]

crates/ruff_benchmark/benches/ty.rs::micro::benchmark_many_string_assignments

76.2 ms76.2 ms

Uses the CPU Simulation instrument
to collect CPU performance metrics.

ty_check_file[cold]

crates/ruff_benchmark/benches/ty.rs::check_file::benchmark_cold

135.2 ms135.3 ms

Uses the CPU Simulation instrument
to collect CPU performance metrics.

ty_micro[complex_constrained_attributes_2]

crates/ruff_benchmark/benches/ty.rs::micro::benchmark_complex_constrained_attributes_2

69.5 ms69.6 ms

Uses the CPU Simulation instrument
to collect CPU performance metrics.

ty_micro[many_enum_members]

crates/ruff_benchmark/benches/ty.rs::micro::benchmark_many_enum_members

93.7 ms94.1 ms

Uses the Wall Time instrument
to collect wall time performance metrics.

medium[colour-science]

crates/ruff_benchmark/benches/ty_walltime.rs

16.2 s16.3 s

Uses the CPU Simulation instrument
to collect CPU performance metrics.

ty_check_file[incremental]

crates/ruff_benchmark/benches/ty.rs::check_file::benchmark_incremental

-1%

6.3 ms6.3 ms

Uses the Wall Time instrument
to collect wall time performance metrics.

small[freqtrade]

crates/ruff_benchmark/benches/ty_walltime.rs

-1%

6.3 s6.4 s

Uses the CPU Simulation instrument
to collect CPU performance metrics.

attrs

crates/ruff_benchmark/benches/ty.rs::project::attrs::project

-1%

444.7 ms450.2 ms

Uses the Wall Time instrument
to collect wall time performance metrics.

large[pydantic]

crates/ruff_benchmark/benches/ty_walltime.rs

-1%

20.5 s20.7 s

Uses the CPU Simulation instrument
to collect CPU performance metrics.

DateType

crates/ruff_benchmark/benches/ty.rs::project::datetype::project

-2%

238.7 ms243 ms

Uses the CPU Simulation instrument
to collect CPU performance metrics.

hydra-zen

crates/ruff_benchmark/benches/ty.rs::project::hydra::project

-2%

1 s1 s

Uses the Wall Time instrument
to collect wall time performance metrics.

large[sympy]

crates/ruff_benchmark/benches/ty_walltime.rs

-2%

54.9 s56 s

Uses the Wall Time instrument
to collect wall time performance metrics.

small[altair]

crates/ruff_benchmark/benches/ty_walltime.rs

-2%

2.9 s3 s

Uses the Wall Time instrument
to collect wall time performance metrics.

medium[pandas]

crates/ruff_benchmark/benches/ty_walltime.rs

-4%

46.8 s48.5 s

Commits

Click on a commit to change the comparison range

Base

main

192c37d

-13.56%

snapshots and docs

da0cdfc

3 days ago

by AlexWaygood

+5.39%

add submodule doc-comment

7f918d7

3 days ago

by AlexWaygood

-0.85%

Merge branch 'main' into alex/basic-liskov

e4b2174

2 days ago

by AlexWaygood

-1.27%

Merge branch 'main' into alex/basic-liskov

a5f0983

2 days ago

by AlexWaygood

+0.19%

Apply suggestions from code review Co-authored-by: Carl Meyer <carl@astral.sh>

c4b5edb

2 days ago

by AlexWaygood

Home Terms Privacy Docs