ag/stabilize-completions - Branch - astral-sh/ruff

[ty] Stabilize completions

#18650Merged

Comparing

ag/stabilize-completions

(

2d2e906

) with

main

(

1f27d53

)

Untouched: 34

Benchmarks

Passed

ty_check_file[incremental]

crates/ruff_benchmark/benches/ty.rs::check_file::benchmark_incremental

5.7 ms5.7 ms

linter/all-rules[large/dataset.py]

crates/ruff_benchmark/benches/linter.rs::all_rules::benchmark_all_rules

16.5 ms16.5 ms

linter/all-with-preview-rules[large/dataset.py]

crates/ruff_benchmark/benches/linter.rs::preview_rules::benchmark_preview_rules

20.3 ms20.3 ms

linter/all-with-preview-rules[numpy/ctypeslib.py]

crates/ruff_benchmark/benches/linter.rs::preview_rules::benchmark_preview_rules

4.8 ms4.8 ms

linter/all-with-preview-rules[pydantic/types.py]

crates/ruff_benchmark/benches/linter.rs::preview_rules::benchmark_preview_rules

9.8 ms9.8 ms

formatter[numpy/ctypeslib.py]

crates/ruff_benchmark/benches/formatter.rs::formatter::benchmark_formatter

1.9 ms1.9 ms

formatter[numpy/globals.py]

crates/ruff_benchmark/benches/formatter.rs::formatter::benchmark_formatter

241.9 µs241.9 µs

linter/all-rules[pydantic/types.py]

crates/ruff_benchmark/benches/linter.rs::all_rules::benchmark_all_rules

8.2 ms8.2 ms

parser[pydantic/types.py]

crates/ruff_benchmark/benches/parser.rs::parser::benchmark_parser

1.9 ms1.9 ms

linter/all-rules[numpy/ctypeslib.py]

crates/ruff_benchmark/benches/linter.rs::all_rules::benchmark_all_rules

4 ms4 ms

linter/all-rules[unicode/pypinyin.py]

crates/ruff_benchmark/benches/linter.rs::all_rules::benchmark_all_rules

1.8 ms1.8 ms

formatter[large/dataset.py]

crates/ruff_benchmark/benches/formatter.rs::formatter::benchmark_formatter

9.5 ms9.5 ms

formatter[pydantic/types.py]

crates/ruff_benchmark/benches/formatter.rs::formatter::benchmark_formatter

3.5 ms3.5 ms

parser[numpy/ctypeslib.py]

crates/ruff_benchmark/benches/parser.rs::parser::benchmark_parser

918.5 µs918.5 µs

parser[large/dataset.py]

crates/ruff_benchmark/benches/parser.rs::parser::benchmark_parser

4.8 ms4.8 ms

lexer[unicode/pypinyin.py]

crates/ruff_benchmark/benches/lexer.rs::lexer::benchmark_lexer

75.2 µs75.2 µs

ty_micro[many_string_assignments]

crates/ruff_benchmark/benches/ty.rs::micro::benchmark_many_string_assignments

66 ms66 ms

linter/default-rules[pydantic/types.py]

crates/ruff_benchmark/benches/linter.rs::default_rules::benchmark_default_rules

2 ms2 ms

ty_micro[many_tuple_assignments]

crates/ruff_benchmark/benches/ty.rs::micro::benchmark_many_tuple_assignments

179.7 ms179.7 ms

ty_check_file[cold]

crates/ruff_benchmark/benches/ty.rs::check_file::benchmark_cold

117.6 ms117.6 ms

linter/default-rules[large/dataset.py]

crates/ruff_benchmark/benches/linter.rs::default_rules::benchmark_default_rules

4 ms4 ms

lexer[large/dataset.py]

crates/ruff_benchmark/benches/lexer.rs::lexer::benchmark_lexer

1.1 ms1.1 ms

linter/all-with-preview-rules[unicode/pypinyin.py]

crates/ruff_benchmark/benches/linter.rs::preview_rules::benchmark_preview_rules

2 ms2 ms

formatter[unicode/pypinyin.py]

crates/ruff_benchmark/benches/formatter.rs::formatter::benchmark_formatter

665.3 µs665.3 µs

linter/all-rules[numpy/globals.py]

crates/ruff_benchmark/benches/linter.rs::all_rules::benchmark_all_rules

672.3 µs672.4 µs

linter/default-rules[numpy/ctypeslib.py]

crates/ruff_benchmark/benches/linter.rs::default_rules::benchmark_default_rules

970.5 µs970.6 µs

lexer[pydantic/types.py]

crates/ruff_benchmark/benches/lexer.rs::lexer::benchmark_lexer

488.2 µs488.3 µs

linter/all-with-preview-rules[numpy/globals.py]

crates/ruff_benchmark/benches/linter.rs::preview_rules::benchmark_preview_rules

793.9 µs794 µs

parser[unicode/pypinyin.py]

crates/ruff_benchmark/benches/parser.rs::parser::benchmark_parser

306.6 µs306.6 µs

lexer[numpy/ctypeslib.py]

crates/ruff_benchmark/benches/lexer.rs::lexer::benchmark_lexer

218.2 µs218.3 µs

linter/default-rules[unicode/pypinyin.py]

crates/ruff_benchmark/benches/linter.rs::default_rules::benchmark_default_rules

380.9 µs381.1 µs

linter/default-rules[numpy/globals.py]

crates/ruff_benchmark/benches/linter.rs::default_rules::benchmark_default_rules

204.1 µs204.2 µs

parser[numpy/globals.py]

crates/ruff_benchmark/benches/parser.rs::parser::benchmark_parser

103.1 µs103.2 µs

lexer[numpy/globals.py]

crates/ruff_benchmark/benches/lexer.rs::lexer::benchmark_lexer

29 µs29.1 µs

Commits

Click on a commit to change the comparison range

Base

main

1f27d53

-0.01%

[ty] Stabilize completions Specifically, this PR reverts "Make completions an opt-in LSP feature (#17921)", corresponding to commit 51e2effd2d6b6cf61bd245a3219168fe661d1a7d. In practice, this means you don't need to opt into completions working by enabling experimental features. i.e., I was able to remove this from my LSP configuration: ``` "experimental": { "completions": { "enable": true } }, ``` There's still a lot of work left to do to make completions awesome, but I think it's in a state where it would be useful to get real user feedback. It's also meaningfully using ty to provide completions that use type information. Ref astral-sh/ty#86

2d2e906

7 months ago

by BurntSushi

Home Terms Privacy Docs