InquisitivePenguin:jane/settings/display-improvements - Branch - astral-sh/ruff

astral-sh

ruff

Instrumentation

Wall Time

Blog Docs Changelog

`--show-settings` displays active settings in a far more readable format

#9464Merged

Comparing

InquisitivePenguin:jane/settings/display-improvements

(

a24a50a

) with

main

(

fee64b5

)

-6%

Regressions: 1

Untouched: 29

Benchmarks

Failed

parser[numpy/ctypeslib.py]Regression

crates/ruff_benchmark/benches/parser.rs::parser::benchmark_parser::parser[numpy/ctypeslib.py]

-6%

2.3 ms2.5 ms

Passed

linter/default-rules[unicode/pypinyin.py]

crates/ruff_benchmark/benches/linter.rs::default_rules::benchmark_default_rules::linter/default-rules[unicode/pypinyin.py]

374.7 µs372.9 µs

linter/default-rules[large/dataset.py]

crates/ruff_benchmark/benches/linter.rs::default_rules::benchmark_default_rules::linter/default-rules[large/dataset.py]

4 ms4 ms

linter/default-rules[pydantic/types.py]

crates/ruff_benchmark/benches/linter.rs::default_rules::benchmark_default_rules::linter/default-rules[pydantic/types.py]

1.9 ms1.9 ms

linter/default-rules[numpy/globals.py]

crates/ruff_benchmark/benches/linter.rs::default_rules::benchmark_default_rules::linter/default-rules[numpy/globals.py]

186.8 µs186.5 µs

linter/default-rules[numpy/ctypeslib.py]

crates/ruff_benchmark/benches/linter.rs::default_rules::benchmark_default_rules::linter/default-rules[numpy/ctypeslib.py]

951.3 µs949.9 µs

linter/all-with-preview-rules[large/dataset.py]

crates/ruff_benchmark/benches/linter.rs::preview_rules::benchmark_preview_rules::linter/all-with-preview-rules[large/dataset.py]

23 ms23 ms

formatter[large/dataset.py]

crates/ruff_benchmark/benches/formatter.rs::formatter::benchmark_formatter::formatter[large/dataset.py]

9.9 ms9.9 ms

formatter[pydantic/types.py]

crates/ruff_benchmark/benches/formatter.rs::formatter::benchmark_formatter::formatter[pydantic/types.py]

3.7 ms3.7 ms

lexer[unicode/pypinyin.py]

crates/ruff_benchmark/benches/lexer.rs::lexer::benchmark_lexer::lexer[unicode/pypinyin.py]

105.2 µs105.2 µs

lexer[pydantic/types.py]

crates/ruff_benchmark/benches/lexer.rs::lexer::benchmark_lexer::lexer[pydantic/types.py]

670.9 µs670.9 µs

lexer[numpy/globals.py]

crates/ruff_benchmark/benches/lexer.rs::lexer::benchmark_lexer::lexer[numpy/globals.py]

47.4 µs47.4 µs

lexer[numpy/ctypeslib.py]

crates/ruff_benchmark/benches/lexer.rs::lexer::benchmark_lexer::lexer[numpy/ctypeslib.py]

329.5 µs329.5 µs

lexer[large/dataset.py]

crates/ruff_benchmark/benches/lexer.rs::lexer::benchmark_lexer::lexer[large/dataset.py]

1.5 ms1.5 ms

parser[numpy/globals.py]

crates/ruff_benchmark/benches/parser.rs::parser::benchmark_parser::parser[numpy/globals.py]

268.2 µs268.2 µs

parser[unicode/pypinyin.py]

crates/ruff_benchmark/benches/parser.rs::parser::benchmark_parser::parser[unicode/pypinyin.py]

850.3 µs850.4 µs

formatter[numpy/ctypeslib.py]

crates/ruff_benchmark/benches/formatter.rs::formatter::benchmark_formatter::formatter[numpy/ctypeslib.py]

2 ms2 ms

parser[pydantic/types.py]

crates/ruff_benchmark/benches/parser.rs::parser::benchmark_parser::parser[pydantic/types.py]

5 ms5 ms

formatter[unicode/pypinyin.py]

crates/ruff_benchmark/benches/formatter.rs::formatter::benchmark_formatter::formatter[unicode/pypinyin.py]

702 µs702.5 µs

linter/all-with-preview-rules[unicode/pypinyin.py]

crates/ruff_benchmark/benches/linter.rs::preview_rules::benchmark_preview_rules::linter/all-with-preview-rules[unicode/pypinyin.py]

2.8 ms2.9 ms

linter/all-with-preview-rules[numpy/ctypeslib.py]

crates/ruff_benchmark/benches/linter.rs::preview_rules::benchmark_preview_rules::linter/all-with-preview-rules[numpy/ctypeslib.py]

5.3 ms5.3 ms

formatter[numpy/globals.py]

crates/ruff_benchmark/benches/formatter.rs::formatter::benchmark_formatter::formatter[numpy/globals.py]

271 µs271.6 µs

linter/all-rules[unicode/pypinyin.py]

crates/ruff_benchmark/benches/linter.rs::all_rules::benchmark_all_rules::linter/all-rules[unicode/pypinyin.py]

2.6 ms2.6 ms

linter/all-rules[large/dataset.py]

crates/ruff_benchmark/benches/linter.rs::all_rules::benchmark_all_rules::linter/all-rules[large/dataset.py]

18.9 ms19 ms

linter/all-rules[numpy/globals.py]

crates/ruff_benchmark/benches/linter.rs::all_rules::benchmark_all_rules::linter/all-rules[numpy/globals.py]

740.3 µs743.5 µs

linter/all-rules[numpy/ctypeslib.py]

crates/ruff_benchmark/benches/linter.rs::all_rules::benchmark_all_rules::linter/all-rules[numpy/ctypeslib.py]

-1%

4.7 ms4.7 ms

linter/all-rules[pydantic/types.py]

crates/ruff_benchmark/benches/linter.rs::all_rules::benchmark_all_rules::linter/all-rules[pydantic/types.py]

-1%

9.1 ms9.2 ms

linter/all-with-preview-rules[pydantic/types.py]

crates/ruff_benchmark/benches/linter.rs::preview_rules::benchmark_preview_rules::linter/all-with-preview-rules[pydantic/types.py]

-1%

10.6 ms10.7 ms

parser[large/dataset.py]

crates/ruff_benchmark/benches/parser.rs::parser::benchmark_parser::parser[large/dataset.py]

-2%

12.8 ms13.1 ms

linter/all-with-preview-rules[numpy/globals.py]

crates/ruff_benchmark/benches/linter.rs::preview_rules::benchmark_preview_rules::linter/all-with-preview-rules[numpy/globals.py]

-3%

815.9 µs843.6 µs

Commits

Click on a commit to change the comparison range

Base

main

fee64b5

+0.02%

First-pass implementation of `Display` for `ruff_workspace::Settings` - A new utility macro, `display_settings`, has been created to reduce boilerplate for displaying settings fields - `Display` has been implemented on many custom types used in `ruff_workspace::Settings` - `--show-settings` now uses `Display` instead of `Debug` on `ruff_workspace::Settings` Work left to be done: - A lot of formatting for Vec<_> and HashSet<_> types has been stubbed out, using `Debug` as a fallback. There should be a way to add generic formatting support for these types as a modifier in `display_settings`. - Several complex types were also stubbed out and need proper `Display` implementations rather than falling back on `Debug` - An open question needs to be answered: should this output be valid TOML? How important is that?

651c1aa

2 years ago

by InquisitivePenguin

-0.15%

Eliminate unnessecary allocations in the `Display` implementations of `FilePatternSet` and `RuleSet`

afe986c

2 years ago

by InquisitivePenguin

-11.94%

Add `quoted` formatter to `display_settings` and document the `display_settings` macro

eb9c1fb

2 years ago

by InquisitivePenguin

+3.39%

Properly implement `Display` for `PerFileIgnores`

0ce38bc

2 years ago

by InquisitivePenguin

+8.38%

Merge branch 'main' of github.com:astral-sh/ruff into jane/settings/display-improvements

2856361

2 years ago

by InquisitivePenguin

+6.2%

Set up a snapshot test for the default output of `--show-settings`

14221b6

2 years ago

by InquisitivePenguin

Cleanup snapshot tests

14a8a6e

2 years ago

by InquisitivePenguin

Make `resolve_per_file_ignores` into an associated function

5793b60

2 years ago

by InquisitivePenguin

-11.49%

Merge branch 'main' of github.com:astral-sh/ruff into jane/settings/display-improvements

a24a50a

2 years ago

by InquisitivePenguin

Home Terms Privacy Docs