Daverball:feat/tch007-tch008 - Branch - astral-sh/ruff

[`flake8-type-checking`] Adds implementation for TC007 and TC008

#12927Merged

Comparing

Daverball:feat/tch007-tch008

(

8cf8f27

) with

main

(

e0f3eaf

)

Untouched: 32

Benchmarks

Passed

linter/all-rules[numpy/globals.py]

crates/ruff_benchmark/benches/linter.rs::all_rules::benchmark_all_rules

+1%

722.4 µs718.8 µs

linter/all-rules[pydantic/types.py]

crates/ruff_benchmark/benches/linter.rs::all_rules::benchmark_all_rules

8.6 ms8.5 ms

linter/all-rules[numpy/ctypeslib.py]

crates/ruff_benchmark/benches/linter.rs::all_rules::benchmark_all_rules

4.2 ms4.1 ms

linter/all-rules[unicode/pypinyin.py]

crates/ruff_benchmark/benches/linter.rs::all_rules::benchmark_all_rules

2.2 ms2.2 ms

red_knot_check_file[cold]

crates/ruff_benchmark/benches/red_knot.rs::check_file::benchmark_cold

63.7 ms63.6 ms

linter/all-rules[large/dataset.py]

crates/ruff_benchmark/benches/linter.rs::all_rules::benchmark_all_rules

16.7 ms16.7 ms

linter/default-rules[numpy/globals.py]

crates/ruff_benchmark/benches/linter.rs::default_rules::benchmark_default_rules

182.7 µs182.2 µs

linter/all-with-preview-rules[pydantic/types.py]

crates/ruff_benchmark/benches/linter.rs::preview_rules::benchmark_preview_rules

10 ms10 ms

linter/all-with-preview-rules[unicode/pypinyin.py]

crates/ruff_benchmark/benches/linter.rs::preview_rules::benchmark_preview_rules

2.4 ms2.4 ms

linter/all-with-preview-rules[large/dataset.py]

crates/ruff_benchmark/benches/linter.rs::preview_rules::benchmark_preview_rules

20 ms20 ms

linter/all-with-preview-rules[numpy/ctypeslib.py]

crates/ruff_benchmark/benches/linter.rs::preview_rules::benchmark_preview_rules

4.9 ms4.9 ms

linter/default-rules[unicode/pypinyin.py]

crates/ruff_benchmark/benches/linter.rs::default_rules::benchmark_default_rules

351.7 µs351.4 µs

linter/all-with-preview-rules[numpy/globals.py]

crates/ruff_benchmark/benches/linter.rs::preview_rules::benchmark_preview_rules

818.4 µs817.9 µs

red_knot_check_file[incremental]

crates/ruff_benchmark/benches/red_knot.rs::check_file::benchmark_incremental

3.9 ms3.9 ms

linter/default-rules[numpy/ctypeslib.py]

crates/ruff_benchmark/benches/linter.rs::default_rules::benchmark_default_rules

907.9 µs907.5 µs

lexer[numpy/ctypeslib.py]

crates/ruff_benchmark/benches/lexer.rs::lexer::benchmark_lexer

217.9 µs217.9 µs

lexer[pydantic/types.py]

crates/ruff_benchmark/benches/lexer.rs::lexer::benchmark_lexer

486.2 µs486.1 µs

formatter[numpy/ctypeslib.py]

crates/ruff_benchmark/benches/formatter.rs::formatter::benchmark_formatter

1.9 ms1.9 ms

formatter[pydantic/types.py]

crates/ruff_benchmark/benches/formatter.rs::formatter::benchmark_formatter

3.5 ms3.5 ms

formatter[large/dataset.py]

crates/ruff_benchmark/benches/formatter.rs::formatter::benchmark_formatter

9.5 ms9.5 ms

lexer[unicode/pypinyin.py]

crates/ruff_benchmark/benches/lexer.rs::lexer::benchmark_lexer

74.7 µs74.7 µs

lexer[large/dataset.py]

crates/ruff_benchmark/benches/lexer.rs::lexer::benchmark_lexer

1.1 ms1.1 ms

parser[pydantic/types.py]

crates/ruff_benchmark/benches/parser.rs::parser::benchmark_parser

2 ms2 ms

parser[large/dataset.py]

crates/ruff_benchmark/benches/parser.rs::parser::benchmark_parser

4.8 ms4.8 ms

parser[numpy/ctypeslib.py]

crates/ruff_benchmark/benches/parser.rs::parser::benchmark_parser

936 µs936.1 µs

parser[unicode/pypinyin.py]

crates/ruff_benchmark/benches/parser.rs::parser::benchmark_parser

310.8 µs310.9 µs

formatter[numpy/globals.py]

crates/ruff_benchmark/benches/formatter.rs::formatter::benchmark_formatter

244.2 µs244.2 µs

formatter[unicode/pypinyin.py]

crates/ruff_benchmark/benches/formatter.rs::formatter::benchmark_formatter

666.7 µs666.7 µs

parser[numpy/globals.py]

crates/ruff_benchmark/benches/parser.rs::parser::benchmark_parser

102.7 µs102.8 µs

lexer[numpy/globals.py]

crates/ruff_benchmark/benches/lexer.rs::lexer::benchmark_lexer

30.2 µs30.2 µs

linter/default-rules[large/dataset.py]

crates/ruff_benchmark/benches/linter.rs::default_rules::benchmark_default_rules

3.7 ms3.7 ms

linter/default-rules[pydantic/types.py]

crates/ruff_benchmark/benches/linter.rs::default_rules::benchmark_default_rules

1.9 ms1.9 ms

Commits

Click on a commit to change the comparison range

Base

main

e0f3eaf

+0.14%

Adds initial implementation for TCH008 The implementation for TCH007 is incomplete and also requires some changes to TCH004 in order to avoid conflicts between TCH004 and TCH007

3de92a5

1 year ago

by Daverball

-0.1%

Fixes mkdocs and clippy complaints

e1ca904

1 year ago

by Daverball

-9.25%

Fixes runtime forward reference binding lookup

3201588

1 year ago

by Daverball

+3.84%

Simulates proper runtime name lookups for more accurate results

bc45146

1 year ago

by Daverball

-0.01%

Adds missing test case back and fixes range overlap check Also fixes lexicographical lookup not taking shadowed bindings into account.

0df3d12

1 year ago

by Daverball

Fixes docstring

4cb32e1

1 year ago

by Daverball

-0.2%

Refactors class name book keeping code

d9cea8f

1 year ago

by Daverball

Removes unnecessary borrow

096eb9d

1 year ago

by Daverball

+5.76%

Fixes some logical errors and simplifies class name lookups

e420697

1 year ago

by Daverball

-0.01%

Guards against TC010/TCH008 overlap

fa9d4df

1 year ago

by Daverball

-0.22%

Adds implementation and tests for TCH007

dd78b52

1 year ago

by Daverball

-0.02%

Fixes TCH004/TCH007 overlap

08b7ddc

1 year ago

by Daverball

+0.13%

Merge branch 'main' into feat/tch007-tch008

bd31311

1 year ago

by Daverball

-0.1%

Merge branch 'main' into feat/tch007-tch008

b185e4b

1 year ago

by Daverball

+0.05%

Simplifies `quote_type_expression`

643ddb6

1 year ago

by Daverball

-0.12%

Fixes errors and only marks fix as unsafe when there are comments

81bb172

1 year ago

by Daverball

+0.01%

Removes unnecessary `return` statement

2555f8a

1 year ago

by Daverball

-0.02%

Merge branch 'main' into feat/tch007-tch008

a36bab6

1 year ago

by Daverball

-0.12%

Fixes new semantic flag values

6799411

1 year ago

by Daverball

+0.41%

`quote_type_annotation` is once again no longer guaranteed to work

bfffb7b

1 year ago

by Daverball

-0.03%

Addressed some of the feedback from the code review

fd051a8

1 year ago

by Daverball

+0.04%

Avoids changing the behavior of `TCH004` for now. Ensures there's no circularity issues between `TCH007` and `TCH008` by always running test cases with both rules enabled.

0fc0d4b

1 year ago

by Daverball

-0.12%

Apply suggestions from code review Co-authored-by: Carl Meyer <carl@oddbird.net>

f1ec697

1 year ago

by Daverball

-0.01%

Fixes snapshot and applies a couple of other suggestions

fd8c045

1 year ago

by Daverball

-0.15%

Remove dummy file that got committed by accident

42c33b2

1 year ago

by Daverball

Improves documentation and naming of type alias related methods/flags

f98400a

1 year ago

by Daverball

-0.01%

Merge branch 'main' into feat/tch007-tch008

4933178

1 year ago

by Daverball

-0.01%

Adjusts type alias naming to be more distinctive

cce3f00

1 year ago

by Daverball

-0.08%

Merge branch 'main' into feat/tch007-tch008

823caaa

1 year ago

by Daverball

-0.01%

Fixes error in `ruff.schema.json` introduced by merge

c8e0d99

1 year ago

by Daverball

+0.06%

Extends docstring for `simulate_runtime_load`

64c7d30

1 year ago

by Daverball

-0.01%

Fixes cross references in docstring

1bf6315

1 year ago

by Daverball

+0.24%

Address some of the code review comments

8cf8f27

1 year ago

by Daverball

Home Terms Privacy Docs