raise_value_error_invalid_last_modified - Branch - aio-libs/aiohttp

Raise `TypeError` when setting `StreamResponse.last_modified` to an unsupported type

#10146Merged

Comparing

raise_value_error_invalid_last_modified

(

1628210

) with

master

(

6200513

)

Untouched: 46

Ignored: 1

Benchmarks

Passed

test_resolve_root_route[pyloop]

tests/test_benchmarks_web_urldispatcher.py

+1%

915.9 µs904.5 µs

test_simple_web_stream_response

tests/test_benchmarks_web_response.py

+1%

239.6 µs237.1 µs

test_resolve_multiple_fixed_url_with_many_routes[pyloop]

tests/test_benchmarks_web_urldispatcher.py

+1%

2.3 ms2.2 ms

test_create_client_request_with_headers[pyloop]

tests/test_benchmarks_client_request.py

+1%

71.4 µs70.6 µs

test_resolve_root_route_with_many_fixed_routes[pyloop]

tests/test_benchmarks_web_urldispatcher.py

+1%

913.7 µs905.2 µs

test_resolve_multiple_level_fixed_url_with_many_routes[pyloop]

tests/test_benchmarks_web_urldispatcher.py

+1%

8.8 ms8.8 ms

test_resolve_single_fixed_url_with_many_routes[pyloop]

tests/test_benchmarks_web_urldispatcher.py

+1%

921 µs913.3 µs

test_resolve_static_root_route[pyloop]

tests/test_benchmarks_web_urldispatcher.py

+1%

1 ms1 ms

test_resolve_prefix_resources_many_prefix_many_plain[pyloop]

tests/test_benchmarks_web_urldispatcher.py

+1%

4.8 ms4.7 ms

test_resolve_dynamic_resource_url_with_many_dynamic_routes_with_common_prefix[pyloop]

tests/test_benchmarks_web_urldispatcher.py

+1%

259.5 ms258.1 ms

test_web_response_with_bytes_body

tests/test_benchmarks_web_response.py

+1%

543.6 µs540.8 µs

test_resolve_dynamic_resource_url_with_many_dynamic_routes[pyloop]

tests/test_benchmarks_web_urldispatcher.py

3.7 ms3.6 ms

test_simple_web_file_sendfile_fallback_response[pyloop]

tests/test_benchmarks_web_fileresponse.py

85.4 ms85.1 ms

test_create_client_request_with_cookies[pyloop]

tests/test_benchmarks_client_request.py

128.4 µs127.9 µs

test_resolve_dynamic_resource_url_with_many_static_routes[pyloop]

tests/test_benchmarks_web_urldispatcher.py

3.7 ms3.7 ms

test_load_cookies_into_temp_cookiejar

tests/test_benchmarks_cookiejar.py

202.4 µs201.7 µs

test_resolve_gitapi_root[pyloop]

tests/test_benchmarks_web_urldispatcher.py

2.1 ms2.1 ms

test_send_one_hundred_large_websocket_text_messages[pyloop]

tests/test_benchmarks_http_websocket.py

537 µs535.5 µs

test_serialize_headers

tests/test_benchmarks_http_writer.py

999.1 µs996.3 µs

test_simple_web_response

tests/test_benchmarks_web_response.py

452.9 µs451.8 µs

test_one_thousand_round_trip_websocket_text_messages[pyloop]

tests/test_benchmarks_client_ws.py

17.7 ms17.6 ms

test_resolve_gitapi_subapps[pyloop]

tests/test_benchmarks_web_urldispatcher.py

313.4 ms312.8 ms

test_send_one_hundred_websocket_text_messages_with_mask[pyloop]

tests/test_benchmarks_http_websocket.py

809 µs807.7 µs

test_send_client_request_one_hundred[pyloop]

tests/test_benchmarks_client_request.py

2.5 ms2.5 ms

test_web_response_with_text_body

tests/test_benchmarks_web_response.py

659 µs658.2 µs

test_client_request_update_cookies[pyloop]

tests/test_benchmarks_client_request.py

175.4 µs175.2 µs

test_send_one_hundred_websocket_compressed_messages[pyloop]

tests/test_benchmarks_http_websocket.py

3.2 ms3.2 ms

test_one_thousand_round_trip_websocket_binary_messages[pyloop]

tests/test_benchmarks_client_ws.py

17.2 ms17.2 ms

test_get_request_with_251308_compressed_chunked_payload[pyloop]

tests/test_benchmarks_client.py

465 ms464.9 ms

test_web_response_with_headers

tests/test_benchmarks_web_response.py

882.8 µs882.7 µs

test_read_large_binary_websocket_messages[pyloop]

tests/test_benchmarks_http_websocket.py

9.1 ms9.1 ms

test_send_one_hundred_websocket_text_messages[pyloop]

tests/test_benchmarks_http_websocket.py

570.9 µs571.2 µs

test_read_one_hundred_websocket_text_messages[pyloop]

tests/test_benchmarks_http_websocket.py

302 µs302.5 µs

test_simple_web_file_response_not_modified[pyloop]

tests/test_benchmarks_web_fileresponse.py

55.9 ms56 ms

test_resolve_gitapi[pyloop]

tests/test_benchmarks_web_urldispatcher.py

310.1 ms310.9 ms

test_one_hundred_get_requests_with_30000_chunked_payload[pyloop]

tests/test_benchmarks_client.py

42.2 ms42.4 ms

test_one_hundred_get_requests_with_1024_content_length_payload[pyloop]

tests/test_benchmarks_client.py

35.4 ms35.6 ms

test_ten_web_middlewares[pyloop]

tests/test_benchmarks_web_middleware.py

35.3 ms35.4 ms

test_one_hundred_get_requests_with_30000_content_length_payload[pyloop]

tests/test_benchmarks_client.py

39.3 ms39.5 ms

test_one_hundred_get_requests_with_1024_chunked_payload[pyloop]

tests/test_benchmarks_client.py

35.7 ms35.9 ms

test_one_hundred_simple_get_requests_multiple_methods_route[pyloop]

tests/test_benchmarks_client.py

-1%

32.2 ms32.4 ms

test_one_hundred_simple_post_requests[pyloop]

tests/test_benchmarks_client.py

-1%

36.9 ms37.1 ms

test_one_hundred_simple_get_requests[pyloop]

tests/test_benchmarks_client.py

-1%

32.4 ms32.6 ms

test_simple_web_file_response[pyloop]

tests/test_benchmarks_web_fileresponse.py

-1%

78.9 ms79.4 ms

test_one_thousand_large_round_trip_websocket_text_messages[pyloop]

tests/test_benchmarks_client_ws.py

-3%

23.4 ms24.2 ms

test_one_hundred_get_requests_with_512kib_content_length_payload[pyloop]

tests/test_benchmarks_client.py

-4%

165 ms171.5 ms

Ignored

test_one_hundred_get_requests_with_512kib_chunked_payload[pyloop]

tests/test_benchmarks_client.py

Ignored

211.4 ms211.6 ms

Commits

Click on a commit to change the comparison range

Base

master

6200513

+0.22%

changelog

4f44202

10 months ago

by bdraco

-0.12%

lint

63c91c5

10 months ago

by bdraco

-0.07%

TypeError makes more sense than ValueError

1628210

10 months ago

by bdraco

Home Terms Privacy Docs