aio-libs/aiohttp - CodSpeed

aiohttp

Performance History

Latest Results

Fix StreamResponse.last_modified rounding inconsistency between datetime and timestamp Setting last_modified from a float/int timestamp with a fractional second rounded up (math.ceil), while setting it from an equivalent datetime.datetime with the same fractional second truncated (dropped the microseconds via utctimetuple()). The same instant therefore produced two different Last-Modified headers depending on which type was used to set it. The float/int path's round-up behavior isn't arbitrary: FileResponse sets last_modified from a file's st_mtime (a float) through that exact branch, and rounding up guarantees the advertised Last-Modified is never earlier than the file's true modification time. Rounding down there could cause a conditional GET (If-Modified-Since) to falsely report a resource as unmodified within the same second it actually changed. Fix the datetime branch to match: round up to the next whole second when there's a fractional part, using the same reasoning and getting the same result as the float/int branch. Added a regression test that sets last_modified from a datetime and from a numerically equivalent timestamp with the same fractional second, and asserts both produce the same header. Confirmed the test fails without the fix (datetime path stays at the truncated second) and passes with it. Verification: this sandbox can't build aiohttp's C extensions in a depth-1 clone (needs the full llhttp vendor build), so I built and ran the actual test suite against a matching v3.14.1 tag checkout (same source line, buildable) with the fix applied and overlaid onto that installed package -- all 9 existing last_modified tests plus the new one pass, and the full test_web_response.py suite (182 tests, 33 skips for optional compression libs not installed here) passes. Fixes #5303

agu2347:fix-last-modified-rounding-consistency

11 minutes ago

master

4 hours ago

fix: upgrade http:// to https:// in README.rst

hanu-14:fix-https-readme-rst

5 hours ago

enforce __Host- and __Secure- cookie name prefixes in CookieJar

arshsmith1:cookie-prefix-enforcement

5 hours ago

Apply suggestion from @Dreamsorcerer

rodrigobnogueira:query-http-method

10 hours ago

Add the ssl parameter to ClientSession (#13122) Backport to 3.15 with adaptations: the session default is resolved before _merge_ssl_params in _request and _ws_connect (the merge treats any non-True ssl as explicit and would reject the sentinel when a legacy parameter is also given), the per-request isinstance checks from master are not carried over (_merge_ssl_params already validates ssl and would raise first, making them dead code on 3.15), the constructor validates its new ssl argument with the 3.x error message, SSL_ALLOWED_TYPES is imported in client.py, the docs version tags say 3.15, and tests cover the constructor, request and ws_connect validation paths. (cherry picked from commit bc3b5cf27e1a1c19b3320c4f36ba1f0f4b3e2b70)

rodrigobnogueira:backport-13122-3.15

11 hours ago

Fix C parser reporting the QUERY method as "<unknown>" llhttp already parses QUERY (RFC 10008, enum value 46), but the method table in _http_parser.pyx ended one entry short, so servers built with the C extensions saw "<unknown>" and answered 405 for routes registered for QUERY. Bump METHODS_COUNT to 47, declare HTTP_QUERY in _cparser.pxd, add hdrs.METH_QUERY, and mark QUERY idempotent for the client connection-retry logic per the RFC.

rodrigobnogueira:query-http-method

11 hours ago

rodrigobnogueira:query-http-method

12 hours ago

Latest Branches

Fix StreamResponse.last_modified rounding inconsistency between datetime and timestamp#13170

21 minutes ago

9d638a8

agu2347:fix-last-modified-rounding-consistency

fix: upgrade http:// to https:// in README.rst#13169

5 hours ago

692b0f6

hanu-14:fix-https-readme-rst

enforce __Host- and __Secure- cookie name prefixes in CookieJar#13168

5 hours ago

ca86660

arshsmith1:cookie-prefix-enforcement

Home Terms Privacy Docs