patchback/backports/3.12/678993a4bd071200fbcc14fa121c6673221aa540/pr-10101 - Branch - aio-libs/aiohttp

[PR #10101/678993a4 backport][3.12] Fix race in `FileResponse` if file is replaced during `prepare`

#10106Merged

Comparing

patchback/backports/3.12/678993a4bd071200fbcc14fa121c6673221aa540/pr-10101

(

1bd4cf1

) with

3.12

(

f180fc1

)

+16%

Improvements: 2

Untouched: 43

Ignored: 1

Benchmarks

Improved

test_simple_web_file_response[pyloop]

tests/test_benchmarks_web_fileresponse.py

+16%

95.6 ms82.7 ms

test_simple_web_file_sendfile_fallback_response[pyloop]

tests/test_benchmarks_web_fileresponse.py

+14%

100.9 ms88.9 ms

Passed

test_web_response_with_bytes_body

tests/test_benchmarks_web_response.py

+1%

575 µs566.7 µs

test_simple_web_response

tests/test_benchmarks_web_response.py

+1%

481.9 µs475.3 µs

test_resolve_root_route[pyloop]

tests/test_benchmarks_web_urldispatcher.py

+1%

935.7 µs925.8 µs

test_resolve_static_root_route[pyloop]

tests/test_benchmarks_web_urldispatcher.py

+1%

1.1 ms1.1 ms

test_web_response_with_headers

tests/test_benchmarks_web_response.py

+1%

914.9 µs906.5 µs

test_simple_web_stream_response

tests/test_benchmarks_web_response.py

+1%

278.8 µs276.6 µs

test_send_one_hundred_websocket_text_messages[pyloop]

tests/test_benchmarks_http_websocket.py

+1%

566.1 µs562 µs

test_resolve_prefix_resources_many_prefix_many_plain[pyloop]

tests/test_benchmarks_web_urldispatcher.py

+1%

5.2 ms5.2 ms

test_resolve_root_route_with_many_fixed_routes[pyloop]

tests/test_benchmarks_web_urldispatcher.py

+1%

932.9 µs927.3 µs

test_web_response_with_text_body

tests/test_benchmarks_web_response.py

692.3 µs689.2 µs

test_resolve_multiple_level_fixed_url_with_many_routes[pyloop]

tests/test_benchmarks_web_urldispatcher.py

9 ms8.9 ms

test_send_one_hundred_websocket_text_messages_with_mask[pyloop]

tests/test_benchmarks_http_websocket.py

808 µs804.9 µs

test_resolve_single_fixed_url_with_many_routes[pyloop]

tests/test_benchmarks_web_urldispatcher.py

935.7 µs933 µs

test_resolve_multiple_fixed_url_with_many_routes[pyloop]

tests/test_benchmarks_web_urldispatcher.py

2.3 ms2.3 ms

test_resolve_dynamic_resource_url_with_many_static_routes[pyloop]

tests/test_benchmarks_web_urldispatcher.py

3.7 ms3.7 ms

test_resolve_gitapi_root[pyloop]

tests/test_benchmarks_web_urldispatcher.py

2.1 ms2.1 ms

test_one_hundred_get_requests_with_1024_content_length_payload[pyloop]

tests/test_benchmarks_client.py

35.9 ms35.8 ms

test_resolve_gitapi[pyloop]

tests/test_benchmarks_web_urldispatcher.py

317.2 ms316.9 ms

test_one_hundred_get_requests_with_30000_content_length_payload[pyloop]

tests/test_benchmarks_client.py

39.7 ms39.7 ms

test_one_hundred_get_requests_with_1024_chunked_payload[pyloop]

tests/test_benchmarks_client.py

37.2 ms37.2 ms

test_resolve_dynamic_resource_url_with_many_dynamic_routes[pyloop]

tests/test_benchmarks_web_urldispatcher.py

3.7 ms3.7 ms

test_ten_web_middlewares[pyloop]

tests/test_benchmarks_web_middleware.py

35.8 ms35.7 ms

test_one_hundred_get_requests_with_512kib_content_length_payload[pyloop]

tests/test_benchmarks_client.py

167 ms166.9 ms

test_one_hundred_get_requests_with_30000_chunked_payload[pyloop]

tests/test_benchmarks_client.py

40.9 ms40.9 ms

test_get_request_with_251308_compressed_chunked_payload[pyloop]

tests/test_benchmarks_client.py

464.9 ms464.8 ms

test_load_cookies_into_temp_cookiejar

tests/test_benchmarks_cookiejar.py

209.6 µs209.6 µs

test_one_hundred_simple_post_requests[pyloop]

tests/test_benchmarks_client.py

37.3 ms37.3 ms

test_send_client_request_one_hundred[pyloop]

tests/test_benchmarks_client_request.py

2.5 ms2.5 ms

test_one_hundred_simple_get_requests_multiple_methods_route[pyloop]

tests/test_benchmarks_client.py

32.6 ms32.6 ms

test_one_hundred_simple_get_requests[pyloop]

tests/test_benchmarks_client.py

32.9 ms32.9 ms

test_read_large_binary_websocket_messages[pyloop]

tests/test_benchmarks_http_websocket.py

9.1 ms9.1 ms

test_one_thousand_round_trip_websocket_text_messages[pyloop]

tests/test_benchmarks_client_ws.py

17 ms17 ms

test_resolve_gitapi_subapps[pyloop]

tests/test_benchmarks_web_urldispatcher.py

321.9 ms322.2 ms

test_client_request_update_cookies[pyloop]

tests/test_benchmarks_client_request.py

174.5 µs174.7 µs

test_send_one_hundred_large_websocket_text_messages[pyloop]

tests/test_benchmarks_http_websocket.py

538.7 µs539.3 µs

test_one_thousand_round_trip_websocket_binary_messages[pyloop]

tests/test_benchmarks_client_ws.py

16.6 ms16.6 ms

test_send_one_hundred_websocket_compressed_messages[pyloop]

tests/test_benchmarks_http_websocket.py

3.3 ms3.3 ms

test_resolve_dynamic_resource_url_with_many_dynamic_routes_with_common_prefix[pyloop]

tests/test_benchmarks_web_urldispatcher.py

260.2 ms261.4 ms

test_serialize_headers

tests/test_benchmarks_http_writer.py

999.9 µs1,004.7 µs

test_create_client_request_with_cookies[pyloop]

tests/test_benchmarks_client_request.py

-1%

130.4 µs131.1 µs

test_read_one_hundred_websocket_text_messages[pyloop]

tests/test_benchmarks_http_websocket.py

-1%

308.6 µs311.7 µs

test_one_thousand_large_round_trip_websocket_text_messages[pyloop]

tests/test_benchmarks_client_ws.py

-2%

24.3 ms24.7 ms

test_create_client_request_with_headers[pyloop]

tests/test_benchmarks_client_request.py

-2%

69.7 µs71.4 µs

Ignored

test_one_hundred_get_requests_with_512kib_chunked_payload[pyloop]

tests/test_benchmarks_client.py

Ignored

168.1 ms168 ms

Commits

Click on a commit to change the comparison range

Base

3.12

f180fc1

+15.54%

Fix race in `FileResponse` if file is replaced during `prepare` (#10101) (cherry picked from commit 678993a4bd071200fbcc14fa121c6673221aa540)

1bd4cf1

11 months ago

by bdraco

Home Terms Privacy Docs