patchback/backports/3.12/3f07b1a38beffc350adbf51a605d27fe306de66c/pr-10154 - Branch - aio-libs/aiohttp

[PR #10154/3f07b1a3 backport][3.12] Update StreamResponse.write annotation for strict-bytes

#10158Merged

Comparing

patchback/backports/3.12/3f07b1a38beffc350adbf51a605d27fe306de66c/pr-10154

(

a31cc46

) with

3.12

(

51cdda8

)

Improvements: 0

Regressions: 0

Untouched: 46

New: 0

Dropped: 0

Ignored: 1

Benchmarks

Passed

test_one_thousand_large_round_trip_websocket_text_messages[pyloop]

tests/test_benchmarks_client_ws.py::test_one_thousand_large_round_trip_websocket_text_messages[pyloop]

+3%

24 ms

23.3 ms

test_send_one_hundred_websocket_text_messages[pyloop]

tests/test_benchmarks_http_websocket.py::test_send_one_hundred_websocket_text_messages[pyloop]

+2%

571.4 µs

560.6 µs

test_load_cookies_into_temp_cookiejar

tests/test_benchmarks_cookiejar.py::test_load_cookies_into_temp_cookiejar

+1%

206.2 µs

203.5 µs

test_client_request_update_cookies[pyloop]

tests/test_benchmarks_client_request.py::test_client_request_update_cookies[pyloop]

+1%

176.1 µs

175 µs

test_send_one_hundred_websocket_text_messages_with_mask[pyloop]

tests/test_benchmarks_http_websocket.py::test_send_one_hundred_websocket_text_messages_with_mask[pyloop]

+1%

810.2 µs

805.4 µs

test_resolve_root_route[pyloop]

tests/test_benchmarks_web_urldispatcher.py::test_resolve_root_route[pyloop]

908.4 µs

904.4 µs

test_web_response_with_text_body

tests/test_benchmarks_web_response.py::test_web_response_with_text_body

673.2 µs

670.3 µs

test_simple_web_file_response[pyloop]

tests/test_benchmarks_web_fileresponse.py::test_simple_web_file_response[pyloop]

79.3 ms

79.1 ms

test_resolve_prefix_resources_many_prefix_many_plain[pyloop]

tests/test_benchmarks_web_urldispatcher.py::test_resolve_prefix_resources_many_prefix_many_plain[pyloop]

5 ms

test_resolve_single_fixed_url_with_many_routes[pyloop]

tests/test_benchmarks_web_urldispatcher.py::test_resolve_single_fixed_url_with_many_routes[pyloop]

911.6 µs

908.9 µs

test_resolve_gitapi_subapps[pyloop]

tests/test_benchmarks_web_urldispatcher.py::test_resolve_gitapi_subapps[pyloop]

311.1 ms

310.4 ms

test_resolve_dynamic_resource_url_with_many_static_routes[pyloop]

tests/test_benchmarks_web_urldispatcher.py::test_resolve_dynamic_resource_url_with_many_static_routes[pyloop]

3.7 ms

3.6 ms

test_simple_web_file_sendfile_fallback_response[pyloop]

tests/test_benchmarks_web_fileresponse.py::test_simple_web_file_sendfile_fallback_response[pyloop]

85.2 ms

85 ms

test_serialize_headers

tests/test_benchmarks_http_writer.py::test_serialize_headers

998.1 µs

996.2 µs

test_resolve_static_root_route[pyloop]

tests/test_benchmarks_web_urldispatcher.py::test_resolve_static_root_route[pyloop]

1 ms

test_resolve_multiple_level_fixed_url_with_many_routes[pyloop]

tests/test_benchmarks_web_urldispatcher.py::test_resolve_multiple_level_fixed_url_with_many_routes[pyloop]

8.8 ms

test_resolve_dynamic_resource_url_with_many_dynamic_routes[pyloop]

tests/test_benchmarks_web_urldispatcher.py::test_resolve_dynamic_resource_url_with_many_dynamic_routes[pyloop]

3.6 ms

test_ten_web_middlewares[pyloop]

tests/test_benchmarks_web_middleware.py::test_ten_web_middlewares[pyloop]

35.5 ms

35.4 ms

test_send_one_hundred_websocket_compressed_messages[pyloop]

tests/test_benchmarks_http_websocket.py::test_send_one_hundred_websocket_compressed_messages[pyloop]

3.2 ms

test_one_hundred_get_requests_with_512kib_content_length_payload[pyloop]

tests/test_benchmarks_client.py::test_one_hundred_get_requests_with_512kib_content_length_payload[pyloop]

165.2 ms

165.1 ms

test_resolve_root_route_with_many_fixed_routes[pyloop]

tests/test_benchmarks_web_urldispatcher.py::test_resolve_root_route_with_many_fixed_routes[pyloop]

906.2 µs

905.8 µs

test_get_request_with_251308_compressed_chunked_payload[pyloop]

tests/test_benchmarks_client.py::test_get_request_with_251308_compressed_chunked_payload[pyloop]

464.9 ms

464.8 ms

test_one_hundred_simple_get_requests_multiple_methods_route[pyloop]

tests/test_benchmarks_client.py::test_one_hundred_simple_get_requests_multiple_methods_route[pyloop]

32.4 ms

test_resolve_gitapi_root[pyloop]

tests/test_benchmarks_web_urldispatcher.py::test_resolve_gitapi_root[pyloop]

2.1 ms

test_one_hundred_simple_get_requests[pyloop]

tests/test_benchmarks_client.py::test_one_hundred_simple_get_requests[pyloop]

32.6 ms

test_one_hundred_get_requests_with_1024_chunked_payload[pyloop]

tests/test_benchmarks_client.py::test_one_hundred_get_requests_with_1024_chunked_payload[pyloop]

36 ms

test_read_large_binary_websocket_messages[pyloop]

tests/test_benchmarks_http_websocket.py::test_read_large_binary_websocket_messages[pyloop]

9.1 ms

test_resolve_multiple_fixed_url_with_many_routes[pyloop]

tests/test_benchmarks_web_urldispatcher.py::test_resolve_multiple_fixed_url_with_many_routes[pyloop]

2.3 ms

test_one_hundred_get_requests_with_30000_content_length_payload[pyloop]

tests/test_benchmarks_client.py::test_one_hundred_get_requests_with_30000_content_length_payload[pyloop]

39.5 ms

test_one_hundred_get_requests_with_30000_chunked_payload[pyloop]

tests/test_benchmarks_client.py::test_one_hundred_get_requests_with_30000_chunked_payload[pyloop]

42.4 ms

test_simple_web_file_response_not_modified[pyloop]

tests/test_benchmarks_web_fileresponse.py::test_simple_web_file_response_not_modified[pyloop]

56 ms

test_web_response_with_headers

tests/test_benchmarks_web_response.py::test_web_response_with_headers

903 µs

903.6 µs

test_one_hundred_get_requests_with_1024_content_length_payload[pyloop]

tests/test_benchmarks_client.py::test_one_hundred_get_requests_with_1024_content_length_payload[pyloop]

35.6 ms

test_one_hundred_simple_post_requests[pyloop]

tests/test_benchmarks_client.py::test_one_hundred_simple_post_requests[pyloop]

37.1 ms

37.2 ms

test_resolve_dynamic_resource_url_with_many_dynamic_routes_with_common_prefix[pyloop]

tests/test_benchmarks_web_urldispatcher.py::test_resolve_dynamic_resource_url_with_many_dynamic_routes_with_common_prefix[pyloop]

260.4 ms

260.7 ms

test_send_client_request_one_hundred[pyloop]

tests/test_benchmarks_client_request.py::test_send_client_request_one_hundred[pyloop]

2.5 ms

test_simple_web_response

tests/test_benchmarks_web_response.py::test_simple_web_response

466.3 µs

467 µs

test_read_one_hundred_websocket_text_messages[pyloop]

tests/test_benchmarks_http_websocket.py::test_read_one_hundred_websocket_text_messages[pyloop]

301.1 µs

301.7 µs

test_one_thousand_round_trip_websocket_binary_messages[pyloop]

tests/test_benchmarks_client_ws.py::test_one_thousand_round_trip_websocket_binary_messages[pyloop]

17.2 ms

test_send_one_hundred_large_websocket_text_messages[pyloop]

tests/test_benchmarks_http_websocket.py::test_send_one_hundred_large_websocket_text_messages[pyloop]

538.8 µs

540.8 µs

test_web_response_with_bytes_body

tests/test_benchmarks_web_response.py::test_web_response_with_bytes_body

554.1 µs

556.6 µs

test_one_thousand_round_trip_websocket_text_messages[pyloop]

tests/test_benchmarks_client_ws.py::test_one_thousand_round_trip_websocket_text_messages[pyloop]

17.7 ms

test_simple_web_stream_response

tests/test_benchmarks_web_response.py::test_simple_web_stream_response

-1%

245.5 µs

247.4 µs

test_resolve_gitapi[pyloop]

tests/test_benchmarks_web_urldispatcher.py::test_resolve_gitapi[pyloop]

-1%

304.8 ms

307.3 ms

test_create_client_request_with_cookies[pyloop]

tests/test_benchmarks_client_request.py::test_create_client_request_with_cookies[pyloop]

-1%

128.4 µs

129.8 µs

test_create_client_request_with_headers[pyloop]

tests/test_benchmarks_client_request.py::test_create_client_request_with_headers[pyloop]

-1%

71.2 µs

72 µs

Ignored

test_one_hundred_get_requests_with_512kib_chunked_payload[pyloop]Ignored

tests/test_benchmarks_client.py::test_one_hundred_get_requests_with_512kib_chunked_payload[pyloop]

211.8 ms

Commits

Click on a commit to change the comparison range

Base

3.12

51cdda8

Update StreamResponse.write annotation for strict-bytes (#10154) ## What do these changes do? Mypy will add a `--strict-bytes` flag. https://github.com/python/mypy/pull/18263 With that `bytearray` and `memoryview` are no longer subclasses of `bytes` and must be listed explicitly instead if they are supported. ## Are there changes in behavior for the user? -- ## Related issue number -- ## Checklist - [ ] I think the code is well written - [ ] Unit tests for the changes exist - [ ] Documentation reflects the changes - [ ] If you provide code modification, please add yourself to `CONTRIBUTORS.txt` * The format is <Name> <Surname>. * Please keep alphabetical order, the file is sorted by names. - [ ] Add a new news fragment into the `CHANGES/` folder * name it `<issue_or_pr_num>.<type>.rst` (e.g. `588.bugfix.rst`) * if you don't have an issue number, change it to the pull request number after creating the PR * `.bugfix`: A bug fix for something the maintainers deemed an improper undesired behavior that got corrected to match pre-agreed expectations. * `.feature`: A new behavior, public APIs. That sort of stuff. * `.deprecation`: A declaration of future API removals and breaking changes in behavior. * `.breaking`: When something public is removed in a breaking way. Could be deprecated in an earlier release. * `.doc`: Notable updates to the documentation structure or build process. * `.packaging`: Notes for downstreams about unobvious side effects and tooling. Changes in the test invocation considerations and runtime assumptions. * `.contrib`: Stuff that affects the contributor experience. e.g. Running tests, building the docs, setting up the development environment. * `.misc`: Changes that are hard to assign to any of the above categories. * Make sure to use full sentences with correct case and punctuation, for example: ```rst Fixed issue with non-ascii contents in doctest text files -- by :user:`contributor-gh-handle`. ``` Use the past tense or the present tense a non-imperative mood, referring to what's changed compared to the last released version of this project. --------- Co-authored-by: J. Nick Koston <nick@koston.org> (cherry picked from commit 3f07b1a38beffc350adbf51a605d27fe306de66c)

a31cc46

8 months ago

by cdce8p

Home Terms Privacy Docs