mdellweg:fix_sub_chunk_file_resonse - Branch - aio-libs/aiohttp

Fix FileResponse fallback code

#6726

Comparing

mdellweg:fix_sub_chunk_file_resonse

(

e9e0f61

) with

master

(

237d467

)

Untouched: 46

Ignored: 1

Benchmarks

Passed

test_send_client_request_one_hundred[pyloop]

tests/test_benchmarks_client_request.py

+2%

2.5 ms2.5 ms

test_web_response_with_bytes_body

tests/test_benchmarks_web_response.py

+1%

538.4 µs534.8 µs

test_client_request_update_cookies[pyloop]

tests/test_benchmarks_client_request.py

+1%

168.8 µs167.7 µs

test_read_one_hundred_websocket_text_messages[pyloop]

tests/test_benchmarks_http_websocket.py

+1%

295.3 µs293.4 µs

test_simple_web_response

tests/test_benchmarks_web_response.py

+1%

446.6 µs443.8 µs

test_simple_web_file_sendfile_fallback_response[pyloop]

tests/test_benchmarks_web_fileresponse.py

+1%

85.4 ms84.9 ms

test_one_hundred_get_requests_with_1024_chunked_payload[pyloop]

tests/test_benchmarks_client.py

35.8 ms35.6 ms

test_resolve_root_route[pyloop]

tests/test_benchmarks_web_urldispatcher.py

908.6 µs904.7 µs

test_simple_web_file_response_not_modified[pyloop]

tests/test_benchmarks_web_fileresponse.py

55.7 ms55.5 ms

test_resolve_dynamic_resource_url_with_many_dynamic_routes[pyloop]

tests/test_benchmarks_web_urldispatcher.py

3.6 ms3.6 ms

test_one_hundred_get_requests_with_30000_chunked_payload[pyloop]

tests/test_benchmarks_client.py

42.3 ms42.1 ms

test_serialize_headers

tests/test_benchmarks_http_writer.py

1 ms1 ms

test_one_hundred_simple_post_requests[pyloop]

tests/test_benchmarks_client.py

37 ms36.9 ms

test_one_hundred_get_requests_with_1024_content_length_payload[pyloop]

tests/test_benchmarks_client.py

35.4 ms35.3 ms

test_ten_web_middlewares[pyloop]

tests/test_benchmarks_web_middleware.py

35.3 ms35.2 ms

test_resolve_dynamic_resource_url_with_many_static_routes[pyloop]

tests/test_benchmarks_web_urldispatcher.py

3.6 ms3.6 ms

test_one_hundred_simple_get_requests[pyloop]

tests/test_benchmarks_client.py

32.5 ms32.4 ms

test_simple_web_stream_response

tests/test_benchmarks_web_response.py

237.8 µs237.1 µs

test_one_hundred_get_requests_with_30000_content_length_payload[pyloop]

tests/test_benchmarks_client.py

39.6 ms39.5 ms

test_one_hundred_simple_get_requests_multiple_methods_route[pyloop]

tests/test_benchmarks_client.py

32.2 ms32.1 ms

test_simple_web_file_response[pyloop]

tests/test_benchmarks_web_fileresponse.py

78.8 ms78.6 ms

test_resolve_dynamic_resource_url_with_many_dynamic_routes_with_common_prefix[pyloop]

tests/test_benchmarks_web_urldispatcher.py

256.6 ms256.2 ms

test_web_response_with_text_body

tests/test_benchmarks_web_response.py

654.5 µs653.9 µs

test_read_large_binary_websocket_messages[pyloop]

tests/test_benchmarks_http_websocket.py

9.1 ms9.1 ms

test_one_hundred_get_requests_with_512kib_content_length_payload[pyloop]

tests/test_benchmarks_client.py

164.9 ms164.8 ms

test_get_request_with_251308_compressed_chunked_payload[pyloop]

tests/test_benchmarks_client.py

426 ms425.9 ms

test_send_one_hundred_websocket_compressed_messages[pyloop]

tests/test_benchmarks_http_websocket.py

3 ms3 ms

test_create_client_request_with_headers[pyloop]

tests/test_benchmarks_client_request.py

69.7 µs69.8 µs

test_one_thousand_round_trip_websocket_text_messages[pyloop]

tests/test_benchmarks_client_ws.py

17.5 ms17.5 ms

test_resolve_multiple_fixed_url_with_many_routes[pyloop]

tests/test_benchmarks_web_urldispatcher.py

2.2 ms2.2 ms

test_resolve_root_route_with_many_fixed_routes[pyloop]

tests/test_benchmarks_web_urldispatcher.py

901.3 µs902.3 µs

test_one_thousand_round_trip_websocket_binary_messages[pyloop]

tests/test_benchmarks_client_ws.py

17 ms17 ms

test_send_one_hundred_large_websocket_text_messages[pyloop]

tests/test_benchmarks_http_websocket.py

537.1 µs537.9 µs

test_resolve_gitapi_subapps[pyloop]

tests/test_benchmarks_web_urldispatcher.py

306.4 ms307 ms

test_one_thousand_large_round_trip_websocket_text_messages[pyloop]

tests/test_benchmarks_client_ws.py

24 ms24 ms

test_resolve_gitapi[pyloop]

tests/test_benchmarks_web_urldispatcher.py

304.1 ms304.8 ms

test_resolve_prefix_resources_many_prefix_many_plain[pyloop]

tests/test_benchmarks_web_urldispatcher.py

4.7 ms4.7 ms

test_web_response_with_headers

tests/test_benchmarks_web_response.py

884.4 µs888.2 µs

test_resolve_gitapi_root[pyloop]

tests/test_benchmarks_web_urldispatcher.py

-1%

2.1 ms2.1 ms

test_send_one_hundred_websocket_text_messages[pyloop]

tests/test_benchmarks_http_websocket.py

-1%

557.9 µs561 µs

test_resolve_single_fixed_url_with_many_routes[pyloop]

tests/test_benchmarks_web_urldispatcher.py

-1%

906.1 µs911.3 µs

test_resolve_static_root_route[pyloop]

tests/test_benchmarks_web_urldispatcher.py

-1%

995 µs1,000.7 µs

test_send_one_hundred_websocket_text_messages_with_mask[pyloop]

tests/test_benchmarks_http_websocket.py

-1%

791.8 µs796.5 µs

test_resolve_multiple_level_fixed_url_with_many_routes[pyloop]

tests/test_benchmarks_web_urldispatcher.py

-1%

8.7 ms8.8 ms

test_create_client_request_with_cookies[pyloop]

tests/test_benchmarks_client_request.py

-2%

126.3 µs128.8 µs

test_load_cookies_into_temp_cookiejar

tests/test_benchmarks_cookiejar.py

-2%

197.2 µs201.6 µs

Ignored

test_one_hundred_get_requests_with_512kib_chunked_payload[pyloop]

tests/test_benchmarks_client.py

Ignored

+5%

234 ms222.6 ms

Commits

Click on a commit to change the comparison range

Base

master

237d467

-0.08%

Fix FileResponse fallback code In case the FileResponse is using _sendfile_fallback and the requested range is smaller then the chunk size, we need to only read and send count bytes.

0ac82e1

4 years ago

by mdellweg

+0.07%

DO NOT MERGE Trying to demonstrate that the test will not even fail when too many bytes are sent.

e9e0f61

1 year ago

by mdellweg

Home Terms Privacy Docs