Fix TCPConnector.close() resolver race on non-cached path (#12497)
#12498Comparing
masonwilde:fix-connector-resolver-close-race
(13a63bf
) withmaster
(9bc498b
)+9%
- Improvement
- 2
- Untouched
- 70
- Skipped
- 69
No successful run was found on master ( 65b42bb) during the generation of this report, so 9bc498b was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.
Benchmarks
141 total
test_client_receive_large_websocket_compressed_messages[zlib_ng.zlib_ng]
tests/test_benchmarks_client_ws.py+9%
29.9 ms27.5 ms
test_client_send_large_websocket_compressed_messages[zlib_ng.zlib_ng]
tests/test_benchmarks_client_ws.py+9%
30 ms27.6 ms
test_ten_compressed_responses_iter_chunked_1mb[isal.isal_zlib]
tests/test_benchmarks_client.py+5%
55.2 ms52.6 ms
test_ten_compressed_responses_iter_chunked_1mb[zlib_ng.zlib_ng]
tests/test_benchmarks_client.py+4%
64.1 ms61.7 ms
test_read_compressed_post_body[zlib]
tests/test_benchmarks_web_request.py+2%
41 ms40.3 ms
test_create_client_request_with_headers
tests/test_benchmarks_client_request.py+2%
72.9 µs71.7 µs
test_one_thousand_large_round_trip_websocket_text_messages
tests/test_benchmarks_client_ws.py+2%
21.3 ms20.9 ms
test_resolve_root_route_with_many_fixed_routes
tests/test_benchmarks_web_urldispatcher.py+1%
955 µs947.5 µs
test_resolve_root_route
tests/test_benchmarks_web_urldispatcher.py+1%
952 µs947.2 µs
test_send_one_hundred_websocket_text_messages_with_mask
tests/test_benchmarks_http_websocket.py0%
836.5 µs832.8 µs
test_resolve_single_fixed_url_with_many_routes
tests/test_benchmarks_web_urldispatcher.py0%
957.3 µs953.5 µs
test_resolve_gitapi
tests/test_benchmarks_web_urldispatcher.py0%
301.1 ms299.9 ms
test_resolve_static_root_route
tests/test_benchmarks_web_urldispatcher.py0%
1.1 ms1.1 ms
test_web_response_with_headers
tests/test_benchmarks_web_response.py0%
686.8 µs684.8 µs
test_simple_web_response
tests/test_benchmarks_web_response.py0%
444.6 µs443.4 µs
test_send_one_hundred_websocket_compressed_messages[isal.isal_zlib]
tests/test_benchmarks_http_websocket.py0%
4.6 ms4.6 ms
test_resolve_gitapi_root
tests/test_benchmarks_web_urldispatcher.py0%
2.2 ms2.2 ms
test_read_one_hundred_websocket_text_messages
tests/test_benchmarks_http_websocket.py0%
212.1 µs211.6 µs
test_send_one_hundred_websocket_compressed_messages[zlib_ng.zlib_ng]
tests/test_benchmarks_http_websocket.py0%
2 ms2 ms
test_serialize_headers
tests/test_benchmarks_http_writer.py0%
839.7 µs838 µs
test_resolve_dynamic_resource_url_with_many_dynamic_routes
tests/test_benchmarks_web_urldispatcher.py0%
3.7 ms3.7 ms
test_resolve_multiple_level_fixed_url_with_many_routes
tests/test_benchmarks_web_urldispatcher.py0%
9.3 ms9.3 ms
test_get_request_with_251308_compressed_chunked_payload[isal.isal_zlib]
tests/test_benchmarks_client.py0%
72.7 ms72.6 ms
test_read_large_binary_websocket_messages
tests/test_benchmarks_http_websocket.py0%
49 µs48.9 µs
test_ten_streamed_responses_iter_chunked_1mb
tests/test_benchmarks_client.py0%
1.1 s1.1 s
Commits
Click on a commit to change the comparison rangeBase
master
9bc498b
+0.06%
[pre-commit.ci] auto fixes from pre-commit.com hooks
b5a83fa
2 days ago
by pre-commit-ci[bot]+0.07%
[pre-commit.ci] auto fixes from pre-commit.com hooks
01ac6b3
3 hours ago
by pre-commit-ci[bot]-0.15%
Fix mypy type error: subclass Trace in test tracer
13d9a74
2 hours ago
by masonwilde+8.81%
Merge branch 'master' into fix-connector-resolver-close-race
13a63bf
2 hours ago
by masonwilde