fix_redirect_upload_422 - Branch - aio-libs/aiohttp

Fix file uploads failing with HTTP 422 on 307/308 redirects

#11290Merged

Comparing

fix_redirect_upload_422

(

9e40b5f

) with

master

(

e38220f

)

Untouched: 59

Ignored: 7

Benchmarks

Passed

test_get_request_with_251308_compressed_chunked_payload[isal.isal_zlib-pyloop]

tests/test_benchmarks_client.py

+2%

65.4 ms64.4 ms

test_resolve_gitapi_subapps[pyloop]

tests/test_benchmarks_web_urldispatcher.py

+1%

294 ms290.1 ms

test_resolve_multiple_level_fixed_url_with_many_routes[pyloop]

tests/test_benchmarks_web_urldispatcher.py

+1%

8.6 ms8.5 ms

test_web_response_with_bytes_body

tests/test_benchmarks_web_response.py

+1%

540.1 µs534.7 µs

test_simple_web_response

tests/test_benchmarks_web_response.py

+1%

448.9 µs444.8 µs

test_web_response_with_text_body

tests/test_benchmarks_web_response.py

+1%

682 µs676.5 µs

test_resolve_root_route[pyloop]

tests/test_benchmarks_web_urldispatcher.py

+1%

879.1 µs873.8 µs

test_one_thousand_round_trip_websocket_text_messages[pyloop]

tests/test_benchmarks_client_ws.py

16.7 ms16.7 ms

test_resolve_static_root_route[pyloop]

tests/test_benchmarks_web_urldispatcher.py

974 µs970.2 µs

test_resolve_root_route_with_many_fixed_routes[pyloop]

tests/test_benchmarks_web_urldispatcher.py

878.8 µs875.6 µs

test_send_one_hundred_large_websocket_text_messages[pyloop]

tests/test_benchmarks_http_websocket.py

545.6 µs544 µs

test_one_thousand_round_trip_websocket_binary_messages[pyloop-small]

tests/test_benchmarks_client_ws.py

16.3 ms16.3 ms

test_resolve_dynamic_resource_url_with_many_dynamic_routes[pyloop]

tests/test_benchmarks_web_urldispatcher.py

3.5 ms3.5 ms

test_web_response_with_headers

tests/test_benchmarks_web_response.py

693.9 µs692.6 µs

test_ten_streamed_responses_iter_chunked_4096[pyloop]

tests/test_benchmarks_client.py

28.1 ms28 ms

test_one_thousand_large_round_trip_websocket_text_messages[pyloop]

tests/test_benchmarks_client_ws.py

21.5 ms21.5 ms

test_resolve_prefix_resources_many_prefix_many_plain[pyloop]

tests/test_benchmarks_web_urldispatcher.py

4.6 ms4.6 ms

test_ten_streamed_responses_iter_chunked_65536[pyloop]

tests/test_benchmarks_client.py

23 ms23 ms

test_resolve_gitapi[pyloop]

tests/test_benchmarks_web_urldispatcher.py

288.7 ms288.4 ms

test_serialize_headers

tests/test_benchmarks_http_writer.py

848.8 µs848.2 µs

test_send_one_hundred_websocket_compressed_messages[zlib_ng.zlib_ng-pyloop]

tests/test_benchmarks_http_websocket.py

2.1 ms2.1 ms

test_client_receive_large_websocket_compressed_messages[zlib-pyloop]

tests/test_benchmarks_client_ws.py

50.3 ms50.3 ms

test_simple_web_file_sendfile_fallback_response[pyloop]

tests/test_benchmarks_web_fileresponse.py

84.4 ms84.3 ms

test_client_send_large_websocket_compressed_messages[zlib-pyloop]

tests/test_benchmarks_client_ws.py

50.3 ms50.3 ms

test_get_request_with_251308_compressed_chunked_payload[zlib_ng.zlib_ng-pyloop]

tests/test_benchmarks_client.py

230.5 ms230.4 ms

test_read_one_hundred_websocket_text_messages[pyloop]

tests/test_benchmarks_http_websocket.py

212.3 µs212.2 µs

test_read_large_binary_websocket_messages[pyloop]

tests/test_benchmarks_http_websocket.py

8.9 ms8.9 ms

test_get_request_with_251308_compressed_chunked_payload[zlib-pyloop]

tests/test_benchmarks_client.py

426.2 ms426.2 ms

test_send_one_hundred_websocket_compressed_messages[zlib-pyloop]

tests/test_benchmarks_http_websocket.py

3.1 ms3.1 ms

test_one_thousand_round_trip_websocket_binary_messages[pyloop-large]

tests/test_benchmarks_client_ws.py

110.1 ms110.1 ms

test_one_hundred_get_requests_with_512kib_content_length_payload[pyloop]

tests/test_benchmarks_client.py

165.5 ms165.5 ms

test_resolve_gitapi_root[pyloop]

tests/test_benchmarks_web_urldispatcher.py

2 ms2 ms

test_one_hundred_simple_get_requests_no_session[pyloop]

tests/test_benchmarks_client.py

86.9 ms87 ms

test_send_one_hundred_websocket_compressed_messages[isal.isal_zlib-pyloop]

tests/test_benchmarks_http_websocket.py

4.7 ms4.7 ms

test_resolve_single_fixed_url_with_many_routes[pyloop]

tests/test_benchmarks_web_urldispatcher.py

880.7 µs881.2 µs

test_resolve_multiple_fixed_url_with_many_routes[pyloop]

tests/test_benchmarks_web_urldispatcher.py

2.2 ms2.2 ms

test_ten_streamed_responses_iter_chunks[pyloop]

tests/test_benchmarks_client.py

16.1 ms16.2 ms

test_send_client_request_one_hundred[pyloop]

tests/test_benchmarks_client_request.py

2.5 ms2.5 ms

test_create_client_request_with_cookies[pyloop]

tests/test_benchmarks_client_request.py

121.4 µs121.7 µs

test_simple_web_file_response[pyloop]

tests/test_benchmarks_web_fileresponse.py

78.1 ms78.4 ms

test_simple_web_file_response_not_modified[pyloop]

tests/test_benchmarks_web_fileresponse.py

55 ms55.2 ms

test_one_hundred_get_requests_with_30000_content_length_payload[pyloop]

tests/test_benchmarks_client.py

40 ms40.2 ms

test_resolve_dynamic_resource_url_with_many_static_routes[pyloop]

tests/test_benchmarks_web_urldispatcher.py

3.5 ms3.6 ms

test_simple_web_stream_response

tests/test_benchmarks_web_response.py

242 µs243 µs

test_one_hundred_get_requests_with_1024_content_length_payload[pyloop]

tests/test_benchmarks_client.py

34.7 ms34.9 ms

test_one_hundred_get_requests_with_30000_chunked_payload[pyloop]

tests/test_benchmarks_client.py

40.2 ms40.4 ms

test_ten_web_middlewares[pyloop]

tests/test_benchmarks_web_middleware.py

35.3 ms35.4 ms

test_one_hundred_simple_post_requests[pyloop]

tests/test_benchmarks_client.py

36.4 ms36.5 ms

test_resolve_dynamic_resource_url_with_many_dynamic_routes_with_common_prefix[pyloop]

tests/test_benchmarks_web_urldispatcher.py

245.4 ms246.5 ms

test_one_hundred_get_requests_with_1024_chunked_payload[pyloop]

tests/test_benchmarks_client.py

35.1 ms35.3 ms

test_create_client_request_with_headers[pyloop]

tests/test_benchmarks_client_request.py

75.6 µs75.9 µs

test_one_hundred_simple_get_requests_multiple_methods_route[pyloop]

tests/test_benchmarks_client.py

-1%

32.3 ms32.5 ms

test_one_hundred_simple_get_requests_alternating_clients[pyloop]

tests/test_benchmarks_client.py

-1%

33.2 ms33.3 ms

test_one_hundred_simple_get_requests[pyloop]

tests/test_benchmarks_client.py

-1%

32.5 ms32.7 ms

test_one_hundred_json_post_requests[pyloop]

tests/test_benchmarks_client.py

-1%

38.2 ms38.4 ms

test_load_cookies_into_temp_cookiejar

tests/test_benchmarks_cookiejar.py

-1%

189.2 µs190.4 µs

test_client_request_update_cookies[pyloop]

tests/test_benchmarks_client_request.py

-1%

151.6 µs152.8 µs

test_send_one_hundred_websocket_text_messages_with_mask[pyloop]

tests/test_benchmarks_http_websocket.py

-1%

782.8 µs794.4 µs

test_send_one_hundred_websocket_text_messages[pyloop]

tests/test_benchmarks_http_websocket.py

-2%

552.6 µs562.7 µs

Ignored

test_one_hundred_get_requests_iter_chunks_on_512kib_chunked_payload[pyloop]

tests/test_benchmarks_client.py

Ignored

96.5 ms96.7 ms

test_one_hundred_get_requests_with_512kib_chunked_payload[pyloop]

tests/test_benchmarks_client.py

Ignored

166 ms166.2 ms

test_ten_streamed_responses_iter_any[pyloop]

tests/test_benchmarks_client.py

Ignored

21.6 ms21.7 ms

test_client_receive_large_websocket_compressed_messages[isal.isal_zlib-pyloop]

tests/test_benchmarks_client_ws.py

Ignored

19.8 ms19.8 ms

test_client_receive_large_websocket_compressed_messages[zlib_ng.zlib_ng-pyloop]

tests/test_benchmarks_client_ws.py

Ignored

-2%

31 ms31.6 ms

test_client_send_large_websocket_compressed_messages[zlib_ng.zlib_ng-pyloop]

tests/test_benchmarks_client_ws.py

Ignored

-2%

31 ms31.6 ms

test_client_send_large_websocket_compressed_messages[isal.isal_zlib-pyloop]

tests/test_benchmarks_client_ws.py

Ignored

19.8 ms19.9 ms

Commits

Click on a commit to change the comparison range

Base

master

e38220f

-0.1%

lint

3f40fd3

3 months ago

by bdraco

+0.06%

fixes

7a32592

3 months ago

by bdraco

-0.33%

fixes

6cb40ad

3 months ago

by bdraco

+0.27%

add multi-redirect test

dcae756

3 months ago

by bdraco

+0.06%

Nit

9e40b5f

3 months ago

by Dreamsorcerer

Home Terms Privacy Docs