agners:use-runtime-exception-if-transport-is-none - Branch - aio-libs/aiohttp

Raise RuntimeError if transport is None

#11761

Comparing

agners:use-runtime-exception-if-transport-is-none

(

9f20389

) with

master

(

056d929

)

Untouched: 59

Ignored: 7

Benchmarks

Passed

test_one_hundred_get_requests_with_512kib_content_length_payload[pyloop]

tests/test_benchmarks_client.py

+7%

177.4 ms165.8 ms

test_resolve_gitapi_subapps[pyloop]

tests/test_benchmarks_web_urldispatcher.py

+1%

296.2 ms292.9 ms

test_ten_streamed_responses_iter_chunks[pyloop]

tests/test_benchmarks_client.py

+1%

16.3 ms16.2 ms

test_ten_streamed_responses_iter_chunked_65536[pyloop]

tests/test_benchmarks_client.py

+1%

23.1 ms23 ms

test_ten_streamed_responses_iter_chunked_4096[pyloop]

tests/test_benchmarks_client.py

+1%

28.2 ms28 ms

test_send_one_hundred_websocket_text_messages_with_mask[pyloop]

tests/test_benchmarks_http_websocket.py

833.3 µs829.6 µs

test_one_thousand_round_trip_websocket_binary_messages[pyloop-large]

tests/test_benchmarks_client_ws.py

111 ms110.6 ms

test_web_response_with_headers

tests/test_benchmarks_web_response.py

701.2 µs699.2 µs

test_one_thousand_large_round_trip_websocket_text_messages[pyloop]

tests/test_benchmarks_client_ws.py

21.6 ms21.5 ms

test_resolve_root_route[pyloop]

tests/test_benchmarks_web_urldispatcher.py

903.1 µs900.8 µs

test_one_hundred_get_requests_with_30000_chunked_payload[pyloop]

tests/test_benchmarks_client.py

40.8 ms40.7 ms

test_one_hundred_simple_get_requests_no_session[pyloop]

tests/test_benchmarks_client.py

88.3 ms88.1 ms

test_one_hundred_get_requests_with_30000_content_length_payload[pyloop]

tests/test_benchmarks_client.py

40.6 ms40.5 ms

test_web_response_with_text_body

tests/test_benchmarks_web_response.py

690.8 µs689.6 µs

test_send_one_hundred_websocket_compressed_messages[zlib-pyloop]

tests/test_benchmarks_http_websocket.py

3 ms3 ms

test_one_hundred_get_requests_with_1024_content_length_payload[pyloop]

tests/test_benchmarks_client.py

35.2 ms35.2 ms

test_send_one_hundred_large_websocket_text_messages[pyloop]

tests/test_benchmarks_http_websocket.py

580.7 µs580.2 µs

test_resolve_gitapi[pyloop]

tests/test_benchmarks_web_urldispatcher.py

293.9 ms293.6 ms

test_resolve_dynamic_resource_url_with_many_dynamic_routes_with_common_prefix[pyloop]

tests/test_benchmarks_web_urldispatcher.py

249.2 ms249 ms

test_client_receive_large_websocket_compressed_messages[zlib-pyloop]

tests/test_benchmarks_client_ws.py

50.7 ms50.6 ms

test_send_one_hundred_websocket_compressed_messages[zlib_ng.zlib_ng-pyloop]

tests/test_benchmarks_http_websocket.py

2 ms2 ms

test_one_hundred_get_requests_with_1024_chunked_payload[pyloop]

tests/test_benchmarks_client.py

35.6 ms35.5 ms

test_resolve_multiple_fixed_url_with_many_routes[pyloop]

tests/test_benchmarks_web_urldispatcher.py

2.2 ms2.2 ms

test_client_send_large_websocket_compressed_messages[zlib-pyloop]

tests/test_benchmarks_client_ws.py

50.7 ms50.7 ms

test_send_one_hundred_websocket_compressed_messages[isal.isal_zlib-pyloop]

tests/test_benchmarks_http_websocket.py

4.6 ms4.6 ms

test_load_cookies_into_temp_cookiejar

tests/test_benchmarks_cookiejar.py

189.3 µs189.3 µs

test_get_request_with_251308_compressed_chunked_payload[zlib_ng.zlib_ng-pyloop]

tests/test_benchmarks_client.py

210 ms210.1 ms

test_get_request_with_251308_compressed_chunked_payload[zlib-pyloop]

tests/test_benchmarks_client.py

426.1 ms426.1 ms

test_resolve_root_route_with_many_fixed_routes[pyloop]

tests/test_benchmarks_web_urldispatcher.py

899.8 µs899.9 µs

test_resolve_single_fixed_url_with_many_routes[pyloop]

tests/test_benchmarks_web_urldispatcher.py

905.8 µs905.9 µs

test_read_large_binary_websocket_messages[pyloop]

tests/test_benchmarks_http_websocket.py

8.9 ms8.9 ms

test_resolve_gitapi_root[pyloop]

tests/test_benchmarks_web_urldispatcher.py

2.1 ms2.1 ms

test_one_hundred_simple_get_requests_alternating_clients[pyloop]

tests/test_benchmarks_client.py

33.7 ms33.7 ms

test_resolve_multiple_level_fixed_url_with_many_routes[pyloop]

tests/test_benchmarks_web_urldispatcher.py

8.7 ms8.8 ms

test_ten_web_middlewares[pyloop]

tests/test_benchmarks_web_middleware.py

35.7 ms35.8 ms

test_create_client_request_with_headers[pyloop]

tests/test_benchmarks_client_request.py

70.6 µs70.7 µs

test_simple_web_file_response_not_modified[pyloop]

tests/test_benchmarks_web_fileresponse.py

55.3 ms55.4 ms

test_one_thousand_round_trip_websocket_text_messages[pyloop]

tests/test_benchmarks_client_ws.py

17.1 ms17.1 ms

test_one_thousand_round_trip_websocket_binary_messages[pyloop-small]

tests/test_benchmarks_client_ws.py

16.7 ms16.7 ms

test_one_hundred_simple_get_requests_multiple_methods_route[pyloop]

tests/test_benchmarks_client.py

32.8 ms32.8 ms

test_serialize_headers

tests/test_benchmarks_http_writer.py

852.2 µs853.8 µs

test_one_hundred_simple_get_requests[pyloop]

tests/test_benchmarks_client.py

33 ms33.1 ms

test_client_request_update_cookies[pyloop]

tests/test_benchmarks_client_request.py

146.6 µs146.9 µs

test_one_hundred_simple_post_requests[pyloop]

tests/test_benchmarks_client.py

36.9 ms37 ms

test_resolve_dynamic_resource_url_with_many_dynamic_routes[pyloop]

tests/test_benchmarks_web_urldispatcher.py

3.6 ms3.6 ms

test_resolve_dynamic_resource_url_with_many_static_routes[pyloop]

tests/test_benchmarks_web_urldispatcher.py

3.6 ms3.6 ms

test_one_hundred_json_post_requests[pyloop]

tests/test_benchmarks_client.py

38.7 ms38.8 ms

test_simple_web_file_sendfile_fallback_response[pyloop]

tests/test_benchmarks_web_fileresponse.py

84.6 ms84.8 ms

test_simple_web_response

tests/test_benchmarks_web_response.py

455.4 µs456.9 µs

test_simple_web_file_response[pyloop]

tests/test_benchmarks_web_fileresponse.py

78.4 ms78.7 ms

test_get_request_with_251308_compressed_chunked_payload[isal.isal_zlib-pyloop]

tests/test_benchmarks_client.py

64.5 ms64.8 ms

test_web_response_with_bytes_body

tests/test_benchmarks_web_response.py

546.1 µs548.4 µs

test_resolve_prefix_resources_many_prefix_many_plain[pyloop]

tests/test_benchmarks_web_urldispatcher.py

4.7 ms4.7 ms

test_read_one_hundred_websocket_text_messages[pyloop]

tests/test_benchmarks_http_websocket.py

-1%

208.8 µs210.1 µs

test_resolve_static_root_route[pyloop]

tests/test_benchmarks_web_urldispatcher.py

-1%

994.5 µs1,003.7 µs

test_create_client_request_with_cookies[pyloop]

tests/test_benchmarks_client_request.py

-1%

120.5 µs121.7 µs

test_simple_web_stream_response

tests/test_benchmarks_web_response.py

-1%

243 µs245.9 µs

test_send_client_request_one_hundred[pyloop]

tests/test_benchmarks_client_request.py

-1%

2.6 ms2.6 ms

test_send_one_hundred_websocket_text_messages[pyloop]

tests/test_benchmarks_http_websocket.py

-2%

581.6 µs595.8 µs

Ignored

test_one_hundred_get_requests_iter_chunks_on_512kib_chunked_payload[pyloop]

tests/test_benchmarks_client.py

Ignored

+1%

97.6 ms97 ms

test_one_hundred_get_requests_with_512kib_chunked_payload[pyloop]

tests/test_benchmarks_client.py

Ignored

166.8 ms166.3 ms

test_ten_streamed_responses_iter_any[pyloop]

tests/test_benchmarks_client.py

Ignored

+11%

24 ms21.7 ms

test_client_receive_large_websocket_compressed_messages[isal.isal_zlib-pyloop]

tests/test_benchmarks_client_ws.py

Ignored

20.2 ms20.2 ms

test_client_send_large_websocket_compressed_messages[zlib_ng.zlib_ng-pyloop]

tests/test_benchmarks_client_ws.py

Ignored

-1%

29.9 ms30.2 ms

test_client_receive_large_websocket_compressed_messages[zlib_ng.zlib_ng-pyloop]

tests/test_benchmarks_client_ws.py

Ignored

30.2 ms30.2 ms

test_client_send_large_websocket_compressed_messages[isal.isal_zlib-pyloop]

tests/test_benchmarks_client_ws.py

Ignored

20.2 ms20.2 ms

Commits

Click on a commit to change the comparison range

Base

master

056d929

+0.01%

Raise RuntimeError if transport is None When a client disconnects immediately after connecting, the transport might become None. This should not lead to an assertion, since this can happen in real-world scenarios. Use a RuntimeException instead.

9f20389

2 days ago

by agners

Home Terms Privacy Docs