Avatar for the aio-libs user
aio-libs
aiohttp
BlogDocsChangelog

Restrict pickle deserialization in CookieJar.load()

#12091Merged
Comparing
YuvalElbar6:security/cookiejar-restrict-pickle
(
953e228
) with
master
(
291d969
)
CodSpeed Performance Gauge
0%
Untouched
59
Ignored
7

Benchmarks

66 total
test_create_client_request_with_headers[pyloop]
tests/test_benchmarks_client_request.py
CodSpeed Performance Gauge
+2%
71.6 µs70.3 µs
test_resolve_dynamic_resource_url_with_many_dynamic_routes_with_common_prefix[pyloop]
tests/test_benchmarks_web_urldispatcher.py
CodSpeed Performance Gauge
+1%
250.7 ms247.3 ms
test_resolve_gitapi_root[pyloop]
tests/test_benchmarks_web_urldispatcher.py
CodSpeed Performance Gauge
+1%
2.1 ms2.1 ms
test_resolve_multiple_level_fixed_url_with_many_routes[pyloop]
tests/test_benchmarks_web_urldispatcher.py
CodSpeed Performance Gauge
+1%
8.8 ms8.7 ms
test_resolve_gitapi[pyloop]
tests/test_benchmarks_web_urldispatcher.py
CodSpeed Performance Gauge
+1%
296.6 ms294.5 ms
test_resolve_dynamic_resource_url_with_many_dynamic_routes[pyloop]
tests/test_benchmarks_web_urldispatcher.py
CodSpeed Performance Gauge
+1%
3.6 ms3.6 ms
test_resolve_multiple_fixed_url_with_many_routes[pyloop]
tests/test_benchmarks_web_urldispatcher.py
CodSpeed Performance Gauge
+1%
2.3 ms2.2 ms
test_resolve_gitapi_subapps[pyloop]
tests/test_benchmarks_web_urldispatcher.py
CodSpeed Performance Gauge
+1%
299.8 ms297.9 ms
test_web_response_with_headers
tests/test_benchmarks_web_response.py
CodSpeed Performance Gauge
+1%
690.4 µs686.5 µs
test_web_response_with_text_body
tests/test_benchmarks_web_response.py
CodSpeed Performance Gauge
+1%
681.7 µs678 µs
test_simple_web_file_sendfile_fallback_response[pyloop]
tests/test_benchmarks_web_fileresponse.py
CodSpeed Performance Gauge
+1%
85.2 ms84.8 ms
test_serialize_headers
tests/test_benchmarks_http_writer.py
CodSpeed Performance Gauge
+1%
855.9 µs851.5 µs
test_resolve_root_route_with_many_fixed_routes[pyloop]
tests/test_benchmarks_web_urldispatcher.py
CodSpeed Performance Gauge
0%
906.2 µs902 µs
test_resolve_dynamic_resource_url_with_many_static_routes[pyloop]
tests/test_benchmarks_web_urldispatcher.py
CodSpeed Performance Gauge
0%
3.6 ms3.6 ms
test_client_request_update_cookies[pyloop]
tests/test_benchmarks_client_request.py
CodSpeed Performance Gauge
0%
144.6 µs144.1 µs
test_send_one_hundred_websocket_text_messages_with_mask[pyloop]
tests/test_benchmarks_http_websocket.py
CodSpeed Performance Gauge
0%
826.9 µs824.3 µs
test_send_one_hundred_websocket_compressed_messages[zlib_ng.zlib_ng-pyloop]
tests/test_benchmarks_http_websocket.py
CodSpeed Performance Gauge
0%
2 ms2 ms
test_resolve_root_route[pyloop]
tests/test_benchmarks_web_urldispatcher.py
CodSpeed Performance Gauge
0%
907.5 µs905.2 µs
test_send_one_hundred_websocket_compressed_messages[isal.isal_zlib-pyloop]
tests/test_benchmarks_http_websocket.py
CodSpeed Performance Gauge
0%
4.6 ms4.6 ms
test_resolve_prefix_resources_many_prefix_many_plain[pyloop]
tests/test_benchmarks_web_urldispatcher.py
CodSpeed Performance Gauge
0%
4.8 ms4.8 ms
test_send_one_hundred_websocket_compressed_messages[zlib-pyloop]
tests/test_benchmarks_http_websocket.py
CodSpeed Performance Gauge
0%
3 ms3 ms
test_resolve_static_root_route[pyloop]
tests/test_benchmarks_web_urldispatcher.py
CodSpeed Performance Gauge
0%
1.1 ms1.1 ms
test_create_client_request_with_cookies[pyloop]
tests/test_benchmarks_client_request.py
CodSpeed Performance Gauge
0%
120.7 µs120.6 µs
test_one_hundred_simple_get_requests_no_session[pyloop]
tests/test_benchmarks_client.py
CodSpeed Performance Gauge
0%
87.7 ms87.7 ms
test_one_hundred_json_post_requests[pyloop]
tests/test_benchmarks_client.py
CodSpeed Performance Gauge
0%
39.1 ms39 ms

Commits

Click on a commit to change the comparison range
Base
master
291d969
-0.01%
[pre-commit.ci] auto fixes from pre-commit.com hooks
2c899ef
2 months ago
by pre-commit-ci[bot]
-0.28%
Add towncrier changelog fragment for CookieJar security fix
4928513
2 months ago
by YuvalElbar6
+0.28%
Fix spelling in changelog fragment: deserialized -> loaded
86177df
2 months ago
by YuvalElbar6
-0.22%
Merge save_json/load_json into save/load per review
cfa864d
2 months ago
by YuvalElbar6
+0.23%
Address review: remove defensive defaults, str(), fix return pattern
6a23343
2 months ago
by YuvalElbar6
-0.24%
Store boolean cookie attrs as native JSON booleans
34b7c90
2 months ago
by YuvalElbar6
+0.5%
Update cookiejar.py
6b691ee
2 months ago
by Dreamsorcerer
-0.13%
Merge branch 'security/cookiejar-restrict-pickle' of https://github.com/YuvalElbar6/aiohttp into security/cookiejar-restrict-pickle
953e228
2 months ago
by YuvalElbar6
© 2026 CodSpeed Technology
Home Terms Privacy Docs