Tasssadar:patchback/backports/3.12/996ad00037d9e729aa58b757099dd2fea5e7dcc9/pr-11150 - Branch - aio-libs/aiohttp

[PR #11150/996ad00 backport][3.12] fix: leak of aiodns.DNSResolver when ClientSession is closed

#11152Merged

Comparing

Tasssadar:patchback/backports/3.12/996ad00037d9e729aa58b757099dd2fea5e7dcc9/pr-11150

(

0284e85

) with

3.12

(

c0e04a2

)

-10%

Regressions: 1
(
1
)

Untouched: 58

Ignored: 7

Benchmarks

Passed

test_send_one_hundred_websocket_text_messages_with_mask[pyloop]

tests/test_benchmarks_http_websocket.py

+3%

808.8 µs788.8 µs

test_send_one_hundred_websocket_text_messages[pyloop]

tests/test_benchmarks_http_websocket.py

+1%

568.3 µs561.7 µs

test_simple_web_stream_response

tests/test_benchmarks_web_response.py

+1%

256.7 µs254.6 µs

test_read_one_hundred_websocket_text_messages[pyloop]

tests/test_benchmarks_http_websocket.py

+1%

215.4 µs214.2 µs

test_send_one_hundred_websocket_compressed_messages[zlib-pyloop]

tests/test_benchmarks_http_websocket.py

3.1 ms3.1 ms

test_send_client_request_one_hundred[pyloop]

tests/test_benchmarks_client_request.py

2.5 ms2.5 ms

test_get_request_with_251308_compressed_chunked_payload[isal.isal_zlib-pyloop]

tests/test_benchmarks_client.py

65.3 ms65.2 ms

test_create_client_request_with_cookies[pyloop]

tests/test_benchmarks_client_request.py

120.4 µs120.4 µs

test_client_receive_large_websocket_compressed_messages[zlib-pyloop]

tests/test_benchmarks_client_ws.py

50.3 ms50.3 ms

test_simple_web_file_sendfile_fallback_response[pyloop]

tests/test_benchmarks_web_fileresponse.py

84.5 ms84.5 ms

test_read_large_binary_websocket_messages[pyloop]

tests/test_benchmarks_http_websocket.py

8.9 ms8.9 ms

test_client_send_large_websocket_compressed_messages[zlib-pyloop]

tests/test_benchmarks_client_ws.py

50.3 ms50.3 ms

test_client_request_update_cookies[pyloop]

tests/test_benchmarks_client_request.py

153.3 µs153.3 µs

test_one_thousand_round_trip_websocket_binary_messages[pyloop-large]

tests/test_benchmarks_client_ws.py

110 ms110 ms

test_simple_web_file_response_not_modified[pyloop]

tests/test_benchmarks_web_fileresponse.py

55.7 ms55.7 ms

test_send_one_hundred_websocket_compressed_messages[zlib_ng.zlib_ng-pyloop]

tests/test_benchmarks_http_websocket.py

2.1 ms2.1 ms

test_web_response_with_text_body

tests/test_benchmarks_web_response.py

671.1 µs671.5 µs

test_get_request_with_251308_compressed_chunked_payload[zlib-pyloop]

tests/test_benchmarks_client.py

426 ms426.3 ms

test_get_request_with_251308_compressed_chunked_payload[zlib_ng.zlib_ng-pyloop]

tests/test_benchmarks_client.py

230.3 ms230.4 ms

test_send_one_hundred_websocket_compressed_messages[isal.isal_zlib-pyloop]

tests/test_benchmarks_http_websocket.py

4.7 ms4.7 ms

test_load_cookies_into_temp_cookiejar

tests/test_benchmarks_cookiejar.py

192.3 µs192.5 µs

test_resolve_gitapi[pyloop]

tests/test_benchmarks_web_urldispatcher.py

294.3 ms294.7 ms

test_one_thousand_large_round_trip_websocket_text_messages[pyloop]

tests/test_benchmarks_client_ws.py

21.4 ms21.5 ms

test_one_hundred_get_requests_with_512kib_content_length_payload[pyloop]

tests/test_benchmarks_client.py

165.7 ms166 ms

test_web_response_with_bytes_body

tests/test_benchmarks_web_response.py

553.9 µs554.9 µs

test_resolve_dynamic_resource_url_with_many_dynamic_routes_with_common_prefix[pyloop]

tests/test_benchmarks_web_urldispatcher.py

246.8 ms247.3 ms

test_one_thousand_round_trip_websocket_text_messages[pyloop]

tests/test_benchmarks_client_ws.py

16.7 ms16.7 ms

test_web_response_with_headers

tests/test_benchmarks_web_response.py

695.3 µs697.2 µs

test_send_one_hundred_large_websocket_text_messages[pyloop]

tests/test_benchmarks_http_websocket.py

544.5 µs546 µs

test_resolve_gitapi_subapps[pyloop]

tests/test_benchmarks_web_urldispatcher.py

296.7 ms297.6 ms

test_resolve_dynamic_resource_url_with_many_dynamic_routes[pyloop]

tests/test_benchmarks_web_urldispatcher.py

3.5 ms3.6 ms

test_resolve_single_fixed_url_with_many_routes[pyloop]

tests/test_benchmarks_web_urldispatcher.py

884.4 µs887 µs

test_create_client_request_with_headers[pyloop]

tests/test_benchmarks_client_request.py

74.6 µs74.8 µs

test_simple_web_file_response[pyloop]

tests/test_benchmarks_web_fileresponse.py

78.6 ms78.8 ms

test_ten_streamed_responses_iter_chunked_4096[pyloop]

tests/test_benchmarks_client.py

28.1 ms28.2 ms

test_one_hundred_json_post_requests[pyloop]

tests/test_benchmarks_client.py

38.7 ms38.9 ms

test_resolve_static_root_route[pyloop]

tests/test_benchmarks_web_urldispatcher.py

974.4 µs979.1 µs

test_serialize_headers

tests/test_benchmarks_http_writer.py

-1%

854.5 µs859.2 µs

test_ten_streamed_responses_iter_chunked_65536[pyloop]

tests/test_benchmarks_client.py

-1%

22.9 ms23 ms

test_one_hundred_get_requests_with_30000_content_length_payload[pyloop]

tests/test_benchmarks_client.py

-1%

40.6 ms40.8 ms

test_one_thousand_round_trip_websocket_binary_messages[pyloop-small]

tests/test_benchmarks_client_ws.py

-1%

16.2 ms16.3 ms

test_resolve_gitapi_root[pyloop]

tests/test_benchmarks_web_urldispatcher.py

-1%

2 ms2 ms

test_simple_web_response

tests/test_benchmarks_web_response.py

-1%

457.2 µs460.2 µs

test_one_hundred_get_requests_with_30000_chunked_payload[pyloop]

tests/test_benchmarks_client.py

-1%

40.8 ms41 ms

test_resolve_dynamic_resource_url_with_many_static_routes[pyloop]

tests/test_benchmarks_web_urldispatcher.py

-1%

3.6 ms3.6 ms

test_resolve_root_route[pyloop]

tests/test_benchmarks_web_urldispatcher.py

-1%

878 µs884.6 µs

test_resolve_prefix_resources_many_prefix_many_plain[pyloop]

tests/test_benchmarks_web_urldispatcher.py

-1%

4.9 ms4.9 ms

test_ten_streamed_responses_iter_chunks[pyloop]

tests/test_benchmarks_client.py

-1%

16.1 ms16.2 ms

test_one_hundred_get_requests_with_1024_content_length_payload[pyloop]

tests/test_benchmarks_client.py

-1%

35.2 ms35.5 ms

test_ten_web_middlewares[pyloop]

tests/test_benchmarks_web_middleware.py

-1%

35.7 ms36 ms

test_one_hundred_get_requests_with_1024_chunked_payload[pyloop]

tests/test_benchmarks_client.py

-1%

35.6 ms35.9 ms

test_one_hundred_simple_get_requests[pyloop]

tests/test_benchmarks_client.py

-1%

33 ms33.3 ms

test_one_hundred_simple_get_requests_multiple_methods_route[pyloop]

tests/test_benchmarks_client.py

-1%

32.8 ms33.1 ms

test_one_hundred_simple_get_requests_alternating_clients[pyloop]

tests/test_benchmarks_client.py

-1%

33.7 ms34 ms

test_one_hundred_simple_post_requests[pyloop]

tests/test_benchmarks_client.py

-1%

36.8 ms37.1 ms

test_resolve_root_route_with_many_fixed_routes[pyloop]

tests/test_benchmarks_web_urldispatcher.py

-1%

874.3 µs883.4 µs

test_resolve_multiple_level_fixed_url_with_many_routes[pyloop]

tests/test_benchmarks_web_urldispatcher.py

-1%

8.5 ms8.6 ms

test_resolve_multiple_fixed_url_with_many_routes[pyloop]

tests/test_benchmarks_web_urldispatcher.py

-1%

2.2 ms2.2 ms

test_one_hundred_simple_get_requests_no_session[pyloop]

tests/test_benchmarks_client.py

Regression

-10%

79.7 ms88.6 ms

Ignored

test_one_hundred_get_requests_with_512kib_chunked_payload[pyloop]

tests/test_benchmarks_client.py

Ignored

166.4 ms166.5 ms

test_one_hundred_get_requests_iter_chunks_on_512kib_chunked_payload[pyloop]

tests/test_benchmarks_client.py

Ignored

108.3 ms108.6 ms

test_ten_streamed_responses_iter_any[pyloop]

tests/test_benchmarks_client.py

Ignored

21.6 ms21.7 ms

test_client_send_large_websocket_compressed_messages[isal.isal_zlib-pyloop]

tests/test_benchmarks_client_ws.py

Ignored

-3%

18 ms18.6 ms

test_client_send_large_websocket_compressed_messages[zlib_ng.zlib_ng-pyloop]

tests/test_benchmarks_client_ws.py

Ignored

29.8 ms29.8 ms

test_client_receive_large_websocket_compressed_messages[zlib_ng.zlib_ng-pyloop]

tests/test_benchmarks_client_ws.py

Ignored

29.8 ms29.8 ms

test_client_receive_large_websocket_compressed_messages[isal.isal_zlib-pyloop]

tests/test_benchmarks_client_ws.py

Ignored

19.2 ms19.2 ms

Commits

Click on a commit to change the comparison range

Base

3.12

c0e04a2

-10.08%

[PR #11150/996ad00 backport][3.12] fix: leak of aiodns.DNSResolver when ClientSession is closed (#11150) Co-authored-by: J. Nick Koston <nick@koston.org> (cherry picked from commit 996ad00037d9e729aa58b757099dd2fea5e7dcc9)

0284e85

4 months ago

by Tasssadar

Home Terms Privacy Docs