zeek
spicy
BlogDocsChangelog

Drop stray CFG edge for `while` loops with inits.

#2226Merged
Comparing
topic/bbannier/cfg-while-stray-edge
(
984c45a
) with
main
(
f67c1f0
)
CodSpeed Performance Gauge
0%
Untouched
28
Ignored
78

Benchmarks

Passed

UnitVectorLookahead][100]
spicy/runtime/tests/benchmarks/parsing.cc::benchmarkParser[Benchmark
CodSpeed Performance Gauge
0%
208.6 µs208.6 µs
UnitVectorSize][10000]
spicy/runtime/tests/benchmarks/parsing.cc::benchmarkParser[Benchmark
CodSpeed Performance Gauge
0%
12.3 ms12.3 ms
iterate_map[len:1]
hilti/runtime/src/benchmarks/iteration.cc
CodSpeed Performance Gauge
0%
1.2 µs1.2 µs
iterate_set[len:1000000]
hilti/runtime/src/benchmarks/iteration.cc
CodSpeed Performance Gauge
0%
33.8 ms33.8 ms
iterate_map[len:1000000]
hilti/runtime/src/benchmarks/iteration.cc
CodSpeed Performance Gauge
0%
41.1 ms41.1 ms
iterate_map[len:10000]
hilti/runtime/src/benchmarks/iteration.cc
CodSpeed Performance Gauge
0%
412.7 µs412.7 µs
iterate_vector[len:10000]
hilti/runtime/src/benchmarks/iteration.cc
CodSpeed Performance Gauge
0%
101 µs101 µs
iterate_vector[len:1000000]
hilti/runtime/src/benchmarks/iteration.cc
CodSpeed Performance Gauge
0%
10 ms10 ms
iterate_set[len:1]
hilti/runtime/src/benchmarks/iteration.cc
CodSpeed Performance Gauge
0%
590 ns590 ns
iterate_vector[len:100]
hilti/runtime/src/benchmarks/iteration.cc
CodSpeed Performance Gauge
0%
2 µs2 µs
iterate_set[len:10000]
hilti/runtime/src/benchmarks/iteration.cc
CodSpeed Performance Gauge
0%
339.1 µs339.1 µs
iterate_map[len:100]
hilti/runtime/src/benchmarks/iteration.cc
CodSpeed Performance Gauge
0%
5.5 µs5.5 µs
iterate_set[len:100]
hilti/runtime/src/benchmarks/iteration.cc
CodSpeed Performance Gauge
0%
4.3 µs4.3 µs
iterate_vector[len:1]
hilti/runtime/src/benchmarks/iteration.cc
CodSpeed Performance Gauge
0%
1 µs1 µs
UnitVectorSize][1000]
spicy/runtime/tests/benchmarks/parsing.cc::benchmarkParser[Benchmark
CodSpeed Performance Gauge
0%
1.2 ms1.2 ms
iterate_bytes[len:100]
hilti/runtime/src/benchmarks/iteration.cc
CodSpeed Performance Gauge
0%
2.1 µs2.1 µs
iterate_bytes[len:1]
hilti/runtime/src/benchmarks/iteration.cc
CodSpeed Performance Gauge
0%
1.1 µs1.1 µs
UnitVectorSize][100]
spicy/runtime/tests/benchmarks/parsing.cc::benchmarkParser[Benchmark
CodSpeed Performance Gauge
0%
158.2 µs158.2 µs
iterate_bytes[len:10000]
hilti/runtime/src/benchmarks/iteration.cc
CodSpeed Performance Gauge
0%
105.6 µs105.6 µs
UnitVectorLookahead][1000]
spicy/runtime/tests/benchmarks/parsing.cc::benchmarkParser[Benchmark
CodSpeed Performance Gauge
0%
1.7 ms1.7 ms
iterate_bytes[len:1000000]
hilti/runtime/src/benchmarks/iteration.cc
CodSpeed Performance Gauge
0%
10.5 ms10.5 ms
UnitVectorLookahead][100000]
spicy/runtime/tests/benchmarks/parsing.cc::benchmarkParser[Benchmark
CodSpeed Performance Gauge
0%
179 ms179 ms
UnitVectorSize][100000]
spicy/runtime/tests/benchmarks/parsing.cc::benchmarkParser[Benchmark
CodSpeed Performance Gauge
0%
130.2 ms130.2 ms
Regex][100000]
spicy/runtime/tests/benchmarks/parsing.cc::benchmarkParser[Benchmark
CodSpeed Performance Gauge
0%
30.1 ms30.1 ms
UnitVectorLookahead][10000]
spicy/runtime/tests/benchmarks/parsing.cc::benchmarkParser[Benchmark
CodSpeed Performance Gauge
0%
17.2 ms17.2 ms
Regex][1000]
spicy/runtime/tests/benchmarks/parsing.cc::benchmarkParser[Benchmark
CodSpeed Performance Gauge
0%
334.8 µs334.8 µs
Regex][10000]
spicy/runtime/tests/benchmarks/parsing.cc::benchmarkParser[Benchmark
CodSpeed Performance Gauge
0%
3 ms3 ms
Regex][100]
spicy/runtime/tests/benchmarks/parsing.cc::benchmarkParser[Benchmark
CodSpeed Performance Gauge
0%
68.9 µs68.9 µs

Ignored

execute_many_resume[addl_stack_usage:8/fibers:64]
hilti/runtime/src/benchmarks/fiber.cc
Ignored
CodSpeed Performance Gauge
0%
189.3 µs189.3 µs
execute_many_resume[addl_stack_usage:8/fibers:1]
hilti/runtime/src/benchmarks/fiber.cc
Ignored
CodSpeed Performance Gauge
0%
12.3 µs12.3 µs
execute_many[addl_stack_usage:1/fibers:64]
hilti/runtime/src/benchmarks/fiber.cc
Ignored
CodSpeed Performance Gauge
0%
137.8 µs137.8 µs
execute_many[addl_stack_usage:1/fibers:512]
hilti/runtime/src/benchmarks/fiber.cc
Ignored
CodSpeed Performance Gauge
0%
891.8 µs891.8 µs
execute_many[addl_stack_usage:1/fibers:1]
hilti/runtime/src/benchmarks/fiber.cc
Ignored
CodSpeed Performance Gauge
0%
11.3 µs11.3 µs
execute_many[addl_stack_usage:1/fibers:8]
hilti/runtime/src/benchmarks/fiber.cc
Ignored
CodSpeed Performance Gauge
0%
25.4 µs25.4 µs
execute_one[addl_stack_usage:1]
hilti/runtime/src/benchmarks/fiber.cc
Ignored
CodSpeed Performance Gauge
0%
10 µs10 µs
execute_many[addl_stack_usage:1/fibers:4096]
hilti/runtime/src/benchmarks/fiber.cc
Ignored
CodSpeed Performance Gauge
0%
6.5 ms6.5 ms
execute_many[addl_stack_usage:18432/fibers:8]
hilti/runtime/src/benchmarks/fiber.cc
Ignored
CodSpeed Performance Gauge
0%
25.6 µs25.6 µs
execute_many[addl_stack_usage:18432/fibers:1]
hilti/runtime/src/benchmarks/fiber.cc
Ignored
CodSpeed Performance Gauge
0%
11.4 µs11.4 µs
execute_many[addl_stack_usage:18432/fibers:4096]
hilti/runtime/src/benchmarks/fiber.cc
Ignored
CodSpeed Performance Gauge
0%
6.5 ms6.5 ms
execute_many_resume[addl_stack_usage:8/fibers:4096]
hilti/runtime/src/benchmarks/fiber.cc
Ignored
CodSpeed Performance Gauge
0%
18.6 ms18.6 ms
execute_many_resume[addl_stack_usage:8/fibers:8]
hilti/runtime/src/benchmarks/fiber.cc
Ignored
CodSpeed Performance Gauge
0%
31.6 µs31.6 µs
execute_many[addl_stack_usage:18432/fibers:512]
hilti/runtime/src/benchmarks/fiber.cc
Ignored
CodSpeed Performance Gauge
0%
896.7 µs896.7 µs
execute_many_resume[addl_stack_usage:8/fibers:512]
hilti/runtime/src/benchmarks/fiber.cc
Ignored
CodSpeed Performance Gauge
0%
1.6 ms1.6 ms
execute_many[addl_stack_usage:4096/fibers:4096]
hilti/runtime/src/benchmarks/fiber.cc
Ignored
CodSpeed Performance Gauge
0%
6.5 ms6.5 ms
execute_many[addl_stack_usage:18432/fibers:64]
hilti/runtime/src/benchmarks/fiber.cc
Ignored
CodSpeed Performance Gauge
0%
139 µs139 µs
execute_many[addl_stack_usage:512/fibers:1]
hilti/runtime/src/benchmarks/fiber.cc
Ignored
CodSpeed Performance Gauge
0%
11.2 µs11.2 µs
execute_one[addl_stack_usage:4096]
hilti/runtime/src/benchmarks/fiber.cc
Ignored
CodSpeed Performance Gauge
0%
10.1 µs10.1 µs
execute_one[addl_stack_usage:512]
hilti/runtime/src/benchmarks/fiber.cc
Ignored
CodSpeed Performance Gauge
0%
10.2 µs10.2 µs
execute_one[addl_stack_usage:8]
hilti/runtime/src/benchmarks/fiber.cc
Ignored
CodSpeed Performance Gauge
0%
10.2 µs10.2 µs
execute_one[addl_stack_usage:18432]
hilti/runtime/src/benchmarks/fiber.cc
Ignored
CodSpeed Performance Gauge
0%
10.2 µs10.2 µs
execute_many[addl_stack_usage:4096/fibers:512]
hilti/runtime/src/benchmarks/fiber.cc
Ignored
CodSpeed Performance Gauge
0%
893 µs893 µs
execute_one[addl_stack_usage:64]
hilti/runtime/src/benchmarks/fiber.cc
Ignored
CodSpeed Performance Gauge
0%
9.7 µs9.7 µs
execute_many[addl_stack_usage:4096/fibers:1]
hilti/runtime/src/benchmarks/fiber.cc
Ignored
CodSpeed Performance Gauge
0%
11.3 µs11.3 µs
execute_many[addl_stack_usage:512/fibers:64]
hilti/runtime/src/benchmarks/fiber.cc
Ignored
CodSpeed Performance Gauge
0%
138.1 µs138.1 µs
execute_one_yield[addl_stack_usage:18432]
hilti/runtime/src/benchmarks/fiber.cc
Ignored
CodSpeed Performance Gauge
0%
64.1 µs64.1 µs
execute_one_yield[addl_stack_usage:512]
hilti/runtime/src/benchmarks/fiber.cc
Ignored
CodSpeed Performance Gauge
0%
11.7 µs11.7 µs
execute_many[addl_stack_usage:512/fibers:4096]
hilti/runtime/src/benchmarks/fiber.cc
Ignored
CodSpeed Performance Gauge
0%
6.5 ms6.5 ms
execute_many[addl_stack_usage:4096/fibers:64]
hilti/runtime/src/benchmarks/fiber.cc
Ignored
CodSpeed Performance Gauge
0%
138.3 µs138.3 µs
execute_many[addl_stack_usage:512/fibers:512]
hilti/runtime/src/benchmarks/fiber.cc
Ignored
CodSpeed Performance Gauge
0%
892 µs892 µs
execute_many[addl_stack_usage:64/fibers:1]
hilti/runtime/src/benchmarks/fiber.cc
Ignored
CodSpeed Performance Gauge
0%
11.3 µs11.3 µs
execute_one_yield[addl_stack_usage:1]
hilti/runtime/src/benchmarks/fiber.cc
Ignored
CodSpeed Performance Gauge
0%
11.1 µs11.1 µs
execute_many[addl_stack_usage:4096/fibers:8]
hilti/runtime/src/benchmarks/fiber.cc
Ignored
CodSpeed Performance Gauge
0%
25.4 µs25.4 µs
execute_one_yield[addl_stack_usage:64]
hilti/runtime/src/benchmarks/fiber.cc
Ignored
CodSpeed Performance Gauge
0%
11.3 µs11.3 µs
execute_yield_to_other[addl_stack_usage:8]
hilti/runtime/src/benchmarks/fiber.cc
Ignored
CodSpeed Performance Gauge
0%
17 µs17 µs
execute_many[addl_stack_usage:512/fibers:8]
hilti/runtime/src/benchmarks/fiber.cc
Ignored
CodSpeed Performance Gauge
0%
25 µs25 µs
execute_one_yield[addl_stack_usage:4096]
hilti/runtime/src/benchmarks/fiber.cc
Ignored
CodSpeed Performance Gauge
0%
15.3 µs15.3 µs
execute_many[addl_stack_usage:64/fibers:4096]
hilti/runtime/src/benchmarks/fiber.cc
Ignored
CodSpeed Performance Gauge
0%
6.5 ms6.5 ms
execute_many[addl_stack_usage:64/fibers:8]
hilti/runtime/src/benchmarks/fiber.cc
Ignored
CodSpeed Performance Gauge
0%
25.4 µs25.4 µs
execute_many[addl_stack_usage:8/fibers:4096]
hilti/runtime/src/benchmarks/fiber.cc
Ignored
CodSpeed Performance Gauge
0%
6.5 ms6.5 ms
execute_one_yield[addl_stack_usage:8]
hilti/runtime/src/benchmarks/fiber.cc
Ignored
CodSpeed Performance Gauge
0%
11.1 µs11.1 µs
execute_many[addl_stack_usage:64/fibers:512]
hilti/runtime/src/benchmarks/fiber.cc
Ignored
CodSpeed Performance Gauge
0%
892.1 µs892.2 µs
execute_yield_to_other[addl_stack_usage:18432]
hilti/runtime/src/benchmarks/fiber.cc
Ignored
CodSpeed Performance Gauge
0%
191 µs191 µs
execute_many[addl_stack_usage:8/fibers:64]
hilti/runtime/src/benchmarks/fiber.cc
Ignored
CodSpeed Performance Gauge
0%
138.1 µs138.1 µs
execute_yield_to_other[addl_stack_usage:4096]
hilti/runtime/src/benchmarks/fiber.cc
Ignored
CodSpeed Performance Gauge
0%
23.9 µs23.9 µs
execute_yield_to_other[addl_stack_usage:512]
hilti/runtime/src/benchmarks/fiber.cc
Ignored
CodSpeed Performance Gauge
0%
17.8 µs17.8 µs
execute_yield_to_other[addl_stack_usage:64]
hilti/runtime/src/benchmarks/fiber.cc
Ignored
CodSpeed Performance Gauge
0%
17.1 µs17.1 µs
execute_many[addl_stack_usage:8/fibers:512]
hilti/runtime/src/benchmarks/fiber.cc
Ignored
CodSpeed Performance Gauge
0%
891.8 µs891.8 µs
execute_many_resume[addl_stack_usage:1/fibers:64]
hilti/runtime/src/benchmarks/fiber.cc
Ignored
CodSpeed Performance Gauge
0%
189.3 µs189.3 µs
execute_many_resume[addl_stack_usage:1/fibers:8]
hilti/runtime/src/benchmarks/fiber.cc
Ignored
CodSpeed Performance Gauge
0%
31.7 µs31.7 µs
execute_many_resume[addl_stack_usage:18432/fibers:4096]
hilti/runtime/src/benchmarks/fiber.cc
Ignored
CodSpeed Performance Gauge
0%
235.4 ms235.4 ms
execute_many_resume[addl_stack_usage:1/fibers:1]
hilti/runtime/src/benchmarks/fiber.cc
Ignored
CodSpeed Performance Gauge
0%
12.2 µs12.2 µs
execute_many_resume[addl_stack_usage:18432/fibers:1]
hilti/runtime/src/benchmarks/fiber.cc
Ignored
CodSpeed Performance Gauge
0%
65.3 µs65.3 µs
execute_many_resume[addl_stack_usage:1/fibers:512]
hilti/runtime/src/benchmarks/fiber.cc
Ignored
CodSpeed Performance Gauge
0%
1.6 ms1.6 ms
execute_many_resume[addl_stack_usage:512/fibers:8]
hilti/runtime/src/benchmarks/fiber.cc
Ignored
CodSpeed Performance Gauge
0%
34.3 µs34.3 µs
execute_many_resume[addl_stack_usage:4096/fibers:1]
hilti/runtime/src/benchmarks/fiber.cc
Ignored
CodSpeed Performance Gauge
0%
16.4 µs16.4 µs
execute_many_resume[addl_stack_usage:18432/fibers:512]
hilti/runtime/src/benchmarks/fiber.cc
Ignored
CodSpeed Performance Gauge
0%
29.1 ms29.1 ms
execute_many_resume[addl_stack_usage:4096/fibers:4096]
hilti/runtime/src/benchmarks/fiber.cc
Ignored
CodSpeed Performance Gauge
0%
35.9 ms35.9 ms
execute_many_resume[addl_stack_usage:1/fibers:4096]
hilti/runtime/src/benchmarks/fiber.cc
Ignored
CodSpeed Performance Gauge
0%
18.6 ms18.6 ms
execute_many[addl_stack_usage:8/fibers:8]
hilti/runtime/src/benchmarks/fiber.cc
Ignored
CodSpeed Performance Gauge
0%
25.4 µs25.4 µs
execute_many_resume[addl_stack_usage:18432/fibers:64]
hilti/runtime/src/benchmarks/fiber.cc
Ignored
CodSpeed Performance Gauge
0%
3.1 ms3.1 ms
execute_many[addl_stack_usage:8/fibers:1]
hilti/runtime/src/benchmarks/fiber.cc
Ignored
CodSpeed Performance Gauge
0%
11.3 µs11.3 µs
execute_many_resume[addl_stack_usage:4096/fibers:512]
hilti/runtime/src/benchmarks/fiber.cc
Ignored
CodSpeed Performance Gauge
0%
2.8 ms2.8 ms
execute_many_resume[addl_stack_usage:4096/fibers:64]
hilti/runtime/src/benchmarks/fiber.cc
Ignored
CodSpeed Performance Gauge
0%
339.3 µs339.3 µs
execute_many_resume[addl_stack_usage:4096/fibers:8]
hilti/runtime/src/benchmarks/fiber.cc
Ignored
CodSpeed Performance Gauge
0%
52.4 µs52.4 µs
execute_many_resume[addl_stack_usage:18432/fibers:8]
hilti/runtime/src/benchmarks/fiber.cc
Ignored
CodSpeed Performance Gauge
0%
397.9 µs397.9 µs
execute_many_resume[addl_stack_usage:512/fibers:1]
hilti/runtime/src/benchmarks/fiber.cc
Ignored
CodSpeed Performance Gauge
0%
12.7 µs12.7 µs
execute_many_resume[addl_stack_usage:512/fibers:512]
hilti/runtime/src/benchmarks/fiber.cc
Ignored
CodSpeed Performance Gauge
0%
1.8 ms1.8 ms
execute_many_resume[addl_stack_usage:64/fibers:8]
hilti/runtime/src/benchmarks/fiber.cc
Ignored
CodSpeed Performance Gauge
0%
32 µs32 µs
execute_many_resume[addl_stack_usage:512/fibers:64]
hilti/runtime/src/benchmarks/fiber.cc
Ignored
CodSpeed Performance Gauge
0%
208.2 µs208.2 µs
execute_many_resume[addl_stack_usage:64/fibers:4096]
hilti/runtime/src/benchmarks/fiber.cc
Ignored
CodSpeed Performance Gauge
0%
18.9 ms18.9 ms
execute_many_resume[addl_stack_usage:512/fibers:4096]
hilti/runtime/src/benchmarks/fiber.cc
Ignored
CodSpeed Performance Gauge
0%
20.8 ms20.8 ms
execute_yield_to_other[addl_stack_usage:1]
hilti/runtime/src/benchmarks/fiber.cc
Ignored
CodSpeed Performance Gauge
0%
17 µs17 µs
execute_many_resume[addl_stack_usage:64/fibers:512]
hilti/runtime/src/benchmarks/fiber.cc
Ignored
CodSpeed Performance Gauge
0%
1.7 ms1.7 ms
execute_many_resume[addl_stack_usage:64/fibers:64]
hilti/runtime/src/benchmarks/fiber.cc
Ignored
CodSpeed Performance Gauge
0%
192 µs192 µs
execute_many_resume[addl_stack_usage:64/fibers:1]
hilti/runtime/src/benchmarks/fiber.cc
Ignored
CodSpeed Performance Gauge
0%
12.4 µs12.4 µs
execute_many[addl_stack_usage:64/fibers:64]
hilti/runtime/src/benchmarks/fiber.cc
Ignored
CodSpeed Performance Gauge
0%
138.2 µs138.2 µs

Commits

Click on a commit to change the comparison range
Base
main
f67c1f0
0%
Drop stray CFG edge for `while` loops with inits. It looks like this was simply added by accident, and never caught since we had no test. This patch fixes the code and adds a test.
984c45a
3 days ago
by bbannier
© 2025 CodSpeed Technology
Home Terms Privacy Docs