fix(template-react-ts): work with newer Node
#10304Comparing
vegerot:pr10304
(684e368
) withmain
(2e75d4f
)0%
- Improvements
- 0
- Regressions
- 0
- Untouched
- 11
- New
- 0
- Dropped
- 0
- Ignored
- 0
Benchmarks
Passed
basic
tasks/benchmark/benches/groups/basic_build.rs::basic::basic_benchmark::basic+1%
2.8 ms
2.8 ms
basic_sourcemap
tasks/benchmark/benches/groups/basic_build.rs::basic::basic_benchmark::basic_sourcemap+1%
3 ms
3 ms
stats.toJson()
tests/bench/ts-react.bench.ts::TypeScript React project::stats.toJson()0%
25.1 ms
25.1 ms
build_chunk_graph
tasks/benchmark/benches/groups/build_chunk_graph.rs::chunk_graph::build_chunk_graph_benchmark::build_chunk_graph0%
93.6 ms
93.5 ms
Traverse module graph by dependencies
tests/bench/ts-react.bench.ts::TypeScript React project::Traverse module graph by dependencies0%
602.7 µs
602.2 µs
collect imported identifiers
tests/bench/ts-react.bench.ts::TypeScript React project::collect imported identifiers0%
222.4 µs
222.3 µs
Traverse module graph by connections
tests/bench/ts-react.bench.ts::TypeScript React project::Traverse module graph by connections0%
291.1 µs
291 µs
Traverse compilation.modules
tests/bench/ts-react.bench.ts::TypeScript React project::Traverse compilation.modules0%
70.5 µs
70.5 µs
record module
tests/bench/ts-react.bench.ts::TypeScript React project::record module0%
2 ms
2 ms
is css mod
tests/bench/ts-react.bench.ts::TypeScript React project::is css mod0%
90.1 µs
90.2 µs
build_chunk_graph_parallel
tasks/benchmark/benches/groups/build_chunk_graph.rs::chunk_graph::build_chunk_graph_benchmark::build_chunk_graph_parallel-4%
70.4 ms
73.4 ms
Commits
Click on a commit to change the comparison rangeBase
main
2e75d4f
0%
fix(template-react-ts): work with newer Node
Summary:
On my machine running Node v23.11.0, running this example fails with two errors:
1. `__dirname` is undefined
2. `RefreshPlugin` is an object instead of a class
This commit fixes both of these errors.
Test Plan:
1. use Node v23.11.0
2. run `pnpm create rspack@latest`
3. select react-typescript config
4. run `pnpm run dev`
Before this commit: it doesn't work
After this commit: it works
684e368
21 hours ago
by vegerot