Avatar for the vuejs user
vuejs
core
BlogDocsChangelog

fix(compiler-core): fix crash when modifier is empty

#9866Merged
Comparing
baiwusanyu-c:bwsy/fix/emptyModifier
(
27b2503
) with
main
(
04d2c05
)
CodSpeed Performance Gauge
0%
Improvements
0
Regressions
0
Untouched
53
New
0
Dropped
0
Ignored
0

Benchmarks

Passed

create watcher
packages/runtime-core/__tests__/apiWatch.bench.ts::create watcher
CodSpeed Performance Gauge
+2%
114 µs
111.4 µs
1000 reactive maps, 1 computed
packages/reactivity/__tests__/reactiveMap.bench.ts::1000 reactive maps, 1 computed
CodSpeed Performance Gauge
+1%
5.9 ms
5.8 ms
reduce *reactive* array, 1000 elements, only change first value
packages/reactivity/__tests__/reactiveArray.bench.ts::reduce *reactive* array, 1000 elements, only change first value
CodSpeed Performance Gauge
+1%
6.5 ms
6.4 ms
update ref to trigger watchEffect (scheduled but not executed)
packages/runtime-core/__tests__/apiWatch.bench.ts::update ref to trigger watchEffect (scheduled but not executed)
CodSpeed Performance Gauge
+1%
336.3 µs
334.1 µs
create watchEffect
packages/runtime-core/__tests__/apiWatch.bench.ts::create watchEffect
CodSpeed Performance Gauge
+1%
58.7 µs
58.4 µs
write ref, read 1000 computeds
packages/reactivity/__tests__/computed.bench.ts::computed::write ref, read 1000 computeds
CodSpeed Performance Gauge
+1%
5.4 ms
5.3 ms
reduce *readonly* array, 1000 elements
packages/reactivity/__tests__/reactiveArray.bench.ts::reduce *readonly* array, 1000 elements
CodSpeed Performance Gauge
+1%
11.7 ms
11.7 ms
write reactive map, read computed
packages/reactivity/__tests__/reactiveMap.bench.ts::write reactive map, read computed
CodSpeed Performance Gauge
+1%
133.3 µs
132.7 µs
reduce *reactive* array, 1000 elements
packages/reactivity/__tests__/reactiveArray.bench.ts::reduce *reactive* array, 1000 elements
CodSpeed Performance Gauge
0%
25 ms
24.9 ms
update ref to trigger watcher (executed)
packages/runtime-core/__tests__/apiWatch.bench.ts::update ref to trigger watcher (executed)
CodSpeed Performance Gauge
0%
425.1 µs
424 µs
reduce *raw* array, manually triggered, 10 elements
packages/reactivity/__tests__/reactiveArray.bench.ts::reduce *raw* array, manually triggered, 10 elements
CodSpeed Performance Gauge
0%
324 µs
323.3 µs
write/read ref
packages/reactivity/__tests__/ref.bench.ts::ref::write/read ref
CodSpeed Performance Gauge
0%
47.1 µs
47.1 µs
write independent ref dep
packages/reactivity/__tests__/computed.bench.ts::computed::write independent ref dep
CodSpeed Performance Gauge
0%
33.9 µs
33.8 µs
update ref to trigger watchEffect (executed)
packages/runtime-core/__tests__/apiWatch.bench.ts::update ref to trigger watchEffect (executed)
CodSpeed Performance Gauge
0%
114.5 µs
114.3 µs
reduce *raw* array, manually triggered, 100 elements
packages/reactivity/__tests__/reactiveArray.bench.ts::reduce *raw* array, manually triggered, 100 elements
CodSpeed Performance Gauge
0%
103.6 µs
103.5 µs
write ref
packages/reactivity/__tests__/ref.bench.ts::ref::write ref
CodSpeed Performance Gauge
0%
50 µs
50 µs
write reactive map, don't read computed (never invoked)
packages/reactivity/__tests__/reactiveMap.bench.ts::write reactive map, don't read computed (never invoked)
CodSpeed Performance Gauge
0%
36.9 µs
36.8 µs
reduce *raw* array, copied, 100 elements
packages/reactivity/__tests__/reactiveArray.bench.ts::reduce *raw* array, copied, 100 elements
CodSpeed Performance Gauge
0%
98.7 µs
98.6 µs
write reactive map, don't read computed (invoked)
packages/reactivity/__tests__/reactiveMap.bench.ts::write reactive map, don't read computed (invoked)
CodSpeed Performance Gauge
0%
82 µs
81.8 µs
reduce *raw* array, manually triggered, 1000 elements
packages/reactivity/__tests__/reactiveArray.bench.ts::reduce *raw* array, manually triggered, 1000 elements
CodSpeed Performance Gauge
0%
233.6 µs
233.4 µs
write reactive obj, read computed
packages/reactivity/__tests__/reactiveObject.bench.ts::write reactive obj, read computed
CodSpeed Performance Gauge
0%
133.1 µs
133.1 µs
reduce *raw* array, copied, 1000 elements
packages/reactivity/__tests__/reactiveArray.bench.ts::reduce *raw* array, copied, 1000 elements
CodSpeed Performance Gauge
0%
224.8 µs
224.7 µs
write reactive map, don't read 1000 computeds (invoked)
packages/reactivity/__tests__/reactiveMap.bench.ts::write reactive map, don't read 1000 computeds (invoked)
CodSpeed Performance Gauge
0%
1.1 ms
1.1 ms
write reactive obj, don't read 1000 computeds (never invoked)
packages/reactivity/__tests__/reactiveObject.bench.ts::write reactive obj, don't read 1000 computeds (never invoked)
CodSpeed Performance Gauge
0%
68.7 µs
68.7 µs
reduce *raw* array, copied, 10 elements
packages/reactivity/__tests__/reactiveArray.bench.ts::reduce *raw* array, copied, 10 elements
CodSpeed Performance Gauge
0%
174 µs
174 µs
reduce *readonly* array, 10 elements
packages/reactivity/__tests__/reactiveArray.bench.ts::reduce *readonly* array, 10 elements
CodSpeed Performance Gauge
0%
304.5 µs
304.4 µs
write reactive map, read 1000 computeds
packages/reactivity/__tests__/reactiveMap.bench.ts::write reactive map, read 1000 computeds
CodSpeed Performance Gauge
0%
9.5 ms
9.5 ms
update ref to trigger watcher (scheduled but not executed)
packages/runtime-core/__tests__/apiWatch.bench.ts::update ref to trigger watcher (scheduled but not executed)
CodSpeed Performance Gauge
0%
134.1 µs
134.1 µs
write reactive map (10'000 items), read computed
packages/reactivity/__tests__/reactiveMap.bench.ts::write reactive map (10'000 items), read computed
CodSpeed Performance Gauge
0%
6.9 ms
6.9 ms
write ref, don't read 1000 computeds (invoked)
packages/reactivity/__tests__/computed.bench.ts::computed::write ref, don't read 1000 computeds (invoked)
CodSpeed Performance Gauge
0%
780.7 µs
780.6 µs
1000 reactive objs, 1 computed
packages/reactivity/__tests__/reactiveObject.bench.ts::1000 reactive objs, 1 computed
CodSpeed Performance Gauge
0%
4.4 ms
4.4 ms
write reactive obj, don't read 1000 computeds (invoked)
packages/reactivity/__tests__/reactiveObject.bench.ts::write reactive obj, don't read 1000 computeds (invoked)
CodSpeed Performance Gauge
0%
804.2 µs
804.2 µs
create reactive obj
packages/reactivity/__tests__/reactiveObject.bench.ts::create reactive obj
CodSpeed Performance Gauge
0%
33.3 µs
33.3 µs
1000 refs, 1 computed
packages/reactivity/__tests__/computed.bench.ts::computed::1000 refs, 1 computed
CodSpeed Performance Gauge
0%
2.6 ms
2.6 ms
write reactive obj, don't read computed (invoked)
packages/reactivity/__tests__/reactiveObject.bench.ts::write reactive obj, don't read computed (invoked)
CodSpeed Performance Gauge
0%
88.5 µs
88.5 µs
write ref, read computed
packages/reactivity/__tests__/computed.bench.ts::computed::write ref, read computed
CodSpeed Performance Gauge
0%
121.4 µs
121.4 µs
write reactive obj property
packages/reactivity/__tests__/reactiveObject.bench.ts::write reactive obj property
CodSpeed Performance Gauge
0%
52.7 µs
52.7 µs
write reactive obj, don't read computed (never invoked)
packages/reactivity/__tests__/reactiveObject.bench.ts::write reactive obj, don't read computed (never invoked)
CodSpeed Performance Gauge
0%
52.6 µs
52.6 µs
reduce *reactive* array, 10 elements
packages/reactivity/__tests__/reactiveArray.bench.ts::reduce *reactive* array, 10 elements
CodSpeed Performance Gauge
0%
851.7 µs
852.2 µs
reduce *reactive* array, 100 elements
packages/reactivity/__tests__/reactiveArray.bench.ts::reduce *reactive* array, 100 elements
CodSpeed Performance Gauge
0%
2.4 ms
2.4 ms
reduce *reactive* array, 10 elements, only change first value
packages/reactivity/__tests__/reactiveArray.bench.ts::reduce *reactive* array, 10 elements, only change first value
CodSpeed Performance Gauge
0%
198.8 µs
199 µs
reduce *readonly* array, 100 elements
packages/reactivity/__tests__/reactiveArray.bench.ts::reduce *readonly* array, 100 elements
CodSpeed Performance Gauge
0%
1.3 ms
1.3 ms
write reactive obj, read 1000 computeds
packages/reactivity/__tests__/reactiveObject.bench.ts::write reactive obj, read 1000 computeds
CodSpeed Performance Gauge
0%
14.5 ms
14.5 ms
write reactive map, don't read 1000 computeds (never invoked)
packages/reactivity/__tests__/reactiveMap.bench.ts::write reactive map, don't read 1000 computeds (never invoked)
CodSpeed Performance Gauge
0%
44.7 µs
44.7 µs
write reactive map property
packages/reactivity/__tests__/reactiveMap.bench.ts::write reactive map property
CodSpeed Performance Gauge
0%
50.5 µs
50.6 µs
create reactive map
packages/reactivity/__tests__/reactiveMap.bench.ts::create reactive map
CodSpeed Performance Gauge
0%
38.1 µs
38.2 µs
reduce *reactive* array, 100 elements, only change first value
packages/reactivity/__tests__/reactiveArray.bench.ts::reduce *reactive* array, 100 elements, only change first value
CodSpeed Performance Gauge
0%
747.5 µs
750.6 µs
create ref
packages/reactivity/__tests__/ref.bench.ts::ref::create ref
CodSpeed Performance Gauge
0%
25.9 µs
26 µs
write ref, don't read computed (invoked)
packages/reactivity/__tests__/computed.bench.ts::computed::write ref, don't read computed (invoked)
CodSpeed Performance Gauge
-1%
63.3 µs
63.7 µs
create computed
packages/reactivity/__tests__/computed.bench.ts::computed::create computed
CodSpeed Performance Gauge
-1%
24.5 µs
24.7 µs
read ref
packages/reactivity/__tests__/ref.bench.ts::ref::read ref
CodSpeed Performance Gauge
-1%
14.9 µs
15.1 µs
write ref, don't read 1000 computeds (never invoked)
packages/reactivity/__tests__/computed.bench.ts::computed::write ref, don't read 1000 computeds (never invoked)
CodSpeed Performance Gauge
-1%
37.9 µs
38.3 µs
write ref, don't read computed (never invoked)
packages/reactivity/__tests__/computed.bench.ts::computed::write ref, don't read computed (never invoked)
CodSpeed Performance Gauge
-1%
33.1 µs
33.6 µs

Commits

Click on a commit to change the comparison range
Base
main
04d2c05
0%
chore: updated code
6c475c3
1 year ago
by baiwusanyu-c
0%
chore: added unit test
27b2503
1 year ago
by baiwusanyu-c
Home Terms PrivacyDocs