[turbopack] Remove turbotasks function annotations from the 'mutating' AssetIdent helpers
#83506Comparing
low_hit_rates
(211815e
) withcanary
(da54d10
)+8%
- Improvements
- 8
- Regressions
- 0
- Untouched
- 1
- New
- 0
- Dropped
- 0
- Ignored
- 3
No successful run was found on trait_flexibility ( 71c54e5) during the generation of this report, so canary ( da54d10) was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.
Benchmarks
Improved
build[framer-motion-all]
turbopack/crates/turbopack-cli/benches/small_apps.rs::benches::bench_small_apps::turbopack/build/apps::build[framer-motion-all]+8%
3.1 s
2.9 s
build[lucide-react-all]
turbopack/crates/turbopack-cli/benches/small_apps.rs::benches::bench_small_apps::turbopack/build/apps::build[lucide-react-all]+8%
8.9 s
8.2 s
build[framer-motion-single]
turbopack/crates/turbopack-cli/benches/small_apps.rs::benches::bench_small_apps::turbopack/build/apps::build[framer-motion-single]+7%
2.2 s
2.1 s
build[mui]
turbopack/crates/turbopack-cli/benches/small_apps.rs::benches::bench_small_apps::turbopack/build/apps::build[mui]+7%
3.2 s
3 s
build[joy]
turbopack/crates/turbopack-cli/benches/small_apps.rs::benches::bench_small_apps::turbopack/build/apps::build[joy]+6%
2.1 s
2 s
build[date-fns-all]
turbopack/crates/turbopack-cli/benches/small_apps.rs::benches::bench_small_apps::turbopack/build/apps::build[date-fns-all]+5%
2.2 s
2.1 s
build[date-fns-single]
turbopack/crates/turbopack-cli/benches/small_apps.rs::benches::bench_small_apps::turbopack/build/apps::build[date-fns-single]+5%
1.3 s
1.3 s
build[shiki]
turbopack/crates/turbopack-cli/benches/small_apps.rs::benches::bench_small_apps::turbopack/build/apps::build[shiki]+4%
6 s
5.8 s
Passed
build[lucide-react-single]
turbopack/crates/turbopack-cli/benches/small_apps.rs::benches::bench_small_apps::turbopack/build/apps::build[lucide-react-single]+1%
894.6 ms
887.6 ms
Ignored
hmr_updates_large_20Ignored
crates/next-api/benches/hmr.rs::hmr_updates_large_200%
16.7 µs
16.6 µs
hmr_updates_medium_10Ignored
crates/next-api/benches/hmr.rs::hmr_updates_medium_100%
16.7 µs
16.7 µs
hmr_updates_small_5Ignored
crates/next-api/benches/hmr.rs::hmr_updates_small_50%
16.5 µs
16.6 µs
Commits
Click on a commit to change the comparison rangeBase
canary
da54d10
+8.4%
Drop `AssetIdent::new_internal` as a turbo task
This gets a relatively low cache hit rate and we don't believe relying on ResoilvedVc<AssetIdent> for identity is completely reasonable.
211815e
5 hours ago
by lukesandberg