Turbopack: Generalize `ImportedBinding` effect creation to avoid as much special-casing of SimpleAssignTarget
#81653MergedComparing
bgw/generalize-import-bindings
(acebf99
) withcanary
(af42dad
)0%
- Improvements
- 0
- Regressions
- 0
- Untouched
- 9
- New
- 0
- Dropped
- 0
- Ignored
- 3
Benchmarks
Passed
build[framer-motion-all]
turbopack/crates/turbopack-cli/benches/small_apps.rs::benches::bench_small_apps::turbopack/build/apps::build[framer-motion-all]0%
3.1 s
3.1 s
build[date-fns-single]
turbopack/crates/turbopack-cli/benches/small_apps.rs::benches::bench_small_apps::turbopack/build/apps::build[date-fns-single]0%
1.4 s
1.4 s
build[joy]
turbopack/crates/turbopack-cli/benches/small_apps.rs::benches::bench_small_apps::turbopack/build/apps::build[joy]0%
2.1 s
2.1 s
build[date-fns-all]
turbopack/crates/turbopack-cli/benches/small_apps.rs::benches::bench_small_apps::turbopack/build/apps::build[date-fns-all]0%
2.3 s
2.3 s
build[shiki]
turbopack/crates/turbopack-cli/benches/small_apps.rs::benches::bench_small_apps::turbopack/build/apps::build[shiki]0%
6.1 s
6.1 s
build[lucide-react-all]
turbopack/crates/turbopack-cli/benches/small_apps.rs::benches::bench_small_apps::turbopack/build/apps::build[lucide-react-all]0%
9.4 s
9.4 s
build[lucide-react-single]
turbopack/crates/turbopack-cli/benches/small_apps.rs::benches::bench_small_apps::turbopack/build/apps::build[lucide-react-single]0%
913.3 ms
917.6 ms
build[framer-motion-single]
turbopack/crates/turbopack-cli/benches/small_apps.rs::benches::bench_small_apps::turbopack/build/apps::build[framer-motion-single]-1%
2.2 s
2.2 s
build[mui]
turbopack/crates/turbopack-cli/benches/small_apps.rs::benches::bench_small_apps::turbopack/build/apps::build[mui]-1%
3.2 s
3.2 s
Ignored
hmr_updates_large_20Ignored
crates/next-api/benches/hmr.rs::hmr_updates_large_20-2%
16.7 µs
16.9 µs
hmr_updates_medium_10Ignored
crates/next-api/benches/hmr.rs::hmr_updates_medium_10-4%
16.6 µs
17.2 µs
hmr_updates_small_5Ignored
crates/next-api/benches/hmr.rs::hmr_updates_small_5-1%
16.9 µs
17 µs
Commits
Click on a commit to change the comparison rangeBase
canary
af42dad
0%
Turbopack: Generalize `ImportedBinding` effect creation to avoid as much special-casing of SimpleAssignTarget
acebf99
1 day ago
by bgw