jakobnissen:fix_oneoff - Branch - uutils/uutils-term-grid

fix off-by-one in column-search loop and add regression test

#57Merged

Comparing

jakobnissen:fix_oneoff

(

2c1371a

) with

main

(

01761fd

)

-7%

Improvement: 1

Regression: 1

Untouched: 14

Benchmarks

16 total

grid_top_to_bottom[10]

benches/bench-grid.rs

-7%

6.9 µs7.4 µs

grid_left_to_right[10]

benches/bench-grid.rs

+3%

7 µs6.8 µs

grid_display[100]

benches/bench-grid.rs

18 µs17.9 µs

grid_left_to_right[100]

benches/bench-grid.rs

41 µs41 µs

grid_left_to_right[10000]

benches/bench-grid.rs

2.6 ms2.6 ms

grid_top_to_bottom[10000]

benches/bench-grid.rs

2.8 ms2.8 ms

grid_top_to_bottom[1000]

benches/bench-grid.rs

286 µs286 µs

grid_left_to_right[1000]

benches/bench-grid.rs

268.4 µs268.4 µs

grid_display[10000]

benches/bench-grid.rs

1.1 ms1.1 ms

grid_varying_width[320]

benches/bench-grid.rs

463.8 µs463.9 µs

grid_varying_width[160]

benches/bench-grid.rs

253.8 µs253.9 µs

grid_varying_width[80]

benches/bench-grid.rs

152.3 µs152.4 µs

grid_varying_width[20]

benches/bench-grid.rs

81.3 µs81.4 µs

grid_display[1000]

benches/bench-grid.rs

135.9 µs136.1 µs

grid_top_to_bottom[100]

benches/bench-grid.rs

43.8 µs43.9 µs

grid_display[10]

benches/bench-grid.rs

7.3 µs7.3 µs

Commits

Click on a commit to change the comparison range

Base

main

01761fd

-7.18%

fix off-by-one in column-search loop and add regression test

2c1371a

3 days ago

by jakobnissen

Home Terms Privacy Docs