Fix nth_root_exact panic on negative even roots
#56Comparing
sylvestre:bug-25
(d9f280a
) withmain
(75e7ea8
)-93%
- Improvement
- 1
- Regression
- 3
- Untouched
- 25
Benchmarks
29 total
num-primes
bench/benches/bench.rs::benches::bench_prime_gen::safe prime generation (256 bits)-93%
759.5 ms11,165.9 ms
num-primes
bench/benches/bench.rs::benches::bench_prime_gen::prime generation (256 bits)-60%
22 ms54.6 ms
glass_pumpkin
bench/benches/bench.rs::benches::bench_prime_gen::prime generation (256 bits)-54%
3.2 ms6.9 ms
glass_pumpkin
bench/benches/bench.rs::benches::bench_prime_gen::safe prime generation (256 bits)+30%
33.9 ms26.1 ms
glass_pumpkin
bench/benches/bench.rs::benches::bench_is_prime::primality check (u64)0%
213.6 ms213.4 ms
num-prime (this crate)
bench/benches/bench.rs::benches::bench_is_prime::primality check (u256)0%
2.7 ms2.7 ms
num-primes
bench/benches/bench.rs::benches::bench_is_prime::primality check (u64)0%
1.9 s1.9 s
number-theory
bench/benches/bench.rs::benches::bench_factorization::factorize (u64)0%
39.5 ms39.5 ms
num-prime (this crate)
bench/benches/bench.rs::benches::bench_is_prime::primality check (u64)0%
1.8 ms1.8 ms
number-theory
bench/benches/bench.rs::benches::bench_is_prime::primality check (u64)0%
1.7 ms1.7 ms
num-prime (this crate)
bench/benches/bench.rs::benches::bench_factorization::factorize (u64)0%
24.8 ms24.8 ms
primal-check
bench/benches/bench.rs::benches::bench_is_prime::primality check (u64)0%
3.2 ms3.2 ms
glass_pumpkin
bench/benches/bench.rs::benches::bench_is_prime::primality check (u256)0%
28.1 µs28.1 µs
glass_pumpkin (BPSW)
bench/benches/bench.rs::benches::bench_is_prime::primality check (u256)0%
28.2 µs28.2 µs
num-prime (this crate)
bench/benches/bench.rs::benches::bench_is_prime::safe primality check (u256)0%
4 ms4 ms
num-prime (this crate)
bench/benches/bench.rs::benches::bench_prime_gen::prime generation (256 bits)0%
8.8 ms8.8 ms
num-prime (this crate)
bench/benches/bench.rs::benches::bench_prime_gen::safe prime generation (256 bits)0%
4 s4 s
num-primes
bench/benches/bench.rs::benches::bench_is_prime::safe primality check (u2048)0%
96.1 ms96.1 ms
num-primes
bench/benches/bench.rs::benches::bench_is_prime::primality check (u256)0%
481.6 µs481.7 µs
num-prime (this crate)
bench/benches/bench.rs::benches::bench_is_prime::safe primality check (u2048)0%
68.9 ms69 ms
num-prime (this crate)
bench/benches/bench.rs::benches::bench_is_prime::primality check (u2048)0%
68.9 ms69 ms
num-primes
bench/benches/bench.rs::benches::bench_is_prime::safe primality check (u256)0%
1.9 ms1.9 ms
glass_pumpkin (BPSW)
bench/benches/bench.rs::benches::bench_is_prime::primality check (u2048)0%
18.8 µs18.8 µs
glass_pumpkin
bench/benches/bench.rs::benches::bench_is_prime::primality check (u2048)0%
18.8 µs18.8 µs
num-primes
bench/benches/bench.rs::benches::bench_is_prime::primality check (u2048)0%
105.6 µs105.8 µs
Commits
Click on a commit to change the comparison rangeBase
main
75e7ea8
-93.2%
Fix nth_root_exact panic on negative even roots - verify with scilab too
d9f280a
3 days ago
by sylvestre