naoNao89:pr1-tsort-minimal-cycle - Branch - uutils/coreutils

tsort: fix minimal cycle reporting and precise back-edge removal (no refactors)

#8786

Comparing

naoNao89:pr1-tsort-minimal-cycle

(

f8db53b

) with

main

(

1331ff1

)

+90%

Improvements: 4

Untouched: 71

New: 2

Skipped: 73

No successful run was found on main ( f08f4d0) during the generation of this report, so 1331ff1 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

Benchmarks

Skipped (73)

Improved

tsort_input_parsing_heavy[50000]

src/uu/tsort/benches/tsort_bench.rs

+90%

12.8 s6.7 s

fold_custom_width[50000]

src/uu/fold/benches/fold_bench.rs

+31%

60.8 ms46.6 ms

fold_many_lines[100000]

src/uu/fold/benches/fold_bench.rs

+22%

153.1 ms125.3 ms

tsort_wide_dag[100000]

src/uu/tsort/benches/tsort_bench.rs

+4%

135.5 ms130.1 ms

New

nl_large_file[10]

src/uu/nl/benches/nl_bench.rs

N/A

N/A128.1 ms

nl_many_lines[100000]

src/uu/nl/benches/nl_bench.rs

N/A

N/A101.6 ms

Passed

sort_ascii_only[500000]

src/uu/sort/benches/sort_bench.rs

801.1 ms797.9 ms

du_summarize_balanced_tree[(5, 4, 10)]

src/uu/du/benches/du_bench.rs

8.5 ms8.5 ms

cp_recursive_deep_tree[(120, 4)]

src/uu/cp/benches/cp_bench.rs

13.7 ms13.7 ms

du_all_wide_tree[(5000, 500)]

src/uu/du/benches/du_bench.rs

18.1 ms18.1 ms

ls_recursive_long_all_balanced_tree[(6, 4, 15)]

src/uu/ls/benches/ls_bench.rs

138.8 ms138.8 ms

ls_recursive_deep_tree[(200, 2)]

src/uu/ls/benches/ls_bench.rs

2.1 ms2.1 ms

cp_recursive_wide_tree[(6000, 800)]

src/uu/cp/benches/cp_bench.rs

192.7 ms192.7 ms

sort_german_locale

src/uu/sort/benches/sort_locale_bench.rs

94.5 ms94.5 ms

ls_recursive_balanced_tree[(6, 4, 15)]

src/uu/ls/benches/ls_bench.rs

55.7 ms55.7 ms

uniq_case_insensitive[10000]

src/uu/uniq/benches/uniq_bench.rs

1.7 ms1.7 ms

ls_recursive_long_all_wide_tree[(15000, 1500)]

src/uu/ls/benches/ls_bench.rs

149.8 ms149.8 ms

sort_case_insensitive[500000]

src/uu/sort/benches/sort_bench.rs

416.8 ms416.8 ms

sort_mixed_c_locale

src/uu/sort/benches/sort_locale_bench.rs

94.1 ms94.1 ms

ls_recursive_wide_tree[(10000, 1000)]

src/uu/ls/benches/ls_bench.rs

51.2 ms51.2 ms

ls_recursive_long_all_deep_tree[(100, 4)]

src/uu/ls/benches/ls_bench.rs

3.1 ms3.1 ms

numfmt_large_numbers_si[10000]

src/uu/numfmt/benches/numfmt_bench.rs

34.5 ms34.5 ms

numfmt_to_si_precision[10000]

src/uu/numfmt/benches/numfmt_bench.rs

35.3 ms35.3 ms

sort_dictionary_order[500000]

src/uu/sort/benches/sort_bench.rs

1.1 s1.1 s

sort_numeric

src/uu/sort/benches/sort_locale_bench.rs

21.7 ms21.7 ms

wc_words_synthetic[2000]

src/uu/wc/benches/wc_bench.rs

10.3 s10.3 s

sort_case_sensitive[500000]

src/uu/sort/benches/sort_bench.rs

326.8 ms326.8 ms

sort_mixed_data[500000]

src/uu/sort/benches/sort_bench.rs

729.5 ms729.5 ms

sort_numeric[500000]

src/uu/sort/benches/sort_bench.rs

1.2 s1.2 s

sort_mixed_utf8_locale

src/uu/sort/benches/sort_locale_bench.rs

94 ms94 ms

wc_bytes_lines_synthetic[2000]

src/uu/wc/benches/wc_bench.rs

120.2 ms120.2 ms

sort_accented_data[500000]

src/uu/sort/benches/sort_bench.rs

819.2 ms819.2 ms

sort_reverse_mixed

src/uu/sort/benches/sort_locale_bench.rs

93.2 ms93.2 ms

numfmt_from_si[10000]

src/uu/numfmt/benches/numfmt_bench.rs

33.1 ms33.1 ms

expand_many_lines[100000]

src/uu/expand/benches/expand_bench.rs

106.6 ms106.6 ms

numfmt_padding[(10000, 50)]

src/uu/numfmt/benches/numfmt_bench.rs

48.6 ms48.6 ms

numfmt_round_modes[("towards-zero", 10000)]

src/uu/numfmt/benches/numfmt_bench.rs

34.5 ms34.5 ms

sort_ascii_utf8_locale

src/uu/sort/benches/sort_locale_bench.rs

55.8 ms55.8 ms

wc_default_large_line_count[100000]

src/uu/wc/benches/wc_bench.rs

48.9 ms48.9 ms

numfmt_to_si[10000]

src/uu/numfmt/benches/numfmt_bench.rs

33.8 ms33.8 ms

sort_reverse_locale[500000]

src/uu/sort/benches/sort_bench.rs

820.7 ms820.7 ms

sort_ascii_c_locale

src/uu/sort/benches/sort_locale_bench.rs

27.9 ms27.9 ms

numfmt_round_modes[("up", 10000)]

src/uu/numfmt/benches/numfmt_bench.rs

32.8 ms32.8 ms

numfmt_to_iec[10000]

src/uu/numfmt/benches/numfmt_bench.rs

34 ms34 ms

expand_custom_tabstops[50000]

src/uu/expand/benches/expand_bench.rs

30.5 ms30.5 ms

wc_words_large_line_count[100000]

src/uu/wc/benches/wc_bench.rs

43.8 ms43.8 ms

sort_german_c_locale

src/uu/sort/benches/sort_locale_bench.rs

94.5 ms94.5 ms

uniq_with_count[10000]

src/uu/uniq/benches/uniq_bench.rs

1.8 ms1.8 ms

numfmt_round_modes[("down", 10000)]

src/uu/numfmt/benches/numfmt_bench.rs

34.5 ms34.5 ms

uniq_heavy_duplicates[10000]

src/uu/uniq/benches/uniq_bench.rs

1.9 ms1.9 ms

wc_lines_variable_length[(50, 500)]

src/uu/wc/benches/wc_bench.rs

3.4 ms3.4 ms

sort_unique_locale[500000]

src/uu/sort/benches/sort_bench.rs

1.1 s1.1 s

wc_lines_extreme_line_lengths[(100000, 200)]

src/uu/wc/benches/wc_bench.rs

1.6 ms1.6 ms

wc_lines_large_line_count[500000]

src/uu/wc/benches/wc_bench.rs

2.9 ms2.9 ms

ls_recursive_long_all_mixed_tree

src/uu/ls/benches/ls_bench.rs

4 ms4 ms

wc_chars_large_line_count[100000]

src/uu/wc/benches/wc_bench.rs

990.1 µs990.1 µs

ls_recursive_mixed_tree

src/uu/ls/benches/ls_bench.rs

1.4 ms1.4 ms

cp_large_file[16]

src/uu/cp/benches/cp_bench.rs

294.1 µs294.1 µs

sort_random_strings

src/uu/sort/benches/sort_locale_bench.rs

55.3 ms55.3 ms

wc_bytes_synthetic[500]

src/uu/wc/benches/wc_bench.rs

162.8 µs162.8 µs

du_max_depth_balanced_tree[(6, 4, 10)]

src/uu/du/benches/du_bench.rs

33 ms33 ms

sort_unique_mixed

src/uu/sort/benches/sort_locale_bench.rs

87.6 ms87.6 ms

b64_encode_synthetic

src/uu/base64/benches/base64_bench.rs

141.5 µs141.6 µs

tsort_linear_chain[1000000]

src/uu/tsort/benches/tsort_bench.rs

1.5 s1.5 s

cp_archive_balanced_tree[(5, 4, 10)]

src/uu/cp/benches/cp_bench.rs

79.7 ms79.7 ms

cp_preserve_metadata[(5, 4, 10)]

src/uu/cp/benches/cp_bench.rs

76.9 ms77 ms

b64_decode_synthetic

src/uu/base64/benches/base64_bench.rs

145.5 µs145.7 µs

du_balanced_tree[(5, 4, 10)]

src/uu/du/benches/du_bench.rs

9.2 ms9.3 ms

du_deep_tree[(100, 3)]

src/uu/du/benches/du_bench.rs

1.1 ms1.1 ms

b64_decode_ignore_garbage_synthetic

src/uu/base64/benches/base64_bench.rs

145 µs145.2 µs

cp_recursive_balanced_tree[(5, 4, 10)]

src/uu/cp/benches/cp_bench.rs

74.4 ms74.5 ms

du_human_balanced_tree[(5, 4, 10)]

src/uu/du/benches/du_bench.rs

10.4 ms10.4 ms

sort_key_field[500000]

src/uu/sort/benches/sort_bench.rs

686.4 ms689 ms

tsort_tree_dag[(10, 3)]

src/uu/tsort/benches/tsort_bench.rs

-1%

34.1 ms34.4 ms

du_all_balanced_tree[(4, 3, 10)]

src/uu/du/benches/du_bench.rs

-1%

1.6 ms1.6 ms

tsort_complex_dag[50000]

src/uu/tsort/benches/tsort_bench.rs

-1%

84 ms84.9 ms

du_wide_tree[(5000, 500)]

src/uu/du/benches/du_bench.rs

-1%

11.2 ms11.3 ms

Commits

Click on a commit to change the comparison range

Base

main

1331ff1

+90.54%

test(tsort): update expected output for corrected cycle handling

76d1ce7

6 days ago

by naoNao89

-0.21%

refactor(tsort): remove non-essential development comments Clean up cycle detection code by removing redundant comments that don't add meaningful value to the implementation.

15f81a2

4 days ago

by naoNao89

-0.34%

Merge branch 'main' into pr1-tsort-minimal-cycle

f8db53b

3 days ago

by naoNao89

Home Terms Privacy Docs