mattsu2020:install-only-updates - Branch - uutils/coreutils

install: improve directory creation

#8986

Comparing

mattsu2020:install-only-updates

(

7206c29

) with

main

(

6cf5b06

)

Untouched: 123

Skipped: 5

Benchmarks

Skipped (5)

Passed

sort_unique_locale[500000]

src/uu/sort/benches/sort_bench.rs

495.7 ms494 ms

cp_large_file[16]

src/uu/cp/benches/cp_bench.rs

341.9 µs341.3 µs

tsort_input_parsing_heavy[5000]

src/uu/tsort/benches/tsort_bench.rs

82.9 ms82.8 ms

du_wide_tree[(5000, 500)]

src/uu/du/benches/du_bench.rs

11.3 ms11.2 ms

b64_decode_ignore_garbage_synthetic

src/uu/base64/benches/base64_bench.rs

150.4 µs150.3 µs

sort_key_field[500000]

src/uu/sort/benches/sort_bench.rs

700.1 ms699.6 ms

sort_mixed_utf8_locale

src/uu/sort/benches/sort_locale_bench.rs

38.8 ms38.8 ms

cp_recursive_wide_tree[(6000, 800)]

src/uu/cp/benches/cp_bench.rs

188.8 ms188.7 ms

tsort_wide_dag[100000]

src/uu/tsort/benches/tsort_bench.rs

134.8 ms134.7 ms

factor_multiple_u64s[2]

src/uu/factor/benches/factor_bench.rs

178.1 ms178.1 ms

sort_german_locale

src/uu/sort/benches/sort_locale_bench.rs

39.1 ms39.1 ms

mv_multiple_to_dir

src/uu/mv/benches/mv_bench.rs

13.1 ms13.1 ms

hashsum_sha1

src/uu/hashsum/benches/hashsum_bench.rs

72.5 ms72.5 ms

ls_recursive_mixed_tree

src/uu/ls/benches/ls_bench.rs

1.4 ms1.4 ms

wc_lines_extreme_line_lengths[(100000, 200)]

src/uu/wc/benches/wc_bench.rs

1.6 ms1.6 ms

tsort_linear_chain[1000000]

src/uu/tsort/benches/tsort_bench.rs

1.5 s1.5 s

b64_decode_synthetic

src/uu/base64/benches/base64_bench.rs

149.9 µs149.9 µs

uniq_heavy_duplicates[10000]

src/uu/uniq/benches/uniq_bench.rs

1.9 ms1.9 ms

sort_reverse_mixed

src/uu/sort/benches/sort_locale_bench.rs

39.1 ms39.1 ms

sort_numeric

src/uu/sort/benches/sort_locale_bench.rs

23.2 ms23.2 ms

hashsum_sha256

src/uu/hashsum/benches/hashsum_bench.rs

173.6 ms173.6 ms

sort_reverse_locale[500000]

src/uu/sort/benches/sort_bench.rs

361.5 ms361.5 ms

wc_lines_large_line_count[500000]

src/uu/wc/benches/wc_bench.rs

2.9 ms2.9 ms

ls_recursive_balanced_tree[(6, 4, 15)]

src/uu/ls/benches/ls_bench.rs

55.6 ms55.6 ms

rm_force_files

src/uu/rm/benches/rm_bench.rs

2.1 ms2.1 ms

ls_recursive_long_all_mixed_tree

src/uu/ls/benches/ls_bench.rs

2.8 ms2.8 ms

tsort_complex_dag[50000]

src/uu/tsort/benches/tsort_bench.rs

84.7 ms84.7 ms

split_lines

src/uu/split/benches/split_bench.rs

5.7 ms5.7 ms

cp_recursive_balanced_tree[(5, 4, 10)]

src/uu/cp/benches/cp_bench.rs

72.1 ms72.1 ms

cksum_crc32b

src/uu/cksum/benches/cksum_bench.rs

14.1 ms14.1 ms

uniq_case_insensitive[10000]

src/uu/uniq/benches/uniq_bench.rs

1.7 ms1.7 ms

cksum_default

src/uu/cksum/benches/cksum_bench.rs

17.7 ms17.7 ms

numfmt_round_modes[("up", 10000)]

src/uu/numfmt/benches/numfmt_bench.rs

34.6 ms34.6 ms

numfmt_round_modes[("down", 10000)]

src/uu/numfmt/benches/numfmt_bench.rs

34.6 ms34.6 ms

numfmt_to_si[10000]

src/uu/numfmt/benches/numfmt_bench.rs

34.2 ms34.2 ms

numfmt_to_iec[10000]

src/uu/numfmt/benches/numfmt_bench.rs

34.2 ms34.2 ms

rm_single_file

src/uu/rm/benches/rm_bench.rs

106.5 ms106.5 ms

numfmt_round_modes[("towards-zero", 10000)]

src/uu/numfmt/benches/numfmt_bench.rs

34.6 ms34.6 ms

numfmt_from_si[10000]

src/uu/numfmt/benches/numfmt_bench.rs

33.3 ms33.3 ms

seq_with_step

src/uu/seq/benches/seq_bench.rs

13.3 ms13.3 ms

numfmt_to_si_precision[10000]

src/uu/numfmt/benches/numfmt_bench.rs

35.4 ms35.4 ms

cksum_sysv

src/uu/cksum/benches/cksum_bench.rs

48 ms48 ms

cut_fields_custom_delim

src/uu/cut/benches/cut_bench.rs

40.7 ms40.7 ms

cksum_raw_output

src/uu/cksum/benches/cksum_bench.rs

17.7 ms17.7 ms

numfmt_padding[(10000, 50)]

src/uu/numfmt/benches/numfmt_bench.rs

47.7 ms47.7 ms

hashsum_md5_check

src/uu/hashsum/benches/hashsum_bench.rs

32 ms32 ms

seq_custom_separator

src/uu/seq/benches/seq_bench.rs

28.7 ms28.7 ms

cksum_blake3

src/uu/cksum/benches/cksum_bench.rs

95.7 ms95.7 ms

cksum_crc

src/uu/cksum/benches/cksum_bench.rs

17.7 ms17.7 ms

cksum_bsd

src/uu/cksum/benches/cksum_bench.rs

128.1 ms128.1 ms

seq_integers

src/uu/seq/benches/seq_bench.rs

26.1 ms26.1 ms

wc_bytes_lines_synthetic[2000]

src/uu/wc/benches/wc_bench.rs

120.2 ms120.2 ms

cksum_blake2b

src/uu/cksum/benches/cksum_bench.rs

192.9 ms192.9 ms

seq_formatted

src/uu/seq/benches/seq_bench.rs

97.2 ms97.2 ms

sort_numeric[500000]

src/uu/sort/benches/sort_bench.rs

1.2 s1.2 s

cksum_md5

src/uu/cksum/benches/cksum_bench.rs

317.8 ms317.8 ms

hashsum_sha512

src/uu/hashsum/benches/hashsum_bench.rs

110.8 ms110.8 ms

unexpand_many_lines[100000]

src/uu/unexpand/benches/unexpand_bench.rs

262 ms262 ms

wc_default_large_line_count[100000]

src/uu/wc/benches/wc_bench.rs

50.4 ms50.4 ms

expand_many_lines[100000]

src/uu/expand/benches/expand_bench.rs

149.9 ms149.9 ms

cut_fields_tab

src/uu/cut/benches/cut_bench.rs

34.1 ms34.1 ms

cksum_sha512

src/uu/cksum/benches/cksum_bench.rs

1.1 s1.1 s

cksum_sha384

src/uu/cksum/benches/cksum_bench.rs

1.1 s1.1 s

hashsum_sha256_check

src/uu/hashsum/benches/hashsum_bench.rs

173.6 ms173.6 ms

unexpand_large_file[10]

src/uu/unexpand/benches/unexpand_bench.rs

549.3 ms549.3 ms

cksum_sha1

src/uu/cksum/benches/cksum_bench.rs

722.9 ms722.9 ms

cksum_sha224

src/uu/cksum/benches/cksum_bench.rs

1.7 s1.7 s

cksum_sha256

src/uu/cksum/benches/cksum_bench.rs

1.7 s1.7 s

cksum_sm3

src/uu/cksum/benches/cksum_bench.rs

1.6 s1.6 s

wc_words_synthetic[2000]

src/uu/wc/benches/wc_bench.rs

11.4 s11.4 s

cksum_shake128

src/uu/cksum/benches/cksum_bench.rs

1.5 s1.5 s

cksum_shake256

src/uu/cksum/benches/cksum_bench.rs

1.9 s1.9 s

cksum_sha3

src/uu/cksum/benches/cksum_bench.rs

1.8 s1.8 s

cksum_sha2

src/uu/cksum/benches/cksum_bench.rs

1.7 s1.7 s

hashsum_md5

src/uu/hashsum/benches/hashsum_bench.rs

32 ms32 ms

wc_words_large_line_count[100000]

src/uu/wc/benches/wc_bench.rs

47.9 ms47.9 ms

rm_recursive_tree

src/uu/rm/benches/rm_bench.rs

13.6 ms13.6 ms

cut_bytes

src/uu/cut/benches/cut_bench.rs

8.5 ms8.5 ms

nl_many_lines[100000]

src/uu/nl/benches/nl_bench.rs

79.8 ms79.8 ms

ls_recursive_long_all_wide_tree[(15000, 1500)]

src/uu/ls/benches/ls_bench.rs

142.3 ms142.3 ms

nl_large_file[10]

src/uu/nl/benches/nl_bench.rs

100.9 ms100.9 ms

fold_many_lines[100000]

src/uu/fold/benches/fold_bench.rs

116.2 ms116.2 ms

expand_custom_tabstops[50000]

src/uu/expand/benches/expand_bench.rs

37 ms37 ms

cksum_multiple_files

src/uu/cksum/benches/cksum_bench.rs

26.5 ms26.5 ms

wc_lines_variable_length[(50, 500)]

src/uu/wc/benches/wc_bench.rs

3.4 ms3.4 ms

sort_mixed_data[500000]

src/uu/sort/benches/sort_bench.rs

327.3 ms327.3 ms

numfmt_large_numbers_si[10000]

src/uu/numfmt/benches/numfmt_bench.rs

32.9 ms32.9 ms

rm_multiple_files

src/uu/rm/benches/rm_bench.rs

2.3 ms2.3 ms

fold_custom_width[50000]

src/uu/fold/benches/fold_bench.rs

43.4 ms43.4 ms

wc_chars_large_line_count[100000]

src/uu/wc/benches/wc_bench.rs

994.7 µs994.7 µs

sort_ascii_only[500000]

src/uu/sort/benches/sort_bench.rs

353.6 ms353.6 ms

split_number_chunks

src/uu/split/benches/split_bench.rs

275.2 µs275.2 µs

ls_recursive_wide_tree[(10000, 1000)]

src/uu/ls/benches/ls_bench.rs

52.6 ms52.6 ms

cut_characters

src/uu/cut/benches/cut_bench.rs

7.5 ms7.5 ms

sort_accented_data[500000]

src/uu/sort/benches/sort_bench.rs

362.4 ms362.5 ms

uniq_with_count[10000]

src/uu/uniq/benches/uniq_bench.rs

1.9 ms1.9 ms

sort_ascii_c_locale

src/uu/sort/benches/sort_locale_bench.rs

21.5 ms21.5 ms

sort_mixed_c_locale

src/uu/sort/benches/sort_locale_bench.rs

38.3 ms38.3 ms

mv_directory

src/uu/mv/benches/mv_bench.rs

3.5 ms3.5 ms

mv_single_file

src/uu/mv/benches/mv_bench.rs

129.6 ms129.6 ms

wc_bytes_synthetic[500]

src/uu/wc/benches/wc_bench.rs

164.4 µs164.4 µs

sort_case_sensitive[500000]

src/uu/sort/benches/sort_bench.rs

174.2 ms174.2 ms

ls_recursive_long_all_deep_tree[(100, 4)]

src/uu/ls/benches/ls_bench.rs

3.2 ms3.2 ms

sort_ascii_utf8_locale

src/uu/sort/benches/sort_locale_bench.rs

43.1 ms43.1 ms

mv_force_overwrite

src/uu/mv/benches/mv_bench.rs

125.1 ms125.1 ms

sort_case_insensitive[500000]

src/uu/sort/benches/sort_bench.rs

278.6 ms278.6 ms

split_numeric_suffix

src/uu/split/benches/split_bench.rs

5.9 ms5.9 ms

sort_german_c_locale

src/uu/sort/benches/sort_locale_bench.rs

38.4 ms38.4 ms

tsort_tree_dag[(10, 3)]

src/uu/tsort/benches/tsort_bench.rs

34.4 ms34.4 ms

ls_recursive_deep_tree[(200, 2)]

src/uu/ls/benches/ls_bench.rs

2.2 ms2.2 ms

cp_recursive_deep_tree[(120, 4)]

src/uu/cp/benches/cp_bench.rs

13.6 ms13.6 ms

cp_archive_balanced_tree[(5, 4, 10)]

src/uu/cp/benches/cp_bench.rs

77.7 ms77.8 ms

du_all_wide_tree[(5000, 500)]

src/uu/du/benches/du_bench.rs

18.2 ms18.2 ms

sort_unique_mixed

src/uu/sort/benches/sort_locale_bench.rs

39.3 ms39.3 ms

ls_recursive_long_all_balanced_tree[(6, 4, 15)]

src/uu/ls/benches/ls_bench.rs

135.8 ms135.9 ms

split_bytes

src/uu/split/benches/split_bench.rs

505.1 µs505.3 µs

b64_encode_synthetic

src/uu/base64/benches/base64_bench.rs

146.6 µs146.7 µs

du_summarize_balanced_tree[(5, 4, 10)]

src/uu/du/benches/du_bench.rs

8.4 ms8.4 ms

sort_long_line[160000]

src/uu/sort/benches/sort_bench.rs

1.6 ms1.6 ms

cp_preserve_metadata[(5, 4, 10)]

src/uu/cp/benches/cp_bench.rs

74.6 ms74.7 ms

du_deep_tree[(100, 3)]

src/uu/du/benches/du_bench.rs

1.2 ms1.2 ms

sort_dictionary_order[500000]

src/uu/sort/benches/sort_bench.rs

1.1 s1.1 s

du_max_depth_balanced_tree[(6, 4, 10)]

src/uu/du/benches/du_bench.rs

-1%

33 ms33.2 ms

Commits

Click on a commit to change the comparison range

Base

main

6cf5b06

-0.01%

refactor: clean up imports in test_install.rs Removed duplicate `use std::path::Path;` import and unified `#[cfg(not(windows))]` to `#[cfg(unix)]` for `use uucore::libc;` to improve code consistency and target Unix-like systems more precisely.

d28c545

25 days ago

by mattsu2020

Update .vscode/cspell.dictionaries/jargon.wordlist.txt delete duplicate word Co-authored-by: Daniel Hofstetter <daniel.hofstetter@42dh.com>

9d4e06f

24 days ago

by mattsu2020

Merge branch 'install-only-updates' of https://github.com/mattsu2020/coreutils into install-only-updates

94664e1

24 days ago

by mattsu2020

-0.01%

test: fix deep path test in install utility Update the deep path generation in the install test to use libc::PATH_MAX, ensuring the test accurately checks behavior at the system's maximum path length limit.

482a667

24 days ago

by mattsu2020

+0.02%

fix: remove redundant parentheses in deep path test

aa93786

24 days ago

by mattsu2020

test: refine deep path generation in install test Refactor the path construction logic in test_install_directory_deep_path_succeeds to ensure the generated path is at least 3000 characters long while respecting PATH_MAX limits, preventing potential overflows and improving test reliability for long path scenarios.

0a6530b

24 days ago

by mattsu2020

-0.01%

refactor: consolidate min_repeat calculation in test_install.rs Combine the min_repeat calculation into a single line for improved readability in the test_install_directory_deep_path_succeeds function.

6d436ab

24 days ago

by mattsu2020

+0.02%

style(tests): format min_repeat calculation in test_install Simplify the min_repeat assignment by consolidating it into a single line, improving code readability and consistency in the install utility tests.

f89854d

24 days ago

by mattsu2020

-0.02%

refactor(tests): adjust imports and simplify expression in install test - Update import conditions: OsStrExt for unix, OsStringExt for linux to improve platform compatibility - Chain method calls in min_repeat calculation for code conciseness and readability

ed74e1e

24 days ago

by mattsu2020

+0.03%

refactor: replace panic with assert in install directory test Replaces a panic with an assert in the `test_install_directory_deep_path_succeeds` function to handle cases where the temporary directory path exceeds PATH_MAX, improving test reliability and error reporting consistency.

e62a629

24 days ago

by mattsu2020

+2.71%

style(install): reformat code and reorder imports in mode.rs Reordered the import statement for nix::fcntl to place OFlag before open and openat. Reformatted long lines, including expressions for base_fd, error creation, and openat calls, to improve readability and adhere to code style guidelines.

1a1c8ed

24 days ago

by mattsu2020

-2.73%

refactor: simplify chmod_long_path for better path handling - Removed platform-specific node_open_flags functions to reduce code duplication - Introduced last_component tracking to properly handle the final path component - Updated CurDir and ParentDir handling to set last_component when it's the last element - Simplified Normal component logic to only open directories for non-final components - Use last_component for fchmod operation, defaulting to "." if no component is found, improving reliability for edge cases in long path chmod operations

312a293

24 days ago

by mattsu2020

-0.02%

feat(install): add AsFd import for unix file descriptor access Added std::os::fd::AsFd import under unix-specific conditions to enable file descriptor-based operations in the install utility's mode handling.

d20acf1

24 days ago

by mattsu2020

feat: add AsRawFd import for raw file descriptor access Added AsRawFd trait import alongside AsFd in mode.rs to enable access to raw file descriptors, supporting enhanced file handling operations in the install utility.

482fd2b

24 days ago

by mattsu2020

+0.02%

refactor(install): remove unused std::fs import and reorder path import Removed the unused `std::fs` import and repositioned `std::path::Path` after the conditional block for better import organization in the mode module.

b32244b

24 days ago

by mattsu2020

docs: add technical terms to cspell jargon wordlist Added dirfd, ENAMETOOLONG, and fchmodat to the VS Code cspell dictionary to prevent false positives during spell checking of technical code terms.

807b56b

24 days ago

by mattsu2020

test: add safety margin for small PATH_MAX in deep path test Adjust path calculation in test_install_directory_deep_path_succeeds to subtract a safety margin when PATH_MAX is 1024 or less, preventing potential buffer overflow issues in long path scenarios.

f112e21

24 days ago

by mattsu2020

+0.04%

Merge branch 'main' of https://github.com/uutils/coreutils into install-only-updates

18e71e9

7 days ago

by mattsu2020

-0.04%

Revert "Improve fold bench data generation" This reverts commit 483a1f2fe9a5d0ccebd025a53d7b7ba4f353f860.

7206c29

7 days ago

by mattsu2020

Home Terms Privacy Docs