abendrothj:fix/is_dir_TOCTOU_and_err_msgs - Branch - uutils/coreutils

fix: eliminate TOCTOU races in ln and tac by deferring is_dir() checks

#10991Merged

Comparing

abendrothj:fix/is_dir_TOCTOU_and_err_msgs

(

e8b98bc

) with

main

(

9ac174b

)

Untouched: 293

Ignored: 1

Skipped: 42

Benchmarks

336 total

cksum_crc32b

src/uu/cksum/benches/cksum_bench.rs

+1%

13.3 ms13.1 ms

cksum_multiple_files

src/uu/cksum/benches/cksum_bench.rs

+1%

25.3 ms25.2 ms

sort_mixed_data[500000]

src/uu/sort/benches/sort_bench.rs

+1%

299.5 ms297.8 ms

cksum_default

src/uu/cksum/benches/cksum_bench.rs

16.9 ms16.8 ms

cksum_crc

src/uu/cksum/benches/cksum_bench.rs

16.9 ms16.8 ms

cksum_raw_output

src/uu/cksum/benches/cksum_bench.rs

16.9 ms16.8 ms

du_max_depth_balanced_tree[(6, 4, 10)]

src/uu/du/benches/du_bench.rs

25.7 ms25.8 ms

sort_general_numeric[200000]

src/uu/sort/benches/sort_bench.rs

712 ms708.9 ms

du_all_wide_tree[(5000, 500)]

src/uu/du/benches/du_bench.rs

16.3 ms16.4 ms

rm_recursive_tree

src/uu/rm/benches/rm_bench.rs

11.6 ms11.7 ms

file_custom_format

src/uu/date/benches/date_bench.rs

15.9 ms15.9 ms

du_summarize_balanced_tree[(5, 4, 10)]

src/uu/du/benches/du_bench.rs

6.7 ms6.7 ms

cksum_sysv

src/uu/cksum/benches/cksum_bench.rs

48.2 ms48.1 ms

du_wide_tree[(5000, 500)]

src/uu/du/benches/du_bench.rs

9.3 ms9.3 ms

sort_ascii_only[500000]

src/uu/sort/benches/sort_bench.rs

325.2 ms325.9 ms

sort_mixed_c_locale

src/uu/sort/benches/sort_locale_c_bench.rs

35.8 ms35.7 ms

cp_recursive_balanced_tree[(5, 4, 10)]

src/uu/cp/benches/cp_bench.rs

71.9 ms71.8 ms

single_date_now

src/uu/date/benches/date_bench.rs

206.6 µs206.9 µs

dd_copy_separate_blocks

src/uu/dd/benches/dd_bench.rs

43.8 ms43.9 ms

ls_recursive_deep_tree[(200, 2)]

src/uu/ls/benches/ls_bench.rs

1.9 ms1.9 ms

sort_unique_utf8_locale

src/uu/sort/benches/sort_locale_utf8_bench.rs

36.2 ms36.2 ms

socket_addrs_direct[100000]

src/uu/hostname/benches/hostname_bench.rs

55.5 µs55.6 µs

cp_archive_balanced_tree[(5, 4, 10)]

src/uu/cp/benches/cp_bench.rs

77.4 ms77.3 ms

file_iso_dates

src/uu/date/benches/date_bench.rs

20.1 ms20.1 ms

shuf_input_range[1000000]

src/uu/shuf/benches/shuf_bench.rs

85.7 ms85.6 ms

Commits

Click on a commit to change the comparison range

Base

main

9ac174b

+0.01%

fix(tac): improve error message formatting for file not found scenario

e8b98bc

6 months ago

by abendrothj

Home Terms Privacy Docs