abendrothj:fix/is_dir_TOCTOU_and_err_msgs - Branch - uutils/coreutils

fix: eliminate TOCTOU races in ln and tac by deferring is_dir() checks

#10991

Comparing

abendrothj:fix/is_dir_TOCTOU_and_err_msgs

(

a3a28ef

) with

main

(

b439534

)

-3%

Regression: 1

Untouched: 287

Skipped: 38

Benchmarks

326 total

cp_large_file[16]

src/uu/cp/benches/cp_bench.rs

-3%

380.5 µs392.5 µs

sort_case_insensitive[500000]

src/uu/sort/benches/sort_bench.rs

+1%

254.3 ms252 ms

cksum_crc32b

src/uu/cksum/benches/cksum_bench.rs

+1%

13.2 ms13.1 ms

dd_copy_4k_blocks

src/uu/dd/benches/dd_bench.rs

+1%

1.3 ms1.3 ms

mv_multiple_to_dir

src/uu/mv/benches/mv_bench.rs

12.6 ms12.6 ms

cksum_raw_output

src/uu/cksum/benches/cksum_bench.rs

16.9 ms16.8 ms

cksum_default

src/uu/cksum/benches/cksum_bench.rs

16.9 ms16.9 ms

dd_copy_1m_blocks

src/uu/dd/benches/dd_bench.rs

1.5 ms1.5 ms

cksum_sysv

src/uu/cksum/benches/cksum_bench.rs

48.2 ms48.1 ms

ls_recursive_deep_tree[(200, 2)]

src/uu/ls/benches/ls_bench.rs

1.9 ms1.9 ms

sort_mixed_c_locale

src/uu/sort/benches/sort_locale_c_bench.rs

36.7 ms36.7 ms

ls_recursive_balanced_tree[(6, 4, 15)]

src/uu/ls/benches/ls_bench.rs

52.5 ms52.4 ms

cp_recursive_balanced_tree[(5, 4, 10)]

src/uu/cp/benches/cp_bench.rs

71.9 ms71.8 ms

dd_copy_with_skip

src/uu/dd/benches/dd_bench.rs

2.2 ms2.2 ms

du_deep_tree[(100, 3)]

src/uu/du/benches/du_bench.rs

1.2 ms1.2 ms

numfmt_padding[(10000, 50)]

src/uu/numfmt/benches/numfmt_bench.rs

51.3 ms51.3 ms

cp_archive_balanced_tree[(5, 4, 10)]

src/uu/cp/benches/cp_bench.rs

77.3 ms77.3 ms

cksum_bsd

src/uu/cksum/benches/cksum_bench.rs

128.3 ms128.2 ms

ls_recursive_mixed_tree

src/uu/ls/benches/ls_bench.rs

1.4 ms1.4 ms

sort_case_sensitive[500000]

src/uu/sort/benches/sort_bench.rs

151.5 ms151.4 ms

shuf_input_range[1000000]

src/uu/shuf/benches/shuf_bench.rs

92.5 ms92.4 ms

file_tz_abbreviations

src/uu/date/benches/date_bench.rs

24.3 ms24.3 ms

file_iso_dates

src/uu/date/benches/date_bench.rs

20.2 ms20.2 ms

shuf_input_range[1000000]

src/uu/shuf/benches/shuf_bench.rs

8.9 MB8.9 MB

sort_accented_data[500000]

src/uu/sort/benches/sort_bench.rs

337.6 ms337.5 ms

Commits

Click on a commit to change the comparison range

Base

main

b439534

-0.01%

fix(tac): improve error message formatting for file not found scenario

ac10014

2 days ago

by abendrothj

-3.06%

Merge branch 'main' into fix/is_dir_TOCTOU_and_err_msgs

a3a28ef

2 days ago

by abendrothj

Home Terms Privacy Docs