SaathwikDasari:fix-fold-dev-zero - Branch - uutils/coreutils

fix(fold): use buffered read to prevent hang on infinite streams like /dev/zero

#9966

Comparing

SaathwikDasari:fix-fold-dev-zero

(

9a67924

) with

main

(

f60072d

)

-6%

Regression: 1

Untouched: 129

Skipped: 30

Benchmarks

160 total

fold_many_lines[100000]

src/uu/fold/benches/fold_bench.rs

-6%

80.4 ms85.9 ms

du_deep_tree[(100, 3)]

src/uu/du/benches/du_bench.rs

+1%

1.2 ms1.2 ms

tsort_input_parsing_heavy[5000]

src/uu/tsort/benches/tsort_bench.rs

+1%

85.8 ms85.3 ms

du_max_depth_balanced_tree[(6, 4, 10)]

src/uu/du/benches/du_bench.rs

+1%

33 ms32.8 ms

dd_copy_1m_blocks

src/uu/dd/benches/dd_bench.rs

+1%

1.5 ms1.5 ms

cksum_multiple_files

src/uu/cksum/benches/cksum_bench.rs

25.4 ms25.3 ms

dd_copy_partial

src/uu/dd/benches/dd_bench.rs

558.4 µs556.1 µs

cp_large_file[16]

src/uu/cp/benches/cp_bench.rs

362.5 µs361.7 µs

cp_recursive_deep_tree[(120, 4)]

src/uu/cp/benches/cp_bench.rs

13.6 ms13.6 ms

dd_copy_8k_blocks

src/uu/dd/benches/dd_bench.rs

1 ms1 ms

dd_copy_default

src/uu/dd/benches/dd_bench.rs

14 ms13.9 ms

b64_decode_synthetic

src/uu/base64/benches/base64_bench.rs

166.3 µs166.2 µs

mv_multiple_to_dir

src/uu/mv/benches/mv_bench.rs

12.9 ms12.9 ms

sort_numeric[500000]

src/uu/sort/benches/sort_bench.rs

1.2 s1.2 s

sort_german_c_locale

src/uu/sort/benches/sort_locale_c_bench.rs

37.9 ms37.9 ms

cp_recursive_balanced_tree[(5, 4, 10)]

src/uu/cp/benches/cp_bench.rs

72.3 ms72.3 ms

shuf_lines[100000]

src/uu/shuf/benches/shuf_bench.rs

31.6 ms31.6 ms

mv_single_file

src/uu/mv/benches/mv_bench.rs

135.6 ms135.5 ms

cksum_default

src/uu/cksum/benches/cksum_bench.rs

16.9 ms16.9 ms

sort_german_de_locale

src/uu/sort/benches/sort_locale_de_bench.rs

37.9 ms37.9 ms

ls_recursive_balanced_tree[(6, 4, 15)]

src/uu/ls/benches/ls_bench.rs

55.3 ms55.3 ms

tsort_complex_dag[50000]

src/uu/tsort/benches/tsort_bench.rs

84 ms84 ms

ls_recursive_long_all_deep_tree[(100, 4)]

src/uu/ls/benches/ls_bench.rs

3.3 ms3.3 ms

ls_recursive_mixed_tree

src/uu/ls/benches/ls_bench.rs

1.4 ms1.4 ms

mv_force_overwrite

src/uu/mv/benches/mv_bench.rs

144.3 ms144.3 ms

Commits

Click on a commit to change the comparison range

Base

main

f60072d

×23

tests: add regression test for char device input

cb20a5f

28 days ago

by SaathwikDasari

fix: use buffered read to prevent hanging on infinite streams like /dev/zero also fixed failure testcases after cargo fmt

bf64d00

28 days ago

by SaathwikDasari

+7.84%

fixed the performance regression hopefully and cargo fmt

12f900d

28 days ago

by SaathwikDasari

fixed the code quality failure

9a67924

28 days ago

by SaathwikDasari

Home Terms Privacy Docs