SaathwikDasari:fix-fold-dev-zero - Branch - uutils/coreutils

fix(fold): use buffered read to prevent hang on infinite streams like /dev/zero

#9966Closed

Comparing

SaathwikDasari:fix-fold-dev-zero

(

9a67924

) with

main

(

f60072d

)

-6%

Regression: 1

Untouched: 128

Ignored: 1

Skipped: 30

Benchmarks

160 total

fold_many_lines[100000]

src/uu/fold/benches/fold_bench.rs

-6%

80.4 ms85.9 ms

fold_custom_width[50000]

src/uu/fold/benches/fold_bench.rs

-3%

33 ms34 ms

du_deep_tree[(100, 3)]

src/uu/du/benches/du_bench.rs

+1%

1.2 ms1.2 ms

tsort_input_parsing_heavy[5000]

src/uu/tsort/benches/tsort_bench.rs

+1%

85.8 ms85.3 ms

du_max_depth_balanced_tree[(6, 4, 10)]

src/uu/du/benches/du_bench.rs

+1%

33 ms32.8 ms

dd_copy_1m_blocks

src/uu/dd/benches/dd_bench.rs

+1%

1.5 ms1.5 ms

dd_copy_with_skip

src/uu/dd/benches/dd_bench.rs

2.2 ms2.3 ms

cksum_multiple_files

src/uu/cksum/benches/cksum_bench.rs

25.4 ms25.3 ms

dd_copy_partial

src/uu/dd/benches/dd_bench.rs

558.4 µs556.1 µs

dd_copy_64k_blocks

src/uu/dd/benches/dd_bench.rs

601.5 µs603.5 µs

du_summarize_balanced_tree[(5, 4, 10)]

src/uu/du/benches/du_bench.rs

8.5 ms8.5 ms

dd_copy_4k_blocks

src/uu/dd/benches/dd_bench.rs

1.3 ms1.3 ms

cksum_raw_output

src/uu/cksum/benches/cksum_bench.rs

16.9 ms17 ms

du_all_wide_tree[(5000, 500)]

src/uu/du/benches/du_bench.rs

18.1 ms18.1 ms

dd_copy_with_seek

src/uu/dd/benches/dd_bench.rs

2.3 ms2.3 ms

dd_copy_separate_blocks

src/uu/dd/benches/dd_bench.rs

44 ms44.1 ms

sort_unique_utf8_locale

src/uu/sort/benches/sort_locale_utf8_bench.rs

37.7 ms37.7 ms

cp_recursive_deep_tree[(120, 4)]

src/uu/cp/benches/cp_bench.rs

13.6 ms13.6 ms

cp_preserve_metadata[(5, 4, 10)]

src/uu/cp/benches/cp_bench.rs

74.9 ms75 ms

sort_case_sensitive[500000]

src/uu/sort/benches/sort_bench.rs

163 ms163.1 ms

dd_copy_8k_blocks

src/uu/dd/benches/dd_bench.rs

1 ms1 ms

sort_dictionary_order[500000]

src/uu/sort/benches/sort_bench.rs

1.1 s1.1 s

sort_reverse_utf8_locale

src/uu/sort/benches/sort_locale_utf8_bench.rs

37.6 ms37.7 ms

dd_copy_default

src/uu/dd/benches/dd_bench.rs

14 ms13.9 ms

b64_decode_synthetic

src/uu/base64/benches/base64_bench.rs

166.3 µs166.2 µs

Commits

Click on a commit to change the comparison range

Base

main

f60072d

×23

tests: add regression test for char device input

cb20a5f

8 months ago

by SaathwikDasari

fix: use buffered read to prevent hanging on infinite streams like /dev/zero also fixed failure testcases after cargo fmt

bf64d00

8 months ago

by SaathwikDasari

+7.84%

fixed the performance regression hopefully and cargo fmt

12f900d

8 months ago

by SaathwikDasari

fixed the code quality failure

9a67924

8 months ago

by SaathwikDasari

Home Terms Privacy Docs