SaathwikDasari:fix-fold-dev-zero - Branch - uutils/coreutils

fix(fold): use buffered read to prevent hang on infinite streams like /dev/zero

#9966

Comparing

SaathwikDasari:fix-fold-dev-zero

(

9a67924

) with

main

(

f60072d

)

-6%

Regressions: 1

Untouched: 129

Skipped: 30

Benchmarks

Skipped (30)

Failed

fold_many_lines[100000]

src/uu/fold/benches/fold_bench.rs

Regression

-6%

80.4 ms85.9 ms

Passed

du_deep_tree[(100, 3)]

src/uu/du/benches/du_bench.rs

+1%

1.2 ms1.2 ms

tsort_input_parsing_heavy[5000]

src/uu/tsort/benches/tsort_bench.rs

+1%

85.8 ms85.3 ms

du_max_depth_balanced_tree[(6, 4, 10)]

src/uu/du/benches/du_bench.rs

+1%

33 ms32.8 ms

dd_copy_1m_blocks

src/uu/dd/benches/dd_bench.rs

+1%

1.5 ms1.5 ms

cksum_multiple_files

src/uu/cksum/benches/cksum_bench.rs

25.4 ms25.3 ms

dd_copy_partial

src/uu/dd/benches/dd_bench.rs

558.4 µs556.1 µs

cp_large_file[16]

src/uu/cp/benches/cp_bench.rs

362.5 µs361.7 µs

cp_recursive_deep_tree[(120, 4)]

src/uu/cp/benches/cp_bench.rs

13.6 ms13.6 ms

dd_copy_8k_blocks

src/uu/dd/benches/dd_bench.rs

1 ms1 ms

dd_copy_default

src/uu/dd/benches/dd_bench.rs

14 ms13.9 ms

b64_decode_synthetic

src/uu/base64/benches/base64_bench.rs

166.3 µs166.2 µs

mv_multiple_to_dir

src/uu/mv/benches/mv_bench.rs

12.9 ms12.9 ms

sort_numeric[500000]

src/uu/sort/benches/sort_bench.rs

1.2 s1.2 s

sort_german_c_locale

src/uu/sort/benches/sort_locale_c_bench.rs

37.9 ms37.9 ms

cp_recursive_balanced_tree[(5, 4, 10)]

src/uu/cp/benches/cp_bench.rs

72.3 ms72.3 ms

shuf_lines[100000]

src/uu/shuf/benches/shuf_bench.rs

31.6 ms31.6 ms

mv_single_file

src/uu/mv/benches/mv_bench.rs

135.6 ms135.5 ms

cksum_default

src/uu/cksum/benches/cksum_bench.rs

16.9 ms16.9 ms

sort_german_de_locale

src/uu/sort/benches/sort_locale_de_bench.rs

37.9 ms37.9 ms

ls_recursive_balanced_tree[(6, 4, 15)]

src/uu/ls/benches/ls_bench.rs

55.3 ms55.3 ms

tsort_complex_dag[50000]

src/uu/tsort/benches/tsort_bench.rs

84 ms84 ms

ls_recursive_long_all_deep_tree[(100, 4)]

src/uu/ls/benches/ls_bench.rs

3.3 ms3.3 ms

ls_recursive_mixed_tree

src/uu/ls/benches/ls_bench.rs

1.4 ms1.4 ms

mv_force_overwrite

src/uu/mv/benches/mv_bench.rs

144.3 ms144.3 ms

tsort_tree_dag[(10, 3)]

src/uu/tsort/benches/tsort_bench.rs

34.1 ms34.1 ms

factor_multiple_u64s[2]

src/uu/factor/benches/factor_bench.rs

212.3 ms212.3 ms

sort_case_insensitive[500000]

src/uu/sort/benches/sort_bench.rs

265.9 ms265.9 ms

ls_recursive_long_all_mixed_tree

src/uu/ls/benches/ls_bench.rs

2.9 ms2.9 ms

b64_decode_ignore_garbage_synthetic

src/uu/base64/benches/base64_bench.rs

163.2 µs163.2 µs

cksum_sha384

src/uu/cksum/benches/cksum_bench.rs

1.1 s1.1 s

split_number_chunks

src/uu/split/benches/split_bench.rs

294.3 µs294.3 µs

cksum_blake3

src/uu/cksum/benches/cksum_bench.rs

208.6 µs208.6 µs

sort_ascii_c_locale

src/uu/sort/benches/sort_locale_c_bench.rs

20.3 ms20.3 ms

cksum_sha512

src/uu/cksum/benches/cksum_bench.rs

1.1 s1.1 s

mv_directory

src/uu/mv/benches/mv_bench.rs

3.5 ms3.5 ms

b64_encode_synthetic

src/uu/base64/benches/base64_bench.rs

161.9 µs161.9 µs

uniq_case_insensitive[10000]

src/uu/uniq/benches/uniq_bench.rs

1.8 ms1.8 ms

sort_ascii_only[500000]

src/uu/sort/benches/sort_bench.rs

343 ms343 ms

ls_recursive_long_all_wide_tree[(15000, 1500)]

src/uu/ls/benches/ls_bench.rs

142.9 ms142.9 ms

split_lines

src/uu/split/benches/split_bench.rs

5.7 ms5.7 ms

cksum_crc

src/uu/cksum/benches/cksum_bench.rs

16.9 ms16.9 ms

sort_accented_data[500000]

src/uu/sort/benches/sort_bench.rs

351.8 ms351.8 ms

numfmt_round_modes[("up", 10000)]

src/uu/numfmt/benches/numfmt_bench.rs

34.3 ms34.3 ms

cut_fields_tab

src/uu/cut/benches/cut_bench.rs

34.1 ms34.1 ms

numfmt_from_si[10000]

src/uu/numfmt/benches/numfmt_bench.rs

32.7 ms32.7 ms

cksum_crc32b

src/uu/cksum/benches/cksum_bench.rs

13.3 ms13.3 ms

numfmt_round_modes[("down", 10000)]

src/uu/numfmt/benches/numfmt_bench.rs

34.3 ms34.3 ms

numfmt_round_modes[("towards-zero", 10000)]

src/uu/numfmt/benches/numfmt_bench.rs

34.3 ms34.3 ms

numfmt_to_si[10000]

src/uu/numfmt/benches/numfmt_bench.rs

33.8 ms33.8 ms

numfmt_to_iec[10000]

src/uu/numfmt/benches/numfmt_bench.rs

33.8 ms33.8 ms

numfmt_to_si_precision[10000]

src/uu/numfmt/benches/numfmt_bench.rs

35.3 ms35.3 ms

numfmt_padding[(10000, 50)]

src/uu/numfmt/benches/numfmt_bench.rs

48 ms48 ms

cksum_sysv

src/uu/cksum/benches/cksum_bench.rs

48.2 ms48.2 ms

numfmt_large_numbers_si[10000]

src/uu/numfmt/benches/numfmt_bench.rs

32.5 ms32.5 ms

expand_many_lines[100000]

src/uu/expand/benches/expand_bench.rs

148.6 ms148.6 ms

cksum_bsd

src/uu/cksum/benches/cksum_bench.rs

128.3 ms128.3 ms

cksum_blake2b

src/uu/cksum/benches/cksum_bench.rs

192.8 ms192.8 ms

cksum_md5

src/uu/cksum/benches/cksum_bench.rs

317.9 ms317.9 ms

unexpand_many_lines[100000]

src/uu/unexpand/benches/unexpand_bench.rs

252.3 ms252.3 ms

unexpand_large_file[10]

src/uu/unexpand/benches/unexpand_bench.rs

529 ms529 ms

cksum_sha256

src/uu/cksum/benches/cksum_bench.rs

1.7 s1.7 s

cksum_sm3

src/uu/cksum/benches/cksum_bench.rs

1.6 s1.6 s

cksum_sha224

src/uu/cksum/benches/cksum_bench.rs

1.7 s1.7 s

cksum_shake256

src/uu/cksum/benches/cksum_bench.rs

1.9 s1.9 s

cksum_shake128

src/uu/cksum/benches/cksum_bench.rs

1.5 s1.5 s

wc_words_synthetic[2000]

src/uu/wc/benches/wc_bench.rs

11.4 s11.4 s

cksum_sha2

src/uu/cksum/benches/cksum_bench.rs

1.7 s1.7 s

cksum_sha1

src/uu/cksum/benches/cksum_bench.rs

723.1 ms723.1 ms

cut_bytes

src/uu/cut/benches/cut_bench.rs

8.4 ms8.4 ms

wc_bytes_lines_synthetic[2000]

src/uu/wc/benches/wc_bench.rs

120.2 ms120.2 ms

sort_reverse_locale[500000]

src/uu/sort/benches/sort_bench.rs

350.9 ms350.9 ms

seq_formatted

src/uu/seq/benches/seq_bench.rs

96.1 ms96.1 ms

wc_default_large_line_count[100000]

src/uu/wc/benches/wc_bench.rs

50.4 ms50.4 ms

cksum_sha3

src/uu/cksum/benches/cksum_bench.rs

1.8 s1.8 s

wc_words_large_line_count[100000]

src/uu/wc/benches/wc_bench.rs

48 ms48 ms

nl_large_file[10]

src/uu/nl/benches/nl_bench.rs

57.1 ms57.1 ms

nl_many_lines[100000]

src/uu/nl/benches/nl_bench.rs

44.9 ms44.9 ms

expand_custom_tabstops[50000]

src/uu/expand/benches/expand_bench.rs

36.9 ms36.9 ms

seq_custom_separator

src/uu/seq/benches/seq_bench.rs

28.7 ms28.7 ms

seq_integers

src/uu/seq/benches/seq_bench.rs

26.1 ms26.1 ms

sort_mixed_data[500000]

src/uu/sort/benches/sort_bench.rs

317.3 ms317.3 ms

seq_with_step

src/uu/seq/benches/seq_bench.rs

13.3 ms13.3 ms

cut_fields_custom_delim

src/uu/cut/benches/cut_bench.rs

40.8 ms40.8 ms

rm_recursive_tree

src/uu/rm/benches/rm_bench.rs

11.7 ms11.7 ms

sort_ascii_utf8_locale

src/uu/sort/benches/sort_locale_utf8_bench.rs

20.1 ms20.1 ms

sort_numeric_utf8_locale

src/uu/sort/benches/sort_locale_utf8_bench.rs

22.8 ms22.8 ms

uniq_heavy_duplicates[10000]

src/uu/uniq/benches/uniq_bench.rs

2 ms2 ms

uniq_with_count[10000]

src/uu/uniq/benches/uniq_bench.rs

1.9 ms1.9 ms

rm_single_file

src/uu/rm/benches/rm_bench.rs

119.3 ms119.3 ms

sort_long_line[160000]

src/uu/sort/benches/sort_bench.rs

1.7 ms1.7 ms

seq_large_integers

src/uu/seq/benches/seq_bench.rs

2.2 ms2.2 ms

wc_lines_variable_length[(50, 500)]

src/uu/wc/benches/wc_bench.rs

3.4 ms3.4 ms

sort_key_field[500000]

src/uu/sort/benches/sort_bench.rs

690.6 ms690.6 ms

cut_characters

src/uu/cut/benches/cut_bench.rs

7.4 ms7.4 ms

wc_lines_extreme_line_lengths[(100000, 200)]

src/uu/wc/benches/wc_bench.rs

1.6 ms1.6 ms

rm_force_files

src/uu/rm/benches/rm_bench.rs

2 ms2 ms

wc_lines_large_line_count[500000]

src/uu/wc/benches/wc_bench.rs

2.9 ms2.9 ms

rm_multiple_files

src/uu/rm/benches/rm_bench.rs

2.2 ms2.2 ms

cp_recursive_wide_tree[(6000, 800)]

src/uu/cp/benches/cp_bench.rs

189.4 ms189.4 ms

ls_recursive_deep_tree[(200, 2)]

src/uu/ls/benches/ls_bench.rs

2.2 ms2.2 ms

ls_recursive_long_all_balanced_tree[(6, 4, 15)]

src/uu/ls/benches/ls_bench.rs

134.4 ms134.4 ms

shuf_input_range[1000000]

src/uu/shuf/benches/shuf_bench.rs

229.4 ms229.4 ms

wc_chars_large_line_count[100000]

src/uu/wc/benches/wc_bench.rs

1 ms1 ms

sort_unique_locale[500000]

src/uu/sort/benches/sort_bench.rs

483.2 ms483.3 ms

tsort_linear_chain[1000000]

src/uu/tsort/benches/tsort_bench.rs

1.5 s1.5 s

split_bytes

src/uu/split/benches/split_bench.rs

508.5 µs508.6 µs

split_numeric_suffix

src/uu/split/benches/split_bench.rs

5.9 ms5.9 ms

tsort_wide_dag[100000]

src/uu/tsort/benches/tsort_bench.rs

133.4 ms133.4 ms

shuf_repeat_sampling[50000]

src/uu/shuf/benches/shuf_bench.rs

5.1 ms5.1 ms

sort_mixed_utf8_locale

src/uu/sort/benches/sort_locale_utf8_bench.rs

37.4 ms37.4 ms

ls_recursive_wide_tree[(10000, 1000)]

src/uu/ls/benches/ls_bench.rs

51.5 ms51.5 ms

sort_mixed_c_locale

src/uu/sort/benches/sort_locale_c_bench.rs

37.2 ms37.2 ms

cp_archive_balanced_tree[(5, 4, 10)]

src/uu/cp/benches/cp_bench.rs

77.9 ms77.9 ms

wc_bytes_synthetic[500]

src/uu/wc/benches/wc_bench.rs

185.6 µs185.7 µs

du_wide_tree[(5000, 500)]

src/uu/du/benches/du_bench.rs

11.2 ms11.2 ms

sort_reverse_utf8_locale

src/uu/sort/benches/sort_locale_utf8_bench.rs

37.6 ms37.7 ms

sort_dictionary_order[500000]

src/uu/sort/benches/sort_bench.rs

1.1 s1.1 s

sort_case_sensitive[500000]

src/uu/sort/benches/sort_bench.rs

163 ms163.1 ms

cp_preserve_metadata[(5, 4, 10)]

src/uu/cp/benches/cp_bench.rs

74.9 ms75 ms

sort_unique_utf8_locale

src/uu/sort/benches/sort_locale_utf8_bench.rs

37.7 ms37.7 ms

dd_copy_separate_blocks

src/uu/dd/benches/dd_bench.rs

44 ms44.1 ms

dd_copy_with_seek

src/uu/dd/benches/dd_bench.rs

2.3 ms2.3 ms

du_all_wide_tree[(5000, 500)]

src/uu/du/benches/du_bench.rs

18.1 ms18.1 ms

cksum_raw_output

src/uu/cksum/benches/cksum_bench.rs

16.9 ms17 ms

dd_copy_4k_blocks

src/uu/dd/benches/dd_bench.rs

1.3 ms1.3 ms

du_summarize_balanced_tree[(5, 4, 10)]

src/uu/du/benches/du_bench.rs

8.5 ms8.5 ms

dd_copy_64k_blocks

src/uu/dd/benches/dd_bench.rs

601.5 µs603.5 µs

dd_copy_with_skip

src/uu/dd/benches/dd_bench.rs

2.2 ms2.3 ms

fold_custom_width[50000]

src/uu/fold/benches/fold_bench.rs

-3%

33 ms34 ms

Commits

Click on a commit to change the comparison range

Base

main

f60072d

×23

tests: add regression test for char device input

cb20a5f

1 day ago

by SaathwikDasari

fix: use buffered read to prevent hanging on infinite streams like /dev/zero also fixed failure testcases after cargo fmt

bf64d00

1 day ago

by SaathwikDasari

+7.84%

fixed the performance regression hopefully and cargo fmt

12f900d

1 day ago

by SaathwikDasari

fixed the code quality failure

9a67924

1 day ago

by SaathwikDasari

Home Terms Privacy Docs