ChrisDryden:fix-read-errors-simple - Branch - uutils/coreutils

cat,comm,expand,unexpand: remove is_dir() pre-checks to let read() report errors

#10891

Comparing

ChrisDryden:fix-read-errors-simple

(

7509656

) with

main

(

8e59663

)

-5%

Regression: 2

Untouched: 282

Skipped: 38

Benchmarks

322 total

unexpand_large_file[10]

src/uu/unexpand/benches/unexpand_bench.rs

-5%

397.7 ms417.6 ms

unexpand_many_lines[100000]

src/uu/unexpand/benches/unexpand_bench.rs

-5%

189.7 ms199.2 ms

dd_copy_partial

src/uu/dd/benches/dd_bench.rs

+1%

548.7 µs542.3 µs

cp_large_file[16]

src/uu/cp/benches/cp_bench.rs

391.8 µs390.6 µs

du_summarize_balanced_tree[(5, 4, 10)]

src/uu/du/benches/du_bench.rs

7 ms7 ms

du_deep_tree[(100, 3)]

src/uu/du/benches/du_bench.rs

1.2 ms1.2 ms

cksum_crc

src/uu/cksum/benches/cksum_bench.rs

16.7 ms16.7 ms

sort_numeric[500000]

src/uu/sort/benches/sort_bench.rs

1.1 s1 s

sort_reverse_locale[500000]

src/uu/sort/benches/sort_bench.rs

337.4 ms337 ms

dd_copy_4k_blocks

src/uu/dd/benches/dd_bench.rs

1.3 ms1.3 ms

sort_long_line[160000]

src/uu/sort/benches/sort_bench.rs

1.4 ms1.4 ms

ls_recursive_long_all_deep_tree[(100, 4)]

src/uu/ls/benches/ls_bench.rs

3.2 ms3.2 ms

cp_recursive_wide_tree[(6000, 800)]

src/uu/cp/benches/cp_bench.rs

188.6 ms188.5 ms

cksum_blake3

src/uu/cksum/benches/cksum_bench.rs

216.9 µs216.8 µs

shuf_lines[100000]

src/uu/shuf/benches/shuf_bench.rs

27.6 ms27.6 ms

ls_recursive_long_all_mixed_tree

src/uu/ls/benches/ls_bench.rs

2.8 ms2.8 ms

ls_recursive_long_all_wide_tree[(15000, 1500)]

src/uu/ls/benches/ls_bench.rs

140.5 ms140.5 ms

sort_mixed_c_locale

src/uu/sort/benches/sort_locale_c_bench.rs

36.7 ms36.7 ms

dd_copy_with_seek

src/uu/dd/benches/dd_bench.rs

2.3 ms2.3 ms

sort_reverse_utf8_locale

src/uu/sort/benches/sort_locale_utf8_bench.rs

36.6 ms36.6 ms

shuf_repeat_sampling[50000]

src/uu/shuf/benches/shuf_bench.rs

4.7 ms4.7 ms

complex_relative_date

src/uu/date/benches/date_bench.rs

245.1 µs245.1 µs

dd_copy_separate_blocks

src/uu/dd/benches/dd_bench.rs

43.9 ms43.9 ms

single_date_now

src/uu/date/benches/date_bench.rs

192.4 µs192.4 µs

ls_recursive_deep_tree[(200, 2)]

src/uu/ls/benches/ls_bench.rs

2.1 ms2.1 ms

Commits

Click on a commit to change the comparison range

Base

main

8e59663

-4.75%

cat,comm,expand,unexpand: remove is_dir() pre-checks to let read() report errors

7509656

1 day ago

by ChrisDryden

Home Terms Privacy Docs