Avatar for the tlambert03 user
tlambert03
ome-types
BlogDocsChangelog

Fix pt unit being misinterpreted as pints

#271Merged
Comparing
jmuhlich:units-pt-is-point
(
c1245f3
) with
main
(
e4bda9e
)
CodSpeed Performance Gauge
+12%
Improvements
1
Regressions
0
Untouched
8
New
0
Dropped
0
Ignored
0

Benchmarks

Improved

test_time_from_xml[large]
tests/test_codspeed.py::test_time_from_xml[large]
CodSpeed Performance Gauge
+12%
3.3 s
3 s

Passed

test_time_from_xml[small]
tests/test_codspeed.py::test_time_from_xml[small]
CodSpeed Performance Gauge
+6%
36.8 ms
34.7 ms
test_time_from_dict_to_ome[small]
tests/test_codspeed.py::test_time_from_dict_to_ome[small]
CodSpeed Performance Gauge
+6%
2.2 ms
2.1 ms
test_time_to_xml[large]
tests/test_codspeed.py::test_time_to_xml[large]
CodSpeed Performance Gauge
+3%
3.4 s
3.3 s
test_time_from_xml[med]
tests/test_codspeed.py::test_time_from_xml[med]
CodSpeed Performance Gauge
+2%
68.2 ms
66.6 ms
test_time_to_xml[med]
tests/test_codspeed.py::test_time_to_xml[med]
CodSpeed Performance Gauge
+2%
64 ms
62.7 ms
test_time_to_xml[small]
tests/test_codspeed.py::test_time_to_xml[small]
CodSpeed Performance Gauge
+2%
12.8 ms
12.5 ms
test_time_from_dict_to_ome[med]
tests/test_codspeed.py::test_time_from_dict_to_ome[med]
CodSpeed Performance Gauge
+2%
25.1 ms
24.6 ms
test_time_from_tiff
tests/test_codspeed.py::test_time_from_tiff
CodSpeed Performance Gauge
0%
10.7 ms
10.6 ms

Commits

Click on a commit to change the comparison range
Base
main
e4bda9e
+12%
fix: prevent pt unit being misinterpreted as pints The OME schema defines "pt" as points but the pint default configuration makes it an alias for pints. This overrides the pt alias in our unit registry and suppresses the warning that pint emits as a result.
c1245f3
20 days ago
by jmuhlich
Home Terms PrivacyDocs