BlogDocs

Support localhost in Pay domains(#3569)

Merged
Merging
pay-domain-support-localhost
(
e5f772d
) into
main
(
373ce19
)
-1%
IMPROVEMENTS
0
REGRESSIONS
0
UNTOUCHED
9
NEW
0
DROPPED
0
IGNORED
0

Benchmarks

Passed

encode tx (human readable)
packages/thirdweb/src/transaction/actions/encode.bench.ts::encode tx (human readable)
+2%
406.1 µs
399.8 µs
encode tx (contract abi)
packages/thirdweb/src/transaction/actions/encode.bench.ts::encode tx (contract abi)
0%
408.6 µs
407.1 µs
encode tx (prepared method)
packages/thirdweb/src/transaction/actions/encode.bench.ts::encode tx (prepared method)
0%
344.1 µs
343.2 µs
encode tx (json abi)
packages/thirdweb/src/transaction/actions/encode.bench.ts::encode tx (json abi)
0%
190.5 µs
190.4 µs
units:toTokens(12345678901234567890n, 18)
packages/thirdweb/src/utils/units.bench.ts::units:toTokens(12345678901234567890n, 18)
0%
25.2 µs
25.2 µs
units:toUnits("40", 18)
packages/thirdweb/src/utils/units.bench.ts::units:toUnits("40", 18)
0%
33.6 µs
33.6 µs
units:toUnits("40.0", 18)
packages/thirdweb/src/utils/units.bench.ts::units:toUnits("40.0", 18)
0%
34.1 µs
34.2 µs
units:toTokens(40000000000000000000n, 18)
packages/thirdweb/src/utils/units.bench.ts::units:toTokens(40000000000000000000n, 18)
-1%
184.3 µs
185.6 µs
keccakId
packages/thirdweb/src/utils/any-evm/keccak-id.bench.ts::keccakId
-8%
1.3 ms
1.4 ms

Commits

Click on a commit to change the comparison range
base
main
373ce19
-1%
Support localhost in Pay domains (#3569) ## Problem solved Use "http://" if localhost domain used for thirdweb Pay <!-- start pr-codex --> --- ## PR-Codex overview This PR adds support for using localhost as a domain override option for the Pay service. ### Detailed summary - Added support for localhost as a domain override option for the Pay service in `definitions.ts` - Updated all endpoint URLs to use the `getPayBaseUrl()` function instead of directly fetching the domain from `getThirdwebDomains().pay` > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
e5f772d
3 months ago
by edwardysun
ResourcesHomePricingDocsBlogGitHubChangelog
Getting StartedSample repositoryExplore repositoriesSupport
AboutCareersTwitterDiscordContact UsTerms of ServicePrivacy Policy
Copyright © 2024 CodSpeed Technology SAS. All rights reserved.