thirdweb-dev
js
BlogDocsChangelog

fix: sign typed data using inAppWalelt with salt in domain

#3266Merged
Comparing
joaquim/fix_signtypeddata_inapp
(
c14bdfd
) with
main
(
f2004b5
)
CodSpeed Performance Gauge
+1%
Untouched
9

Benchmarks

Passed

keccakId
packages/thirdweb/src/utils/any-evm/keccak-id.bench.ts
CodSpeed Performance Gauge
+7%
1.5 ms1.4 ms
encode tx (prepared method)
packages/thirdweb/src/transaction/actions/encode.bench.ts
CodSpeed Performance Gauge
+2%
344.7 µs337.5 µs
encode tx (contract abi)
packages/thirdweb/src/transaction/actions/encode.bench.ts
CodSpeed Performance Gauge
+1%
409.3 µs405.9 µs
encode tx (json abi)
packages/thirdweb/src/transaction/actions/encode.bench.ts
CodSpeed Performance Gauge
0%
192.3 µs191.6 µs
encode tx (human readable)
packages/thirdweb/src/transaction/actions/encode.bench.ts
CodSpeed Performance Gauge
0%
377.7 µs377.2 µs
units:toTokens(12345678901234567890n, 18)
packages/thirdweb/src/utils/units.bench.ts
CodSpeed Performance Gauge
0%
25.3 µs25.4 µs
units:toUnits("40.0", 18)
packages/thirdweb/src/utils/units.bench.ts
CodSpeed Performance Gauge
0%
37.4 µs37.5 µs
units:toUnits("40", 18)
packages/thirdweb/src/utils/units.bench.ts
CodSpeed Performance Gauge
-1%
33.7 µs33.8 µs
units:toTokens(40000000000000000000n, 18)
packages/thirdweb/src/utils/units.bench.ts
CodSpeed Performance Gauge
-4%
184.8 µs192.7 µs

Commits

Click on a commit to change the comparison range
Base
main
f2004b5
-0.57%
changeset
1562d7f
1 year ago
by joaquim-verges
+1.15%
Merge branch 'main' into joaquim/fix_signtypeddata_inapp
c14bdfd
1 year ago
by joaquim-verges
© 2025 CodSpeed Technology
Home Terms Privacy Docs