BlogDocs

fix(ts): properly disconnect wallet connect(#3539)

Merged
Merging
fix/wallet-connect-disconnection
(
85f2f6d
) into
main
(
6704fa8
)
0%
IMPROVEMENTS
0
REGRESSIONS
0
UNTOUCHED
9
NEW
0
DROPPED
0
IGNORED
0

Benchmarks

Passed

encode tx (contract abi)
packages/thirdweb/src/transaction/actions/encode.bench.ts::encode tx (contract abi)
+1%
412.4 µs
408.9 µs
units:toTokens(40000000000000000000n, 18)
packages/thirdweb/src/utils/units.bench.ts::units:toTokens(40000000000000000000n, 18)
0%
184.7 µs
184.3 µs
units:toUnits("40", 18)
packages/thirdweb/src/utils/units.bench.ts::units:toUnits("40", 18)
0%
33.6 µs
33.6 µs
keccakId
packages/thirdweb/src/utils/any-evm/keccak-id.bench.ts::keccakId
0%
1.3 ms
1.3 ms
units:toUnits("40.0", 18)
packages/thirdweb/src/utils/units.bench.ts::units:toUnits("40.0", 18)
0%
34.2 µs
34.2 µs
encode tx (human readable)
packages/thirdweb/src/transaction/actions/encode.bench.ts::encode tx (human readable)
0%
378.2 µs
378.8 µs
units:toTokens(12345678901234567890n, 18)
packages/thirdweb/src/utils/units.bench.ts::units:toTokens(12345678901234567890n, 18)
0%
25.1 µs
25.2 µs
encode tx (prepared method)
packages/thirdweb/src/transaction/actions/encode.bench.ts::encode tx (prepared method)
0%
338.9 µs
339.8 µs
encode tx (json abi)
packages/thirdweb/src/transaction/actions/encode.bench.ts::encode tx (json abi)
-1%
190.7 µs
192.1 µs

Commits

Click on a commit to change the comparison range
base
main
6704fa8
0%
fix(ts): properly disconnect wallet connect (#3539) <!-- start pr-codex --> ## PR-Codex overview This PR focuses on fixing WalletConnect client disconnections and improving error handling. ### Detailed summary - Added a delay in testing for WalletConnect client disconnections - Updated the `onDisconnect` function in `WalletConnectReceiverScreen.tsx` to handle loading state and query invalidation - Improved error handling in `wallet-connect/receiver/index.ts` by catching errors during disconnect - Added a function to remove sessions in `disconnectWalletConnectSession` - Updated `disconnectWalletConnectSession` to handle errors gracefully > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
85f2f6d
3 months ago
by gregfromstl
ResourcesHomePricingDocsBlogGitHubChangelog
Getting StartedSample repositoryExplore repositoriesSupport
AboutCareersTwitterDiscordContact UsTerms of ServicePrivacy Policy
Copyright © 2024 CodSpeed Technology SAS. All rights reserved.