BlogDocs

fix(utils): correct filter condition for recommended wallets(#3558)

Merged
Merging
fix/recommended-wallet-ordering
(
54c1789
) into
main
(
cbb0bc2
)
0%
IMPROVEMENTS
0
REGRESSIONS
0
UNTOUCHED
9
NEW
0
DROPPED
0
IGNORED
0

Benchmarks

Passed

units:toTokens(40000000000000000000n, 18)
packages/thirdweb/src/utils/units.bench.ts::units:toTokens(40000000000000000000n, 18)
+3%
190.1 µs
185.1 µs
encode tx (prepared method)
packages/thirdweb/src/transaction/actions/encode.bench.ts::encode tx (prepared method)
+2%
344.2 µs
339 µs
units:toUnits("40.0", 18)
packages/thirdweb/src/utils/units.bench.ts::units:toUnits("40.0", 18)
0%
34.2 µs
34.1 µs
units:toUnits("40", 18)
packages/thirdweb/src/utils/units.bench.ts::units:toUnits("40", 18)
0%
33.7 µs
33.6 µs
encode tx (json abi)
packages/thirdweb/src/transaction/actions/encode.bench.ts::encode tx (json abi)
0%
191.3 µs
190.9 µs
keccakId
packages/thirdweb/src/utils/any-evm/keccak-id.bench.ts::keccakId
0%
1.3 ms
1.3 ms
units:toTokens(12345678901234567890n, 18)
packages/thirdweb/src/utils/units.bench.ts::units:toTokens(12345678901234567890n, 18)
0%
25.1 µs
25.2 µs
encode tx (contract abi)
packages/thirdweb/src/transaction/actions/encode.bench.ts::encode tx (contract abi)
0%
402.1 µs
404 µs
encode tx (human readable)
packages/thirdweb/src/transaction/actions/encode.bench.ts::encode tx (human readable)
-1%
400.6 µs
406.4 µs

Commits

Click on a commit to change the comparison range
base
main
cbb0bc2
0%
fix(utils): correct filter condition for recommended wallets (#3558) ## Problem solved Recommended wallets were being compared for object equality when sorting, which caused confusion when using inline `createWallet` to set the recommended wallets. This PR updates sorting to compare the recommended wallets by ID (installed providers already work this way)
54c1789
3 months ago
by gregfromstl
ResourcesHomePricingDocsBlogGitHubChangelog
Getting StartedSample repositoryExplore repositoriesSupport
AboutCareersTwitterDiscordContact UsTerms of ServicePrivacy Policy
Copyright © 2024 CodSpeed Technology SAS. All rights reserved.