BlogDocs

fix(ts): prepare incoming walletconnect transactions(#3541)

Merged
Merging
fix/prepare-wc-transactions
(
27daf22
) into
main
(
7e24260
)
+1%
IMPROVEMENTS
0
REGRESSIONS
0
UNTOUCHED
9
NEW
0
DROPPED
0
IGNORED
0

Benchmarks

Passed

encode tx (prepared method)
packages/thirdweb/src/transaction/actions/encode.bench.ts::encode tx (prepared method)
+3%
348.9 µs
338.9 µs
encode tx (human readable)
packages/thirdweb/src/transaction/actions/encode.bench.ts::encode tx (human readable)
+2%
387.2 µs
378.5 µs
encode tx (contract abi)
packages/thirdweb/src/transaction/actions/encode.bench.ts::encode tx (contract abi)
+1%
416.4 µs
411.2 µs
units:toTokens(12345678901234567890n, 18)
packages/thirdweb/src/utils/units.bench.ts::units:toTokens(12345678901234567890n, 18)
0%
25.2 µs
25.1 µs
keccakId
packages/thirdweb/src/utils/any-evm/keccak-id.bench.ts::keccakId
0%
1.3 ms
1.3 ms
encode tx (json abi)
packages/thirdweb/src/transaction/actions/encode.bench.ts::encode tx (json abi)
0%
191.5 µs
191.8 µs
units:toTokens(40000000000000000000n, 18)
packages/thirdweb/src/utils/units.bench.ts::units:toTokens(40000000000000000000n, 18)
0%
184.8 µs
185.1 µs
units:toUnits("40.0", 18)
packages/thirdweb/src/utils/units.bench.ts::units:toUnits("40.0", 18)
-1%
34.2 µs
34.4 µs
units:toUnits("40", 18)
packages/thirdweb/src/utils/units.bench.ts::units:toUnits("40", 18)
-1%
33.7 µs
33.9 µs

Commits

Click on a commit to change the comparison range
base
main
7e24260
+1%
fix(ts): prepare incoming walletconnect transactions (#3541) Adding thirdwebClient to createWalletConnectClient and fulfillRequest functions to ensure proper transaction execution through WalletConnect. This update includes a refactor of handleSendTransactionRequest to utilize the new client and various other related changes for consistency. --- <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on fixing in-app wallet transaction execution via WalletConnect by introducing `thirdwebClient` and updating related functions. ### Detailed summary - Introduced `thirdwebClient` to handle WalletConnect transactions - Updated functions to include `thirdwebClient` parameter - Added tests using `TEST_CLIENT` for `thirdwebClient` integration > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
27daf22
3 months ago
by gregfromstl
ResourcesHomePricingDocsBlogGitHubChangelog
Getting StartedSample repositoryExplore repositoriesSupport
AboutCareersTwitterDiscordContact UsTerms of ServicePrivacy Policy
Copyright © 2024 CodSpeed Technology SAS. All rights reserved.