BlogDocs

fix(wallet): handle errors when connecting with open access ecosystem(#3545)

Merged
Merging
fix/in-app-wallet-permissions
(
7e24260
) into
main
(
85f2f6d
)
0%
IMPROVEMENTS
0
REGRESSIONS
0
UNTOUCHED
9
NEW
0
DROPPED
0
IGNORED
0

Benchmarks

Passed

encode tx (prepared method)
packages/thirdweb/src/transaction/actions/encode.bench.ts::encode tx (prepared method)
+1%
343.6 µs
339.9 µs
encode tx (contract abi)
packages/thirdweb/src/transaction/actions/encode.bench.ts::encode tx (contract abi)
0%
410.5 µs
409 µs
units:toTokens(40000000000000000000n, 18)
packages/thirdweb/src/utils/units.bench.ts::units:toTokens(40000000000000000000n, 18)
0%
184.5 µs
184 µs
keccakId
packages/thirdweb/src/utils/any-evm/keccak-id.bench.ts::keccakId
0%
1.3 ms
1.3 ms
units:toTokens(12345678901234567890n, 18)
packages/thirdweb/src/utils/units.bench.ts::units:toTokens(12345678901234567890n, 18)
0%
25.1 µs
25.1 µs
units:toUnits("40.0", 18)
packages/thirdweb/src/utils/units.bench.ts::units:toUnits("40.0", 18)
0%
34.1 µs
34.2 µs
units:toUnits("40", 18)
packages/thirdweb/src/utils/units.bench.ts::units:toUnits("40", 18)
0%
33.6 µs
33.7 µs
encode tx (human readable)
packages/thirdweb/src/transaction/actions/encode.bench.ts::encode tx (human readable)
-1%
376.9 µs
378.8 µs
encode tx (json abi)
packages/thirdweb/src/transaction/actions/encode.bench.ts::encode tx (json abi)
-1%
190.9 µs
192.1 µs

Commits

Click on a commit to change the comparison range
base
main
85f2f6d
0%
fix(wallet): handle errors when connecting with open access ecosystem (#3545) <!-- start pr-codex --> ## PR-Codex overview This PR focuses on fixing errors related to connecting with an open access ecosystem by updating permissions logic in the `in-app-account.ts` file. ### Detailed summary - Updated permissions logic to include partnerId check for ecosystem connectivity. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
7e24260
3 months ago
by gregfromstl
ResourcesHomePricingDocsBlogGitHubChangelog