BlogDocs

fix(react-native): ensure onClose is called on successful wallet connection in ConnectModal(#3573)

Merged
Merging
fix/connect-modal-on-connect-callback
(
9516259
) into
main
(
f526d73
)
0%
IMPROVEMENTS
0
REGRESSIONS
0
UNTOUCHED
9
NEW
0
DROPPED
0
IGNORED
0

Benchmarks

Passed

encode tx (prepared method)
packages/thirdweb/src/transaction/actions/encode.bench.ts::encode tx (prepared method)
+2%
345.4 µs
340 µs
encode tx (human readable)
packages/thirdweb/src/transaction/actions/encode.bench.ts::encode tx (human readable)
0%
407.8 µs
406.6 µs
keccakId
packages/thirdweb/src/utils/any-evm/keccak-id.bench.ts::keccakId
0%
1.3 ms
1.3 ms
units:toUnits("40.0", 18)
packages/thirdweb/src/utils/units.bench.ts::units:toUnits("40.0", 18)
0%
34.2 µs
34.2 µs
units:toUnits("40", 18)
packages/thirdweb/src/utils/units.bench.ts::units:toUnits("40", 18)
0%
33.6 µs
33.7 µs
encode tx (json abi)
packages/thirdweb/src/transaction/actions/encode.bench.ts::encode tx (json abi)
0%
190.9 µs
191.4 µs
units:toTokens(40000000000000000000n, 18)
packages/thirdweb/src/utils/units.bench.ts::units:toTokens(40000000000000000000n, 18)
-1%
183.3 µs
184.4 µs
units:toTokens(12345678901234567890n, 18)
packages/thirdweb/src/utils/units.bench.ts::units:toTokens(12345678901234567890n, 18)
-1%
25 µs
25.2 µs
encode tx (contract abi)
packages/thirdweb/src/transaction/actions/encode.bench.ts::encode tx (contract abi)
-1%
408.4 µs
412.7 µs

Commits

Click on a commit to change the comparison range
base
main
f526d73
0%
fix(react-native): ensure onClose is called on successful wallet connection in ConnectModal (#3573)
9516259
3 months ago
by joaquim-verges
ResourcesHomePricingDocsBlogGitHubChangelog
Getting StartedSample repositoryExplore repositoriesSupport
AboutCareersTwitterDiscordContact UsTerms of ServicePrivacy Policy
Copyright © 2024 CodSpeed Technology SAS. All rights reserved.