Comparing
fix-thirdweb-update-readcontract-options
(6cc3038
) withmain
(db2cadf
)0%
- Improvements
- 0
- Regressions
- 0
- Untouched
- 9
- New
- 0
- Dropped
- 0
- Ignored
- 0
Benchmarks
Passed
units:toTokens(40000000000000000000n, 18)
packages/thirdweb/src/utils/units.bench.ts::units:toTokens(40000000000000000000n, 18)0%
185.3 µs
184.9 µs
units:toUnits("40.0", 18)
packages/thirdweb/src/utils/units.bench.ts::units:toUnits("40.0", 18)0%
34.6 µs
34.6 µs
units:toUnits("40", 18)
packages/thirdweb/src/utils/units.bench.ts::units:toUnits("40", 18)0%
34 µs
34 µs
keccakId
packages/thirdweb/src/utils/any-evm/keccak-id.bench.ts::keccakId0%
1.3 ms
1.3 ms
units:toTokens(12345678901234567890n, 18)
packages/thirdweb/src/utils/units.bench.ts::units:toTokens(12345678901234567890n, 18)0%
25.4 µs
25.4 µs
encode tx (json abi)
packages/thirdweb/src/transaction/actions/encode.bench.ts::encode tx (json abi)0%
191.5 µs
191.9 µs
encode tx (contract abi)
packages/thirdweb/src/transaction/actions/encode.bench.ts::encode tx (contract abi)-1%
403.2 µs
406 µs
encode tx (prepared method)
packages/thirdweb/src/transaction/actions/encode.bench.ts::encode tx (prepared method)-1%
337.2 µs
340.6 µs
encode tx (human readable)
packages/thirdweb/src/transaction/actions/encode.bench.ts::encode tx (human readable)-2%
399.8 µs
408 µs
Commits
Click on a commit to change the comparison rangeBase
main
db2cadf
0%
fix(thirdweb): add optional 'from' in readContract method (#3735)
Fixes #3683
<!-- start pr-codex -->
---
## PR-Codex overview
The focus of this PR is to add an optional 'from' parameter in the `readContract()` function and update default max block wait times to 100 in various files.
### Detailed summary
- Added optional 'from' parameter in `readContract()`
- Updated default max block wait times to 10 in specific files
- Increased default max block wait times to 100 in other files
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
6cc3038
1 year ago
by joaquim-verges