kdy1/port-private-in-object - Branch - swc-project/swc

feat(es/transformer): Merge `private_properties_in_object`

#11378Merged

Comparing

kdy1/port-private-in-object

(

801967d

) with

main

(

686d154

)

Untouched: 138

Ignored: 1

No successful run was found on main ( 27329c1) during the generation of this report, so 686d154 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

Benchmarks

Passed

es/preset-env/usage/builtin_type

crates/swc_ecma_preset_env/benches/polyfills.rs::benches::bench_cases

+1%

234.2 µs232.2 µs

es/codegen/colors

crates/swc_ecma_codegen/benches/bench.rs::benches::bench_cases

+1%

68.7 µs68.4 µs

es/minifier/libs/d3

crates/swc_ecma_minifier/benches/full.rs::bench_all::bench_libs::es/minifier/libs

399.8 ms398 ms

es/lints/libs/vue

crates/swc_ecma_lints/benches/all.rs::files::bench_files::es/lints/libs

8.2 ms8.2 ms

es/minifier/libs/terser

crates/swc_ecma_minifier/benches/full.rs::bench_all::bench_libs::es/minifier/libs

352.8 ms352 ms

es2015_destructuring

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

347.3 µs346.5 µs

es/parser/cal-com

crates/swc_ecma_parser/benches/parser.rs::benches::bench_files

55.8 ms55.7 ms

es/parser/typescript

crates/swc_ecma_parser/benches/parser.rs::benches::bench_files

369.6 ms368.9 ms

es/codegen/with-parser/colors

crates/swc_ecma_codegen/benches/with_parse.rs::benches::bench_cases

155.4 µs155.1 µs

es/hygiene/typescript

crates/swc_ecma_transforms_base/benches/base.rs::benches::bench_cases

423.5 ms422.8 ms

es/parser/underscore

crates/swc_ecma_parser/benches/parser.rs::benches::bench_files

2.3 ms2.3 ms

es/parser/jquery

crates/swc_ecma_parser/benches/parser.rs::benches::bench_files

13.7 ms13.7 ms

es/lints/libs/three

crates/swc_ecma_lints/benches/all.rs::files::bench_files::es/lints/libs

49.3 ms49.3 ms

es/parser/jquery mobile

crates/swc_ecma_parser/benches/parser.rs::benches::bench_files

21.3 ms21.3 ms

es/parser/mootools

crates/swc_ecma_parser/benches/parser.rs::benches::bench_files

10.8 ms10.8 ms

es/parser/backbone

crates/swc_ecma_parser/benches/parser.rs::benches::bench_files

2.7 ms2.7 ms

es/parser/angular

crates/swc_ecma_parser/benches/parser.rs::benches::bench_files

16.8 ms16.8 ms

es/parser/yui

crates/swc_ecma_parser/benches/parser.rs::benches::bench_files

10.5 ms10.5 ms

es/minifier/libs/three

crates/swc_ecma_minifier/benches/full.rs::bench_all::bench_libs::es/minifier/libs

646.9 ms646 ms

es/lexer/colors

crates/swc_ecma_parser/benches/lexer.rs::benches::bench_files

23.9 µs23.9 µs

es/parser/three

crates/swc_ecma_parser/benches/parser.rs::benches::bench_files

65.7 ms65.6 ms

es/codegen/large

crates/swc_ecma_codegen/benches/bench.rs::benches::bench_cases

640.1 µs639.5 µs

es/minifier/libs/typescript

crates/swc_ecma_minifier/benches/full.rs::bench_all::bench_libs::es/minifier/libs

3.8 s3.8 s

es2015_fn_name

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

281.4 µs281.2 µs

es2015_typeof_symbol

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

277.6 µs277.4 µs

es/lints/libs/react

crates/swc_ecma_lints/benches/all.rs::files::bench_files::es/lints/libs

1.3 ms1.3 ms

es/minifier/libs/vue

crates/swc_ecma_minifier/benches/full.rs::bench_all::bench_libs::es/minifier/libs

143.1 ms143 ms

es/fixer/typescript

crates/swc_ecma_transforms_base/benches/base.rs::benches::bench_cases

201.9 ms201.8 ms

html/parser/parser_document_fragment/css_2021_spec

crates/swc_html_parser/benches/parser.rs::benches::bench_files

70.6 ms70.6 ms

es2015_parameters

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

333.1 µs332.9 µs

es/transform/baseline/base

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::baseline_group

259.8 µs259.7 µs

github

crates/swc_html_minifier/benches/full.rs::files_document::bench_files_document::html/minify/document

42 ms42 ms

es2015_instanceof

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

279.3 µs279.2 µs

github

crates/swc_html_minifier/benches/full.rs::files_document_fragment::bench_files_document_fragment::html/minify/document_fragment

41.3 ms41.3 ms

es/transform/baseline/common_reserved_word

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::baseline_group

278.7 µs278.6 µs

es/minifier/libs/victory

crates/swc_ecma_minifier/benches/full.rs::bench_all::bench_libs::es/minifier/libs

850.9 ms850.6 ms

stackoverflow

crates/swc_html_minifier/benches/full.rs::files_document_fragment::bench_files_document_fragment::html/minify/document_fragment

37 ms37 ms

html/parser/parser_document_fragment/github_com_17_05_2022

crates/swc_html_parser/benches/parser.rs::benches::bench_files

22.1 ms22.1 ms

es/resolver/typescript

crates/swc_ecma_transforms_base/benches/base.rs::benches::bench_cases

243.5 ms243.4 ms

es2015_sticky_regex

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

275.9 µs275.8 µs

html/parser/parser_document/css_2021_spec

crates/swc_html_parser/benches/parser.rs::benches::bench_files

71 ms71 ms

css/visitor/compare/visit_mut_span

crates/swc_css_parser/benches/compare.rs::benches::bench_cases

5.1 ms5.1 ms

es/lexer/yui

crates/swc_ecma_parser/benches/lexer.rs::benches::bench_files

3.4 ms3.4 ms

css_spec

crates/swc_html_minifier/benches/full.rs::files_document_fragment::bench_files_document_fragment::html/minify/document_fragment

195 ms194.9 ms

es/lints/libs/jquery

crates/swc_ecma_lints/benches/all.rs::files::bench_files::es/lints/libs

6.4 ms6.4 ms

html/document/visitor/compare/visit_mut_span_panic

crates/swc_html_parser/benches/compare.rs::benches::bench_cases

1.1 ms1.1 ms

stackoverflow

crates/swc_html_minifier/benches/full.rs::files_document::bench_files_document::html/minify/document

35.8 ms35.8 ms

html/document/visitor/compare/visit_mut_span

crates/swc_html_parser/benches/compare.rs::benches::bench_cases

1.1 ms1.1 ms

css_spec

crates/swc_html_minifier/benches/full.rs::files_document::bench_files_document::html/minify/document

195.2 ms195.2 ms

html/parser/parser_document_fragment/stackoverflow_com_17_05_2022

crates/swc_html_parser/benches/parser.rs::benches::bench_files

22.2 ms22.2 ms

html/document_fragment/visitor/compare/visit_mut_span_panic

crates/swc_html_parser/benches/compare.rs::benches::bench_cases

1.1 ms1.1 ms

es2015_arrow

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

298.5 µs298.4 µs

html/document_fragment/visitor/compare/visit_mut_span

crates/swc_html_parser/benches/compare.rs::benches::bench_cases

1.1 ms1.1 ms

es/lints/libs/echarts

crates/swc_ecma_lints/benches/all.rs::files::bench_files::es/lints/libs

114.3 ms114.3 ms

html/parser/parser_document/github_com_17_05_2022

crates/swc_html_parser/benches/parser.rs::benches::bench_files

22.1 ms22.1 ms

html/parser/parser_document/stackoverflow_com_17_05_2022

crates/swc_html_parser/benches/parser.rs::benches::bench_files

22.2 ms22.2 ms

html/document_fragment/visitor/compare/fold_span

crates/swc_html_parser/benches/compare.rs::benches::bench_cases

1.2 ms1.2 ms

es/lexer/underscore

crates/swc_ecma_parser/benches/lexer.rs::benches::bench_files

667.5 µs667.5 µs

html/document/visitor/compare/fold_span

crates/swc_html_parser/benches/compare.rs::benches::bench_cases

1.2 ms1.2 ms

css/parser/bootstrap_5_1_3

crates/swc_css_parser/benches/parser.rs::benches::bench_files

46.9 ms46.9 ms

css/visitor/compare/fold_span

crates/swc_css_parser/benches/compare.rs::benches::bench_cases

5.8 ms5.8 ms

html/document/visitor/compare/clone

crates/swc_html_parser/benches/compare.rs::benches::bench_cases

1 ms1 ms

html/document/visitor/compare/fold_span_panic

crates/swc_html_parser/benches/compare.rs::benches::bench_cases

1.2 ms1.2 ms

es2015_spread

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

273.6 µs273.5 µs

parse_and_babelify_jquery_mobile

crates/swc_estree_compat/benches/babelify.rs::benches::bench_cases

169.4 ms169.4 ms

css/visitor/compare/clone

crates/swc_css_parser/benches/compare.rs::benches::bench_cases

4.8 ms4.8 ms

parse_and_babelify_backbone

crates/swc_estree_compat/benches/babelify.rs::benches::bench_cases

15.4 ms15.4 ms

css/visitor/compare/fold_span_panic

crates/swc_css_parser/benches/compare.rs::benches::bench_cases

5.8 ms5.8 ms

es/lints/libs/lodash

crates/swc_ecma_lints/benches/all.rs::files::bench_files::es/lints/libs

6.1 ms6.1 ms

parse_and_babelify_underscore

crates/swc_estree_compat/benches/babelify.rs::benches::bench_cases

13.2 ms13.2 ms

parse_and_babelify_mootools

crates/swc_estree_compat/benches/babelify.rs::benches::bench_cases

72.7 ms72.7 ms

es/target/es3

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::version_group

397.8 µs397.8 µs

css/parser/foundation_6_7_4

crates/swc_css_parser/benches/parser.rs::benches::bench_files

37.2 ms37.2 ms

babelify-only

crates/swc_estree_compat/benches/babelify.rs::benches::bench_cases

2.1 ms2.1 ms

css/lexer/tailwind_3_1_1

crates/swc_css_parser/benches/lexer.rs::benches::bench_files

1.8 ms1.8 ms

es/lexer/three

crates/swc_ecma_parser/benches/lexer.rs::benches::bench_files

17.2 ms17.2 ms

html/lexer/stackoverflow_com_17_05_2022

crates/swc_html_parser/benches/lexer.rs::benches::bench_files

14 ms14 ms

html/document_fragment/visitor/compare/fold_span_panic

crates/swc_html_parser/benches/compare.rs::benches::bench_cases

1.2 ms1.2 ms

css/lexer/foundation_6_7_4

crates/swc_css_parser/benches/lexer.rs::benches::bench_files

9.3 ms9.3 ms

es/lexer/jquery

crates/swc_ecma_parser/benches/lexer.rs::benches::bench_files

4.2 ms4.2 ms

css/lexer/bootstrap_5_1_3

crates/swc_css_parser/benches/lexer.rs::benches::bench_files

11.3 ms11.3 ms

es/lints/libs/typescript

crates/swc_ecma_lints/benches/all.rs::files::bench_files::es/lints/libs

276.6 ms276.6 ms

es/visitor/compare/fold_span_panic

crates/swc_ecma_parser/benches/compare.rs::benches::bench_cases

6.8 ms6.8 ms

html/lexer/github_com_17_05_2022

crates/swc_html_parser/benches/lexer.rs::benches::bench_files

14 ms14 ms

html/lexer/css_2021_spec

crates/swc_html_parser/benches/lexer.rs::benches::bench_files

38.7 ms38.7 ms

parse_and_babelify_angular

crates/swc_estree_compat/benches/babelify.rs::benches::bench_cases

159.5 ms159.5 ms

es/lints/libs/antd

crates/swc_ecma_lints/benches/all.rs::files::bench_files::es/lints/libs

156.3 ms156.3 ms

parse_and_babelify_jquery

crates/swc_estree_compat/benches/babelify.rs::benches::bench_cases

99 ms99 ms

es/lexer/backbone

crates/swc_ecma_parser/benches/lexer.rs::benches::bench_files

788.1 µs788.2 µs

es/visitor/compare/visit_mut_span

crates/swc_ecma_parser/benches/compare.rs::benches::bench_cases

6 ms6 ms

es/lexer/jquery mobile

crates/swc_ecma_parser/benches/lexer.rs::benches::bench_files

6.4 ms6.4 ms

html/document_fragment/visitor/compare/clone

crates/swc_html_parser/benches/compare.rs::benches::bench_cases

1 ms1 ms

es/visitor/compare/visit_mut_span_panic

crates/swc_ecma_parser/benches/compare.rs::benches::bench_cases

6 ms6 ms

es/lexer/cal-com

crates/swc_ecma_parser/benches/lexer.rs::benches::bench_files

12.9 ms12.9 ms

es/lexer/angular

crates/swc_ecma_parser/benches/lexer.rs::benches::bench_files

5.6 ms5.6 ms

es2015_duplicate_keys

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

281.2 µs281.2 µs

css/visitor/compare/visit_mut_span_panic

crates/swc_css_parser/benches/compare.rs::benches::bench_cases

5.1 ms5.1 ms

es/minifier/libs/echarts

crates/swc_ecma_minifier/benches/full.rs::bench_all::bench_libs::es/minifier/libs

1.5 s1.5 s

es/minifier/libs/react

crates/swc_ecma_minifier/benches/full.rs::bench_all::bench_libs::es/minifier/libs

19.5 ms19.5 ms

es/lints/libs/moment

crates/swc_ecma_lints/benches/all.rs::files::bench_files::es/lints/libs

4.1 ms4.1 ms

css/parser/tailwind_3_1_1

crates/swc_css_parser/benches/parser.rs::benches::bench_files

7.2 ms7.2 ms

es2015_block_scoping

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

459.8 µs459.9 µs

es/visitor/compare/clone

crates/swc_ecma_parser/benches/compare.rs::benches::bench_cases

5.5 ms5.5 ms

es/visitor/compare/fold_span

crates/swc_ecma_parser/benches/compare.rs::benches::bench_cases

6.8 ms6.8 ms

es/lexer/mootools

crates/swc_ecma_parser/benches/lexer.rs::benches::bench_files

3.2 ms3.2 ms

es/minifier/libs/antd

crates/swc_ecma_minifier/benches/full.rs::bench_all::bench_libs::es/minifier/libs

1.9 s1.9 s

es2015_computed_props

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

273.8 µs273.8 µs

es2015_shorthand_property

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

274.8 µs274.9 µs

es2015_block_scoped_fn

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

292.5 µs292.6 µs

parse_and_babelify_yui

crates/swc_estree_compat/benches/babelify.rs::benches::bench_cases

67.4 ms67.5 ms

es2015_classes

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

390.9 µs391 µs

es2020_optional_chaining

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

337.9 µs338.1 µs

es2015_for_of

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

294.9 µs295.1 µs

es/minifier/libs/jquery

crates/swc_ecma_minifier/benches/full.rs::bench_all::bench_libs::es/minifier/libs

96.7 ms96.7 ms

typescript/fast-strip

crates/swc_ts_fast_strip/benches/assets.rs::benches::fast_ts

417.1 µs417.4 µs

es/codegen/with-parser/large

crates/swc_ecma_codegen/benches/with_parse.rs::benches::bench_cases

1.1 ms1.1 ms

es/resolver_with_hygiene/typescript

crates/swc_ecma_transforms_base/benches/base.rs::benches::bench_cases

746.2 ms747.2 ms

es2022_class_properties

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

384.4 µs384.9 µs

es/lexer/typescript

crates/swc_ecma_parser/benches/lexer.rs::benches::bench_files

102.1 ms102.3 ms

es/transform/baseline/common_typescript

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::baseline_group

371.2 µs371.7 µs

es/minifier/libs/moment

crates/swc_ecma_minifier/benches/full.rs::bench_all::bench_libs::es/minifier/libs

62.5 ms62.7 ms

es/preset-env/usage/property

crates/swc_ecma_preset_env/benches/polyfills.rs::benches::bench_cases

108 µs108.2 µs

es/target/es2015

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::version_group

1.2 ms1.2 ms

es/parser/colors

crates/swc_ecma_parser/benches/parser.rs::benches::bench_files

79.7 µs79.8 µs

es/lints/libs/victory

crates/swc_ecma_lints/benches/all.rs::files::bench_files::es/lints/libs

70.1 ms70.3 ms

es/minifier/libs/lodash

crates/swc_ecma_minifier/benches/full.rs::bench_all::bench_libs::es/minifier/libs

113.8 ms114.3 ms

es/target/es2020

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::version_group

-1%

479.7 µs482.9 µs

es/target/es2016

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::version_group

-1%

298.7 µs301.1 µs

es2016_exponentiation

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

-1%

296.8 µs299.3 µs

es2019_optional_catch_binding

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

-1%

291.3 µs293.8 µs

es/target/es2018

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::version_group

-1%

310.7 µs313.3 µs

es2018_object_rest_spread

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

-1%

303.4 µs306.1 µs

es/target/es2017

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::version_group

-1%

298.7 µs301.4 µs

es2020_nullish_coalescing

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

-1%

299.7 µs302.4 µs

es2017_async_to_generator

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

-1%

297.2 µs299.9 µs

es/full-target/es2018

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::full_group

-1%

552.4 µs560.2 µs

es/full-target/es2017

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::full_group

-2%

586.5 µs596.5 µs

es/full-target/es2016

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::full_group

-2%

622.2 µs634.3 µs

Ignored

es/preset-env/entry/import

crates/swc_ecma_preset_env/benches/polyfills.rs::benches::bench_cases

Ignored

-3%

27.7 µs28.5 µs

Commits

Click on a commit to change the comparison range

Base

main

686d154

+2.35%

Create shiny-lies-drive.md

4765586

10 hours ago

by kdy1

-2.42%

feat: Implement private property in object transform for ES2022 Ported the private-in-object transform to the new VisitMutHook system. This transform converts `#private in object` expressions into WeakSet-based brand checks as specified by the TC39 proposal. Key changes: - Implemented PrivatePropertyInObjectPass with VisitMutHook<TraverseCtx> - Added necessary hooks to hook_utils.rs (enter/exit for class_decl, class_expr, assign_pat, private_prop) - Integrated the hook into es2022/mod.rs using HookBuilder pattern - Handles private fields, methods, and static members correctly - Optimizes static methods to use simple === comparison - All tests passing (swc_ecma_compat_es2022, swc_ecma_transforms_compat, projects, tsc) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 (1M context) <noreply@anthropic.com>

801967d

9 hours ago

by kdy1

Home Terms Privacy Docs