devbird/fix-nullish-coalescing-segfault - Branch - swc-project/swc

fix(es/compiler): Fix ARM64 segfault in nullish coalescing variable hoisting

#11181Closed

Comparing

devbird/fix-nullish-coalescing-segfault

(

86073dc

) with

main

(

dd6f71b

)

Untouched: 140

Ignored: 1

Benchmarks

Passed

es/minifier/libs/terser

crates/swc_ecma_minifier/benches/full.rs::bench_all::bench_libs::es/minifier/libs

+1%

344.1 ms342.1 ms

es/codegen/colors

crates/swc_ecma_codegen/benches/bench.rs::benches::bench_cases

71 µs70.8 µs

es/minifier/libs/victory

crates/swc_ecma_minifier/benches/full.rs::bench_all::bench_libs::es/minifier/libs

839.9 ms837.8 ms

es2015_classes

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

390.3 µs389.7 µs

es/lexer/colors

crates/swc_ecma_lexer/benches/lexer.rs::benches::bench_files

36 µs36 µs

es/minifier/libs/d3

crates/swc_ecma_minifier/benches/full.rs::bench_all::bench_libs::es/minifier/libs

386.6 ms386 ms

es/transform/baseline/common_reserved_word

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::baseline_group

285 µs284.6 µs

es/target/es2017

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::version_group

276 µs275.6 µs

es2017_async_to_generator

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

276.4 µs276 µs

es2015_fn_name

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

282.6 µs282.2 µs

es/minifier/libs/lodash

crates/swc_ecma_minifier/benches/full.rs::bench_all::bench_libs::es/minifier/libs

111.8 ms111.6 ms

es/target/es3

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::version_group

395.9 µs395.5 µs

es2019_optional_catch_binding

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

274 µs273.7 µs

es/minifier/libs/typescript

crates/swc_ecma_minifier/benches/full.rs::bench_all::bench_libs::es/minifier/libs

3.7 s3.7 s

es/lints/libs/react

crates/swc_ecma_lints/benches/all.rs::files::bench_files::es/lints/libs

1.3 ms1.3 ms

es2020_optional_chaining

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

336.8 µs336.5 µs

es/transform/baseline/base

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::baseline_group

260.8 µs260.6 µs

es2015_for_of

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

290.4 µs290.2 µs

github

crates/swc_html_minifier/benches/full.rs::files_document_fragment::bench_files_document_fragment::html/minify/document_fragment

40.3 ms40.3 ms

es/minifier/libs/react

crates/swc_ecma_minifier/benches/full.rs::bench_all::bench_libs::es/minifier/libs

19.2 ms19.2 ms

stackoverflow

crates/swc_html_minifier/benches/full.rs::files_document::bench_files_document::html/minify/document

35.3 ms35.3 ms

es/minifier/libs/vue

crates/swc_ecma_minifier/benches/full.rs::bench_all::bench_libs::es/minifier/libs

140.2 ms140.1 ms

es2015_instanceof

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

280.7 µs280.5 µs

es2015_spread

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

274.7 µs274.6 µs

es2015_destructuring

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

348.2 µs348 µs

es/codegen/large

crates/swc_ecma_codegen/benches/bench.rs::benches::bench_cases

645.1 µs644.8 µs

es/minifier/libs/echarts

crates/swc_ecma_minifier/benches/full.rs::bench_all::bench_libs::es/minifier/libs

1.5 s1.5 s

es/target/es2016

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::version_group

290 µs289.9 µs

stackoverflow

crates/swc_html_minifier/benches/full.rs::files_document_fragment::bench_files_document_fragment::html/minify/document_fragment

35.5 ms35.5 ms

es2016_exponentiation

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

289.4 µs289.3 µs

es2015_sticky_regex

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

277.9 µs277.8 µs

es/transform/baseline/common_typescript

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::baseline_group

364.3 µs364.2 µs

html/document/visitor/compare/fold_span_panic

crates/swc_html_parser/benches/compare.rs::benches::bench_cases

1.2 ms1.2 ms

html/document_fragment/visitor/compare/visit_mut_span

crates/swc_html_parser/benches/compare.rs::benches::bench_cases

1.1 ms1.1 ms

es/fixer/typescript

crates/swc_ecma_transforms_base/benches/base.rs::benches::bench_cases

202.7 ms202.7 ms

es2015_parameters

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

331.7 µs331.6 µs

hygiene/typescript

crates/swc_ecma_transforms_base/benches/parallel.rs::benches::bench_cases::es/base/parallel

21.3 s21.3 s

es/minifier/libs/moment

crates/swc_ecma_minifier/benches/full.rs::bench_all::bench_libs::es/minifier/libs

61.5 ms61.5 ms

es2015_duplicate_keys

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

281.1 µs281.1 µs

es2015_shorthand_property

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

274.1 µs274.1 µs

es/minifier/libs/antd

crates/swc_ecma_minifier/benches/full.rs::bench_all::bench_libs::es/minifier/libs

1.9 s1.9 s

es/lints/libs/echarts

crates/swc_ecma_lints/benches/all.rs::files::bench_files::es/lints/libs

114.1 ms114 ms

es/lints/libs/three

crates/swc_ecma_lints/benches/all.rs::files::bench_files::es/lints/libs

50.3 ms50.2 ms

github

crates/swc_html_minifier/benches/full.rs::files_document::bench_files_document::html/minify/document

40.9 ms40.9 ms

es/parser/cal-com

crates/swc_ecma_parser/benches/parser.rs::benches::bench_files

59.3 ms59.3 ms

html/parser/parser_document_fragment/css_2021_spec

crates/swc_html_parser/benches/parser.rs::benches::bench_files

71.2 ms71.2 ms

html/document/visitor/compare/visit_mut_span

crates/swc_html_parser/benches/compare.rs::benches::bench_cases

1.1 ms1.1 ms

css_spec

crates/swc_html_minifier/benches/full.rs::files_document::bench_files_document::html/minify/document

194 ms194 ms

es/target/es2018

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::version_group

309.7 µs309.6 µs

es/lints/libs/typescript

crates/swc_ecma_lints/benches/all.rs::files::bench_files::es/lints/libs

276.1 ms276 ms

css/parser/bootstrap_5_1_3

crates/swc_css_parser/benches/parser.rs::benches::bench_files

46.8 ms46.8 ms

html/document/visitor/compare/fold_span

crates/swc_html_parser/benches/compare.rs::benches::bench_cases

1.2 ms1.2 ms

es/parser/three

crates/swc_ecma_parser/benches/parser.rs::benches::bench_files

72.9 ms72.9 ms

html/document/visitor/compare/clone

crates/swc_html_parser/benches/compare.rs::benches::bench_cases

1 ms1 ms

es2015_block_scoping

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

451.9 µs451.8 µs

html/document/visitor/compare/visit_mut_span_panic

crates/swc_html_parser/benches/compare.rs::benches::bench_cases

1.1 ms1.1 ms

resolver/typescript

crates/swc_ecma_transforms_base/benches/parallel.rs::benches::bench_cases::es/base/parallel

12.3 s12.3 s

html/document_fragment/visitor/compare/visit_mut_span_panic

crates/swc_html_parser/benches/compare.rs::benches::bench_cases

1.1 ms1.1 ms

css/lexer/foundation_6_7_4

crates/swc_css_parser/benches/lexer.rs::benches::bench_files

8.2 ms8.2 ms

css/visitor/compare/clone

crates/swc_css_parser/benches/compare.rs::benches::bench_cases

4.8 ms4.8 ms

es/visitor/compare/clone

crates/swc_ecma_parser/benches/compare.rs::benches::bench_cases

5.5 ms5.5 ms

es/full-target/es2017

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::full_group

527.8 µs527.8 µs

css/parser/foundation_6_7_4

crates/swc_css_parser/benches/parser.rs::benches::bench_files

37.2 ms37.2 ms

css/visitor/compare/visit_mut_span_panic

crates/swc_css_parser/benches/compare.rs::benches::bench_cases

5.2 ms5.2 ms

es/hygiene/typescript

crates/swc_ecma_transforms_base/benches/base.rs::benches::bench_cases

425.6 ms425.6 ms

html/document_fragment/visitor/compare/fold_span

crates/swc_html_parser/benches/compare.rs::benches::bench_cases

1.2 ms1.2 ms

es/lexer/angular

crates/swc_ecma_lexer/benches/lexer.rs::benches::bench_files

10.1 ms10.1 ms

es/visitor/compare/visit_mut_span_panic

crates/swc_ecma_parser/benches/compare.rs::benches::bench_cases

6 ms6 ms

css/lexer/bootstrap_5_1_3

crates/swc_css_parser/benches/lexer.rs::benches::bench_files

10 ms10 ms

es/lexer/backbone

crates/swc_ecma_lexer/benches/lexer.rs::benches::bench_files

1.4 ms1.4 ms

es/visitor/compare/fold_span

crates/swc_ecma_parser/benches/compare.rs::benches::bench_cases

6.8 ms6.8 ms

es/lexer/jquery mobile

crates/swc_ecma_lexer/benches/lexer.rs::benches::bench_files

11.7 ms11.7 ms

es/lexer/mootools

crates/swc_ecma_lexer/benches/lexer.rs::benches::bench_files

6.1 ms6.1 ms

html/lexer/stackoverflow_com_17_05_2022

crates/swc_html_parser/benches/lexer.rs::benches::bench_files

14.7 ms14.7 ms

html/lexer/github_com_17_05_2022

crates/swc_html_parser/benches/lexer.rs::benches::bench_files

14.6 ms14.6 ms

es/lexer/cal-com

crates/swc_ecma_lexer/benches/lexer.rs::benches::bench_files

29.5 ms29.5 ms

es/codegen/with-parser/colors

crates/swc_ecma_codegen/benches/with_parse.rs::benches::bench_cases

156 µs156 µs

html/lexer/css_2021_spec

crates/swc_html_parser/benches/lexer.rs::benches::bench_files

40.7 ms40.7 ms

es/parser/typescript

crates/swc_ecma_parser/benches/parser.rs::benches::bench_files

402.2 ms402.2 ms

es/lexer/three

crates/swc_ecma_lexer/benches/lexer.rs::benches::bench_files

36.2 ms36.2 ms

es/visitor/compare/visit_mut_span

crates/swc_ecma_parser/benches/compare.rs::benches::bench_cases

6 ms6 ms

es/visitor/compare/fold_span_panic

crates/swc_ecma_parser/benches/compare.rs::benches::bench_cases

6.8 ms6.8 ms

css/visitor/compare/fold_span

crates/swc_css_parser/benches/compare.rs::benches::bench_cases

5.7 ms5.7 ms

es/lexer/typescript

crates/swc_ecma_lexer/benches/lexer.rs::benches::bench_files

184.6 ms184.6 ms

es/resolver/typescript

crates/swc_ecma_transforms_base/benches/base.rs::benches::bench_cases

244.3 ms244.3 ms

es/lexer/yui

crates/swc_ecma_lexer/benches/lexer.rs::benches::bench_files

6.2 ms6.2 ms

css/visitor/compare/visit_mut_span

crates/swc_css_parser/benches/compare.rs::benches::bench_cases

5.1 ms5.1 ms

css/lexer/tailwind_3_1_1

crates/swc_css_parser/benches/lexer.rs::benches::bench_files

1.6 ms1.6 ms

css/visitor/compare/fold_span_panic

crates/swc_css_parser/benches/compare.rs::benches::bench_cases

5.7 ms5.7 ms

es/lexer/jquery

crates/swc_ecma_lexer/benches/lexer.rs::benches::bench_files

7.7 ms7.7 ms

es/lints/libs/vue

crates/swc_ecma_lints/benches/all.rs::files::bench_files::es/lints/libs

8.3 ms8.3 ms

parse_and_babelify_yui

crates/swc_estree_compat/benches/babelify.rs::benches::bench_cases

66.3 ms66.3 ms

es/lints/libs/antd

crates/swc_ecma_lints/benches/all.rs::files::bench_files::es/lints/libs

156 ms156 ms

parse_and_babelify_jquery

crates/swc_estree_compat/benches/babelify.rs::benches::bench_cases

98.6 ms98.7 ms

es/parser/jquery

crates/swc_ecma_parser/benches/parser.rs::benches::bench_files

15.1 ms15.1 ms

es/parser/angular

crates/swc_ecma_parser/benches/parser.rs::benches::bench_files

18.8 ms18.8 ms

html/parser/parser_document_fragment/stackoverflow_com_17_05_2022

crates/swc_html_parser/benches/parser.rs::benches::bench_files

22.3 ms22.3 ms

parse_and_babelify_jquery_mobile

crates/swc_estree_compat/benches/babelify.rs::benches::bench_cases

168.9 ms168.9 ms

parse_and_babelify_angular

crates/swc_estree_compat/benches/babelify.rs::benches::bench_cases

157.4 ms157.5 ms

es/lints/libs/moment

crates/swc_ecma_lints/benches/all.rs::files::bench_files::es/lints/libs

4.2 ms4.2 ms

es/lints/libs/jquery

crates/swc_ecma_lints/benches/all.rs::files::bench_files::es/lints/libs

6.5 ms6.5 ms

es/lexer/underscore

crates/swc_ecma_lexer/benches/lexer.rs::benches::bench_files

1.2 ms1.2 ms

css/parser/tailwind_3_1_1

crates/swc_css_parser/benches/parser.rs::benches::bench_files

7.2 ms7.2 ms

es/codegen/with-parser/large

crates/swc_ecma_codegen/benches/with_parse.rs::benches::bench_cases

1.2 ms1.2 ms

parse_and_babelify_backbone

crates/swc_estree_compat/benches/babelify.rs::benches::bench_cases

15.3 ms15.3 ms

es2015_typeof_symbol

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

278.6 µs278.6 µs

es2015_computed_props

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

274.4 µs274.4 µs

es2015_block_scoped_fn

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

289.7 µs289.7 µs

es/target/es2015

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::version_group

1.2 ms1.2 ms

html/document_fragment/visitor/compare/fold_span_panic

crates/swc_html_parser/benches/compare.rs::benches::bench_cases

1.2 ms1.2 ms

es/parser/mootools

crates/swc_ecma_parser/benches/parser.rs::benches::bench_files

11.9 ms11.9 ms

es2020_nullish_coalescing

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

310.9 µs310.9 µs

html/parser/parser_document_fragment/github_com_17_05_2022

crates/swc_html_parser/benches/parser.rs::benches::bench_files

22.3 ms22.3 ms

es/lints/libs/victory

crates/swc_ecma_lints/benches/all.rs::files::bench_files::es/lints/libs

70.6 ms70.6 ms

html/parser/parser_document/css_2021_spec

crates/swc_html_parser/benches/parser.rs::benches::bench_files

71.5 ms71.6 ms

es/lints/libs/lodash

crates/swc_ecma_lints/benches/all.rs::files::bench_files::es/lints/libs

6.2 ms6.2 ms

parse_and_babelify_mootools

crates/swc_estree_compat/benches/babelify.rs::benches::bench_cases

72.7 ms72.7 ms

es/parser/underscore

crates/swc_ecma_parser/benches/parser.rs::benches::bench_files

2.5 ms2.5 ms

html/document_fragment/visitor/compare/clone

crates/swc_html_parser/benches/compare.rs::benches::bench_cases

1 ms1 ms

babelify-only

crates/swc_estree_compat/benches/babelify.rs::benches::bench_cases

2.1 ms2.1 ms

parse_and_babelify_underscore

crates/swc_estree_compat/benches/babelify.rs::benches::bench_cases

13 ms13 ms

es2018_object_rest_spread

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

292.1 µs292.2 µs

es/parser/jquery mobile

crates/swc_ecma_parser/benches/parser.rs::benches::bench_files

23.5 ms23.5 ms

es/full-target/es2016

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::full_group

563.7 µs563.8 µs

es/parser/backbone

crates/swc_ecma_parser/benches/parser.rs::benches::bench_files

2.9 ms2.9 ms

css_spec

crates/swc_html_minifier/benches/full.rs::files_document_fragment::bench_files_document_fragment::html/minify/document_fragment

191.7 ms191.7 ms

es/resolver_with_hygiene/typescript

crates/swc_ecma_transforms_base/benches/base.rs::benches::bench_cases

734.7 ms734.9 ms

html/parser/parser_document/github_com_17_05_2022

crates/swc_html_parser/benches/parser.rs::benches::bench_files

22.4 ms22.4 ms

es/full-target/es2018

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::full_group

511.2 µs511.4 µs

es2015_arrow

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

302.5 µs302.6 µs

es/parser/colors

crates/swc_ecma_parser/benches/parser.rs::benches::bench_files

84.3 µs84.3 µs

html/parser/parser_document/stackoverflow_com_17_05_2022

crates/swc_html_parser/benches/parser.rs::benches::bench_files

22.3 ms22.3 ms

typescript/fast-strip

crates/swc_ts_fast_strip/benches/assets.rs::benches::fast_ts

434.6 µs434.7 µs

es/minifier/libs/jquery

crates/swc_ecma_minifier/benches/full.rs::bench_all::bench_libs::es/minifier/libs

94.9 ms95 ms

es/parser/yui

crates/swc_ecma_parser/benches/parser.rs::benches::bench_files

11.6 ms11.6 ms

es/target/es2020

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::version_group

448.7 µs449 µs

es2022_class_properties

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

381.1 µs381.4 µs

es/preset-env/usage/builtin_type

crates/swc_ecma_preset_env/benches/polyfills.rs::benches::bench_cases

245.8 µs246.2 µs

es/minifier/libs/three

crates/swc_ecma_minifier/benches/full.rs::bench_all::bench_libs::es/minifier/libs

632.6 ms633.8 ms

es/preset-env/usage/property

crates/swc_ecma_preset_env/benches/polyfills.rs::benches::bench_cases

114.7 µs115 µs

Ignored

es/preset-env/entry/import

crates/swc_ecma_preset_env/benches/polyfills.rs::benches::bench_cases

Ignored

-1%

28.3 µs28.6 µs

Commits

Click on a commit to change the comparison range

Base

main

dd6f71b

+0.02%

fix(es/compiler): Fix ARM64 segfault in nullish coalescing variable hoisting This fixes a critical segfault issue on ARM64 platforms (AWS Graviton, macOS Apple Silicon) that was introduced in the nullish coalescing merge (#11157). **Root Cause:** The `visit_mut_module_items` and `visit_mut_stmts` functions were unconditionally restoring saved variable vectors at the end, even after those vectors had been properly moved and emptied during the nullish coalescing processing loop. This created a use-after-free scenario where: 1. Saved vectors were taken (emptied) at the start 2. New items were added to the instance vectors during processing 3. The instance vectors were properly consumed via `.take()` 4. The saved (empty) vectors were restored, discarding the properly processed state On ARM64 architectures with stricter memory alignment requirements and different register calling conventions, this pattern exposed memory safety issues that manifested as segmentation faults. **Solution:** Move the variable restoration logic into each branch of the conditional, ensuring vectors are only restored in the appropriate control flow path and not after they've been properly consumed during nullish coalescing hoisting. Fixes #11129 Fixes #11176 Fixes #11177 Fixes #11178 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>

86073dc

3 days ago

by github-actions[bot]

Home Terms Privacy Docs