devbird/fix-lexer-windows-path-escape - Branch - swc-project/swc

fix(lexer): Handle unrecognized escape sequences correctly

#11217

Comparing

devbird/fix-lexer-windows-path-escape

(

d03ae7a

) with

main

(

58a9d81

)

Untouched: 138

Ignored: 1

No successful run was found on main ( 47c22df) during the generation of this report, so 58a9d81 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

Benchmarks

Passed

es/minifier/libs/terser

crates/swc_ecma_minifier/benches/full.rs::bench_all::bench_libs::es/minifier/libs

+1%

350.6 ms348.8 ms

es/minifier/libs/d3

crates/swc_ecma_minifier/benches/full.rs::bench_all::bench_libs::es/minifier/libs

398.3 ms396.9 ms

es/minifier/libs/antd

crates/swc_ecma_minifier/benches/full.rs::bench_all::bench_libs::es/minifier/libs

1.9 s1.9 s

es2015_sticky_regex

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

274.3 µs273.8 µs

es/codegen/colors

crates/swc_ecma_codegen/benches/bench.rs::benches::bench_cases

68.4 µs68.3 µs

es/transform/baseline/common_typescript

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::baseline_group

371.1 µs370.6 µs

es2015_arrow

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

299.8 µs299.4 µs

es/lints/libs/three

crates/swc_ecma_lints/benches/all.rs::files::bench_files::es/lints/libs

50.3 ms50.2 ms

es2015_instanceof

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

278.7 µs278.3 µs

typescript/fast-strip

crates/swc_ts_fast_strip/benches/assets.rs::benches::fast_ts

420.6 µs420 µs

es/lints/libs/victory

crates/swc_ecma_lints/benches/all.rs::files::bench_files::es/lints/libs

70.8 ms70.7 ms

parse_and_babelify_backbone

crates/swc_estree_compat/benches/babelify.rs::benches::bench_cases

15.4 ms15.4 ms

es2020_optional_chaining

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

338.3 µs338 µs

parse_and_babelify_underscore

crates/swc_estree_compat/benches/babelify.rs::benches::bench_cases

13.1 ms13.1 ms

es/parser/cal-com

crates/swc_ecma_parser/benches/parser.rs::benches::bench_files

56.8 ms56.7 ms

es2022_class_properties

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

384.8 µs384.4 µs

es/transform/baseline/base

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::baseline_group

260 µs259.7 µs

es2018_object_rest_spread

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

291 µs290.7 µs

es2015_classes

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

391.3 µs390.9 µs

es2019_optional_catch_binding

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

272.2 µs271.9 µs

github

crates/swc_html_minifier/benches/full.rs::files_document_fragment::bench_files_document_fragment::html/minify/document_fragment

41.7 ms41.7 ms

stackoverflow

crates/swc_html_minifier/benches/full.rs::files_document::bench_files_document::html/minify/document

36.2 ms36.2 ms

es2015_fn_name

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

281.1 µs280.9 µs

html/parser/parser_document_fragment/css_2021_spec

crates/swc_html_parser/benches/parser.rs::benches::bench_files

71.9 ms71.8 ms

parse_and_babelify_yui

crates/swc_estree_compat/benches/babelify.rs::benches::bench_cases

67.6 ms67.6 ms

es2016_exponentiation

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

292.1 µs291.9 µs

es/transform/baseline/common_reserved_word

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::baseline_group

278.3 µs278.1 µs

es2015_destructuring

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

345.8 µs345.6 µs

stackoverflow

crates/swc_html_minifier/benches/full.rs::files_document_fragment::bench_files_document_fragment::html/minify/document_fragment

37.5 ms37.4 ms

es/full-target/es2016

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::full_group

578.2 µs577.8 µs

parse_and_babelify_mootools

crates/swc_estree_compat/benches/babelify.rs::benches::bench_cases

72.7 ms72.6 ms

html/parser/parser_document_fragment/github_com_17_05_2022

crates/swc_html_parser/benches/parser.rs::benches::bench_files

22.5 ms22.5 ms

es2015_shorthand_property

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

274.6 µs274.4 µs

es2015_for_of

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

293.9 µs293.7 µs

es/full-target/es2018

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::full_group

523.8 µs523.4 µs

css_spec

crates/swc_html_minifier/benches/full.rs::files_document_fragment::bench_files_document_fragment::html/minify/document_fragment

196.3 ms196.2 ms

es2015_block_scoped_fn

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

292.3 µs292.1 µs

es2015_computed_props

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

273.9 µs273.7 µs

parse_and_babelify_jquery

crates/swc_estree_compat/benches/babelify.rs::benches::bench_cases

99.4 ms99.4 ms

es/target/es2016

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::version_group

292 µs291.8 µs

css_spec

crates/swc_html_minifier/benches/full.rs::files_document::bench_files_document::html/minify/document

196.6 ms196.5 ms

es/codegen/with-parser/large

crates/swc_ecma_codegen/benches/with_parse.rs::benches::bench_cases

1.2 ms1.2 ms

parse_and_babelify_jquery_mobile

crates/swc_estree_compat/benches/babelify.rs::benches::bench_cases

169.9 ms169.8 ms

es2015_spread

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

273.3 µs273.1 µs

es/parser/typescript

crates/swc_ecma_parser/benches/parser.rs::benches::bench_files

380 ms379.8 ms

parse_and_babelify_angular

crates/swc_estree_compat/benches/babelify.rs::benches::bench_cases

160.4 ms160.3 ms

es/target/es2018

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::version_group

310.1 µs309.9 µs

es/target/es2015

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::version_group

1.2 ms1.2 ms

es/hygiene/typescript

crates/swc_ecma_transforms_base/benches/base.rs::benches::bench_cases

423.4 ms423.2 ms

es2017_async_to_generator

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

277.2 µs277.1 µs

html/parser/parser_document/stackoverflow_com_17_05_2022

crates/swc_html_parser/benches/parser.rs::benches::bench_files

22.7 ms22.6 ms

es2015_block_scoping

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

456.9 µs456.7 µs

es/full-target/es2017

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::full_group

542.7 µs542.5 µs

es/lexer/jquery

crates/swc_ecma_parser/benches/lexer.rs::benches::bench_files

4.6 ms4.6 ms

es/target/es2017

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::version_group

276.2 µs276.1 µs

es/target/es2020

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::version_group

459 µs458.9 µs

es2015_duplicate_keys

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

281.2 µs281.1 µs

html/document_fragment/visitor/compare/fold_span_panic

crates/swc_html_parser/benches/compare.rs::benches::bench_cases

1.2 ms1.2 ms

css/parser/bootstrap_5_1_3

crates/swc_css_parser/benches/parser.rs::benches::bench_files

46.5 ms46.5 ms

es/lints/libs/antd

crates/swc_ecma_lints/benches/all.rs::files::bench_files::es/lints/libs

156.4 ms156.3 ms

es/lexer/jquery mobile

crates/swc_ecma_parser/benches/lexer.rs::benches::bench_files

7.2 ms7.2 ms

es/lints/libs/react

crates/swc_ecma_lints/benches/all.rs::files::bench_files::es/lints/libs

1.3 ms1.3 ms

es/lexer/angular

crates/swc_ecma_parser/benches/lexer.rs::benches::bench_files

6.6 ms6.6 ms

html/document_fragment/visitor/compare/clone

crates/swc_html_parser/benches/compare.rs::benches::bench_cases

1 ms1 ms

es/target/es3

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::version_group

398.7 µs398.6 µs

es/codegen/large

crates/swc_ecma_codegen/benches/bench.rs::benches::bench_cases

639.3 µs639.3 µs

es/lexer/backbone

crates/swc_ecma_parser/benches/lexer.rs::benches::bench_files

875.4 µs875.3 µs

es/lexer/mootools

crates/swc_ecma_parser/benches/lexer.rs::benches::bench_files

3.6 ms3.6 ms

es2015_parameters

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

332.7 µs332.7 µs

es/lints/libs/moment

crates/swc_ecma_lints/benches/all.rs::files::bench_files::es/lints/libs

4.2 ms4.2 ms

css/parser/foundation_6_7_4

crates/swc_css_parser/benches/parser.rs::benches::bench_files

37 ms37 ms

es/lexer/yui

crates/swc_ecma_parser/benches/lexer.rs::benches::bench_files

4 ms4 ms

html/parser/parser_document/github_com_17_05_2022

crates/swc_html_parser/benches/parser.rs::benches::bench_files

22.5 ms22.5 ms

babelify-only

crates/swc_estree_compat/benches/babelify.rs::benches::bench_cases

2.1 ms2.1 ms

es/lexer/typescript

crates/swc_ecma_parser/benches/lexer.rs::benches::bench_files

107.7 ms107.7 ms

es/lexer/underscore

crates/swc_ecma_parser/benches/lexer.rs::benches::bench_files

737.5 µs737.5 µs

html/parser/parser_document/css_2021_spec

crates/swc_html_parser/benches/parser.rs::benches::bench_files

72.3 ms72.3 ms

css/lexer/bootstrap_5_1_3

crates/swc_css_parser/benches/lexer.rs::benches::bench_files

11 ms11 ms

html/lexer/css_2021_spec

crates/swc_html_parser/benches/lexer.rs::benches::bench_files

40 ms40 ms

html/lexer/stackoverflow_com_17_05_2022

crates/swc_html_parser/benches/lexer.rs::benches::bench_files

14.5 ms14.5 ms

html/parser/parser_document_fragment/stackoverflow_com_17_05_2022

crates/swc_html_parser/benches/parser.rs::benches::bench_files

22.6 ms22.6 ms

html/lexer/github_com_17_05_2022

crates/swc_html_parser/benches/lexer.rs::benches::bench_files

14.4 ms14.4 ms

es/lints/libs/typescript

crates/swc_ecma_lints/benches/all.rs::files::bench_files::es/lints/libs

276.3 ms276.3 ms

es/lexer/cal-com

crates/swc_ecma_parser/benches/lexer.rs::benches::bench_files

13.1 ms13.1 ms

es/visitor/compare/clone

crates/swc_ecma_parser/benches/compare.rs::benches::bench_cases

5.5 ms5.5 ms

es/minifier/libs/victory

crates/swc_ecma_minifier/benches/full.rs::bench_all::bench_libs::es/minifier/libs

856.1 ms856.1 ms

html/document/visitor/compare/clone

crates/swc_html_parser/benches/compare.rs::benches::bench_cases

1 ms1 ms

css/visitor/compare/fold_span_panic

crates/swc_css_parser/benches/compare.rs::benches::bench_cases

5.8 ms5.8 ms

es2020_nullish_coalescing

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

291.3 µs291.3 µs

css/visitor/compare/fold_span

crates/swc_css_parser/benches/compare.rs::benches::bench_cases

5.8 ms5.8 ms

es/visitor/compare/fold_span

crates/swc_ecma_parser/benches/compare.rs::benches::bench_cases

6.8 ms6.8 ms

css/parser/tailwind_3_1_1

crates/swc_css_parser/benches/parser.rs::benches::bench_files

7.2 ms7.2 ms

es/visitor/compare/visit_mut_span_panic

crates/swc_ecma_parser/benches/compare.rs::benches::bench_cases

6 ms6 ms

es/lints/libs/vue

crates/swc_ecma_lints/benches/all.rs::files::bench_files::es/lints/libs

8.3 ms8.3 ms

css/lexer/tailwind_3_1_1

crates/swc_css_parser/benches/lexer.rs::benches::bench_files

1.8 ms1.8 ms

github

crates/swc_html_minifier/benches/full.rs::files_document::bench_files_document::html/minify/document

42.4 ms42.4 ms

es/lints/libs/echarts

crates/swc_ecma_lints/benches/all.rs::files::bench_files::es/lints/libs

114.3 ms114.3 ms

es/visitor/compare/visit_mut_span

crates/swc_ecma_parser/benches/compare.rs::benches::bench_cases

6 ms6 ms

css/visitor/compare/visit_mut_span_panic

crates/swc_css_parser/benches/compare.rs::benches::bench_cases

5.1 ms5.1 ms

es/visitor/compare/fold_span_panic

crates/swc_ecma_parser/benches/compare.rs::benches::bench_cases

6.8 ms6.8 ms

html/document_fragment/visitor/compare/fold_span

crates/swc_html_parser/benches/compare.rs::benches::bench_cases

1.2 ms1.2 ms

es/resolver_with_hygiene/typescript

crates/swc_ecma_transforms_base/benches/base.rs::benches::bench_cases

747 ms747.1 ms

css/lexer/foundation_6_7_4

crates/swc_css_parser/benches/lexer.rs::benches::bench_files

9 ms9 ms

es/lints/libs/jquery

crates/swc_ecma_lints/benches/all.rs::files::bench_files::es/lints/libs

6.5 ms6.5 ms

html/document/visitor/compare/visit_mut_span

crates/swc_html_parser/benches/compare.rs::benches::bench_cases

1.1 ms1.1 ms

html/document/visitor/compare/fold_span

crates/swc_html_parser/benches/compare.rs::benches::bench_cases

1.2 ms1.2 ms

es/resolver/typescript

crates/swc_ecma_transforms_base/benches/base.rs::benches::bench_cases

243.4 ms243.4 ms

html/document_fragment/visitor/compare/visit_mut_span

crates/swc_html_parser/benches/compare.rs::benches::bench_cases

1.1 ms1.1 ms

es/parser/jquery mobile

crates/swc_ecma_parser/benches/parser.rs::benches::bench_files

21.8 ms21.8 ms

es/parser/three

crates/swc_ecma_parser/benches/parser.rs::benches::bench_files

67.6 ms67.6 ms

es/minifier/libs/moment

crates/swc_ecma_minifier/benches/full.rs::bench_all::bench_libs::es/minifier/libs

62.9 ms62.9 ms

css/visitor/compare/visit_mut_span

crates/swc_css_parser/benches/compare.rs::benches::bench_cases

5.1 ms5.1 ms

es/minifier/libs/vue

crates/swc_ecma_minifier/benches/full.rs::bench_all::bench_libs::es/minifier/libs

143.5 ms143.5 ms

es/parser/colors

crates/swc_ecma_parser/benches/parser.rs::benches::bench_files

81.6 µs81.6 µs

es2015_typeof_symbol

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

275.9 µs275.9 µs

html/document/visitor/compare/fold_span_panic

crates/swc_html_parser/benches/compare.rs::benches::bench_cases

1.2 ms1.2 ms

es/lints/libs/lodash

crates/swc_ecma_lints/benches/all.rs::files::bench_files::es/lints/libs

6.2 ms6.2 ms

css/visitor/compare/clone

crates/swc_css_parser/benches/compare.rs::benches::bench_cases

4.8 ms4.8 ms

es/parser/underscore

crates/swc_ecma_parser/benches/parser.rs::benches::bench_files

2.4 ms2.4 ms

es/parser/angular

crates/swc_ecma_parser/benches/parser.rs::benches::bench_files

17.7 ms17.7 ms

html/document_fragment/visitor/compare/visit_mut_span_panic

crates/swc_html_parser/benches/compare.rs::benches::bench_cases

1.1 ms1.1 ms

html/document/visitor/compare/visit_mut_span_panic

crates/swc_html_parser/benches/compare.rs::benches::bench_cases

1.1 ms1.1 ms

es/minifier/libs/react

crates/swc_ecma_minifier/benches/full.rs::bench_all::bench_libs::es/minifier/libs

19.6 ms19.6 ms

es/fixer/typescript

crates/swc_ecma_transforms_base/benches/base.rs::benches::bench_cases

201.8 ms201.9 ms

es/parser/backbone

crates/swc_ecma_parser/benches/parser.rs::benches::bench_files

2.7 ms2.7 ms

es/minifier/libs/echarts

crates/swc_ecma_minifier/benches/full.rs::bench_all::bench_libs::es/minifier/libs

1.5 s1.5 s

es/lexer/three

crates/swc_ecma_parser/benches/lexer.rs::benches::bench_files

18.3 ms18.3 ms

es/parser/jquery

crates/swc_ecma_parser/benches/parser.rs::benches::bench_files

14.1 ms14.1 ms

es/parser/mootools

crates/swc_ecma_parser/benches/parser.rs::benches::bench_files

11 ms11 ms

es/minifier/libs/lodash

crates/swc_ecma_minifier/benches/full.rs::bench_all::bench_libs::es/minifier/libs

114.4 ms114.5 ms

es/lexer/colors

crates/swc_ecma_parser/benches/lexer.rs::benches::bench_files

26.3 µs26.3 µs

es/minifier/libs/three

crates/swc_ecma_minifier/benches/full.rs::bench_all::bench_libs::es/minifier/libs

646.5 ms647.2 ms

es/parser/yui

crates/swc_ecma_parser/benches/parser.rs::benches::bench_files

10.9 ms10.9 ms

es/minifier/libs/jquery

crates/swc_ecma_minifier/benches/full.rs::bench_all::bench_libs::es/minifier/libs

97.1 ms97.3 ms

es/minifier/libs/typescript

crates/swc_ecma_minifier/benches/full.rs::bench_all::bench_libs::es/minifier/libs

3.8 s3.8 s

es/preset-env/usage/builtin_type

crates/swc_ecma_preset_env/benches/polyfills.rs::benches::bench_cases

243.2 µs244.4 µs

es/codegen/with-parser/colors

crates/swc_ecma_codegen/benches/with_parse.rs::benches::bench_cases

156.9 µs157.7 µs

es/preset-env/usage/property

crates/swc_ecma_preset_env/benches/polyfills.rs::benches::bench_cases

-1%

112.9 µs114.3 µs

Ignored

es/preset-env/entry/import

crates/swc_ecma_preset_env/benches/polyfills.rs::benches::bench_cases

Ignored

-1%

29.2 µs29.6 µs

Commits

Click on a commit to change the comparison range

Base

main

58a9d81

+0.01%

fix(lexer): Handle unrecognized escape sequences correctly Fixes #11214 This commit fixes a bug in the ECMAScript lexer where Windows file paths with backslashes were being inconsistently escaped in the AST's value field for string literals. The issue occurred when a backslash preceded a character that doesn't form a valid escape sequence (like `\s` in `spec\util`). According to ECMAScript specification, when a backslash precedes a character that doesn't form a valid escape sequence, both the backslash and the character should be preserved in the string value. Changes: - Added explicit handling for `\'` and `\"` as valid escape sequences - Modified the catch-all case in `read_escaped_char` to return the backslash character and not consume the following character for unrecognized escapes - Added comprehensive tests for Windows paths and unrecognized escape sequences Test cases: - `issue_11214_windows_path_escape`: Tests Windows file paths with backslashes - `issue_11214_unrecognized_escape_sequences`: Tests various unrecognized escape sequences like `\s`, `\g`, `\a` All existing tests continue to pass, confirming no regressions. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>

46fdbb3

20 days ago

by github-actions[bot]

Add strict mode and template literal error handling for unrecognized escape sequences This commit addresses the PR review feedback to properly handle unrecognized escape sequences according to ECMAScript specification: - In template literals: unrecognized escape sequences are always syntax errors - In strict mode: unrecognized escape sequences are syntax errors - In non-strict mode: unrecognized escape sequences preserve the backslash The implementation follows the same pattern used for octal escape sequences, ensuring consistent error handling behavior across the lexer. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>

d03ae7a

5 days ago

by github-actions[bot]

Home Terms Privacy Docs