devbird/fix-es3-reserved-word-syntaxcontext - Branch - swc-project/swc

fix(es/compat): Preserve SyntaxContext in ES3 reserved word transformation

#11330

Comparing

devbird/fix-es3-reserved-word-syntaxcontext

(

7b5ceeb

) with

main

(

583619d

)

Untouched: 138

Ignored: 1

Benchmarks

Passed

es/minifier/libs/d3

crates/swc_ecma_minifier/benches/full.rs::bench_all::bench_libs::es/minifier/libs

+1%

397.1 ms395 ms

es/lexer/typescript

crates/swc_ecma_parser/benches/lexer.rs::benches::bench_files

107 ms106.9 ms

es/transform/baseline/common_typescript

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::baseline_group

371.2 µs370.8 µs

es/minifier/libs/victory

crates/swc_ecma_minifier/benches/full.rs::bench_all::bench_libs::es/minifier/libs

854.3 ms853.5 ms

es/parser/yui

crates/swc_ecma_parser/benches/parser.rs::benches::bench_files

10.7 ms10.6 ms

es2022_class_properties

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

384.5 µs384.3 µs

es/codegen/with-parser/colors

crates/swc_ecma_codegen/benches/with_parse.rs::benches::bench_cases

157.1 µs157 µs

github

crates/swc_html_minifier/benches/full.rs::files_document::bench_files_document::html/minify/document

42.3 ms42.3 ms

es/minifier/libs/moment

crates/swc_ecma_minifier/benches/full.rs::bench_all::bench_libs::es/minifier/libs

62.8 ms62.7 ms

css_spec

crates/swc_html_minifier/benches/full.rs::files_document_fragment::bench_files_document_fragment::html/minify/document_fragment

196.3 ms196.3 ms

es/lints/libs/react

crates/swc_ecma_lints/benches/all.rs::files::bench_files::es/lints/libs

1.3 ms1.3 ms

es2015_fn_name

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

281.2 µs281.1 µs

typescript/fast-strip

crates/swc_ts_fast_strip/benches/assets.rs::benches::fast_ts

420.1 µs419.9 µs

css/visitor/compare/visit_mut_span

crates/swc_css_parser/benches/compare.rs::benches::bench_cases

5.1 ms5.1 ms

es/lints/libs/antd

crates/swc_ecma_lints/benches/all.rs::files::bench_files::es/lints/libs

156.4 ms156.3 ms

es/lints/libs/moment

crates/swc_ecma_lints/benches/all.rs::files::bench_files::es/lints/libs

4.2 ms4.2 ms

css/visitor/compare/clone

crates/swc_css_parser/benches/compare.rs::benches::bench_cases

4.8 ms4.8 ms

es/lints/libs/vue

crates/swc_ecma_lints/benches/all.rs::files::bench_files::es/lints/libs

8.3 ms8.3 ms

css/visitor/compare/fold_span

crates/swc_css_parser/benches/compare.rs::benches::bench_cases

5.8 ms5.8 ms

es/parser/mootools

crates/swc_ecma_parser/benches/parser.rs::benches::bench_files

10.9 ms10.9 ms

github

crates/swc_html_minifier/benches/full.rs::files_document_fragment::bench_files_document_fragment::html/minify/document_fragment

41.7 ms41.7 ms

es/minifier/libs/vue

crates/swc_ecma_minifier/benches/full.rs::bench_all::bench_libs::es/minifier/libs

143.2 ms143.2 ms

es/resolver/typescript

crates/swc_ecma_transforms_base/benches/base.rs::benches::bench_cases

243.4 ms243.4 ms

html/document_fragment/visitor/compare/clone

crates/swc_html_parser/benches/compare.rs::benches::bench_cases

1 ms1 ms

es/lexer/jquery

crates/swc_ecma_parser/benches/lexer.rs::benches::bench_files

4.5 ms4.5 ms

es/parser/typescript

crates/swc_ecma_parser/benches/parser.rs::benches::bench_files

375.4 ms375.3 ms

html/parser/parser_document/css_2021_spec

crates/swc_html_parser/benches/parser.rs::benches::bench_files

72.3 ms72.2 ms

html/document_fragment/visitor/compare/fold_span_panic

crates/swc_html_parser/benches/compare.rs::benches::bench_cases

1.2 ms1.2 ms

es/lints/libs/jquery

crates/swc_ecma_lints/benches/all.rs::files::bench_files::es/lints/libs

6.5 ms6.5 ms

html/parser/parser_document_fragment/css_2021_spec

crates/swc_html_parser/benches/parser.rs::benches::bench_files

71.9 ms71.9 ms

css/lexer/foundation_6_7_4

crates/swc_css_parser/benches/lexer.rs::benches::bench_files

9 ms9 ms

html/document_fragment/visitor/compare/visit_mut_span_panic

crates/swc_html_parser/benches/compare.rs::benches::bench_cases

1.1 ms1.1 ms

es/lints/libs/lodash

crates/swc_ecma_lints/benches/all.rs::files::bench_files::es/lints/libs

6.2 ms6.2 ms

es/visitor/compare/fold_span

crates/swc_ecma_parser/benches/compare.rs::benches::bench_cases

6.8 ms6.8 ms

es/minifier/libs/typescript

crates/swc_ecma_minifier/benches/full.rs::bench_all::bench_libs::es/minifier/libs

3.8 s3.8 s

html/document/visitor/compare/visit_mut_span_panic

crates/swc_html_parser/benches/compare.rs::benches::bench_cases

1.1 ms1.1 ms

css/visitor/compare/fold_span_panic

crates/swc_css_parser/benches/compare.rs::benches::bench_cases

5.8 ms5.8 ms

es/codegen/with-parser/large

crates/swc_ecma_codegen/benches/with_parse.rs::benches::bench_cases

1.1 ms1.1 ms

es/lexer/underscore

crates/swc_ecma_parser/benches/lexer.rs::benches::bench_files

707.1 µs707.1 µs

es/resolver_with_hygiene/typescript

crates/swc_ecma_transforms_base/benches/base.rs::benches::bench_cases

747 ms746.9 ms

es2015_arrow

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

299.8 µs299.8 µs

es/codegen/colors

crates/swc_ecma_codegen/benches/bench.rs::benches::bench_cases

67.9 µs67.9 µs

html/document_fragment/visitor/compare/fold_span

crates/swc_html_parser/benches/compare.rs::benches::bench_cases

1.2 ms1.2 ms

css/visitor/compare/visit_mut_span_panic

crates/swc_css_parser/benches/compare.rs::benches::bench_cases

5.1 ms5.1 ms

parse_and_babelify_underscore

crates/swc_estree_compat/benches/babelify.rs::benches::bench_cases

13.1 ms13.1 ms

html/document/visitor/compare/clone

crates/swc_html_parser/benches/compare.rs::benches::bench_cases

1 ms1 ms

css/lexer/bootstrap_5_1_3

crates/swc_css_parser/benches/lexer.rs::benches::bench_files

11 ms11 ms

css/lexer/tailwind_3_1_1

crates/swc_css_parser/benches/lexer.rs::benches::bench_files

1.8 ms1.8 ms

es/lexer/angular

crates/swc_ecma_parser/benches/lexer.rs::benches::bench_files

5.9 ms5.9 ms

html/document/visitor/compare/visit_mut_span

crates/swc_html_parser/benches/compare.rs::benches::bench_cases

1.1 ms1.1 ms

es/lexer/jquery mobile

crates/swc_ecma_parser/benches/lexer.rs::benches::bench_files

6.8 ms6.8 ms

parse_and_babelify_jquery

crates/swc_estree_compat/benches/babelify.rs::benches::bench_cases

99.3 ms99.3 ms

parse_and_babelify_angular

crates/swc_estree_compat/benches/babelify.rs::benches::bench_cases

159.8 ms159.8 ms

es/visitor/compare/clone

crates/swc_ecma_parser/benches/compare.rs::benches::bench_cases

5.5 ms5.5 ms

parse_and_babelify_backbone

crates/swc_estree_compat/benches/babelify.rs::benches::bench_cases

15.4 ms15.4 ms

html/lexer/github_com_17_05_2022

crates/swc_html_parser/benches/lexer.rs::benches::bench_files

14.4 ms14.4 ms

parse_and_babelify_mootools

crates/swc_estree_compat/benches/babelify.rs::benches::bench_cases

72.6 ms72.6 ms

es2019_optional_catch_binding

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

272.1 µs272.1 µs

es2015_computed_props

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

274 µs274 µs

parse_and_babelify_yui

crates/swc_estree_compat/benches/babelify.rs::benches::bench_cases

67.4 ms67.4 ms

html/document_fragment/visitor/compare/visit_mut_span

crates/swc_html_parser/benches/compare.rs::benches::bench_cases

1.1 ms1.1 ms

html/document/visitor/compare/fold_span

crates/swc_html_parser/benches/compare.rs::benches::bench_cases

1.2 ms1.2 ms

html/lexer/css_2021_spec

crates/swc_html_parser/benches/lexer.rs::benches::bench_files

40 ms40 ms

html/document/visitor/compare/fold_span_panic

crates/swc_html_parser/benches/compare.rs::benches::bench_cases

1.2 ms1.2 ms

html/lexer/stackoverflow_com_17_05_2022

crates/swc_html_parser/benches/lexer.rs::benches::bench_files

14.5 ms14.5 ms

html/parser/parser_document/stackoverflow_com_17_05_2022

crates/swc_html_parser/benches/parser.rs::benches::bench_files

22.7 ms22.7 ms

parse_and_babelify_jquery_mobile

crates/swc_estree_compat/benches/babelify.rs::benches::bench_cases

169.7 ms169.7 ms

es/visitor/compare/visit_mut_span

crates/swc_ecma_parser/benches/compare.rs::benches::bench_cases

6 ms6 ms

es/lexer/cal-com

crates/swc_ecma_parser/benches/lexer.rs::benches::bench_files

13 ms13 ms

es/target/es2020

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::version_group

464.3 µs464.3 µs

es/parser/jquery mobile

crates/swc_ecma_parser/benches/parser.rs::benches::bench_files

21.6 ms21.6 ms

css/parser/foundation_6_7_4

crates/swc_css_parser/benches/parser.rs::benches::bench_files

37 ms37 ms

es/lints/libs/victory

crates/swc_ecma_lints/benches/all.rs::files::bench_files::es/lints/libs

70.7 ms70.8 ms

babelify-only

crates/swc_estree_compat/benches/babelify.rs::benches::bench_cases

2.1 ms2.1 ms

html/parser/parser_document_fragment/stackoverflow_com_17_05_2022

crates/swc_html_parser/benches/parser.rs::benches::bench_files

22.6 ms22.6 ms

es/visitor/compare/visit_mut_span_panic

crates/swc_ecma_parser/benches/compare.rs::benches::bench_cases

6 ms6 ms

es2020_optional_chaining

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

338.1 µs338.1 µs

es2015_block_scoped_fn

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

292.1 µs292.1 µs

html/parser/parser_document_fragment/github_com_17_05_2022

crates/swc_html_parser/benches/parser.rs::benches::bench_files

22.5 ms22.5 ms

es/lexer/yui

crates/swc_ecma_parser/benches/lexer.rs::benches::bench_files

3.7 ms3.7 ms

css/parser/tailwind_3_1_1

crates/swc_css_parser/benches/parser.rs::benches::bench_files

7.2 ms7.2 ms

es/lexer/mootools

crates/swc_ecma_parser/benches/lexer.rs::benches::bench_files

3.4 ms3.4 ms

es2020_nullish_coalescing

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

291.5 µs291.5 µs

es/visitor/compare/fold_span_panic

crates/swc_ecma_parser/benches/compare.rs::benches::bench_cases

6.8 ms6.8 ms

es/parser/three

crates/swc_ecma_parser/benches/parser.rs::benches::bench_files

66.9 ms66.9 ms

css/parser/bootstrap_5_1_3

crates/swc_css_parser/benches/parser.rs::benches::bench_files

46.5 ms46.5 ms

html/parser/parser_document/github_com_17_05_2022

crates/swc_html_parser/benches/parser.rs::benches::bench_files

22.5 ms22.5 ms

es/lexer/backbone

crates/swc_ecma_parser/benches/lexer.rs::benches::bench_files

831.3 µs831.4 µs

es/parser/backbone

crates/swc_ecma_parser/benches/parser.rs::benches::bench_files

2.7 ms2.7 ms

es/parser/colors

crates/swc_ecma_parser/benches/parser.rs::benches::bench_files

81.5 µs81.5 µs

es2015_classes

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

391.1 µs391.2 µs

es/parser/jquery

crates/swc_ecma_parser/benches/parser.rs::benches::bench_files

13.9 ms13.9 ms

css_spec

crates/swc_html_minifier/benches/full.rs::files_document::bench_files_document::html/minify/document

196.5 ms196.5 ms

es/codegen/large

crates/swc_ecma_codegen/benches/bench.rs::benches::bench_cases

639.4 µs639.6 µs

es2015_instanceof

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

278.6 µs278.6 µs

es/lints/libs/echarts

crates/swc_ecma_lints/benches/all.rs::files::bench_files::es/lints/libs

114.3 ms114.3 ms

es/parser/underscore

crates/swc_ecma_parser/benches/parser.rs::benches::bench_files

2.3 ms2.3 ms

es2015_typeof_symbol

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

276.1 µs276.1 µs

es/lints/libs/typescript

crates/swc_ecma_lints/benches/all.rs::files::bench_files::es/lints/libs

276.3 ms276.4 ms

es2015_for_of

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

293.6 µs293.7 µs

es/transform/baseline/common_reserved_word

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::baseline_group

278.3 µs278.4 µs

es/minifier/libs/jquery

crates/swc_ecma_minifier/benches/full.rs::bench_all::bench_libs::es/minifier/libs

96.9 ms97 ms

es/transform/baseline/base

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::baseline_group

259.9 µs260.1 µs

es/fixer/typescript

crates/swc_ecma_transforms_base/benches/base.rs::benches::bench_cases

201.7 ms201.8 ms

es/lexer/three

crates/swc_ecma_parser/benches/lexer.rs::benches::bench_files

18 ms18 ms

es/full-target/es2017

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::full_group

553.5 µs553.8 µs

stackoverflow

crates/swc_html_minifier/benches/full.rs::files_document::bench_files_document::html/minify/document

36.2 ms36.2 ms

es2016_exponentiation

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

292.1 µs292.3 µs

es/parser/angular

crates/swc_ecma_parser/benches/parser.rs::benches::bench_files

17.1 ms17.1 ms

es/full-target/es2018

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::full_group

534.7 µs535 µs

es2015_block_scoping

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

456.2 µs456.5 µs

stackoverflow

crates/swc_html_minifier/benches/full.rs::files_document_fragment::bench_files_document_fragment::html/minify/document_fragment

37.4 ms37.5 ms

es2015_parameters

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

332.4 µs332.6 µs

es2015_duplicate_keys

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

281.1 µs281.3 µs

es/target/es2016

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::version_group

292 µs292.2 µs

es/minifier/libs/three

crates/swc_ecma_minifier/benches/full.rs::bench_all::bench_libs::es/minifier/libs

646.4 ms647 ms

es/minifier/libs/react

crates/swc_ecma_minifier/benches/full.rs::bench_all::bench_libs::es/minifier/libs

19.6 ms19.6 ms

es2015_destructuring

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

345.7 µs346 µs

es/full-target/es2016

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::full_group

588.8 µs589.3 µs

es/parser/cal-com

crates/swc_ecma_parser/benches/parser.rs::benches::bench_files

56.2 ms56.2 ms

es/lexer/colors

crates/swc_ecma_parser/benches/lexer.rs::benches::bench_files

25.8 µs25.9 µs

es2015_shorthand_property

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

274.5 µs274.8 µs

es/target/es2015

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::version_group

1.2 ms1.2 ms

es2018_object_rest_spread

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

290.8 µs291.2 µs

es2015_sticky_regex

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

274 µs274.4 µs

es/target/es3

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::version_group

398.6 µs399.2 µs

es2015_spread

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

273.1 µs273.5 µs

es/minifier/libs/lodash

crates/swc_ecma_minifier/benches/full.rs::bench_all::bench_libs::es/minifier/libs

114 ms114.2 ms

es/minifier/libs/antd

crates/swc_ecma_minifier/benches/full.rs::bench_all::bench_libs::es/minifier/libs

1.9 s1.9 s

es2017_async_to_generator

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

277 µs277.5 µs

es/hygiene/typescript

crates/swc_ecma_transforms_base/benches/base.rs::benches::bench_cases

422.6 ms423.4 ms

es/target/es2017

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::version_group

276 µs276.5 µs

es/lints/libs/three

crates/swc_ecma_lints/benches/all.rs::files::bench_files::es/lints/libs

50.3 ms50.4 ms

es/minifier/libs/echarts

crates/swc_ecma_minifier/benches/full.rs::bench_all::bench_libs::es/minifier/libs

1.5 s1.5 s

es/target/es2018

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::version_group

315.4 µs316.1 µs

es/preset-env/usage/builtin_type

crates/swc_ecma_preset_env/benches/polyfills.rs::benches::bench_cases

245.5 µs246.1 µs

es/preset-env/usage/property

crates/swc_ecma_preset_env/benches/polyfills.rs::benches::bench_cases

114.1 µs114.4 µs

es/minifier/libs/terser

crates/swc_ecma_minifier/benches/full.rs::bench_all::bench_libs::es/minifier/libs

347.5 ms349.1 ms

Ignored

es/preset-env/entry/import

crates/swc_ecma_preset_env/benches/polyfills.rs::benches::bench_cases

Ignored

-1%

29.4 µs29.7 µs

Commits

Click on a commit to change the comparison range

Base

main

583619d

-0.03%

fix(es/compat): Preserve SyntaxContext in ES3 reserved word transformation This commit improves the ES3 reserved word transformation pass to use the explicit `with_prefix` method when renaming identifiers, ensuring that the SyntaxContext field is preserved properly. ## Background The ES3 reserved word pass renames identifiers that are reserved in ES3 (like `char`, `byte`, `int`, etc.) by prefixing them with underscore to avoid conflicts in ES3 environments. Previously, the code directly modified the `sym` field: `i.sym = format!("_{}", i.sym).into()`. While this did preserve the `ctxt` field implicitly, it was not as explicit and clear as using the dedicated `with_prefix` method. ## Changes - Use `Ident::with_prefix("_")` instead of direct `sym` field modification - Add comprehensive test cases covering: - Multiple reserved words in exports (nextjs_issue_86076 test) - Mixed export syntax with function, const, and class - Multiple reserved words exported together - Variable declarations with reserved words ## Testing All existing tests pass, and new tests verify the transformation works correctly for various scenarios including the Next.js issue #86076 case. Related: vercel/next.js#86076 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>

7b5ceeb

3 hours ago

by github-actions[bot]

Home Terms Privacy Docs