claude/issue-11167-20251118-1636 - Branch - swc-project/swc

fix(es/codegen): Restore missing top-level comments

#11302

Comparing

claude/issue-11167-20251118-1636

(

68772aa

) with

main

(

c1e32fa

)

Untouched: 138

Ignored: 1

No successful run was found on main ( 0fc7496) during the generation of this report, so c1e32fa was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

Benchmarks

Passed

es/codegen/colors

crates/swc_ecma_codegen/benches/bench.rs::benches::bench_cases

+1%

68.3 µs67.9 µs

es/preset-env/usage/property

crates/swc_ecma_preset_env/benches/polyfills.rs::benches::bench_cases

+1%

114.2 µs113.7 µs

es/lints/libs/three

crates/swc_ecma_lints/benches/all.rs::files::bench_files::es/lints/libs

50.5 ms50.2 ms

es/minifier/libs/three

crates/swc_ecma_minifier/benches/full.rs::bench_all::bench_libs::es/minifier/libs

647.7 ms644.7 ms

es/resolver_with_hygiene/typescript

crates/swc_ecma_transforms_base/benches/base.rs::benches::bench_cases

746.9 ms743.9 ms

es/preset-env/usage/builtin_type

crates/swc_ecma_preset_env/benches/polyfills.rs::benches::bench_cases

244.2 µs243.4 µs

es/codegen/with-parser/colors

crates/swc_ecma_codegen/benches/with_parse.rs::benches::bench_cases

157.6 µs157.1 µs

es/minifier/libs/react

crates/swc_ecma_minifier/benches/full.rs::bench_all::bench_libs::es/minifier/libs

19.6 ms19.6 ms

es/minifier/libs/d3

crates/swc_ecma_minifier/benches/full.rs::bench_all::bench_libs::es/minifier/libs

397.1 ms396.5 ms

es/minifier/libs/antd

crates/swc_ecma_minifier/benches/full.rs::bench_all::bench_libs::es/minifier/libs

1.9 s1.9 s

es/codegen/with-parser/large

crates/swc_ecma_codegen/benches/with_parse.rs::benches::bench_cases

1.2 ms1.2 ms

es/minifier/libs/moment

crates/swc_ecma_minifier/benches/full.rs::bench_all::bench_libs::es/minifier/libs

62.9 ms62.9 ms

es/codegen/large

crates/swc_ecma_codegen/benches/bench.rs::benches::bench_cases

639.5 µs639.2 µs

stackoverflow

crates/swc_html_minifier/benches/full.rs::files_document::bench_files_document::html/minify/document

36.2 ms36.2 ms

es/lints/libs/moment

crates/swc_ecma_lints/benches/all.rs::files::bench_files::es/lints/libs

4.2 ms4.2 ms

es/lints/libs/echarts

crates/swc_ecma_lints/benches/all.rs::files::bench_files::es/lints/libs

114.3 ms114.2 ms

es/parser/colors

crates/swc_ecma_parser/benches/parser.rs::benches::bench_files

81.6 µs81.5 µs

es/lints/libs/antd

crates/swc_ecma_lints/benches/all.rs::files::bench_files::es/lints/libs

156.4 ms156.3 ms

html/document/visitor/compare/clone

crates/swc_html_parser/benches/compare.rs::benches::bench_cases

1 ms1 ms

css_spec

crates/swc_html_minifier/benches/full.rs::files_document_fragment::bench_files_document_fragment::html/minify/document_fragment

196.3 ms196.2 ms

es/parser/angular

crates/swc_ecma_parser/benches/parser.rs::benches::bench_files

17.7 ms17.7 ms

es/parser/jquery mobile

crates/swc_ecma_parser/benches/parser.rs::benches::bench_files

21.8 ms21.8 ms

css/parser/bootstrap_5_1_3

crates/swc_css_parser/benches/parser.rs::benches::bench_files

46.5 ms46.5 ms

html/document_fragment/visitor/compare/fold_span_panic

crates/swc_html_parser/benches/compare.rs::benches::bench_cases

1.2 ms1.2 ms

es/lints/libs/react

crates/swc_ecma_lints/benches/all.rs::files::bench_files::es/lints/libs

1.3 ms1.3 ms

html/document_fragment/visitor/compare/clone

crates/swc_html_parser/benches/compare.rs::benches::bench_cases

1 ms1 ms

es/lexer/typescript

crates/swc_ecma_parser/benches/lexer.rs::benches::bench_files

107.7 ms107.7 ms

stackoverflow

crates/swc_html_minifier/benches/full.rs::files_document_fragment::bench_files_document_fragment::html/minify/document_fragment

37.5 ms37.5 ms

babelify-only

crates/swc_estree_compat/benches/babelify.rs::benches::bench_cases

2.1 ms2.1 ms

github

crates/swc_html_minifier/benches/full.rs::files_document::bench_files_document::html/minify/document

42.3 ms42.3 ms

es/visitor/compare/visit_mut_span

crates/swc_ecma_parser/benches/compare.rs::benches::bench_cases

6 ms6 ms

es/minifier/libs/echarts

crates/swc_ecma_minifier/benches/full.rs::bench_all::bench_libs::es/minifier/libs

1.5 s1.5 s

es/visitor/compare/visit_mut_span_panic

crates/swc_ecma_parser/benches/compare.rs::benches::bench_cases

6 ms6 ms

html/document/visitor/compare/visit_mut_span

crates/swc_html_parser/benches/compare.rs::benches::bench_cases

1.1 ms1.1 ms

es/visitor/compare/fold_span_panic

crates/swc_ecma_parser/benches/compare.rs::benches::bench_cases

6.8 ms6.8 ms

es2015_sticky_regex

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

273.8 µs273.8 µs

es/minifier/libs/jquery

crates/swc_ecma_minifier/benches/full.rs::bench_all::bench_libs::es/minifier/libs

97.1 ms97.1 ms

es/full-target/es2017

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::full_group

542.4 µs542.4 µs

css_spec

crates/swc_html_minifier/benches/full.rs::files_document::bench_files_document::html/minify/document

196.5 ms196.5 ms

typescript/fast-strip

crates/swc_ts_fast_strip/benches/assets.rs::benches::fast_ts

420.1 µs420.1 µs

es/full-target/es2016

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::full_group

577.9 µs577.9 µs

github

crates/swc_html_minifier/benches/full.rs::files_document_fragment::bench_files_document_fragment::html/minify/document_fragment

41.7 ms41.7 ms

css/lexer/bootstrap_5_1_3

crates/swc_css_parser/benches/lexer.rs::benches::bench_files

11 ms11 ms

css/visitor/compare/fold_span_panic

crates/swc_css_parser/benches/compare.rs::benches::bench_cases

5.8 ms5.8 ms

es2015_instanceof

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

278.3 µs278.3 µs

es/minifier/libs/lodash

crates/swc_ecma_minifier/benches/full.rs::bench_all::bench_libs::es/minifier/libs

114.6 ms114.6 ms

es/transform/baseline/common_reserved_word

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::baseline_group

278.1 µs278.1 µs

es2015_for_of

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

293.7 µs293.7 µs

html/parser/parser_document_fragment/css_2021_spec

crates/swc_html_parser/benches/parser.rs::benches::bench_files

71.9 ms71.9 ms

es/lexer/angular

crates/swc_ecma_parser/benches/lexer.rs::benches::bench_files

6.6 ms6.6 ms

es/target/es2017

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::version_group

276.1 µs276.1 µs

es2015_classes

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

390.9 µs390.9 µs

es/lexer/mootools

crates/swc_ecma_parser/benches/lexer.rs::benches::bench_files

3.6 ms3.6 ms

es2015_parameters

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

332.6 µs332.6 µs

es/transform/baseline/base

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::baseline_group

259.8 µs259.8 µs

es2015_shorthand_property

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

274.4 µs274.4 µs

es/target/es2016

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::version_group

291.8 µs291.8 µs

es2020_optional_chaining

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

338 µs338 µs

es/full-target/es2018

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::full_group

523.4 µs523.4 µs

es2018_object_rest_spread

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

290.7 µs290.7 µs

html/lexer/css_2021_spec

crates/swc_html_parser/benches/lexer.rs::benches::bench_files

40 ms40 ms

html/lexer/github_com_17_05_2022

crates/swc_html_parser/benches/lexer.rs::benches::bench_files

14.4 ms14.4 ms

es2015_duplicate_keys

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

281.1 µs281.1 µs

es2019_optional_catch_binding

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

271.9 µs271.9 µs

es/target/es2018

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::version_group

309.9 µs309.9 µs

es/lexer/jquery

crates/swc_ecma_parser/benches/lexer.rs::benches::bench_files

4.6 ms4.6 ms

es/lexer/colors

crates/swc_ecma_parser/benches/lexer.rs::benches::bench_files

26.3 µs26.3 µs

es/lexer/cal-com

crates/swc_ecma_parser/benches/lexer.rs::benches::bench_files

13.1 ms13.1 ms

es/visitor/compare/fold_span

crates/swc_ecma_parser/benches/compare.rs::benches::bench_cases

6.8 ms6.8 ms

es/lexer/yui

crates/swc_ecma_parser/benches/lexer.rs::benches::bench_files

4 ms4 ms

es/lexer/jquery mobile

crates/swc_ecma_parser/benches/lexer.rs::benches::bench_files

7.2 ms7.2 ms

html/document/visitor/compare/fold_span

crates/swc_html_parser/benches/compare.rs::benches::bench_cases

1.2 ms1.2 ms

es/lints/libs/victory

crates/swc_ecma_lints/benches/all.rs::files::bench_files::es/lints/libs

70.7 ms70.7 ms

es2017_async_to_generator

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

277.1 µs277.1 µs

es/target/es2015

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::version_group

1.2 ms1.2 ms

html/parser/parser_document/stackoverflow_com_17_05_2022

crates/swc_html_parser/benches/parser.rs::benches::bench_files

22.7 ms22.7 ms

es/lexer/backbone

crates/swc_ecma_parser/benches/lexer.rs::benches::bench_files

875.5 µs875.5 µs

html/lexer/stackoverflow_com_17_05_2022

crates/swc_html_parser/benches/lexer.rs::benches::bench_files

14.5 ms14.5 ms

es2016_exponentiation

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

291.9 µs291.9 µs

es2022_class_properties

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

384.5 µs384.5 µs

es/transform/baseline/common_typescript

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::baseline_group

370.7 µs370.7 µs

es/lexer/underscore

crates/swc_ecma_parser/benches/lexer.rs::benches::bench_files

737.4 µs737.4 µs

css/visitor/compare/visit_mut_span_panic

crates/swc_css_parser/benches/compare.rs::benches::bench_cases

5.1 ms5.1 ms

es/visitor/compare/clone

crates/swc_ecma_parser/benches/compare.rs::benches::bench_cases

5.5 ms5.5 ms

es2015_block_scoped_fn

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

292.1 µs292.1 µs

es2015_computed_props

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

273.7 µs273.7 µs

es2015_arrow

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

299.4 µs299.4 µs

es2015_fn_name

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

280.9 µs280.9 µs

es/target/es3

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::version_group

398.6 µs398.6 µs

es2020_nullish_coalescing

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

291.4 µs291.4 µs

es2015_typeof_symbol

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

276 µs276 µs

es2015_block_scoping

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

456.8 µs456.8 µs

html/document_fragment/visitor/compare/fold_span

crates/swc_html_parser/benches/compare.rs::benches::bench_cases

1.2 ms1.2 ms

es2015_spread

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

273.1 µs273.2 µs

parse_and_babelify_jquery_mobile

crates/swc_estree_compat/benches/babelify.rs::benches::bench_cases

169.8 ms169.8 ms

es/hygiene/typescript

crates/swc_ecma_transforms_base/benches/base.rs::benches::bench_cases

422.5 ms422.5 ms

es/resolver/typescript

crates/swc_ecma_transforms_base/benches/base.rs::benches::bench_cases

243.4 ms243.4 ms

es/parser/mootools

crates/swc_ecma_parser/benches/parser.rs::benches::bench_files

11 ms11 ms

parse_and_babelify_angular

crates/swc_estree_compat/benches/babelify.rs::benches::bench_cases

160.3 ms160.4 ms

css/lexer/foundation_6_7_4

crates/swc_css_parser/benches/lexer.rs::benches::bench_files

9 ms9 ms

es/target/es2020

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::version_group

458.9 µs458.9 µs

es2015_destructuring

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

345.6 µs345.6 µs

css/lexer/tailwind_3_1_1

crates/swc_css_parser/benches/lexer.rs::benches::bench_files

1.8 ms1.8 ms

html/parser/parser_document/github_com_17_05_2022

crates/swc_html_parser/benches/parser.rs::benches::bench_files

22.5 ms22.5 ms

es/minifier/libs/typescript

crates/swc_ecma_minifier/benches/full.rs::bench_all::bench_libs::es/minifier/libs

3.8 s3.8 s

es/parser/underscore

crates/swc_ecma_parser/benches/parser.rs::benches::bench_files

2.4 ms2.4 ms

html/parser/parser_document_fragment/github_com_17_05_2022

crates/swc_html_parser/benches/parser.rs::benches::bench_files

22.5 ms22.5 ms

css/parser/tailwind_3_1_1

crates/swc_css_parser/benches/parser.rs::benches::bench_files

7.2 ms7.2 ms

es/lints/libs/vue

crates/swc_ecma_lints/benches/all.rs::files::bench_files::es/lints/libs

8.3 ms8.3 ms

es/parser/jquery

crates/swc_ecma_parser/benches/parser.rs::benches::bench_files

14.1 ms14.1 ms

html/document_fragment/visitor/compare/visit_mut_span

crates/swc_html_parser/benches/compare.rs::benches::bench_cases

1.1 ms1.1 ms

es/parser/typescript

crates/swc_ecma_parser/benches/parser.rs::benches::bench_files

379.7 ms379.7 ms

html/parser/parser_document/css_2021_spec

crates/swc_html_parser/benches/parser.rs::benches::bench_files

72.2 ms72.3 ms

parse_and_babelify_jquery

crates/swc_estree_compat/benches/babelify.rs::benches::bench_cases

99.4 ms99.4 ms

es/lexer/three

crates/swc_ecma_parser/benches/lexer.rs::benches::bench_files

18.3 ms18.3 ms

es/lints/libs/lodash

crates/swc_ecma_lints/benches/all.rs::files::bench_files::es/lints/libs

6.2 ms6.2 ms

css/visitor/compare/clone

crates/swc_css_parser/benches/compare.rs::benches::bench_cases

4.8 ms4.8 ms

es/parser/yui

crates/swc_ecma_parser/benches/parser.rs::benches::bench_files

10.9 ms10.9 ms

parse_and_babelify_mootools

crates/swc_estree_compat/benches/babelify.rs::benches::bench_cases

72.6 ms72.6 ms

css/visitor/compare/visit_mut_span

crates/swc_css_parser/benches/compare.rs::benches::bench_cases

5.1 ms5.1 ms

parse_and_babelify_underscore

crates/swc_estree_compat/benches/babelify.rs::benches::bench_cases

13.1 ms13.1 ms

css/visitor/compare/fold_span

crates/swc_css_parser/benches/compare.rs::benches::bench_cases

5.8 ms5.8 ms

html/parser/parser_document_fragment/stackoverflow_com_17_05_2022

crates/swc_html_parser/benches/parser.rs::benches::bench_files

22.6 ms22.6 ms

html/document/visitor/compare/visit_mut_span_panic

crates/swc_html_parser/benches/compare.rs::benches::bench_cases

1.1 ms1.1 ms

parse_and_babelify_backbone

crates/swc_estree_compat/benches/babelify.rs::benches::bench_cases

15.4 ms15.4 ms

parse_and_babelify_yui

crates/swc_estree_compat/benches/babelify.rs::benches::bench_cases

67.6 ms67.6 ms

es/fixer/typescript

crates/swc_ecma_transforms_base/benches/base.rs::benches::bench_cases

201.7 ms201.8 ms

es/parser/backbone

crates/swc_ecma_parser/benches/parser.rs::benches::bench_files

2.7 ms2.7 ms

es/lints/libs/jquery

crates/swc_ecma_lints/benches/all.rs::files::bench_files::es/lints/libs

6.5 ms6.5 ms

html/document/visitor/compare/fold_span_panic

crates/swc_html_parser/benches/compare.rs::benches::bench_cases

1.2 ms1.2 ms

html/document_fragment/visitor/compare/visit_mut_span_panic

crates/swc_html_parser/benches/compare.rs::benches::bench_cases

1.1 ms1.1 ms

css/parser/foundation_6_7_4

crates/swc_css_parser/benches/parser.rs::benches::bench_files

36.9 ms37 ms

es/lints/libs/typescript

crates/swc_ecma_lints/benches/all.rs::files::bench_files::es/lints/libs

276.3 ms276.4 ms

es/parser/three

crates/swc_ecma_parser/benches/parser.rs::benches::bench_files

67.6 ms67.6 ms

es/parser/cal-com

crates/swc_ecma_parser/benches/parser.rs::benches::bench_files

56.7 ms56.7 ms

es/minifier/libs/vue

crates/swc_ecma_minifier/benches/full.rs::bench_all::bench_libs::es/minifier/libs

143.6 ms143.8 ms

es/minifier/libs/victory

crates/swc_ecma_minifier/benches/full.rs::bench_all::bench_libs::es/minifier/libs

854 ms856.3 ms

es/minifier/libs/terser

crates/swc_ecma_minifier/benches/full.rs::bench_all::bench_libs::es/minifier/libs

-2%

349.3 ms355.6 ms

Ignored

es/preset-env/entry/import

crates/swc_ecma_preset_env/benches/polyfills.rs::benches::bench_cases

Ignored

+2%

29.5 µs28.8 µs

Commits

Click on a commit to change the comparison range

Base

main

c1e32fa

+0.01%

fix(es/codegen): Restore missing top-level comments This fixes an issue where top-level comments (like copyright headers) were being lost after PR #11199 changed Module/Script spans to start at position 0. The problem was that Module::emit() was taking and emitting all leading comments before any body items were processed. When helper imports were injected at the beginning, comments would either appear before them (wrong) or be lost entirely. The fix is to skip emitting leading comments at Module/Script level when the body is non-empty. Instead, comments are emitted by the first body item with a real source span. Injected imports have DUMMY_SP, so they skip comment emission, and the original source items emit their comments correctly after the imports. This ensures: - Comments appear after injected imports (maintains fix for #11167) - Comments are not lost (fixes regression from PR #11199) - Module span still starts at position 0 (maintains PR #11199 changes) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Donny/강동윤 <kdy1@users.noreply.github.com>

1aee3e5

6 hours ago

by github-actions[bot]

restore

68772aa

5 hours ago

by kdy1

Home Terms Privacy Docs