autodev/fix-ts-non-null-in-destructuring - Branch - swc-project/swc

fix(es/parser): Support TypeScript non-null assertion in destructuring assignment

#11168

Comparing

autodev/fix-ts-non-null-in-destructuring

(

8bd0128

) with

main

(

146c77c

)

Untouched: 140

Ignored: 1

Benchmarks

Passed

es/parser/colors

crates/swc_ecma_parser/benches/parser.rs::benches::bench_files

84.7 µs84.5 µs

es/minifier/libs/vue

crates/swc_ecma_minifier/benches/full.rs::bench_all::bench_libs::es/minifier/libs

140.4 ms140.1 ms

es/minifier/libs/echarts

crates/swc_ecma_minifier/benches/full.rs::bench_all::bench_libs::es/minifier/libs

1.5 s1.5 s

es/lexer/colors

crates/swc_ecma_lexer/benches/lexer.rs::benches::bench_files

35.9 µs35.9 µs

es/lints/libs/three

crates/swc_ecma_lints/benches/all.rs::files::bench_files::es/lints/libs

50.3 ms50.2 ms

es/parser/jquery mobile

crates/swc_ecma_parser/benches/parser.rs::benches::bench_files

23.6 ms23.6 ms

es/lints/libs/react

crates/swc_ecma_lints/benches/all.rs::files::bench_files::es/lints/libs

1.3 ms1.3 ms

es/parser/underscore

crates/swc_ecma_parser/benches/parser.rs::benches::bench_files

2.5 ms2.5 ms

html/parser/parser_document_fragment/css_2021_spec

crates/swc_html_parser/benches/parser.rs::benches::bench_files

71.4 ms71.4 ms

es/parser/backbone

crates/swc_ecma_parser/benches/parser.rs::benches::bench_files

2.9 ms2.9 ms

es/parser/typescript

crates/swc_ecma_parser/benches/parser.rs::benches::bench_files

402.8 ms402.6 ms

html/document/visitor/compare/clone

crates/swc_html_parser/benches/compare.rs::benches::bench_cases

1 ms1 ms

es/parser/angular

crates/swc_ecma_parser/benches/parser.rs::benches::bench_files

18.9 ms18.9 ms

es/parser/jquery

crates/swc_ecma_parser/benches/parser.rs::benches::bench_files

15.1 ms15.1 ms

es/minifier/libs/typescript

crates/swc_ecma_minifier/benches/full.rs::bench_all::bench_libs::es/minifier/libs

3.7 s3.7 s

resolver/typescript

crates/swc_ecma_transforms_base/benches/parallel.rs::benches::bench_cases::es/base/parallel

12.3 s12.3 s

es2015_duplicate_keys

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

281.2 µs281.1 µs

es/parser/yui

crates/swc_ecma_parser/benches/parser.rs::benches::bench_files

11.6 ms11.6 ms

es2015_instanceof

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

280.6 µs280.5 µs

es2015_sticky_regex

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

277.9 µs277.8 µs

es/lints/libs/typescript

crates/swc_ecma_lints/benches/all.rs::files::bench_files::es/lints/libs

276.1 ms276 ms

es2015_shorthand_property

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

274.1 µs274.1 µs

es2015_block_scoped_fn

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

289.7 µs289.6 µs

css/parser/bootstrap_5_1_3

crates/swc_css_parser/benches/parser.rs::benches::bench_files

46.8 ms46.8 ms

es/transform/baseline/common_reserved_word

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::baseline_group

285.1 µs285 µs

es2015_fn_name

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

282.3 µs282.3 µs

es/transform/baseline/common_typescript

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::baseline_group

364.3 µs364.2 µs

es2015_typeof_symbol

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

278.8 µs278.7 µs

html/document_fragment/visitor/compare/fold_span_panic

crates/swc_html_parser/benches/compare.rs::benches::bench_cases

1.2 ms1.2 ms

es/resolver/typescript

crates/swc_ecma_transforms_base/benches/base.rs::benches::bench_cases

244.3 ms244.2 ms

es/target/es2018

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::version_group

309.7 µs309.6 µs

html/parser/parser_document_fragment/github_com_17_05_2022

crates/swc_html_parser/benches/parser.rs::benches::bench_files

22.4 ms22.4 ms

es2015_classes

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

390 µs389.9 µs

es2015_parameters

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

331.6 µs331.6 µs

es/lints/libs/antd

crates/swc_ecma_lints/benches/all.rs::files::bench_files::es/lints/libs

156.1 ms156 ms

es/full-target/es2017

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::full_group

524.8 µs524.7 µs

es/parser/mootools

crates/swc_ecma_parser/benches/parser.rs::benches::bench_files

11.9 ms11.9 ms

es/codegen/with-parser/colors

crates/swc_ecma_codegen/benches/with_parse.rs::benches::bench_cases

156.2 µs156.2 µs

es2015_spread

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

274.7 µs274.6 µs

es/lints/libs/moment

crates/swc_ecma_lints/benches/all.rs::files::bench_files::es/lints/libs

4.2 ms4.2 ms

html/document_fragment/visitor/compare/clone

crates/swc_html_parser/benches/compare.rs::benches::bench_cases

1 ms1 ms

html/document/visitor/compare/fold_span_panic

crates/swc_html_parser/benches/compare.rs::benches::bench_cases

1.2 ms1.2 ms

es/lints/libs/lodash

crates/swc_ecma_lints/benches/all.rs::files::bench_files::es/lints/libs

6.2 ms6.2 ms

es/transform/baseline/base

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::baseline_group

260.8 µs260.8 µs

es2020_nullish_coalescing

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

298.8 µs298.8 µs

es/target/es2017

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::version_group

275.9 µs275.9 µs

es2020_optional_chaining

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

336.6 µs336.6 µs

es/minifier/libs/jquery

crates/swc_ecma_minifier/benches/full.rs::bench_all::bench_libs::es/minifier/libs

95 ms95 ms

html/parser/parser_document_fragment/stackoverflow_com_17_05_2022

crates/swc_html_parser/benches/parser.rs::benches::bench_files

22.3 ms22.3 ms

es/full-target/es2016

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::full_group

560.7 µs560.6 µs

html/document_fragment/visitor/compare/fold_span

crates/swc_html_parser/benches/compare.rs::benches::bench_cases

1.2 ms1.2 ms

es2017_async_to_generator

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

276.3 µs276.3 µs

es/target/es2020

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::version_group

445.7 µs445.7 µs

es2016_exponentiation

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

289.3 µs289.3 µs

es2022_class_properties

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

381.2 µs381.2 µs

es/hygiene/typescript

crates/swc_ecma_transforms_base/benches/base.rs::benches::bench_cases

425.6 ms425.6 ms

es2015_for_of

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

290.5 µs290.5 µs

es2015_arrow

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

302.8 µs302.8 µs

es2018_object_rest_spread

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

292.1 µs292.1 µs

es/target/es2015

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::version_group

1.2 ms1.2 ms

es2015_block_scoping

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

451.8 µs451.8 µs

es/lexer/jquery mobile

crates/swc_ecma_lexer/benches/lexer.rs::benches::bench_files

11.7 ms11.7 ms

es/target/es2016

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::version_group

290 µs290 µs

es/lexer/cal-com

crates/swc_ecma_lexer/benches/lexer.rs::benches::bench_files

29.5 ms29.5 ms

es2015_computed_props

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

274.6 µs274.6 µs

es/full-target/es2018

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::full_group

508.2 µs508.2 µs

es/lexer/angular

crates/swc_ecma_lexer/benches/lexer.rs::benches::bench_files

10.1 ms10.1 ms

es2019_optional_catch_binding

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

274 µs274 µs

css/lexer/tailwind_3_1_1

crates/swc_css_parser/benches/lexer.rs::benches::bench_files

1.6 ms1.6 ms

es/lexer/three

crates/swc_ecma_lexer/benches/lexer.rs::benches::bench_files

36.2 ms36.2 ms

html/document/visitor/compare/visit_mut_span

crates/swc_html_parser/benches/compare.rs::benches::bench_cases

1.1 ms1.1 ms

html/lexer/css_2021_spec

crates/swc_html_parser/benches/lexer.rs::benches::bench_files

40.7 ms40.7 ms

es/lexer/mootools

crates/swc_ecma_lexer/benches/lexer.rs::benches::bench_files

6.1 ms6.1 ms

html/lexer/stackoverflow_com_17_05_2022

crates/swc_html_parser/benches/lexer.rs::benches::bench_files

14.7 ms14.7 ms

parse_and_babelify_jquery_mobile

crates/swc_estree_compat/benches/babelify.rs::benches::bench_cases

169 ms169 ms

html/lexer/github_com_17_05_2022

crates/swc_html_parser/benches/lexer.rs::benches::bench_files

14.6 ms14.6 ms

es/lexer/typescript

crates/swc_ecma_lexer/benches/lexer.rs::benches::bench_files

184.5 ms184.5 ms

css/visitor/compare/visit_mut_span

crates/swc_css_parser/benches/compare.rs::benches::bench_cases

5.1 ms5.1 ms

parse_and_babelify_backbone

crates/swc_estree_compat/benches/babelify.rs::benches::bench_cases

15.3 ms15.3 ms

es/lexer/yui

crates/swc_ecma_lexer/benches/lexer.rs::benches::bench_files

6.2 ms6.2 ms

es/target/es3

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::version_group

396 µs396.1 µs

es/minifier/libs/react

crates/swc_ecma_minifier/benches/full.rs::bench_all::bench_libs::es/minifier/libs

19.2 ms19.2 ms

css/lexer/bootstrap_5_1_3

crates/swc_css_parser/benches/lexer.rs::benches::bench_files

10 ms10 ms

css/parser/tailwind_3_1_1

crates/swc_css_parser/benches/parser.rs::benches::bench_files

7.2 ms7.2 ms

parse_and_babelify_angular

crates/swc_estree_compat/benches/babelify.rs::benches::bench_cases

157.5 ms157.5 ms

es/fixer/typescript

crates/swc_ecma_transforms_base/benches/base.rs::benches::bench_cases

202.7 ms202.7 ms

es/visitor/compare/fold_span_panic

crates/swc_ecma_parser/benches/compare.rs::benches::bench_cases

6.8 ms6.8 ms

es2015_destructuring

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

347.8 µs347.8 µs

es/lexer/jquery

crates/swc_ecma_lexer/benches/lexer.rs::benches::bench_files

7.7 ms7.7 ms

css/visitor/compare/fold_span

crates/swc_css_parser/benches/compare.rs::benches::bench_cases

5.7 ms5.7 ms

css/visitor/compare/visit_mut_span_panic

crates/swc_css_parser/benches/compare.rs::benches::bench_cases

5.1 ms5.1 ms

css/visitor/compare/fold_span_panic

crates/swc_css_parser/benches/compare.rs::benches::bench_cases

5.7 ms5.7 ms

html/parser/parser_document/stackoverflow_com_17_05_2022

crates/swc_html_parser/benches/parser.rs::benches::bench_files

22.4 ms22.4 ms

es/visitor/compare/fold_span

crates/swc_ecma_parser/benches/compare.rs::benches::bench_cases

6.8 ms6.8 ms

es/resolver_with_hygiene/typescript

crates/swc_ecma_transforms_base/benches/base.rs::benches::bench_cases

734.5 ms734.6 ms

css/parser/foundation_6_7_4

crates/swc_css_parser/benches/parser.rs::benches::bench_files

37.2 ms37.2 ms

css/lexer/foundation_6_7_4

crates/swc_css_parser/benches/lexer.rs::benches::bench_files

8.2 ms8.2 ms

css/visitor/compare/clone

crates/swc_css_parser/benches/compare.rs::benches::bench_cases

4.8 ms4.8 ms

parse_and_babelify_yui

crates/swc_estree_compat/benches/babelify.rs::benches::bench_cases

66.3 ms66.3 ms

es/lints/libs/echarts

crates/swc_ecma_lints/benches/all.rs::files::bench_files::es/lints/libs

114 ms114.1 ms

parse_and_babelify_mootools

crates/swc_estree_compat/benches/babelify.rs::benches::bench_cases

72.7 ms72.8 ms

parse_and_babelify_underscore

crates/swc_estree_compat/benches/babelify.rs::benches::bench_cases

13.1 ms13.1 ms

es/lexer/underscore

crates/swc_ecma_lexer/benches/lexer.rs::benches::bench_files

1.2 ms1.2 ms

parse_and_babelify_jquery

crates/swc_estree_compat/benches/babelify.rs::benches::bench_cases

98.6 ms98.6 ms

html/parser/parser_document/css_2021_spec

crates/swc_html_parser/benches/parser.rs::benches::bench_files

71.7 ms71.8 ms

html/document_fragment/visitor/compare/visit_mut_span

crates/swc_html_parser/benches/compare.rs::benches::bench_cases

1.1 ms1.1 ms

es/visitor/compare/clone

crates/swc_ecma_parser/benches/compare.rs::benches::bench_cases

5.5 ms5.5 ms

hygiene/typescript

crates/swc_ecma_transforms_base/benches/parallel.rs::benches::bench_cases::es/base/parallel

21.3 s21.3 s

html/document/visitor/compare/visit_mut_span_panic

crates/swc_html_parser/benches/compare.rs::benches::bench_cases

1.1 ms1.1 ms

es/lexer/backbone

crates/swc_ecma_lexer/benches/lexer.rs::benches::bench_files

1.4 ms1.4 ms

html/document/visitor/compare/fold_span

crates/swc_html_parser/benches/compare.rs::benches::bench_cases

1.2 ms1.2 ms

es/visitor/compare/visit_mut_span_panic

crates/swc_ecma_parser/benches/compare.rs::benches::bench_cases

6 ms6 ms

es/lints/libs/jquery

crates/swc_ecma_lints/benches/all.rs::files::bench_files::es/lints/libs

6.5 ms6.5 ms

es/visitor/compare/visit_mut_span

crates/swc_ecma_parser/benches/compare.rs::benches::bench_cases

6 ms6 ms

babelify-only

crates/swc_estree_compat/benches/babelify.rs::benches::bench_cases

2.1 ms2.1 ms

es/codegen/with-parser/large

crates/swc_ecma_codegen/benches/with_parse.rs::benches::bench_cases

1.2 ms1.2 ms

es/lints/libs/vue

crates/swc_ecma_lints/benches/all.rs::files::bench_files::es/lints/libs

8.3 ms8.3 ms

github

crates/swc_html_minifier/benches/full.rs::files_document_fragment::bench_files_document_fragment::html/minify/document_fragment

40.2 ms40.3 ms

html/document_fragment/visitor/compare/visit_mut_span_panic

crates/swc_html_parser/benches/compare.rs::benches::bench_cases

1.1 ms1.1 ms

es/parser/three

crates/swc_ecma_parser/benches/parser.rs::benches::bench_files

73 ms73 ms

typescript/fast-strip

crates/swc_ts_fast_strip/benches/assets.rs::benches::fast_ts

434.5 µs434.6 µs

css_spec

crates/swc_html_minifier/benches/full.rs::files_document::bench_files_document::html/minify/document

194 ms194 ms

es/lints/libs/victory

crates/swc_ecma_lints/benches/all.rs::files::bench_files::es/lints/libs

70.6 ms70.6 ms

es/minifier/libs/moment

crates/swc_ecma_minifier/benches/full.rs::bench_all::bench_libs::es/minifier/libs

61.5 ms61.5 ms

html/parser/parser_document/github_com_17_05_2022

crates/swc_html_parser/benches/parser.rs::benches::bench_files

22.4 ms22.4 ms

es/parser/cal-com

crates/swc_ecma_parser/benches/parser.rs::benches::bench_files

59.3 ms59.3 ms

github

crates/swc_html_minifier/benches/full.rs::files_document::bench_files_document::html/minify/document

40.9 ms40.9 ms

es/minifier/libs/lodash

crates/swc_ecma_minifier/benches/full.rs::bench_all::bench_libs::es/minifier/libs

111.6 ms111.7 ms

css_spec

crates/swc_html_minifier/benches/full.rs::files_document_fragment::bench_files_document_fragment::html/minify/document_fragment

191.6 ms191.8 ms

es/minifier/libs/victory

crates/swc_ecma_minifier/benches/full.rs::bench_all::bench_libs::es/minifier/libs

838.8 ms839.5 ms

es/codegen/large

crates/swc_ecma_codegen/benches/bench.rs::benches::bench_cases

644.7 µs645.2 µs

stackoverflow

crates/swc_html_minifier/benches/full.rs::files_document::bench_files_document::html/minify/document

35.3 ms35.3 ms

es/minifier/libs/three

crates/swc_ecma_minifier/benches/full.rs::bench_all::bench_libs::es/minifier/libs

632.3 ms633 ms

es/minifier/libs/d3

crates/swc_ecma_minifier/benches/full.rs::bench_all::bench_libs::es/minifier/libs

385.1 ms385.5 ms

stackoverflow

crates/swc_html_minifier/benches/full.rs::files_document_fragment::bench_files_document_fragment::html/minify/document_fragment

35.5 ms35.5 ms

es/minifier/libs/antd

crates/swc_ecma_minifier/benches/full.rs::bench_all::bench_libs::es/minifier/libs

1.9 s1.9 s

es/preset-env/usage/builtin_type

crates/swc_ecma_preset_env/benches/polyfills.rs::benches::bench_cases

247.3 µs247.7 µs

es/minifier/libs/terser

crates/swc_ecma_minifier/benches/full.rs::bench_all::bench_libs::es/minifier/libs

341.1 ms342.1 ms

es/codegen/colors

crates/swc_ecma_codegen/benches/bench.rs::benches::bench_cases

70.8 µs71.1 µs

es/preset-env/usage/property

crates/swc_ecma_preset_env/benches/polyfills.rs::benches::bench_cases

-1%

115.2 µs115.7 µs

Ignored

es/preset-env/entry/import

crates/swc_ecma_preset_env/benches/polyfills.rs::benches::bench_cases

Ignored

+1%

28.4 µs28.2 µs

Commits

Click on a commit to change the comparison range

Base

main

146c77c

-0.01%

fix(es/parser): Support TypeScript non-null assertion in destructuring assignment This fixes the parser to correctly handle TypeScript non-null assertion operators (!) in destructuring assignment patterns, specifically in array element access expressions. Previously, code like: ```typescript [arr[i]!, arr[j]!] = [arr[j]!, arr[i]!] ``` Would fail with "Not a pattern" error (SyntaxError::InvalidPat), while the TypeScript compiler successfully parses this code. The fix adds support for `Expr::TsNonNull`, `Expr::TsTypeAssertion`, `Expr::TsInstantiation`, and `Expr::TsSatisfies` to the list of allowed expression types in the `PatType::AssignElement` match block. These TypeScript expression types are valid simple assignment targets when their inner expressions are valid. This aligns with how the `ExprExt` trait already correctly implements `is_valid_simple_assignment_target` for these expression types by delegating to the inner expression. Fixes #11142 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>

8bd0128

4 days ago

by github-actions[bot]

Home Terms Privacy Docs