autodev/fix-decorator-metadata-enum-params - Branch - swc-project/swc

fix(es/decorators): Emit correct metadata for enum parameters

#11154Merged

Comparing

autodev/fix-decorator-metadata-enum-params

(

8970cc3

) with

main

(

e347c5b

)

Untouched: 127

Ignored: 1

Archived: 13

No successful run was found on main ( c2e75f3) during the generation of this report, so e347c5b was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

Benchmarks

13 archived benchmarks were run. If they were deleted in another branch, consider rebasing to remove them from the report. .

Passed

es/minifier/libs/terser

crates/swc_ecma_minifier/benches/full.rs::bench_all::bench_libs::es/minifier/libs

340.6 ms339.6 ms

es/minifier/libs/echarts

crates/swc_ecma_minifier/benches/full.rs::bench_all::bench_libs::es/minifier/libs

1.5 s1.5 s

es/minifier/libs/lodash

crates/swc_ecma_minifier/benches/full.rs::bench_all::bench_libs::es/minifier/libs

111.4 ms111.3 ms

stackoverflow

crates/swc_html_minifier/benches/full.rs::files_document_fragment::bench_files_document_fragment::html/minify/document_fragment

35.5 ms35.5 ms

es/minifier/libs/vue

crates/swc_ecma_minifier/benches/full.rs::bench_all::bench_libs::es/minifier/libs

139.7 ms139.6 ms

es/resolver_with_hygiene/typescript

crates/swc_ecma_transforms_base/benches/base.rs::benches::bench_cases

735.2 ms734.7 ms

es/preset-env/usage/property

crates/swc_ecma_preset_env/benches/polyfills.rs::benches::bench_cases

115.7 µs115.7 µs

stackoverflow

crates/swc_html_minifier/benches/full.rs::files_document::bench_files_document::html/minify/document

35.3 ms35.2 ms

es/parser/colors

crates/swc_ecma_parser/benches/parser.rs::benches::bench_files

84.3 µs84.3 µs

html/document_fragment/visitor/compare/visit_mut_span_panic

crates/swc_html_parser/benches/compare.rs::benches::bench_cases

1.1 ms1.1 ms

html/document_fragment/visitor/compare/visit_mut_span

crates/swc_html_parser/benches/compare.rs::benches::bench_cases

1.1 ms1.1 ms

html/document_fragment/visitor/compare/clone

crates/swc_html_parser/benches/compare.rs::benches::bench_cases

1 ms1 ms

es/preset-env/usage/builtin_type

crates/swc_ecma_preset_env/benches/polyfills.rs::benches::bench_cases

247 µs246.9 µs

html/document/visitor/compare/fold_span

crates/swc_html_parser/benches/compare.rs::benches::bench_cases

1.2 ms1.2 ms

html/parser/parser_document_fragment/css_2021_spec

crates/swc_html_parser/benches/parser.rs::benches::bench_files

71.2 ms71.2 ms

html/document/visitor/compare/visit_mut_span

crates/swc_html_parser/benches/compare.rs::benches::bench_cases

1.1 ms1.1 ms

es/resolver/typescript

crates/swc_ecma_transforms_base/benches/base.rs::benches::bench_cases

244.3 ms244.2 ms

html/parser/parser_document_fragment/stackoverflow_com_17_05_2022

crates/swc_html_parser/benches/parser.rs::benches::bench_files

22.3 ms22.3 ms

github

crates/swc_html_minifier/benches/full.rs::files_document::bench_files_document::html/minify/document

40.8 ms40.8 ms

html/document/visitor/compare/visit_mut_span_panic

crates/swc_html_parser/benches/compare.rs::benches::bench_cases

1.1 ms1.1 ms

html/document/visitor/compare/clone

crates/swc_html_parser/benches/compare.rs::benches::bench_cases

1 ms1 ms

html/document_fragment/visitor/compare/fold_span

crates/swc_html_parser/benches/compare.rs::benches::bench_cases

1.2 ms1.2 ms

html/document_fragment/visitor/compare/fold_span_panic

crates/swc_html_parser/benches/compare.rs::benches::bench_cases

1.2 ms1.2 ms

es/fixer/typescript

crates/swc_ecma_transforms_base/benches/base.rs::benches::bench_cases

202.7 ms202.7 ms

html/document/visitor/compare/fold_span_panic

crates/swc_html_parser/benches/compare.rs::benches::bench_cases

1.2 ms1.2 ms

es/hygiene/typescript

crates/swc_ecma_transforms_base/benches/base.rs::benches::bench_cases

425.8 ms425.7 ms

es/visitor/compare/clone

crates/swc_ecma_parser/benches/compare.rs::benches::bench_cases

5.5 ms5.5 ms

es/lints/libs/echarts

crates/swc_ecma_lints/benches/all.rs::files::bench_files::es/lints/libs

114.1 ms114 ms

github

crates/swc_html_minifier/benches/full.rs::files_document_fragment::bench_files_document_fragment::html/minify/document_fragment

40.2 ms40.2 ms

es/codegen/with-parser/large

crates/swc_ecma_codegen/benches/with_parse.rs::benches::bench_cases

1.2 ms1.2 ms

css/parser/bootstrap_5_1_3

crates/swc_css_parser/benches/parser.rs::benches::bench_files

46.8 ms46.8 ms

css/parser/tailwind_3_1_1

crates/swc_css_parser/benches/parser.rs::benches::bench_files

7.2 ms7.2 ms

es/parser/backbone

crates/swc_ecma_parser/benches/parser.rs::benches::bench_files

2.9 ms2.9 ms

es/parser/typescript

crates/swc_ecma_parser/benches/parser.rs::benches::bench_files

401.7 ms401.6 ms

es/lints/libs/victory

crates/swc_ecma_lints/benches/all.rs::files::bench_files::es/lints/libs

70.6 ms70.6 ms

es/lints/libs/vue

crates/swc_ecma_lints/benches/all.rs::files::bench_files::es/lints/libs

8.3 ms8.3 ms

es2015_shorthand_property

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

273.9 µs273.9 µs

es2015_duplicate_keys

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

280.9 µs280.9 µs

html/parser/parser_document_fragment/github_com_17_05_2022

crates/swc_html_parser/benches/parser.rs::benches::bench_files

22.3 ms22.3 ms

es/minifier/libs/victory

crates/swc_ecma_minifier/benches/full.rs::bench_all::bench_libs::es/minifier/libs

837.2 ms837.1 ms

es/visitor/compare/fold_span

crates/swc_ecma_parser/benches/compare.rs::benches::bench_cases

6.8 ms6.8 ms

es2015_sticky_regex

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

277.6 µs277.6 µs

es/codegen/with-parser/colors

crates/swc_ecma_codegen/benches/with_parse.rs::benches::bench_cases

156.3 µs156.3 µs

es/parser/yui

crates/swc_ecma_parser/benches/parser.rs::benches::bench_files

11.6 ms11.6 ms

es2015_instanceof

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

280.4 µs280.4 µs

es/transform/baseline/common_typescript

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::baseline_group

364.1 µs364.1 µs

es2015_arrow

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

302.4 µs302.4 µs

parse_and_babelify_underscore

crates/swc_estree_compat/benches/babelify.rs::benches::bench_cases

13.1 ms13.1 ms

es/target/es2017

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::version_group

275.6 µs275.6 µs

es/target/es3

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::version_group

395.3 µs395.3 µs

es/lints/libs/react

crates/swc_ecma_lints/benches/all.rs::files::bench_files::es/lints/libs

1.3 ms1.3 ms

es2015_destructuring

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

347.8 µs347.8 µs

es/transform/baseline/common_reserved_word

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::baseline_group

284.6 µs284.6 µs

html/lexer/github_com_17_05_2022

crates/swc_html_parser/benches/lexer.rs::benches::bench_files

14.6 ms14.6 ms

es2015_for_of

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

290.3 µs290.3 µs

es/visitor/compare/visit_mut_span_panic

crates/swc_ecma_parser/benches/compare.rs::benches::bench_cases

6 ms6 ms

es2020_optional_chaining

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

336.7 µs336.7 µs

es/parser/underscore

crates/swc_ecma_parser/benches/parser.rs::benches::bench_files

2.5 ms2.5 ms

es2019_optional_catch_binding

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

273.7 µs273.7 µs

es2015_spread

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

274.4 µs274.4 µs

es2017_async_to_generator

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

276 µs276 µs

css/lexer/tailwind_3_1_1

crates/swc_css_parser/benches/lexer.rs::benches::bench_files

1.6 ms1.6 ms

es/full-target/es2017

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::full_group

524.2 µs524.1 µs

css/visitor/compare/visit_mut_span_panic

crates/swc_css_parser/benches/compare.rs::benches::bench_cases

5.1 ms5.1 ms

es2016_exponentiation

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

289.1 µs289.1 µs

html/lexer/stackoverflow_com_17_05_2022

crates/swc_html_parser/benches/lexer.rs::benches::bench_files

14.7 ms14.7 ms

parse_and_babelify_yui

crates/swc_estree_compat/benches/babelify.rs::benches::bench_cases

66.3 ms66.3 ms

css/lexer/foundation_6_7_4

crates/swc_css_parser/benches/lexer.rs::benches::bench_files

8.2 ms8.2 ms

css/visitor/compare/fold_span_panic

crates/swc_css_parser/benches/compare.rs::benches::bench_cases

5.7 ms5.7 ms

es2015_block_scoped_fn

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

289.6 µs289.6 µs

es/target/es2015

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::version_group

1.2 ms1.2 ms

parse_and_babelify_backbone

crates/swc_estree_compat/benches/babelify.rs::benches::bench_cases

15.3 ms15.3 ms

es/full-target/es2016

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::full_group

559.9 µs559.9 µs

babelify-only

crates/swc_estree_compat/benches/babelify.rs::benches::bench_cases

2.1 ms2.1 ms

parse_and_babelify_mootools

crates/swc_estree_compat/benches/babelify.rs::benches::bench_cases

72.7 ms72.7 ms

typescript/fast-strip

crates/swc_ts_fast_strip/benches/assets.rs::benches::fast_ts

434.4 µs434.4 µs

css_spec

crates/swc_html_minifier/benches/full.rs::files_document_fragment::bench_files_document_fragment::html/minify/document_fragment

191.7 ms191.7 ms

css/lexer/bootstrap_5_1_3

crates/swc_css_parser/benches/lexer.rs::benches::bench_files

10 ms10 ms

html/lexer/css_2021_spec

crates/swc_html_parser/benches/lexer.rs::benches::bench_files

40.7 ms40.7 ms

parse_and_babelify_jquery_mobile

crates/swc_estree_compat/benches/babelify.rs::benches::bench_cases

169 ms169 ms

es2022_class_properties

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

381 µs381 µs

es2020_nullish_coalescing

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

298.6 µs298.6 µs

es/parser/mootools

crates/swc_ecma_parser/benches/parser.rs::benches::bench_files

11.9 ms11.9 ms

es/full-target/es2018

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::full_group

507.7 µs507.7 µs

parse_and_babelify_angular

crates/swc_estree_compat/benches/babelify.rs::benches::bench_cases

157.5 ms157.5 ms

es/target/es2016

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::version_group

289.7 µs289.7 µs

es2015_computed_props

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

274.2 µs274.2 µs

es/visitor/compare/fold_span_panic

crates/swc_ecma_parser/benches/compare.rs::benches::bench_cases

6.8 ms6.8 ms

es2015_block_scoping

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

451.8 µs451.9 µs

es/transform/baseline/base

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::baseline_group

260.5 µs260.5 µs

es/visitor/compare/visit_mut_span

crates/swc_ecma_parser/benches/compare.rs::benches::bench_cases

6 ms6 ms

parse_and_babelify_jquery

crates/swc_estree_compat/benches/babelify.rs::benches::bench_cases

98.6 ms98.6 ms

es2015_classes

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

389.8 µs389.8 µs

es2015_typeof_symbol

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

278.4 µs278.4 µs

css/visitor/compare/fold_span

crates/swc_css_parser/benches/compare.rs::benches::bench_cases

5.7 ms5.7 ms

es2015_parameters

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

330.5 µs330.5 µs

es/target/es2020

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::version_group

445.2 µs445.2 µs

es2018_object_rest_spread

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

291.7 µs291.8 µs

es2015_fn_name

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

282.1 µs282.1 µs

es/minifier/libs/react

crates/swc_ecma_minifier/benches/full.rs::bench_all::bench_libs::es/minifier/libs

19.1 ms19.1 ms

es/parser/angular

crates/swc_ecma_parser/benches/parser.rs::benches::bench_files

18.8 ms18.8 ms

css_spec

crates/swc_html_minifier/benches/full.rs::files_document::bench_files_document::html/minify/document

194 ms194 ms

html/parser/parser_document/css_2021_spec

crates/swc_html_parser/benches/parser.rs::benches::bench_files

71.5 ms71.5 ms

es/lints/libs/jquery

crates/swc_ecma_lints/benches/all.rs::files::bench_files::es/lints/libs

6.5 ms6.5 ms

es/target/es2018

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::version_group

309.4 µs309.4 µs

es/parser/three

crates/swc_ecma_parser/benches/parser.rs::benches::bench_files

72.8 ms72.8 ms

css/parser/foundation_6_7_4

crates/swc_css_parser/benches/parser.rs::benches::bench_files

37.2 ms37.2 ms

es/lints/libs/moment

crates/swc_ecma_lints/benches/all.rs::files::bench_files::es/lints/libs

4.2 ms4.2 ms

css/visitor/compare/visit_mut_span

crates/swc_css_parser/benches/compare.rs::benches::bench_cases

5.1 ms5.1 ms

es/lints/libs/lodash

crates/swc_ecma_lints/benches/all.rs::files::bench_files::es/lints/libs

6.2 ms6.2 ms

html/parser/parser_document/stackoverflow_com_17_05_2022

crates/swc_html_parser/benches/parser.rs::benches::bench_files

22.3 ms22.3 ms

es/lints/libs/typescript

crates/swc_ecma_lints/benches/all.rs::files::bench_files::es/lints/libs

276.1 ms276.1 ms

es/parser/jquery

crates/swc_ecma_parser/benches/parser.rs::benches::bench_files

15 ms15 ms

css/visitor/compare/clone

crates/swc_css_parser/benches/compare.rs::benches::bench_cases

4.8 ms4.8 ms

es/lints/libs/antd

crates/swc_ecma_lints/benches/all.rs::files::bench_files::es/lints/libs

156 ms156.1 ms

html/parser/parser_document/github_com_17_05_2022

crates/swc_html_parser/benches/parser.rs::benches::bench_files

22.4 ms22.4 ms

es/minifier/libs/three

crates/swc_ecma_minifier/benches/full.rs::bench_all::bench_libs::es/minifier/libs

631.4 ms631.7 ms

es/parser/cal-com

crates/swc_ecma_parser/benches/parser.rs::benches::bench_files

59.2 ms59.2 ms

es/minifier/libs/moment

crates/swc_ecma_minifier/benches/full.rs::bench_all::bench_libs::es/minifier/libs

61.3 ms61.3 ms

es/codegen/large

crates/swc_ecma_codegen/benches/bench.rs::benches::bench_cases

645.1 µs645.4 µs

es/minifier/libs/jquery

crates/swc_ecma_minifier/benches/full.rs::bench_all::bench_libs::es/minifier/libs

94.6 ms94.7 ms

es/minifier/libs/typescript

crates/swc_ecma_minifier/benches/full.rs::bench_all::bench_libs::es/minifier/libs

3.7 s3.7 s

es/minifier/libs/antd

crates/swc_ecma_minifier/benches/full.rs::bench_all::bench_libs::es/minifier/libs

1.9 s1.9 s

es/codegen/colors

crates/swc_ecma_codegen/benches/bench.rs::benches::bench_cases

70.6 µs70.6 µs

es/parser/jquery mobile

crates/swc_ecma_parser/benches/parser.rs::benches::bench_files

23.4 ms23.5 ms

es/lints/libs/three

crates/swc_ecma_lints/benches/all.rs::files::bench_files::es/lints/libs

50.2 ms50.3 ms

es/minifier/libs/d3

crates/swc_ecma_minifier/benches/full.rs::bench_all::bench_libs::es/minifier/libs

-1%

383.7 ms386.6 ms

Ignored

es/preset-env/entry/import

crates/swc_ecma_preset_env/benches/polyfills.rs::benches::bench_cases

Ignored

28.2 µs28.2 µs

Commits

Click on a commit to change the comparison range

Base

main

e347c5b

fix(decorators): Emit correct metadata for enum parameters This fixes decorator metadata emission to correctly handle enum parameters in decorated methods and constructors. Previously, SWC incorrectly emitted `typeof Options === "undefined" ? Object : Options` for enum parameters. Now it correctly emits: - `Number` for numeric enums - `String` for string enums - `Object` for mixed enums This matches TypeScript's behavior. Changes: - Updated `visit_mut_class_method` to check enum map before serializing parameter types - Updated `visit_mut_class` to check enum map for constructor parameters - Added test case for issue #11032 Fixes #11032 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>

93d58bc

2 months ago

by github-actions[bot]

Fix metadata emission for enum parameters in decorators Fixes the metadata emission for enum parameters in decorators.

8970cc3

2 months ago

by kdy1

Home Terms Privacy Docs