mixcloud:fix/dataloader-cancelled-future-in-error-handler - Branch - strawberry-graphql/strawberry

fix: skip cancelled futures in DataLoader error handler

#4300Merged

Comparing

mixcloud:fix/dataloader-cancelled-future-in-error-handler

(

4b1626e

) with

main

(

ff50604

)

Untouched: 31

Ignored: 1

Benchmarks

32 total

test_execute_with_many_fields

tests/benchmarks/test_execute_sync.py

35.3 ms35.2 ms

test_execute_with_100_items

tests/benchmarks/test_execute_sync.py

10.7 ms10.6 ms

test_execute_with_10_items

tests/benchmarks/test_execute_sync.py

5.5 ms5.4 ms

test_interface_performance[4096]

tests/benchmarks/test_execute.py

65.1 ms65 ms

test_convert_argument_large_list[16384]

tests/benchmarks/test_arguments.py

208.5 µs208.3 µs

test_subscription_long_run[20000]

tests/benchmarks/test_subscriptions.py

3.5 s3.5 s

test_interface_performance[256]

tests/benchmarks/test_execute.py

58.6 ms58.6 ms

test_stadium[seats_per_row_500]

tests/benchmarks/test_stadium.py

12.1 s12.1 s

test_stadium[seats_per_row_250]

tests/benchmarks/test_stadium.py

6 s6 s

test_execute[with_simpleextension-items_1000]

tests/benchmarks/test_execute_with_extensions.py

64.2 ms64.2 ms

test_execute[with_resolveextension-items_1000]

tests/benchmarks/test_execute_with_extensions.py

187.9 ms187.9 ms

test_convert_argument_large_list[262144]

tests/benchmarks/test_arguments.py

2.4 ms2.4 ms

test_convert_argument_large_list[1048576]

tests/benchmarks/test_arguments.py

9.4 ms9.4 ms

test_convert_argument_large_list[4194304]

tests/benchmarks/test_arguments.py

37.5 ms37.5 ms

test_execute[with_no_extensions-items_1000]

tests/benchmarks/test_execute_with_extensions.py

63.9 ms63.9 ms

test_execute[with_no_extensions-items_10000]

tests/benchmarks/test_execute_with_extensions.py

592.6 ms592.6 ms

test_convert_argument_large_list[65536]

tests/benchmarks/test_arguments.py

634.8 µs634.9 µs

test_execute_with_many_fields_and_directives

tests/benchmarks/test_execute_sync.py

40.9 ms40.9 ms

test_execute_complex_schema[50]

tests/benchmarks/test_complex_schema.py

3.8 s3.8 s

test_execute

tests/benchmarks/test_execute.py

501.8 ms502.1 ms

test_execute[with_simpleextension-items_10000]

tests/benchmarks/test_execute_with_extensions.py

595.8 ms596.3 ms

test_interface_performance[1]

tests/benchmarks/test_execute.py

56.1 ms56.1 ms

test_execute_large_query[baseline]

tests/benchmarks/test_parse_execute_large_query.py

2.2 s2.2 s

test_execute[with_resolveextension-items_10000]

tests/benchmarks/test_execute_with_extensions.py

1.9 s1.9 s

test_subscription

tests/benchmarks/test_subscriptions.py

220.8 ms221.2 ms

Commits

Click on a commit to change the comparison range

Base

main

ff50604

-0.03%

fix: skip cancelled futures in DataLoader error handler

4b1626e

11 hours ago

by ben-xo

Home Terms Privacy Docs