magicmark:generate_directives - Branch - strawberry-graphql/strawberry

fix: support custom directive definitions in schema codegen (option 2, generating)

#4093

Comparing

magicmark:generate_directives

(

13c94f4

) with

main

(

c8d6ae4

)

Untouched: 31

Ignored: 1

Benchmarks

Passed

test_subscription_long_run[1000]

tests/benchmarks/test_subscriptions.py

180.6 ms179.8 ms

test_parse_large_query

tests/benchmarks/test_parse_execute_large_query.py

585.3 ms584.1 ms

test_interface_performance[4096]

tests/benchmarks/test_execute.py

68.6 ms68.4 ms

test_execute_generic_input

tests/benchmarks/test_generic_input.py

498.6 ms497.8 ms

test_execute_with_many_fields

tests/benchmarks/test_execute_sync.py

37.7 ms37.6 ms

test_subscription

tests/benchmarks/test_subscriptions.py

216.8 ms216.5 ms

test_execute_with_1000_items

tests/benchmarks/test_execute_sync.py

67.3 ms67.2 ms

test_execute[with_simpleextension-items_1000]

tests/benchmarks/test_execute_with_extensions.py

68 ms68 ms

test_execute_with_10_items

tests/benchmarks/test_execute_sync.py

5.4 ms5.4 ms

test_execute_large_query[baseline]

tests/benchmarks/test_parse_execute_large_query.py

2.2 s2.2 s

test_subscription_long_run[20000]

tests/benchmarks/test_subscriptions.py

3.5 s3.5 s

test_convert_argument_large_list[16384]

tests/benchmarks/test_arguments.py

207.3 µs207.3 µs

test_convert_argument_large_list[65536]

tests/benchmarks/test_arguments.py

634.8 µs634.8 µs

test_convert_argument_large_list[1048576]

tests/benchmarks/test_arguments.py

9.4 ms9.4 ms

test_convert_argument_large_list[262144]

tests/benchmarks/test_arguments.py

2.4 ms2.4 ms

test_convert_argument_large_list[4194304]

tests/benchmarks/test_arguments.py

37.5 ms37.5 ms

test_execute[with_no_extensions-items_1000]

tests/benchmarks/test_execute_with_extensions.py

67.7 ms67.7 ms

test_execute

tests/benchmarks/test_execute.py

534 ms534.1 ms

test_execute[with_simpleextension-items_10000]

tests/benchmarks/test_execute_with_extensions.py

634.6 ms634.8 ms

test_execute[with_no_extensions-items_10000]

tests/benchmarks/test_execute_with_extensions.py

630.9 ms631.3 ms

test_execute_large_query[with_parser_cache]

tests/benchmarks/test_parse_execute_large_query.py

1.4 s1.4 s

test_execute[with_resolveextension-items_10000]

tests/benchmarks/test_execute_with_extensions.py

1.9 s1.9 s

test_stadium[seats_per_row_500]

tests/benchmarks/test_stadium.py

13.3 s13.3 s

test_stadium[seats_per_row_250]

tests/benchmarks/test_stadium.py

6.6 s6.7 s

test_execute_with_many_fields_and_directives

tests/benchmarks/test_execute_sync.py

43.2 ms43.3 ms

test_execute_with_100_items

tests/benchmarks/test_execute_sync.py

10.9 ms11 ms

test_interface_performance[1]

tests/benchmarks/test_execute.py

59.6 ms59.8 ms

test_execute[with_resolveextension-items_1000]

tests/benchmarks/test_execute_with_extensions.py

185.4 ms186 ms

test_interface_performance[16]

tests/benchmarks/test_execute.py

59.6 ms59.8 ms

test_execute_complex_schema[50]

tests/benchmarks/test_complex_schema.py

4 s4 s

test_interface_performance[256]

tests/benchmarks/test_execute.py

-1%

61.8 ms62.2 ms

Ignored

test_execute_basic

tests/benchmarks/test_execute_sync.py

Ignored

-1%

2.2 ms2.3 ms

Commits

Click on a commit to change the comparison range

Base

main

c8d6ae4

-0.04%

fix: support custom directive definitions in schema codegen Previously, schemas containing custom directive definitions would fail with `NotImplementedError: Unknown definition None`. Now directive definitions are generated with stub implementations. Also fixes the error message for unknown definitions to show the actual type name instead of `None`. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>

13c94f4

3 days ago

by magicmark

Home Terms Privacy Docs