thePromger:fix-router - Branch - sparckles/Robyn

fix: Fixes routing issues which causes bugs like authentication bypass...

#1265

Comparing

thePromger:fix-router

(

03ab7af

) with

main

(

118660f

)

-1%

Untouched: 150

New: 6

No successful run was found on main ( 40a8bd1) during the generation of this report, so 118660f was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

Benchmarks

New

test_invalid_authentication_header_trailing_slash[sync]

integration_tests/test_authentication.py

N/A

N/A4.6 ms

test_invalid_authentication_header_trailing_slash[async]

integration_tests/test_authentication.py

N/A

N/A4.6 ms

test_invalid_authentication_token_trailing_slash[async]

integration_tests/test_authentication.py

N/A

N/A4.6 ms

test_invalid_authentication_token_trailing_slash[sync]

integration_tests/test_authentication.py

N/A

N/A4.6 ms

test_valid_authentication_trailing_slash[sync]

integration_tests/test_authentication.py

N/A

N/A4.6 ms

test_valid_authentication_trailing_slash[async]

integration_tests/test_authentication.py

N/A

N/A4.7 ms

Passed

test_sse_streaming_async_real_time

integration_tests/test_sse.py

6.2 ms6.2 ms

test_sse_streaming_sync_real_time

integration_tests/test_sse.py

5.9 ms5.9 ms

test_custom_openapi_spec

integration_tests/test_openapi.py

762.3 µs764 µs

test_global_index_request

integration_tests/test_base_url.py

4.5 ms4.5 ms

test_patch[async]

integration_tests/test_patch_requests.py

4.7 ms4.7 ms

test_delete_with_param[async]

integration_tests/test_delete_requests.py

4.6 ms4.7 ms

test_split_request_params_get_query_params[split_request_untyped-sync]

integration_tests/test_split_request_params.py

13.2 ms13.3 ms

test_sse_named_events

integration_tests/test_sse.py

4.7 ms4.7 ms

test_sse_async_endpoint

integration_tests/test_sse.py

4.7 ms4.7 ms

test_add_subrouter_paths

integration_tests/test_openapi.py

6.4 ms6.5 ms

test_openapi_query_params

integration_tests/test_openapi.py

6.4 ms6.5 ms

test_openapi_response_body

integration_tests/test_openapi.py

6.4 ms6.5 ms

test_sse_custom_headers

integration_tests/test_sse.py

4.6 ms4.7 ms

test_split_request_params_get_method[split_request_typed-async]

integration_tests/test_split_request_params.py

4.6 ms4.7 ms

test_sub_router[get]

integration_tests/test_subrouter.py

4.6 ms4.6 ms

test_docs_handler

integration_tests/test_openapi.py

4.4 ms4.5 ms

test_split_request_params_get_combined[split_request_untyped-sync]

integration_tests/test_split_request_params.py

4.9 ms4.9 ms

test_json_get[/sync/json-expected_json0]

integration_tests/test_basic_routes.py

4.6 ms4.6 ms

test_openapi_request_body

integration_tests/test_openapi.py

6.5 ms6.5 ms

test_sse_empty_stream

integration_tests/test_sse.py

4.7 ms4.7 ms

test_multipart_file[sync]

integration_tests/test_multipart_data.py

4.8 ms4.9 ms

test_post[sync]

integration_tests/test_post_requests.py

-1%

4.7 ms4.7 ms

test_invalid_authentication_no_token[sync]

integration_tests/test_authentication.py

-1%

4.5 ms4.5 ms

test_json_handler

integration_tests/test_openapi.py

-1%

6.4 ms6.5 ms

test_response_in_before_middleware

integration_tests/test_middlewares.py

-1%

4.5 ms4.5 ms

test_http_request_info_get[/async/http/param-expected_json1]

integration_tests/test_basic_routes.py

-1%

4.6 ms4.7 ms

test_invalid_authentication_token[async]

integration_tests/test_authentication.py

-1%

4.5 ms4.6 ms

test_sub_router_head

integration_tests/test_subrouter.py

-1%

4.5 ms4.6 ms

test_binary_output[/async/octet/response-async octet response]

integration_tests/test_binary_output.py

-1%

4.7 ms4.8 ms

test_add_openapi_path

integration_tests/test_openapi.py

-1%

6.4 ms6.5 ms

test_sse_basic_stream

integration_tests/test_sse.py

-1%

4.6 ms4.7 ms

test_param_suffix[sync]

integration_tests/test_get_requests.py

-1%

8.7 ms8.7 ms

test_sse_json_data

integration_tests/test_sse.py

-1%

4.7 ms4.7 ms

test_put[async]

integration_tests/test_put_requests.py

-1%

4.7 ms4.7 ms

test_delete_with_param[sync]

integration_tests/test_delete_requests.py

-1%

4.6 ms4.6 ms

test_default_url_index_request

integration_tests/test_base_url.py

-1%

4.5 ms4.5 ms

test_queries[sync]

integration_tests/test_get_requests.py

-1%

8.7 ms8.7 ms

test_local_index_request

integration_tests/test_base_url.py

-1%

4.5 ms4.5 ms

test_split_request_params_get_combined[split_request_typed-sync]

integration_tests/test_split_request_params.py

-1%

4.9 ms4.9 ms

test_split_request_params_get_path_params[split_request_untyped-sync]

integration_tests/test_split_request_params.py

-1%

4.7 ms4.7 ms

test_invalid_authentication_no_token[async]

integration_tests/test_authentication.py

-1%

4.5 ms4.5 ms

test_split_request_params_get_body[split_request_untyped-sync]

integration_tests/test_split_request_params.py

-1%

4.7 ms4.7 ms

test_delete[async]

integration_tests/test_delete_requests.py

-1%

4.7 ms4.7 ms

test_invalid_authentication_token[sync]

integration_tests/test_authentication.py

-1%

4.5 ms4.6 ms

test_split_request_params_get_method[split_request_untyped-sync]

integration_tests/test_split_request_params.py

-1%

4.6 ms4.7 ms

test_post[async]

integration_tests/test_post_requests.py

-1%

4.7 ms4.7 ms

test_exception_handling[/sync/exception/put-put]

integration_tests/test_exception_handling.py

-1%

4.7 ms4.7 ms

test_split_request_params_get_headers[split_request_untyped-sync]

integration_tests/test_split_request_params.py

-1%

4.6 ms4.7 ms

test_exception_handling[/sync/exception/post-post]

integration_tests/test_exception_handling.py

-1%

4.7 ms4.7 ms

test_sse_optimization_headers

integration_tests/test_sse.py

-1%

4.6 ms4.7 ms

test_basic_get[/async/response/const-async response const get-async_const-response]

integration_tests/test_basic_routes.py

-1%

4.7 ms4.7 ms

test_basic_get[/sync/str/const-sync str const get-None-None]

integration_tests/test_basic_routes.py

-1%

4.6 ms4.6 ms

test_binary_output[/sync/octet-sync octet]

integration_tests/test_binary_output.py

-1%

4.7 ms4.7 ms

test_put_with_param[sync]

integration_tests/test_put_requests.py

-1%

4.6 ms4.6 ms

test_middlewares[async]

integration_tests/test_middlewares.py

-1%

4.6 ms4.6 ms

test_json_get[/async/json-expected_json1]

integration_tests/test_basic_routes.py

-1%

4.6 ms4.6 ms

test_serve_html[sync]

integration_tests/test_get_requests.py

-1%

4.6 ms4.6 ms

test_patch[sync]

integration_tests/test_patch_requests.py

-1%

4.7 ms4.7 ms

test_trailing_slash

integration_tests/test_get_requests.py

-1%

8.5 ms8.5 ms

test_split_request_params_typed_untyped_post_combined[async]

integration_tests/test_split_request_params.py

-1%

4.9 ms4.9 ms

test_sse_formatted_messages

integration_tests/test_sse.py

-1%

4.7 ms4.7 ms

test_queries[async]

integration_tests/test_get_requests.py

-1%

8.7 ms8.8 ms

test_sse_custom_status_code

integration_tests/test_sse.py

-1%

4.6 ms4.6 ms

test_delete[sync]

integration_tests/test_delete_requests.py

-1%

4.7 ms4.7 ms

test_sub_router[delete]

integration_tests/test_subrouter.py

-1%

4.6 ms4.6 ms

test_sub_router[put]

integration_tests/test_subrouter.py

-1%

4.6 ms4.6 ms

test_form_data[sync]

integration_tests/test_multipart_data.py

-1%

4.8 ms4.8 ms

test_valid_authentication[async]

integration_tests/test_authentication.py

-1%

4.6 ms4.6 ms

test_404_not_found

integration_tests/test_status_code.py

-1%

4.6 ms4.6 ms

test_split_request_params_get_body[split_request_typed-async]

integration_tests/test_split_request_params.py

-1%

4.7 ms4.7 ms

test_post_with_param[sync]

integration_tests/test_post_requests.py

-1%

4.6 ms4.6 ms

test_split_request_params_get_combined[split_request_typed-async]

integration_tests/test_split_request_params.py

-1%

4.9 ms4.9 ms

test_split_request_params_get_path_params[split_request_typed-sync]

integration_tests/test_split_request_params.py

-1%

4.7 ms4.7 ms

test_split_request_params_typed_untyped_post_combined[sync]

integration_tests/test_split_request_params.py

-1%

4.9 ms4.9 ms

test_http_request_info_get[/sync/http/param-expected_json0]

integration_tests/test_basic_routes.py

-1%

4.6 ms4.7 ms

test_binary_output[/async/octet-async octet]

integration_tests/test_binary_output.py

-1%

4.7 ms4.7 ms

test_basic_get[/sync/dict/const-sync dict const get-sync_const-dict]

integration_tests/test_basic_routes.py

-1%

4.7 ms4.7 ms

test_split_request_params_get_body[split_request_typed-sync]

integration_tests/test_split_request_params.py

-1%

4.7 ms4.7 ms

test_serve_html[async]

integration_tests/test_get_requests.py

-1%

4.6 ms4.6 ms

test_exception_handling[/async/exception/post-post]

integration_tests/test_exception_handling.py

-1%

4.7 ms4.7 ms

test_web_socket_raw_benchmark

integration_tests/test_web_sockets.py

-1%

1.6 ms1.6 ms

test_split_request_params_get_headers[split_request_typed-sync]

integration_tests/test_split_request_params.py

-1%

4.6 ms4.7 ms

test_202_status_code

integration_tests/test_status_code.py

-1%

4.5 ms4.5 ms

test_sse_middleware_compatibility

integration_tests/test_sse.py

-1%

4.6 ms4.6 ms

test_param_suffix[async]

integration_tests/test_get_requests.py

-1%

8.7 ms8.7 ms

test_split_request_params_get_method[split_request_typed-sync]

integration_tests/test_split_request_params.py

-1%

4.6 ms4.7 ms

test_json_get[/sync/json/const-expected_json2]

integration_tests/test_basic_routes.py

-1%

4.6 ms4.6 ms

test_split_request_params_get_combined_failure[async]

integration_tests/test_split_request_params.py

-1%

4.9 ms4.9 ms

test_split_request_params_get_headers[split_request_untyped-async]

integration_tests/test_split_request_params.py

-1%

4.6 ms4.7 ms

test_basic_get[/async/dict/const-async dict const get-async_const-dict]

integration_tests/test_basic_routes.py

-1%

4.7 ms4.7 ms

test_invalid_authentication_header[async]

integration_tests/test_authentication.py

-1%

4.5 ms4.6 ms

test_put_with_param[async]

integration_tests/test_put_requests.py

-1%

4.6 ms4.6 ms

test_exception_handling[/async/exception/put-put]

integration_tests/test_exception_handling.py

-1%

4.7 ms4.7 ms

test_404_status_code

integration_tests/test_status_code.py

-1%

4.5 ms4.5 ms

test_put[sync]

integration_tests/test_put_requests.py

-1%

4.7 ms4.7 ms

test_sub_router[patch]

integration_tests/test_subrouter.py

-1%

4.6 ms4.6 ms

test_split_request_params_get_query_params[split_request_untyped-async]

integration_tests/test_split_request_params.py

-1%

13.2 ms13.3 ms

test_basic_get[/sync/response/const-sync response const get-sync_const-response]

integration_tests/test_basic_routes.py

-1%

4.7 ms4.7 ms

test_sync_500_internal_server_error[async]

integration_tests/test_status_code.py

-1%

4.5 ms4.5 ms

test_invalid_authentication_header[sync]

integration_tests/test_authentication.py

-1%

4.5 ms4.6 ms

test_split_request_params_get_path_params[split_request_untyped-async]

integration_tests/test_split_request_params.py

-1%

4.7 ms4.7 ms

test_json_get[/async/json/const-expected_json3]

integration_tests/test_basic_routes.py

-1%

4.6 ms4.6 ms

test_split_request_params_get_query_params[split_request_typed-sync]

integration_tests/test_split_request_params.py

-1%

13.1 ms13.2 ms

test_exception_handling[/sync/post/no_dec-post]

integration_tests/test_add_route_without_decorator.py

-1%

4.6 ms4.7 ms

test_split_request_params_get_body[split_request_untyped-async]

integration_tests/test_split_request_params.py

-1%

4.7 ms4.7 ms

test_basic_get[/sync/response-sync response get-sync-response]

integration_tests/test_basic_routes.py

-1%

4.7 ms4.7 ms

test_param[sync]

integration_tests/test_get_requests.py

-1%

8.6 ms8.7 ms

test_binary_output[/sync/octet/response-sync octet response]

integration_tests/test_binary_output.py

-1%

4.7 ms4.8 ms

test_global_middleware

integration_tests/test_middlewares.py

-1%

4.6 ms4.6 ms

test_split_request_params_get_combined[split_request_untyped-async]

integration_tests/test_split_request_params.py

-1%

4.9 ms4.9 ms

test_sse_single_message

integration_tests/test_sse.py

-1%

4.6 ms4.6 ms

test_file_download[sync]

integration_tests/test_file_download.py

-1%

4.6 ms4.6 ms

test_basic_get[/sync/dict-sync dict get-sync-dict]

integration_tests/test_basic_routes.py

-1%

4.7 ms4.7 ms

test_file_download[async]

integration_tests/test_file_download.py

-1%

4.6 ms4.6 ms

test_split_request_params_get_combined_failure[sync]

integration_tests/test_split_request_params.py

-1%

4.9 ms4.9 ms

test_split_request_params_get_method[split_request_untyped-async]

integration_tests/test_split_request_params.py

-1%

4.6 ms4.7 ms

test_basic_get[/async/dict-async dict get-async-dict]

integration_tests/test_basic_routes.py

-1%

4.7 ms4.7 ms

test_sse_basic_headers

integration_tests/test_sse.py

-1%

4.6 ms4.6 ms

test_split_request_params_get_query_params[split_request_typed-async]

integration_tests/test_split_request_params.py

-1%

13.1 ms13.2 ms

test_basic_get[/async/str-async str get-None-None]

integration_tests/test_basic_routes.py

-1%

4.6 ms4.6 ms

test_sub_router[post]

integration_tests/test_subrouter.py

-1%

4.6 ms4.6 ms

test_exception_handling[/sync/get/no_dec-get]

integration_tests/test_add_route_without_decorator.py

-1%

4.7 ms4.7 ms

test_middlewares[sync]

integration_tests/test_middlewares.py

-1%

4.6 ms4.6 ms

test_exception_handling[/sync/put/no_dec-put]

integration_tests/test_add_route_without_decorator.py

-1%

4.6 ms4.7 ms

test_basic_get[/sync/str-sync str get-None-None]

integration_tests/test_basic_routes.py

-1%

4.6 ms4.6 ms

test_basic_get[/async/str/const-async str const get-None-None]

integration_tests/test_basic_routes.py

-1%

4.6 ms4.6 ms

test_sub_router[trace]

integration_tests/test_subrouter.py

-1%

4.6 ms4.6 ms

test_split_request_params_get_headers[split_request_typed-async]

integration_tests/test_split_request_params.py

-1%

4.6 ms4.7 ms

test_basic_get[/async/response-async response get-async-response]

integration_tests/test_basic_routes.py

-1%

4.7 ms4.7 ms

test_exception_handling[/async/post/no_dec-post]

integration_tests/test_add_route_without_decorator.py

-1%

4.6 ms4.7 ms

test_param[async]

integration_tests/test_get_requests.py

-1%

8.6 ms8.7 ms

test_patch_with_param[sync]

integration_tests/test_patch_requests.py

-1%

4.6 ms4.6 ms

test_template[async]

integration_tests/test_get_requests.py

-1%

4.6 ms4.6 ms

test_exception_handling[/async/exception/get-get]

integration_tests/test_exception_handling.py

-1%

4.7 ms4.7 ms

test_exception_handling[/async/get/no_dec-get]

integration_tests/test_add_route_without_decorator.py

-1%

4.6 ms4.6 ms

test_template[sync]

integration_tests/test_get_requests.py

-1%

4.6 ms4.6 ms

test_sync_500_internal_server_error[sync]

integration_tests/test_status_code.py

-1%

4.5 ms4.5 ms

test_exception_handling[/sync/exception/get-get]

integration_tests/test_exception_handling.py

-1%

4.7 ms4.7 ms

test_split_request_params_get_path_params[split_request_typed-async]

integration_tests/test_split_request_params.py

-1%

4.7 ms4.7 ms

test_post_with_param[async]

integration_tests/test_post_requests.py

-1%

4.6 ms4.7 ms

test_exception_handling[/async/put/no_dec-put]

integration_tests/test_add_route_without_decorator.py

-1%

4.6 ms4.7 ms

test_valid_authentication[sync]

integration_tests/test_authentication.py

-1%

4.6 ms4.6 ms

test_sub_router[options]

integration_tests/test_subrouter.py

-1%

4.6 ms4.6 ms

test_patch_with_param[async]

integration_tests/test_patch_requests.py

-1%

4.6 ms4.7 ms

test_sub_router_web_socket

integration_tests/test_subrouter.py

-1%

1 ms1.1 ms

test_add_request_header

integration_tests/test_app.py

-1%

648 µs656.7 µs

test_allow_cors

integration_tests/test_app.py

-1%

756 µs767.1 µs

test_add_response_header

integration_tests/test_app.py

-1%

649.2 µs658.9 µs

test_lifecycle_handlers

integration_tests/test_app.py

-2%

680.8 µs691.3 µs

Commits

Click on a commit to change the comparison range

Base

main

118660f

-0.75%

fix: some formatting & linting issues * update _normalize_endpoint to handle None and empty strings too

7d78f93

23 days ago

by thePromger

-0.01%

refactor: simplify route matching logic and update normalization rules

5d6011b

23 days ago

by thePromger

-46.6%

test: enhance authentication tests for endpoint consistency * using _normalized_endpoint in subRouter correct way, after doing changes in function

b7b62cb

22 days ago

by thePromger

-0.18%

fix: update endpoint normalization to handle empty strings and slashes * Improved test cases, which checks request url after successful response, to confirm whether request goes to correct endpoint & internal routing works for trailing slashes

a5ecfe8

20 days ago

by thePromger

+27.45%

feat: enhance authentication tests, docs & and improve endpoint normalization * Added documentation for middleware. * Fixed formatting & linting issues. * Completed the TODO in line 127, by log warning if openAPI config file not found. * Created new tests funcs for trailing slash endpoints.

5a1983a

20 days ago

by thePromger

+19.43%

feat: refactoring endpoint normalizing code, to avoid logical bugs

03ab7af

19 days ago

by thePromger

Home Terms Privacy Docs