dave42w:lazy-openapi - Branch - sparckles/Robyn

refactor: openApi made lazy.

#1066

Comparing

dave42w:lazy-openapi

(

f9bf080

) with

main

(

7495342

)

-48%

Improvements: 0

Regressions: 5

Untouched: 141

New: 0

Dropped: 0

Ignored: 0

Benchmarks

Failed

test_add_request_headerRegression

integration_tests/test_app.py::test_add_request_header

-48%

341.9 µs

652.8 µs

test_add_response_headerRegression

integration_tests/test_app.py::test_add_response_header

-48%

342 µs

652.5 µs

test_allow_corsRegression

integration_tests/test_app.py::test_allow_cors

-40%

455.3 µs

756.7 µs

test_lifecycle_handlersRegression

integration_tests/test_app.py::test_lifecycle_handlers

-45%

373.5 µs

682.9 µs

test_custom_openapi_specRegression

integration_tests/test_openapi.py::test_custom_openapi_spec

-39%

466.3 µs

765.7 µs

Passed

test_env_population

integration_tests/test_env_populator.py::test_env_population

317.6 µs

317.3 µs

test_exception_handling[/sync/put/no_dec-put]

integration_tests/test_add_route_without_decorator.py::test_exception_handling[/sync/put/no_dec-put]

4.8 ms

test_valid_authentication[sync]

integration_tests/test_authentication.py::test_valid_authentication[sync]

4.7 ms

test_sub_router_web_socket

integration_tests/test_subrouter.py::test_sub_router_web_socket

1.1 ms

test_default_url_index_request

integration_tests/test_base_url.py::test_default_url_index_request

4.6 ms

test_template[sync]

integration_tests/test_get_requests.py::test_template[sync]

4.7 ms

test_get_async_decorator_view

integration_tests/test_views.py::test_get_async_decorator_view

4.7 ms

test_web_socket_raw_benchmark

integration_tests/test_web_sockets.py::test_web_socket_raw_benchmark

1.6 ms

test_split_request_params_get_path_params[split_request_untyped-async]

integration_tests/test_split_request_params.py::test_split_request_params_get_path_params[split_request_untyped-async]

4.8 ms

test_basic_get[/async/str/const-async str const get-None-None]

integration_tests/test_basic_routes.py::test_basic_get[/async/str/const-async str const get-None-None]

4.7 ms

test_local_index_request

integration_tests/test_base_url.py::test_local_index_request

4.6 ms

test_split_request_params_get_combined[split_request_typed-sync]

integration_tests/test_split_request_params.py::test_split_request_params_get_combined[split_request_typed-sync]

5 ms

test_sub_router[patch]

integration_tests/test_subrouter.py::test_sub_router[patch]

4.7 ms

test_sub_router[options]

integration_tests/test_subrouter.py::test_sub_router[options]

4.7 ms

test_post_async_view

integration_tests/test_views.py::test_post_async_view

4.7 ms

4.8 ms

test_response_in_before_middleware

integration_tests/test_middlewares.py::test_response_in_before_middleware

4.6 ms

test_serve_html[sync]

integration_tests/test_get_requests.py::test_serve_html[sync]

4.7 ms

test_split_request_params_get_path_params[split_request_typed-async]

integration_tests/test_split_request_params.py::test_split_request_params_get_path_params[split_request_typed-async]

4.8 ms

test_delete[sync]

integration_tests/test_delete_requests.py::test_delete[sync]

4.8 ms

test_basic_get[/sync/str-sync str get-None-None]

integration_tests/test_basic_routes.py::test_basic_get[/sync/str-sync str get-None-None]

4.7 ms

test_split_request_params_typed_untyped_post_combined[async]

integration_tests/test_split_request_params.py::test_split_request_params_typed_untyped_post_combined[async]

5 ms

test_split_request_params_get_combined[split_request_typed-async]

integration_tests/test_split_request_params.py::test_split_request_params_get_combined[split_request_typed-async]

5 ms

test_basic_get[/sync/dict/const-sync dict const get-sync_const-dict]

integration_tests/test_basic_routes.py::test_basic_get[/sync/dict/const-sync dict const get-sync_const-dict]

4.8 ms

test_file_download[sync]

integration_tests/test_file_download.py::test_file_download[sync]

4.8 ms

test_get_sync_decorator_view

integration_tests/test_views.py::test_get_sync_decorator_view

4.7 ms

test_http_request_info_get[/sync/http/param-expected_json0]

integration_tests/test_basic_routes.py::test_http_request_info_get[/sync/http/param-expected_json0]

4.8 ms

test_exception_handling[/async/exception/get-get]

integration_tests/test_exception_handling.py::test_exception_handling[/async/exception/get-get]

4.8 ms

test_split_request_params_get_method[split_request_typed-async]

integration_tests/test_split_request_params.py::test_split_request_params_get_method[split_request_typed-async]

4.8 ms

test_sub_router[trace]

integration_tests/test_subrouter.py::test_sub_router[trace]

4.7 ms

test_param_suffix[async]

integration_tests/test_get_requests.py::test_param_suffix[async]

9 ms

test_post_sync_decorator_view

integration_tests/test_views.py::test_post_sync_decorator_view

4.8 ms

test_split_request_params_get_method[split_request_typed-sync]

integration_tests/test_split_request_params.py::test_split_request_params_get_method[split_request_typed-sync]

4.8 ms

test_delete[async]

integration_tests/test_delete_requests.py::test_delete[async]

4.8 ms

test_binary_output[/async/octet-async octet]

integration_tests/test_binary_output.py::test_binary_output[/async/octet-async octet]

4.8 ms

test_patch[async]

integration_tests/test_patch_requests.py::test_patch[async]

4.8 ms

test_split_request_params_get_combined_failure[async]

integration_tests/test_split_request_params.py::test_split_request_params_get_combined_failure[async]

5 ms

test_sub_router_head

integration_tests/test_subrouter.py::test_sub_router_head

4.7 ms

test_post_sync_view

integration_tests/test_views.py::test_post_sync_view

4.7 ms

test_serve_html[async]

integration_tests/test_get_requests.py::test_serve_html[async]

4.7 ms

test_split_request_params_get_combined[split_request_untyped-async]

integration_tests/test_split_request_params.py::test_split_request_params_get_combined[split_request_untyped-async]

5 ms

test_get_async_view

integration_tests/test_views.py::test_get_async_view

4.7 ms

test_basic_get[/sync/response-sync response get-sync-response]

integration_tests/test_basic_routes.py::test_basic_get[/sync/response-sync response get-sync-response]

4.8 ms

test_json_get[/sync/json/const-expected_json2]

integration_tests/test_basic_routes.py::test_json_get[/sync/json/const-expected_json2]

4.8 ms

test_basic_get[/async/response/const-async response const get-async_const-response]

integration_tests/test_basic_routes.py::test_basic_get[/async/response/const-async response const get-async_const-response]

4.9 ms

test_split_request_params_get_query_params[split_request_typed-sync]

integration_tests/test_split_request_params.py::test_split_request_params_get_query_params[split_request_typed-sync]

13.5 ms

13.6 ms

test_404_status_code

integration_tests/test_status_code.py::test_404_status_code

4.6 ms

test_exception_handling[/sync/exception/put-put]

integration_tests/test_exception_handling.py::test_exception_handling[/sync/exception/put-put]

4.8 ms

test_split_request_params_get_path_params[split_request_untyped-sync]

integration_tests/test_split_request_params.py::test_split_request_params_get_path_params[split_request_untyped-sync]

4.8 ms

test_split_request_params_get_query_params[split_request_typed-async]

integration_tests/test_split_request_params.py::test_split_request_params_get_query_params[split_request_typed-async]

13.6 ms

test_global_middleware

integration_tests/test_middlewares.py::test_global_middleware

4.7 ms

test_202_status_code

integration_tests/test_status_code.py::test_202_status_code

4.6 ms

test_param[async]

integration_tests/test_get_requests.py::test_param[async]

8.9 ms

test_template[async]

integration_tests/test_get_requests.py::test_template[async]

4.7 ms

test_http_request_info_get[/async/http/param-expected_json1]

integration_tests/test_basic_routes.py::test_http_request_info_get[/async/http/param-expected_json1]

4.8 ms

test_param[sync]

integration_tests/test_get_requests.py::test_param[sync]

8.9 ms

test_basic_get[/sync/response/const-sync response const get-sync_const-response]

integration_tests/test_basic_routes.py::test_basic_get[/sync/response/const-sync response const get-sync_const-response]

4.9 ms

test_file_download[async]

integration_tests/test_file_download.py::test_file_download[async]

4.8 ms

test_binary_output[/async/octet/response-async octet response]

integration_tests/test_binary_output.py::test_binary_output[/async/octet/response-async octet response]

4.9 ms

test_split_request_params_get_query_params[split_request_untyped-sync]

integration_tests/test_split_request_params.py::test_split_request_params_get_query_params[split_request_untyped-sync]

13.6 ms

test_sub_router[post]

integration_tests/test_subrouter.py::test_sub_router[post]

4.7 ms

test_param_suffix[sync]

integration_tests/test_get_requests.py::test_param_suffix[sync]

8.9 ms

9 ms

test_exception_handling[/async/post/no_dec-post]

integration_tests/test_add_route_without_decorator.py::test_exception_handling[/async/post/no_dec-post]

4.8 ms

test_trailing_slash

integration_tests/test_get_requests.py::test_trailing_slash

8.7 ms

8.8 ms

test_404_not_found

integration_tests/test_status_code.py::test_404_not_found

4.7 ms

test_post[async]

integration_tests/test_post_requests.py::test_post[async]

4.8 ms

test_put[sync]

integration_tests/test_put_requests.py::test_put[sync]

4.8 ms

test_exception_handling[/async/exception/put-put]

integration_tests/test_exception_handling.py::test_exception_handling[/async/exception/put-put]

4.8 ms

test_basic_get[/sync/dict-sync dict get-sync-dict]

integration_tests/test_basic_routes.py::test_basic_get[/sync/dict-sync dict get-sync-dict]

4.8 ms

test_binary_output[/sync/octet-sync octet]

integration_tests/test_binary_output.py::test_binary_output[/sync/octet-sync octet]

4.8 ms

test_json_get[/async/json/const-expected_json3]

integration_tests/test_basic_routes.py::test_json_get[/async/json/const-expected_json3]

4.8 ms

test_split_request_params_get_headers[split_request_untyped-async]

integration_tests/test_split_request_params.py::test_split_request_params_get_headers[split_request_untyped-async]

4.8 ms

test_invalid_authentication_token[async]

integration_tests/test_authentication.py::test_invalid_authentication_token[async]

4.7 ms

test_delete_with_param[async]

integration_tests/test_delete_requests.py::test_delete_with_param[async]

4.8 ms

test_split_request_params_get_combined[split_request_untyped-sync]

integration_tests/test_split_request_params.py::test_split_request_params_get_combined[split_request_untyped-sync]

5 ms

test_invalid_authentication_header[async]

integration_tests/test_authentication.py::test_invalid_authentication_header[async]

4.7 ms

test_valid_authentication[async]

integration_tests/test_authentication.py::test_valid_authentication[async]

4.7 ms

test_sync_500_internal_server_error[async]

integration_tests/test_status_code.py::test_sync_500_internal_server_error[async]

4.6 ms

test_sub_router[get]

integration_tests/test_subrouter.py::test_sub_router[get]

4.7 ms

test_put_with_param[sync]

integration_tests/test_put_requests.py::test_put_with_param[sync]

4.7 ms

test_exception_handling[/async/put/no_dec-put]

integration_tests/test_add_route_without_decorator.py::test_exception_handling[/async/put/no_dec-put]

4.8 ms

test_split_request_params_get_headers[split_request_typed-sync]

integration_tests/test_split_request_params.py::test_split_request_params_get_headers[split_request_typed-sync]

4.8 ms

test_split_request_params_get_body[split_request_typed-async]

integration_tests/test_split_request_params.py::test_split_request_params_get_body[split_request_typed-async]

4.8 ms

test_split_request_params_typed_untyped_post_combined[sync]

integration_tests/test_split_request_params.py::test_split_request_params_typed_untyped_post_combined[sync]

5 ms

test_json_get[/sync/json-expected_json0]

integration_tests/test_basic_routes.py::test_json_get[/sync/json-expected_json0]

4.7 ms

test_invalid_authentication_no_token[sync]

integration_tests/test_authentication.py::test_invalid_authentication_no_token[sync]

4.6 ms

test_patch_with_param[sync]

integration_tests/test_patch_requests.py::test_patch_with_param[sync]

4.7 ms

4.8 ms

test_invalid_authentication_header[sync]

integration_tests/test_authentication.py::test_invalid_authentication_header[sync]

4.7 ms

test_exception_handling[/sync/exception/post-post]

integration_tests/test_exception_handling.py::test_exception_handling[/sync/exception/post-post]

4.8 ms

test_form_data[sync]

integration_tests/test_multipart_data.py::test_form_data[sync]

4.9 ms

5 ms

test_sub_router[put]

integration_tests/test_subrouter.py::test_sub_router[put]

4.7 ms

test_exception_handling[/sync/get/no_dec-get]

integration_tests/test_add_route_without_decorator.py::test_exception_handling[/sync/get/no_dec-get]

4.8 ms

test_exception_handling[/sync/exception/get-get]

integration_tests/test_exception_handling.py::test_exception_handling[/sync/exception/get-get]

4.8 ms

test_sub_router[delete]

integration_tests/test_subrouter.py::test_sub_router[delete]

4.7 ms

test_split_request_params_get_headers[split_request_untyped-sync]

integration_tests/test_split_request_params.py::test_split_request_params_get_headers[split_request_untyped-sync]

4.8 ms

test_post_with_param[async]

integration_tests/test_post_requests.py::test_post_with_param[async]

4.7 ms

4.8 ms

test_patch[sync]

integration_tests/test_patch_requests.py::test_patch[sync]

4.8 ms

test_split_request_params_get_path_params[split_request_typed-sync]

integration_tests/test_split_request_params.py::test_split_request_params_get_path_params[split_request_typed-sync]

4.8 ms

test_split_request_params_get_method[split_request_untyped-sync]

integration_tests/test_split_request_params.py::test_split_request_params_get_method[split_request_untyped-sync]

4.8 ms

test_basic_get[/async/str-async str get-None-None]

integration_tests/test_basic_routes.py::test_basic_get[/async/str-async str get-None-None]

4.7 ms

test_multipart_file[sync]

integration_tests/test_multipart_data.py::test_multipart_file[sync]

5 ms

test_invalid_authentication_no_token[async]

integration_tests/test_authentication.py::test_invalid_authentication_no_token[async]

4.6 ms

4.7 ms

test_sync_500_internal_server_error[sync]

integration_tests/test_status_code.py::test_sync_500_internal_server_error[sync]

4.6 ms

test_split_request_params_get_query_params[split_request_untyped-async]

integration_tests/test_split_request_params.py::test_split_request_params_get_query_params[split_request_untyped-async]

13.6 ms

test_patch_with_param[async]

integration_tests/test_patch_requests.py::test_patch_with_param[async]

4.7 ms

4.8 ms

test_dev_index_request

integration_tests/test_base_url.py::test_dev_index_request

4.6 ms

4.7 ms

test_invalid_authentication_token[sync]

integration_tests/test_authentication.py::test_invalid_authentication_token[sync]

4.7 ms

test_split_request_params_get_body[split_request_typed-sync]

integration_tests/test_split_request_params.py::test_split_request_params_get_body[split_request_typed-sync]

4.8 ms

test_json_get[/async/json-expected_json1]

integration_tests/test_basic_routes.py::test_json_get[/async/json-expected_json1]

4.7 ms

test_split_request_params_get_headers[split_request_typed-async]

integration_tests/test_split_request_params.py::test_split_request_params_get_headers[split_request_typed-async]

4.8 ms

test_exception_handling[/sync/post/no_dec-post]

integration_tests/test_add_route_without_decorator.py::test_exception_handling[/sync/post/no_dec-post]

4.8 ms

test_queries[sync]

integration_tests/test_get_requests.py::test_queries[sync]

9 ms

test_docs_handler

integration_tests/test_openapi.py::test_docs_handler

4.6 ms

test_get_sync_view

integration_tests/test_views.py::test_get_sync_view

4.7 ms

test_split_request_params_get_method[split_request_untyped-async]

integration_tests/test_split_request_params.py::test_split_request_params_get_method[split_request_untyped-async]

4.8 ms

test_basic_get[/async/response-async response get-async-response]

integration_tests/test_basic_routes.py::test_basic_get[/async/response-async response get-async-response]

4.8 ms

test_basic_get[/async/dict-async dict get-async-dict]

integration_tests/test_basic_routes.py::test_basic_get[/async/dict-async dict get-async-dict]

4.8 ms

test_post_with_param[sync]

integration_tests/test_post_requests.py::test_post_with_param[sync]

4.7 ms

4.8 ms

test_binary_output[/sync/octet/response-sync octet response]

integration_tests/test_binary_output.py::test_binary_output[/sync/octet/response-sync octet response]

4.9 ms

test_middlewares[async]

integration_tests/test_middlewares.py::test_middlewares[async]

4.7 ms

4.8 ms

test_post[sync]

integration_tests/test_post_requests.py::test_post[sync]

4.8 ms

test_put[async]

integration_tests/test_put_requests.py::test_put[async]

4.8 ms

test_queries[async]

integration_tests/test_get_requests.py::test_queries[async]

9 ms

test_global_index_request

integration_tests/test_base_url.py::test_global_index_request

4.6 ms

test_split_request_params_get_body[split_request_untyped-sync]

integration_tests/test_split_request_params.py::test_split_request_params_get_body[split_request_untyped-sync]

4.8 ms

4.9 ms

test_split_request_params_get_body[split_request_untyped-async]

integration_tests/test_split_request_params.py::test_split_request_params_get_body[split_request_untyped-async]

4.8 ms

4.9 ms

test_basic_get[/sync/str/const-sync str const get-None-None]

integration_tests/test_basic_routes.py::test_basic_get[/sync/str/const-sync str const get-None-None]

4.7 ms

test_middlewares[sync]

integration_tests/test_middlewares.py::test_middlewares[sync]

4.7 ms

4.8 ms

test_exception_handling[/async/get/no_dec-get]

integration_tests/test_add_route_without_decorator.py::test_exception_handling[/async/get/no_dec-get]

4.7 ms

test_put_with_param[async]

integration_tests/test_put_requests.py::test_put_with_param[async]

4.7 ms

4.8 ms

test_basic_get[/async/dict/const-async dict const get-async_const-dict]

integration_tests/test_basic_routes.py::test_basic_get[/async/dict/const-async dict const get-async_const-dict]

4.8 ms

4.9 ms

test_split_request_params_get_combined_failure[sync]

integration_tests/test_split_request_params.py::test_split_request_params_get_combined_failure[sync]

5 ms

test_delete_with_param[sync]

integration_tests/test_delete_requests.py::test_delete_with_param[sync]

4.8 ms

test_post_async_decorator_view

integration_tests/test_views.py::test_post_async_decorator_view

4.8 ms

test_exception_handling[/async/exception/post-post]

integration_tests/test_exception_handling.py::test_exception_handling[/async/exception/post-post]

4.8 ms

test_add_subrouter_paths

integration_tests/test_openapi.py::test_add_subrouter_paths

-3%

6.3 ms

6.5 ms

test_openapi_request_body

integration_tests/test_openapi.py::test_openapi_request_body

-3%

6.3 ms

6.5 ms

test_openapi_response_body

integration_tests/test_openapi.py::test_openapi_response_body

-3%

6.3 ms

6.5 ms

test_add_openapi_path

integration_tests/test_openapi.py::test_add_openapi_path

-3%

6.3 ms

6.5 ms

test_json_handler

integration_tests/test_openapi.py::test_json_handler

-3%

6.3 ms

6.5 ms

test_openapi_query_params

integration_tests/test_openapi.py::test_openapi_query_params

-3%

6.3 ms

6.5 ms

Commits

Click on a commit to change the comparison range

Base

main

7495342

-49%

refactor: openApi made lazy. This is a staging post so there are extra tests (in all the decorators). Fixes a potential issue in __init__ where the default argument creates a shared object at parse time rather than a separate one for each instance. As only one instance, not normally an issue but not good practice. One FIXME is an edge case in init_openapi where neither if clause evaluates to True for openapi_file_path (should we log an error or what?)

0dccef3

25 days ago

by dave42w

refactor: openApi made lazy. All add_route methods have auth_required, openapi_name and openapi_tags which get stored in the route. Instead of incrementally adding them to openapi routes they are added all at once in app.start include_routes now additionally tracks the list of routers whose routes have been added to the main app. This will be used more later to avoid merging routes until app.start for more flexibility

642eac9

25 days ago

by dave42w

refactor: try to solve the speed issue by improving handling moving from allowing None for openApi_tags to not

2ae5e7f

25 days ago

by dave42w

refactor: slightly optimised lower_http_method I've tested with 100,000 loops. This is marginally faster. This PR lowers slows full test suite by 0.004s on my system. However, those benchmarks are mostly setup. Once we are making calls to a running server none of this code is being executed.

f9ebbee

24 days ago

by dave42w

refactor: remove extra Robyn instance variable to avoid extra side effects in the future. No consistent peformance impact on 100,000 Robyn(__file__) calls

b1dae0b

24 days ago

by dave42w

Merge branch 'sparckles:main' into lazy-openapi

cf11725

23 days ago

by dave42w

Merge branch 'sparckles:main' into lazy-openapi

2d261e0

16 days ago

by dave42w

+1%

Merge branch 'sparckles:main' into lazy-openapi

f9bf080

7 days ago

by dave42w

Home Terms Privacy Docs