BlogDocs

Kafka: fix producing with acks=0(#1630)

Merged
Merging
rukai:kafka_fix_acks0
(
f0f528d
) into
main
(
3cdefda
)
+18%
IMPROVEMENTS
1
REGRESSIONS
0
UNTOUCHED
36
NEW
0
DROPPED
0
IGNORED
0

Benchmarks

Improved

encode_request_produce
shotover/benches/benches/codec/kafka.rs::benches::criterion_benchmark::kafka_codec::encode_request_produce
+18%
15.8 µs
13.4 µs

Passed

decode_request_produce_drop
shotover/benches/benches/codec/kafka.rs::benches::criterion_benchmark::kafka_codec::decode_request_produce_drop
+1%
4.2 µs
4.2 µs
encode_system.local_result_v4_lz4_compression
shotover/benches/benches/codec/cassandra.rs::benches::criterion_benchmark::cassandra_codec::encode_system.local_result_v4_lz4_compression
+1%
196.2 µs
194.9 µs
cassandra_request_throttling_unparsed
shotover/benches/benches/chain.rs::benches::criterion_benchmark::transform::cassandra_request_throttling_unparsed
+1%
14.6 µs
14.5 µs
decode_request_list_offsets_create
shotover/benches/benches/codec/kafka.rs::benches::criterion_benchmark::kafka_codec::decode_request_list_offsets_create
+1%
11 µs
10.9 µs
redis_cluster_ports_rewrite
shotover/benches/benches/chain.rs::benches::criterion_benchmark::transform::redis_cluster_ports_rewrite
0%
18.1 µs
18 µs
loopback
shotover/benches/benches/chain.rs::benches::criterion_benchmark::transform::loopback
0%
6.2 µs
6.2 µs
redis_filter
shotover/benches/benches/chain.rs::benches::criterion_benchmark::transform::redis_filter
0%
23 µs
22.9 µs
decode_request_metadata_create
shotover/benches/benches/codec/kafka.rs::benches::criterion_benchmark::kafka_codec::decode_request_metadata_create
0%
9.9 µs
9.9 µs
decode_system.local_result_v5_lz4_compression
shotover/benches/benches/codec/cassandra.rs::benches::criterion_benchmark::cassandra_codec::decode_system.local_result_v5_lz4_compression
0%
44.5 µs
44.4 µs
decode_request_fetch_create
shotover/benches/benches/codec/kafka.rs::benches::criterion_benchmark::kafka_codec::decode_request_fetch_create
0%
12.4 µs
12.3 µs
decode_system.local_query_v5_lz4_compression
shotover/benches/benches/codec/cassandra.rs::benches::criterion_benchmark::cassandra_codec::decode_system.local_query_v5_lz4_compression
0%
56.8 µs
56.7 µs
decode_request_produce_create
shotover/benches/benches/codec/kafka.rs::benches::criterion_benchmark::kafka_codec::decode_request_produce_create
0%
14.1 µs
14.1 µs
nullsink
shotover/benches/benches/chain.rs::benches::criterion_benchmark::transform::nullsink
0%
14.1 µs
14.1 µs
encode_system.local_result_v5_no_compression
shotover/benches/benches/codec/cassandra.rs::benches::criterion_benchmark::cassandra_codec::encode_system.local_result_v5_no_compression
0%
102.7 µs
102.5 µs
cassandra_protect_protected
shotover/benches/benches/chain.rs::benches::criterion_benchmark::transform::cassandra_protect_protected
0%
74.9 µs
74.8 µs
cassandra_rewrite_peers_passthrough
shotover/benches/benches/chain.rs::benches::criterion_benchmark::transform::cassandra_rewrite_peers_passthrough
0%
82.6 µs
82.6 µs
decode_request_fetch_drop
shotover/benches/benches/codec/kafka.rs::benches::criterion_benchmark::kafka_codec::decode_request_fetch_drop
0%
4.1 µs
4.1 µs
decode_request_list_offsets_drop
shotover/benches/benches/codec/kafka.rs::benches::criterion_benchmark::kafka_codec::decode_request_list_offsets_drop
0%
3.9 µs
3.9 µs
decode_request_metadata_drop
shotover/benches/benches/codec/kafka.rs::benches::criterion_benchmark::kafka_codec::decode_request_metadata_drop
0%
3.4 µs
3.4 µs
decode_system.local_query_v4_lz4_compression
shotover/benches/benches/codec/cassandra.rs::benches::criterion_benchmark::cassandra_codec::decode_system.local_query_v4_lz4_compression
0%
56 µs
56.1 µs
decode_system.local_query_v4_no_compression
shotover/benches/benches/codec/cassandra.rs::benches::criterion_benchmark::cassandra_codec::decode_system.local_query_v4_no_compression
0%
55.1 µs
55.2 µs
encode_system.local_result_v4_no_compression
shotover/benches/benches/codec/cassandra.rs::benches::criterion_benchmark::cassandra_codec::encode_system.local_result_v4_no_compression
0%
102.5 µs
102.6 µs
cassandra_protect_unprotected
shotover/benches/benches/chain.rs::benches::criterion_benchmark::transform::cassandra_protect_unprotected
0%
43.4 µs
43.5 µs
decode_system.local_result_v4_lz4_compression
shotover/benches/benches/codec/cassandra.rs::benches::criterion_benchmark::cassandra_codec::decode_system.local_result_v4_lz4_compression
0%
44.5 µs
44.6 µs
decode_system.local_query_v5_no_compression
shotover/benches/benches/codec/cassandra.rs::benches::criterion_benchmark::cassandra_codec::decode_system.local_query_v5_no_compression
0%
56.6 µs
56.8 µs
encode_system.local_query_v4_lz4_compression
shotover/benches/benches/codec/cassandra.rs::benches::criterion_benchmark::cassandra_codec::encode_system.local_query_v4_lz4_compression
-1%
13.9 µs
14 µs
encode_system.local_result_v5_lz4_compression
shotover/benches/benches/codec/cassandra.rs::benches::criterion_benchmark::cassandra_codec::encode_system.local_result_v5_lz4_compression
-1%
194.8 µs
196.5 µs
encode_system.local_query_v5_lz4_compression
shotover/benches/benches/codec/cassandra.rs::benches::criterion_benchmark::cassandra_codec::encode_system.local_query_v5_lz4_compression
-2%
27.1 µs
27.5 µs
decode_system.local_result_v4_no_compression
shotover/benches/benches/codec/cassandra.rs::benches::criterion_benchmark::cassandra_codec::decode_system.local_result_v4_no_compression
-3%
14.6 µs
15 µs
encode_system.local_query_v4_no_compression
shotover/benches/benches/codec/cassandra.rs::benches::criterion_benchmark::cassandra_codec::encode_system.local_query_v4_no_compression
-3%
14.4 µs
14.8 µs
decode_system.local_result_v5_no_compression
shotover/benches/benches/codec/cassandra.rs::benches::criterion_benchmark::cassandra_codec::decode_system.local_result_v5_no_compression
-3%
14.3 µs
14.8 µs
encode_request_fetch
shotover/benches/benches/codec/kafka.rs::benches::criterion_benchmark::kafka_codec::encode_request_fetch
-3%
16.4 µs
16.9 µs
encode_all
shotover/benches/benches/codec/kafka.rs::benches::criterion_benchmark::kafka_codec::encode_all
-5%
26.1 µs
27.4 µs
encode_request_metadata
shotover/benches/benches/codec/kafka.rs::benches::criterion_benchmark::kafka_codec::encode_request_metadata
-5%
14.2 µs
14.9 µs
encode_request_list_offsets
shotover/benches/benches/codec/kafka.rs::benches::criterion_benchmark::kafka_codec::encode_request_list_offsets
-5%
14.6 µs
15.4 µs
encode_system.local_query_v5_no_compression
shotover/benches/benches/codec/cassandra.rs::benches::criterion_benchmark::cassandra_codec::encode_system.local_query_v5_no_compression
-6%
15.4 µs
16.5 µs

Commits

Click on a commit to change the comparison range
base
main
3cdefda
+15%
Kafka: fix producing with acks=0
529d8ff
4 months ago
by rukai
+3%
Merge branch 'main' into kafka_fix_acks0
f0f528d
4 months ago
by rukai
ResourcesHomePricingDocsBlogGitHubChangelog