BlogDocs

Fix determining the coordinator for OffsetFetch requests(#1742)

Merged
Merging
rukai:fix_coordinator_fetching_for_offset_fetch
(
1f1314a
) into
main
(
149dc70
)
+14%
IMPROVEMENTS
1
REGRESSIONS
0
UNTOUCHED
38
NEW
0
DROPPED
0
IGNORED
0

Benchmarks

Improved

encode_system.local_result_v5_no_compression
shotover/benches/benches/codec/cassandra.rs::benches::criterion_benchmark::cassandra_codec::encode_system.local_result_v5_no_compression
+14%
105.6 µs
93 µs

Passed

encode_system.local_result_v5_lz4_compression
shotover/benches/benches/codec/cassandra.rs::benches::criterion_benchmark::cassandra_codec::encode_system.local_result_v5_lz4_compression
+4%
211.4 µs
202.5 µs
decode_request_produce_drop
shotover/benches/benches/codec/kafka.rs::benches::criterion_benchmark::kafka_codec::decode_request_produce_drop
+2%
4.1 µs
4 µs
encode_system.local_query_v4_no_compression
shotover/benches/benches/codec/cassandra.rs::benches::criterion_benchmark::cassandra_codec::encode_system.local_query_v4_no_compression
+2%
14 µs
13.8 µs
encode_request_metadata
shotover/benches/benches/codec/kafka.rs::benches::criterion_benchmark::kafka_codec::encode_request_metadata
+2%
13.5 µs
13.3 µs
decode_request_metadata_create
shotover/benches/benches/codec/kafka.rs::benches::criterion_benchmark::kafka_codec::decode_request_metadata_create
+1%
10 µs
9.9 µs
encode_request_fetch
shotover/benches/benches/codec/kafka.rs::benches::criterion_benchmark::kafka_codec::encode_request_fetch
+1%
13.9 µs
13.7 µs
decode_request_fetch_create
shotover/benches/benches/codec/kafka.rs::benches::criterion_benchmark::kafka_codec::decode_request_fetch_create
+1%
12.3 µs
12.2 µs
decode_request_produce_create
shotover/benches/benches/codec/kafka.rs::benches::criterion_benchmark::kafka_codec::decode_request_produce_create
+1%
14 µs
13.9 µs
encode_request_produce
shotover/benches/benches/codec/kafka.rs::benches::criterion_benchmark::kafka_codec::encode_request_produce
+1%
9.7 µs
9.7 µs
decode_request_list_offsets_create
shotover/benches/benches/codec/kafka.rs::benches::criterion_benchmark::kafka_codec::decode_request_list_offsets_create
+1%
11 µs
10.9 µs
encode_system.local_query_v5_no_compression
shotover/benches/benches/codec/cassandra.rs::benches::criterion_benchmark::cassandra_codec::encode_system.local_query_v5_no_compression
+1%
14.9 µs
14.8 µs
redis_cluster_ports_rewrite
shotover/benches/benches/chain.rs::benches::criterion_benchmark::transform::redis_cluster_ports_rewrite
0%
17.3 µs
17.2 µs
encode_system.local_result_v4_lz4_compression
shotover/benches/benches/codec/cassandra.rs::benches::criterion_benchmark::cassandra_codec::encode_system.local_result_v4_lz4_compression
0%
201.8 µs
201.2 µs
cassandra_request_throttling_unparsed
shotover/benches/benches/chain.rs::benches::criterion_benchmark::transform::cassandra_request_throttling_unparsed
0%
13.8 µs
13.7 µs
query_counter_fresh
shotover/benches/benches/chain.rs::benches::criterion_benchmark::transform::query_counter_fresh
0%
14.2 µs
14.2 µs
redis_filter
shotover/benches/benches/chain.rs::benches::criterion_benchmark::transform::redis_filter
0%
22.1 µs
22.1 µs
decode_system.local_result_v5_lz4_compression
shotover/benches/benches/codec/cassandra.rs::benches::criterion_benchmark::cassandra_codec::decode_system.local_result_v5_lz4_compression
0%
44.7 µs
44.6 µs
encode_system.local_result_v4_no_compression
shotover/benches/benches/codec/cassandra.rs::benches::criterion_benchmark::cassandra_codec::encode_system.local_result_v4_no_compression
0%
92.9 µs
92.8 µs
nullsink
shotover/benches/benches/chain.rs::benches::criterion_benchmark::transform::nullsink
0%
13.3 µs
13.3 µs
query_counter_pre_used
shotover/benches/benches/chain.rs::benches::criterion_benchmark::transform::query_counter_pre_used
0%
10.8 µs
10.8 µs
decode_request_fetch_drop
shotover/benches/benches/codec/kafka.rs::benches::criterion_benchmark::kafka_codec::decode_request_fetch_drop
0%
4 µs
4 µs
decode_request_list_offsets_drop
shotover/benches/benches/codec/kafka.rs::benches::criterion_benchmark::kafka_codec::decode_request_list_offsets_drop
0%
3.8 µs
3.8 µs
cassandra_rewrite_peers_passthrough
shotover/benches/benches/chain.rs::benches::criterion_benchmark::transform::cassandra_rewrite_peers_passthrough
0%
80.5 µs
80.5 µs
cassandra_protect_protected
shotover/benches/benches/chain.rs::benches::criterion_benchmark::transform::cassandra_protect_protected
0%
73.1 µs
73.1 µs
cassandra_protect_unprotected
shotover/benches/benches/chain.rs::benches::criterion_benchmark::transform::cassandra_protect_unprotected
0%
42.2 µs
42.3 µs
encode_request_list_offsets
shotover/benches/benches/codec/kafka.rs::benches::criterion_benchmark::kafka_codec::encode_request_list_offsets
0%
12.8 µs
12.8 µs
decode_system.local_query_v4_no_compression
shotover/benches/benches/codec/cassandra.rs::benches::criterion_benchmark::cassandra_codec::decode_system.local_query_v4_no_compression
0%
54.7 µs
54.9 µs
decode_system.local_result_v4_lz4_compression
shotover/benches/benches/codec/cassandra.rs::benches::criterion_benchmark::cassandra_codec::decode_system.local_result_v4_lz4_compression
0%
44.6 µs
44.8 µs
decode_system.local_result_v5_no_compression
shotover/benches/benches/codec/cassandra.rs::benches::criterion_benchmark::cassandra_codec::decode_system.local_result_v5_no_compression
0%
14.8 µs
14.9 µs
loopback
shotover/benches/benches/chain.rs::benches::criterion_benchmark::transform::loopback
0%
5.8 µs
5.9 µs
decode_system.local_query_v4_lz4_compression
shotover/benches/benches/codec/cassandra.rs::benches::criterion_benchmark::cassandra_codec::decode_system.local_query_v4_lz4_compression
-1%
55 µs
55.3 µs
encode_system.local_query_v5_lz4_compression
shotover/benches/benches/codec/cassandra.rs::benches::criterion_benchmark::cassandra_codec::encode_system.local_query_v5_lz4_compression
-1%
26.4 µs
26.5 µs
decode_system.local_result_v4_no_compression
shotover/benches/benches/codec/cassandra.rs::benches::criterion_benchmark::cassandra_codec::decode_system.local_result_v4_no_compression
-1%
14.8 µs
14.9 µs
decode_system.local_query_v5_no_compression
shotover/benches/benches/codec/cassandra.rs::benches::criterion_benchmark::cassandra_codec::decode_system.local_query_v5_no_compression
-1%
56.4 µs
56.9 µs
decode_system.local_query_v5_lz4_compression
shotover/benches/benches/codec/cassandra.rs::benches::criterion_benchmark::cassandra_codec::decode_system.local_query_v5_lz4_compression
-1%
56.4 µs
56.9 µs
decode_request_metadata_drop
shotover/benches/benches/codec/kafka.rs::benches::criterion_benchmark::kafka_codec::decode_request_metadata_drop
-2%
3.3 µs
3.4 µs
encode_all
shotover/benches/benches/codec/kafka.rs::benches::criterion_benchmark::kafka_codec::encode_all
-3%
22.4 µs
23.2 µs
encode_system.local_query_v4_lz4_compression
shotover/benches/benches/codec/cassandra.rs::benches::criterion_benchmark::cassandra_codec::encode_system.local_query_v4_lz4_compression
-4%
13.5 µs
14.1 µs

Commits

Click on a commit to change the comparison range
base
main
149dc70
+14%
Fix determining the coordinator for OffsetFetch requests
1f1314a
17 days ago
by rukai
ResourcesHomePricingDocsBlogGitHubChangelog
Copyright © 2024 CodSpeed Technology SAS. All rights reserved.