ric-pro:socket-recreation - Branch - shotover/shotover-proxy

Listening Socket Recreation

#1944Merged

Comparing

ric-pro:socket-recreation

(

3db706c

) with

main

(

4884af5

)

Untouched: 38

Benchmarks

Passed

decode_request_list_offsets_create

shotover/benches/benches/codec/kafka.rs::benches::criterion_benchmark::kafka_codec

+1%

10.3 µs10.1 µs

decode_request_metadata_create

shotover/benches/benches/codec/kafka.rs::benches::criterion_benchmark::kafka_codec

+1%

8.9 µs8.8 µs

encode_request_produce

shotover/benches/benches/codec/kafka.rs::benches::criterion_benchmark::kafka_codec

+1%

8 µs7.9 µs

decode_request_produce_create

shotover/benches/benches/codec/kafka.rs::benches::criterion_benchmark::kafka_codec

+1%

10.8 µs10.7 µs

encode_request_metadata

shotover/benches/benches/codec/kafka.rs::benches::criterion_benchmark::kafka_codec

+1%

10.4 µs10.4 µs

encode_request_list_offsets

shotover/benches/benches/codec/kafka.rs::benches::criterion_benchmark::kafka_codec

+1%

11.3 µs11.2 µs

decode_system.local_query_v5_no_compression

shotover/benches/benches/codec/cassandra.rs::benches::criterion_benchmark::cassandra_codec

+1%

55.7 µs55.4 µs

encode_request_fetch

shotover/benches/benches/codec/kafka.rs::benches::criterion_benchmark::kafka_codec

11.6 µs11.6 µs

decode_request_fetch_create

shotover/benches/benches/codec/kafka.rs::benches::criterion_benchmark::kafka_codec

11.5 µs11.5 µs

query_counter_fresh

shotover/benches/benches/chain.rs::benches::criterion_benchmark::transform

15.3 µs15.2 µs

encode_system.local_result_v5_lz4_compression

shotover/benches/benches/codec/cassandra.rs::benches::criterion_benchmark::cassandra_codec

202.3 µs202.1 µs

encode_system.local_result_v4_lz4_compression

shotover/benches/benches/codec/cassandra.rs::benches::criterion_benchmark::cassandra_codec

205.4 µs205.3 µs

encode_system.local_result_v4_no_compression

shotover/benches/benches/codec/cassandra.rs::benches::criterion_benchmark::cassandra_codec

92.7 µs92.7 µs

decode_system.local_result_v5_lz4_compression

shotover/benches/benches/codec/cassandra.rs::benches::criterion_benchmark::cassandra_codec

44.5 µs44.5 µs

decode_request_fetch_drop

shotover/benches/benches/codec/kafka.rs::benches::criterion_benchmark::kafka_codec

3.5 µs3.5 µs

nullsink

shotover/benches/benches/chain.rs::benches::criterion_benchmark::transform

13.4 µs13.4 µs

cassandra_request_throttling_unparsed

shotover/benches/benches/chain.rs::benches::criterion_benchmark::transform

12.5 µs12.5 µs

query_counter_pre_used

shotover/benches/benches/chain.rs::benches::criterion_benchmark::transform

10.5 µs10.5 µs

loopback

shotover/benches/benches/chain.rs::benches::criterion_benchmark::transform

6.4 µs6.4 µs

valkey_cluster_ports_rewrite

shotover/benches/benches/chain.rs::benches::criterion_benchmark::transform

17.1 µs17.1 µs

valkey_filter

shotover/benches/benches/chain.rs::benches::criterion_benchmark::transform

20.2 µs20.2 µs

decode_request_list_offsets_drop

shotover/benches/benches/codec/kafka.rs::benches::criterion_benchmark::kafka_codec

3.3 µs3.3 µs

decode_system.local_result_v4_lz4_compression

shotover/benches/benches/codec/cassandra.rs::benches::criterion_benchmark::cassandra_codec

44.6 µs44.6 µs

decode_request_produce_drop

shotover/benches/benches/codec/kafka.rs::benches::criterion_benchmark::kafka_codec

3.4 µs3.4 µs

cassandra_protect_protected

shotover/benches/benches/chain.rs::benches::criterion_benchmark::transform

70.8 µs70.8 µs

encode_system.local_query_v4_lz4_compression

shotover/benches/benches/codec/cassandra.rs::benches::criterion_benchmark::cassandra_codec

13.2 µs13.2 µs

cassandra_protect_unprotected

shotover/benches/benches/chain.rs::benches::criterion_benchmark::transform

40.8 µs40.8 µs

cassandra_rewrite_peers_passthrough

shotover/benches/benches/chain.rs::benches::criterion_benchmark::transform

79.2 µs79.3 µs

decode_system.local_query_v4_lz4_compression

shotover/benches/benches/codec/cassandra.rs::benches::criterion_benchmark::cassandra_codec

53.8 µs53.9 µs

decode_system.local_result_v4_no_compression

shotover/benches/benches/codec/cassandra.rs::benches::criterion_benchmark::cassandra_codec

12.4 µs12.4 µs

decode_system.local_result_v5_no_compression

shotover/benches/benches/codec/cassandra.rs::benches::criterion_benchmark::cassandra_codec

12.4 µs12.4 µs

encode_all

shotover/benches/benches/codec/kafka.rs::benches::criterion_benchmark::kafka_codec

18.7 µs18.8 µs

decode_system.local_query_v5_lz4_compression

shotover/benches/benches/codec/cassandra.rs::benches::criterion_benchmark::cassandra_codec

-1%

55.4 µs55.8 µs

decode_system.local_query_v4_no_compression

shotover/benches/benches/codec/cassandra.rs::benches::criterion_benchmark::cassandra_codec

-1%

53.5 µs53.9 µs

encode_system.local_query_v5_lz4_compression

shotover/benches/benches/codec/cassandra.rs::benches::criterion_benchmark::cassandra_codec

-1%

25.9 µs26 µs

decode_request_metadata_drop

shotover/benches/benches/codec/kafka.rs::benches::criterion_benchmark::kafka_codec

-1%

2.6 µs2.6 µs

encode_system.local_query_v4_no_compression

shotover/benches/benches/codec/cassandra.rs::benches::criterion_benchmark::cassandra_codec

-3%

13.4 µs13.9 µs

encode_system.local_query_v5_no_compression

shotover/benches/benches/codec/cassandra.rs::benches::criterion_benchmark::cassandra_codec

-7%

14.5 µs15.7 µs

Commits

Click on a commit to change the comparison range

Base

main

4884af5

+0.13%

Socket Recreation

efbb8e3

18 days ago

by ric-pro

+0.1%

--no caputre added to github workflow

eda4fac

17 days ago

by ric-pro

-0.14%

integration test modified

270aead

16 days ago

by ric-pro

+0.16%

integration test modified

49de336

16 days ago

by ric-pro

+0.13%

int test delay removed

dc978ac

16 days ago

by ric-pro

-0.23%

eliminated code duplication

06c9849

15 days ago

by ric-pro

+0.01%

removed get_source from all source files

74e4ad3

15 days ago

by ric-pro

-0.04%

removed unused fn from test, shortened fn name

28261da

15 days ago

by ric-pro

-0.08%

changes made to return an error if listen_addr is invalid, added port value to TcpCodecListener

76658aa

15 days ago

by ric-pro

-0.09%

error fixed removed unused imports

b2c6801

15 days ago

by ric-pro

+0.24%

test case added to ensure con_old continues to work after hot reload, open a new connection after shutting down old shotover but before shutting down new shotover

0e38acf

15 days ago

by ric-pro

+0.04%

consolidate Valkey connection tests into single helper function

c36c283

14 days ago

by ric-pro

-0.11%

lint error fixed

d646ed8

14 days ago

by ric-pro

-0.31%

error fixed

3db706c

14 days ago

by ric-pro

Home Terms Privacy Docs